Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-26 Thread Sergio Paracuellos
Hi Greg, On Mon, May 27, 2019 at 6:37 AM Greg Ungerer wrote: > > Hi Sergio, > > On 24/5/19 3:35 pm, Sergio Paracuellos wrote: > > On Fri, May 24, 2019 at 2:35 AM Greg Ungerer wrote: > >> On 23/5/19 3:26 pm, Sergio Paracuellos wrote: > >>> On Thu, May 23, 2019 at 4:11 AM Greg Ungerer wrote: > >>

Re: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2019-05-26 Thread Greg Ungerer
Hi Sergio, On 24/5/19 3:35 pm, Sergio Paracuellos wrote: On Fri, May 24, 2019 at 2:35 AM Greg Ungerer wrote: On 23/5/19 3:26 pm, Sergio Paracuellos wrote: On Thu, May 23, 2019 at 4:11 AM Greg Ungerer wrote: On 22/5/19 4:27 pm, Sergio Paracuellos wrote: [snip] There are some big changes bet

Re: [PATCH net] staging: Remove set but not used variable ‘status’

2019-05-26 Thread maowenan
On 2019/5/25 20:59, Sven Van Asbroeck wrote: > On Sat, May 25, 2019 at 12:20 AM Mao Wenan wrote: >> >> The variable 'status' is not used any more, remve it. > >> /* do the transfers for this message */ >> list_for_each_entry(transfer, &m->transfers, transfer_list) { >> if (t

[PATCH] emxx_udc : Fix #if 0 coding style warning

2019-05-26 Thread Yacov Simhony
This patch fixes the checkpathc.pl warning: WARNING: Consider removing the code enclosed by this #if 0 and its #endif Signed-off-by: Yacov Simhony --- drivers/staging/emxx_udc/emxx_udc.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.h

Re: [PATCH] dt-bindings: iio: adc: add adi,ad7780.yaml binding

2019-05-26 Thread Jonathan Cameron
On Fri, 24 May 2019 21:28:02 -0300 Renato Lui Geh wrote: > Hi Jonathan, Alex, > > Thanks for the review. Some comments inline. > > Thanks, > Renato > > On 05/20, Ardelean, Alexandru wrote: > >On Sun, 2019-05-19 at 12:32 +0100, Jonathan Cameron wrote: > >> [External] > >> > >> > >> On Sat, 18

Re: [PATCH v2 1/2] dt-bindings: iio: adc: add adi,ad7780.yaml binding

2019-05-26 Thread Jonathan Cameron
On Fri, 24 May 2019 22:26:30 -0300 Renato Lui Geh wrote: > This patch adds a YAML binding for the Analog Devices AD7780/1 and > AD7170/1 analog-to-digital converters. > > Signed-off-by: Renato Lui Geh Looks good to me, but I'm still finding my feet with these so will leave it for a few days for

Re: [PATCH] staging: iio: adis16240: add of_match_table entry

2019-05-26 Thread Jonathan Cameron
On Fri, 24 May 2019 13:54:49 + "Ardelean, Alexandru" wrote: > On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote: > > [External] > > > > > > Hi Alexandru, > > > > On 05/24, Alexandru Ardelean wrote: > > > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro > > > wrote: > > > > > >

Re: [PATCH] staging: kpc2000: simplify nested conditionals that just return a boolean.

2019-05-26 Thread Jeremy Sowden
On 2019-05-24, at 16:59:45 +, Matt Sickler wrote: > From: devel On Behalf Of > Greg KH > > On Fri, May 24, 2019 at 01:19:26PM +0100, Jeremy Sowden wrote: > > > kp2000_check_uio_irq contained a pair of nested ifs which each > > > evaluated a bitwise operation. If both operations yielded true,

[PATCH] drivers: staging: speakup: serialio: fix warning linux/serial.h is included more than once

2019-05-26 Thread Hariprasad Kelam
fix below warning reported by includecheck ./drivers/staging/speakup/serialio.h: linux/serial.h is included more than once. Signed-off-by: Hariprasad Kelam --- drivers/staging/speakup/serialio.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/speakup/serialio.h b/drivers