Re: [PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

On 11.05.19 15:48, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized however this is never read and later > it is being reassigned to a new value. The initialization is redundant and > hence can be removed. > > Addresses-Coverity: ("Unused Value") > Signed-off-by:

[PATCH v2 1/8] Staging: kpc2000: kpc_dma: resolve trailing whitespace error reported by checkpatch

Resolve trailing whitespace error from checkpatch.pl ERROR: trailing whitespace Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 86 ++--- drivers/staging/kpc2000/kpc_dma/fileops.c | 114 +- .../staging/kpc2000/kpc_dma/kpc_dma_driver.c |

[PATCH v2 7/8] Staging: kpc2000: kpc_dma: Resolve coding style warning reported by checkpatch

This patch resolves warnings to use __func__ insted of funtion name. WARNING: Prefer using '"%s...", __func__' to using 'setup_dma_engine', this function's name, in a string Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 6 ++--- drivers/staging/kpc2000/kpc_dma/f

[PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.

This patch resolves below errors reported by checkpatch ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo __init bar" should be "foo __init bar" ERROR: "foo __exit bar" should be "foo __exit bar" Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dm

[PATCH v2 5/8] Staging: kpc2000: kpc_dma: Resolve coding style error reported by checkpatch

This patch fixes below errors reported by checkpath ERROR: Macros with complex values should be enclosed in parentheses CHECK: Prefer using the BIT macro ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- drivers/stag

[PATCH v2 8/8] Staging: kpc2000: kpc_dma: Resolve coding style warning reported by checkpatch

This Patch resolves unnecessary cast warning and const file_operations WARNING: unnecessary cast may hide bugs WARNING: struct file_operations should normally be const Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/fileops.c| 4 ++-- drivers/staging/kpc2000/kpc_dma/kpc_dma

[PATCH v2 6/8] Staging: kpc2000: kpc_dma: Resolve coding style warning reported by checkpatch

This patch resloves below warnings reported by checkpath in kpc_dma WARNING: Missing a blank line after declarations WARNING: labels should not be indented CHECK: Please don't use multiple blank lines CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Vanda

[PATCH v2 3/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch

This patch resolves below errors reported by checkpath ERROR: space required before the open brace '{' ERROR: space prohibited after that '!' (ctx:BxW) ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 28 +--

[PATCH v2 4/8] Staging: kpc2000: kpc_dma: Resolve code indent error reported by checkpatch

This patch fixes code indentaion error reported by checkpath ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/fileops.c | 12 1 file changed, 8 insertions(+), 4 deletio

Re: [PATCH] staging: rtl8723bs: core fix warning "Comparison to bool"

On Sun, 2019-05-12 at 17:49 +0530, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > drivers/staging/rtl8723bs/core/rtw_cmd.c:1741:7-17: WARNING: Comparison > to bool [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c > b/drivers/staging/rtl8723bs/core/rtw_cmd.c [] > @@ -1

[PATCH] staging :rtl8723bs :core fix WARNING: Comparison to bool

fix below warning reported by coccicheck drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:181:5-40: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl872

Re: [Linux-kernel-mentees] [PATCH] Staging: kpc2000: kpc_dma: resolve checkpath errors and warnings

On 11/05/19 2:04 AM, Lukas Bulwahn wrote: > On Fri, May 10, 2019 at 9:39 PM Vandana BN wrote: >> This patch resolves coding style errors and warnings reported by chechpatch >> > I did not look at the patch in detail, but you might want to also > consider to replace the CamlCase (function) names

[PATCH] staging: rtl8723bs: core fix warning Comparison to bool

fix below issue reported by coccicheck drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/cor

[PATCH] staging: rtl8723bs: core fix warning "Comparison to bool"

fix below issue reported by coccicheck drivers/staging/rtl8723bs/core/rtw_cmd.c:1741:7-17: WARNING: Comparison to bool Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/r

[PATCH] drivers: staging :rtl8723bs :os_dep Remove Unneeded variable ret

fix below issue reported by coccicheck drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2685:5-8: Unneeded variable: "ret". Return "0" on line 3266 Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --gi

[PATCH v3] drivers: staging : wlan-ng : collect return status without variable

As caller rdev_set_default_key not particular about -EFAULT. We can preserve the return value of prism2_domibset_uint32. Signed-off-by: Hariprasad Kelam Changes in v2: - remove masking of original return value with EFAULT Changes in v3: - merge patch v1 and v2 sothat it can be applied

ION doesn't set the cache attributes according to ION_FLAG_CACHED buffer flag

Hi, Mapping the buffer to user space, ION failed to set the cache attributes according to ION_FLAG_CACHED flag on x86. When the reserved memory (reserved by memmap= kernel boot option) or part of it is mapped to the user space, the user space memory mapping is always *uncachable*. ION uses remap

[PATCH -next] staging: kpc2000: remove unused function kp2000_cdev_write

There is no callers in tree, so can be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/kpc2000/kpc2000/fileops.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/fileops.c b/drivers/staging/kpc2000/kpc2000/fileops.c index