Re: [PATCH] staging: most: protect potential string overflow

2019-04-25 Thread Bo YU
On Wed, Apr 24, 2019 at 10:55 PM Dan Carpenter wrote: > > On Mon, Apr 22, 2019 at 10:20:18PM -0400, Bo YU wrote: > > There maybe cause potential string overflow issue due to use > > strcpy without checking the length > > > > Detected By CoversityScan CID# 1444760 > > > > Fixes: 131ac62253dba:(stag

Your Notice

2019-04-25 Thread Mrs Huda Alghoson
Great Opportunity awaits you, reply to my private email below for details. Mrs Huda Alghoson (Saudi Aramco) huda.algho...@gmail.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-dev

[PATCH 6/6] media: staging/imx: Re-organize modules

2019-04-25 Thread Steve Longerbeam
Re-organize modules, and which objects are linked into those modules, so that: - imx6-media (renamed from imx-media) is the media driver module for imx5/6 only, and has no symbol exports. The IPU internal subdevice objects now link directly with imx6-media. - imx6-media-csi (renamed from imx-

[PATCH 5/6] media: staging/imx: Remove capture_device_set_format

2019-04-25 Thread Steve Longerbeam
Don't propagate the source pad format to the connected capture device. It's now the responsibility of userspace to call VIDIOC_S_FMT on the capture device to ensure the capture format and compose rectangle are compatible with the connected source. To check this, validate the capture format with the

[PATCH 1/6] media: staging/imx: Switch to sync registration for IPU subdevs

2019-04-25 Thread Steve Longerbeam
Because the IPU sub-devices VDIC and IC are not present in the device-tree, platform devices were created for them instead. This allowed these sub-devices to be added to the media device's async notifier and registered asynchronously along with the other sub-devices that do have a device-tree prese

[PATCH 4/6] Revert "media: imx: Set capture compose rectangle in capture_device_set_format"

2019-04-25 Thread Steve Longerbeam
Rvert this commit, as imx_media_capture_device_set_format() will be removed. This reverts commit 5964cbd8692252615370b77eb96764dd70c2f837. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++-- drivers/staging/media/imx/imx-media-capture.c | 24 +---

[PATCH 3/6] media: staging/imx: Move add_video_device into capture_device_register

2019-04-25 Thread Steve Longerbeam
Move imx_media_add_video_device() into imx_media_capture_device_register(). Also the former has no error conditions to convert to void. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 - drivers/staging/media/imx/imx-media-capture.c | 3 +++ drivers/st

[PATCH 2/6] media: staging/imx: Pass device to alloc/free_dma_buf

2019-04-25 Thread Steve Longerbeam
Allocate and free a DMA coherent buffer in imx_media_alloc/free_dma_buf() from the given device. This allows DMA alloc and free using a device that is backed by real hardware, which for the imx5/6/7 CSI is the CSI unit, and for the internal IPU sub-devices, is the parent IPU. Signed-off-by: Steve

Re: [PATCH] staging: xgifb: delete the driver

2019-04-25 Thread Aaro Koskinen
Hi, On Fri, Jan 18, 2019 at 12:20:28PM +0100, Daniel Vetter wrote: > On Fri, Jan 18, 2019 at 11:08:28AM +0100, Greg Kroah-Hartman wrote: > > There has not been any real work done on cleaning this driver up and > > getting it out of the staging tree in years. Also, no new fb drivers > > are being

Re: [PATCH] staging: rtl8192u: ieee80211: Replace bit shifting with BIT macro

2019-04-25 Thread Gustavo A. R. Silva
Hi Vatsala, On 4/25/19 1:33 PM, Vatsala Narang wrote: > Challenge suggested by coccinelle. > I think you mean *change*. See more comments below... > Replace bit shifting on 1 with the BIT(x) macro. > Coccinelle script: > > @@ > expression c; > @@ > > -(1 << c) > +BIT(c) > > Signed-off-by:

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Johannes Berg
On Thu, 2019-04-25 at 17:55 +0200, Arnd Bergmann wrote: > On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > > > If I understand your patch description well, using compat_ptr_ioctl > > > only works if the driver is

Re: [PATCH] staging: rtl8723bs: core: Remove return in void function

2019-04-25 Thread Julia Lawall
On Fri, 26 Apr 2019, Vatsala Narang wrote: > Remove return in void function to get rid of checkpatch warning. > > Signed-off-by: Vatsala Narang Acked-by: Julia Lawall > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging

[PATCH] staging: rtl8723bs: core: Remove return in void function

2019-04-25 Thread Vatsala Narang
Remove return in void function to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 094d61bcb

[PATCH 1/2] staging: refer to TODO in Kconfig help text

2019-04-25 Thread Aaro Koskinen
Refer to TODO file instead of driver_name.README that does not seem to be used. Signed-off-by: Aaro Koskinen --- drivers/staging/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 62951e836cbc..35aa09ed3972 1006

[PATCH 2/2] staging: octeon-ethernet: add TODO

2019-04-25 Thread Aaro Koskinen
Add missing TODO to describe the plan to get this driver out of staging. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/TODO | 9 + 1 file changed, 9 insertions(+) create mode 100644 drivers/staging/octeon/TODO diff --git a/drivers/staging/octeon/TODO b/drivers/staging/octeon/

[PATCH] staging: rtl8192u: ieee80211: Replace bit shifting with BIT macro

2019-04-25 Thread Vatsala Narang
Challenge suggested by coccinelle. Replace bit shifting on 1 with the BIT(x) macro. Coccinelle script: @@ expression c; @@ -(1 << c) +BIT(c) Signed-off-by: Vatsala Narang --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [PATCH] staging: comedi: comedi_isadma: Use a non-NULL device for DMA API

2019-04-25 Thread Greg Kroah-Hartman
On Thu, Apr 25, 2019 at 05:26:44PM +0100, Ian Abbott wrote: > The "comedi_isadma" module calls `dma_alloc_coherent()` and > `dma_free_coherent()` with a NULL device pointer which is no longer > allowed. If the `hw_dev` member of the `struct comedi_device` has been > set to a valid device, that can

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Al Viro
On Thu, Apr 25, 2019 at 05:55:23PM +0200, Arnd Bergmann wrote: > On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > > > If I understand your patch description well, using compat_ptr_ioctl > > > only works if the drive

[PATCH] staging: comedi: comedi_isadma: Use a non-NULL device for DMA API

2019-04-25 Thread Ian Abbott
The "comedi_isadma" module calls `dma_alloc_coherent()` and `dma_free_coherent()` with a NULL device pointer which is no longer allowed. If the `hw_dev` member of the `struct comedi_device` has been set to a valid device, that can be used instead. Unfortunately, all the current users of the "come

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Al Viro
On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > If I understand your patch description well, using compat_ptr_ioctl > only works if the driver is not for s390, right? No; s390 is where "oh, just set ->compat_ioctl same as ->unlocked_ioctl and be done with that; compat_ptr

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Arnd Bergmann
On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s390 is where "oh, just set ->compat_ioct

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Apr 2019 16:35:34 +0100 Al Viro escreveu: > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s390 is where "oh, just set ->co

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
Em Tue, 16 Apr 2019 22:25:33 +0200 Arnd Bergmann escreveu: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architectur

[PATCH v3 0/2] MT7621 PCIe PHY

2019-04-25 Thread Sergio Paracuellos
This series adds support for the PCIe PHY found in the Mediatek MT7621 SoC. This is the first attempt to get feedback of what is missing in this driver to be promoted from staging. There is also a 'mt7621-pci' driver which is the controller part which is still in staging and is a client of this p

[PATCH v3 1/2] dt-bindings: phy: Add binding for Mediatek MT7621 PCIe PHY

2019-04-25 Thread Sergio Paracuellos
Add bindings to describe Mediatek MT7621 PCIe PHY. Reviewed-by: Rob Herring Signed-off-by: Sergio Paracuellos --- .../bindings/phy/mediatek,mt7621-pci-phy.txt | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt7621-p

[PATCH v3 2/2] phy: ralink: Add PHY driver for MT7621 PCIe PHY

2019-04-25 Thread Sergio Paracuellos
This patch adds a driver for the PCIe PHY of MT7621 SoC. Signed-off-by: Sergio Paracuellos --- drivers/phy/ralink/Kconfig | 8 + drivers/phy/ralink/Makefile | 1 + drivers/phy/ralink/phy-mt7621-pci.c | 423 3 files changed, 432 insertions(+) cre

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Arnd Bergmann
On Thu, Apr 25, 2019 at 5:22 PM Mauro Carvalho Chehab wrote: > Em Tue, 16 Apr 2019 22:25:33 +0200 Arnd Bergmann escreveu: > > If I understand your patch description well, using compat_ptr_ioctl > only works if the driver is not for s390, right? No, the purpose of compat_ptr_ioctl() is to make su

Re: [PATCH v2] staging: kpc2000: Add DMA driver

2019-04-25 Thread 'gre...@linuxfoundation.org'
On Mon, Apr 22, 2019 at 10:05:58PM +, Matt Sickler wrote: > Add Daktronics DMA driver. I've added the SPDX license identifiers, Kconfig > entry, and cleaned up as many of the warnings as I could. > > The AIO support code will be removed in a future patch. > > Signed-off-by: Matt Sickler Lo

[PATCH v4 3/4] media: pixfmt: Document the HEVC slice pixel format

2019-04-25 Thread Paul Kocialkowski
Document the current state of the HEVC slice pixel format. The format will need to evolve in the future, which is why it is not part of the public API. Signed-off-by: Paul Kocialkowski --- .../media/uapi/v4l/pixfmt-compressed.rst | 21 +++ 1 file changed, 21 insertions(+) d

[PATCH v4 4/4] media: cedrus: Add HEVC/H.265 decoding support

2019-04-25 Thread Paul Kocialkowski
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with both uni-directional and bi-directional prediction modes supported. Field-coded (interlaced) pictures, custom quantization matrices and 10-bit output are not supported at this point. Signed-off-by: Paul Kocialkowski --- drive

[PATCH v4 2/4] media: pixfmt: Add HEVC slice pixel format

2019-04-25 Thread Paul Kocialkowski
Introduce the V4L2_PIX_FMT_HEVC_SLICE pixel format, which currently describes an output buffer with enough appended slice data for producing one decoded frame with a stateless video decoder. This will need to be reworked (along with the controls and the core) to allow passing slice data individual

[PATCH v4 0/4] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-04-25 Thread Paul Kocialkowski
This is early support for HEVC/H.265 stateless decoding in V4L2, including both definitions and driver support for the Cedrus VPU driver, which concerns Allwinner devices. A specific pixel format is introduced for the HEVC slice format and controls are provided to pass the bitstream metadata to th

[PATCH v4 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-04-25 Thread Paul Kocialkowski
This introduces the required definitions for HEVC decoding support with stateless VPUs. The controls associated to the HEVC slice format provide the required meta-data for decoding slices extracted from the bitstream. They are not exported to the public V4L2 API since reworking this API will be ne