[PATCH V2] staging: vc04_services: handle kzalloc failure

The kzalloc here was being used without checking the return - if the kzalloc fails return VCHIQ_ERROR. The call-site of vchiq_platform_init_state() vchiq_init_state() was not responding to an allocation failure so checks for != VCHIQ_SUCCESS and pass VCHIQ_ERROR up to vchiq_platform_init() which th

Re: [PATCH] media: staging/imx: add media device to capture register

Acked-by: Steve Longerbeam On 4/12/19 9:44 AM, Rui Miguel Silva wrote: When register the capture media device it is assumed that the device data is the media device. In the imx6 case is but in the imx7 is not case. The device data is the csi structure. Add the explicit argument of the media de

Re: [PATCH] media: staging/imx: add media device to capture register

Hi Rui, Thank you for the patch. On Fri, Apr 12, 2019 at 05:44:00PM +0100, Rui Miguel Silva wrote: > When register the capture media device it is assumed that the device > data is the media device. In the imx6 case is but in the imx7 is not > case. The device data is the csi structure. > > Add t

Re: [PATCH v2] staging: greybus: power_supply: use struct_size() helper

On 4/18/19 1:27 AM, Johan Hovold wrote: > On Wed, Apr 17, 2019 at 01:44:40PM -0500, Gustavo A. R. Silva wrote: >> Make use of the struct_size() helper instead of an open-coded version >> in order to avoid any potential type mistakes, in particular in the >> context in which this code is being us

Re: [PATCH] staging: rtl8723bs: hal: fix spelling mistake "singal" -> "signal"

On 4/18/2019 5:50 PM, Colin King wrote: From: Colin Ian King There are multiple spelling mistakes in variable names, fix these. Signed-off-by: Colin Ian King Well, this one a bit sensitive to touch. Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/rtl8723bs/hal/hal_com.

Re: [PATCH RFC] staging: vc04_services: handle kzalloc failure

On 18.04.19 12:29, Nicholas Mc Guire wrote: > The kzalloc here was being used without checking the return - if the > kzalloc fails return VCHIQ_ERROR. The call-site of > vchiq_platform_init_state() vchiq_init_state() was not responding > to an allocation failure so checks for != VCHIQ_SUCCESS > and

[PATCH] staging: rtl8723bs: hal: fix spelling mistake "singal" -> "signal"

From: Colin Ian King There are multiple spelling mistakes in variable names, fix these. Signed-off-by: Colin Ian King --- drivers/staging/rtl8723bs/hal/hal_com.c | 18 +- drivers/staging/rtl8723bs/include/rtw_recv.h | 4 ++-- 2 files changed, 11 insertions(+), 11 deletion

Re: [PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl

On Tue, Apr 16, 2019 at 10:19:47PM +0200, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg Kroah-Har

[PATCH RFC] staging: vc04_services: handle kzalloc failure

The kzalloc here was being used without checking the return - if the kzalloc fails return VCHIQ_ERROR. The call-site of vchiq_platform_init_state() vchiq_init_state() was not responding to an allocation failure so checks for != VCHIQ_SUCCESS and pass VCHIQ_ERROR up to vchiq_platform_init() which th

Re: [PATCH v2] staging: greybus: power_supply: use struct_size() helper

Oi Gustavo, Thanks for the patch, and the rebasing. On Wed 17 Apr 2019 at 19:44, Gustavo A. R. Silva wrote: Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, r