Re: [PATCH] staging: gdm724x: Add parenthesis to Macro arguments

On Tue, Apr 02, 2019 at 10:04:05PM -0300, Andre Dainez wrote: > Fix checkpatch errors: > > CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence > issues > CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence > issues > > Signed-off-by: Andre Dainez > ---

[PATCH] staging: vchiq_arm: remove space after open '('

Fix checkpatch error "ERROR: space prohibited after that open parenthesis '('" in vchiq_arm.c:563. Signed-off-by: Mario Balan --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interf

[PATCH] staging: gdm724x: Add parenthesis to Macro arguments

Fix checkpatch errors: CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues Signed-off-by: Andre Dainez --- drivers/staging/gdm724x/netlink_k.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] Staging: rtl8192e: Fix spaces around "+"

Fix checkpatch error: CHECK: spaces preferred around that '+' (ctx:VxV) 99: FILE: drivers/staging/rtl8192e/rtllib_module.c:99: + memset(ieee, 0, sizeof(struct rtllib_device)+sizeof_priv); Signed-off-by: Hildo Guillardi Júnior --- drivers/staging/rtl8192e/rtllib_module.c | 2 +- 1 file chan

[PATCH] media: zoran: remove unnecessary space

fix the following errors from checkpath: WARNING: Unnecessary space before function pointer arguments + void (*init) (struct zoran *zr); Signed-off-by: Gilberto Martinez Jr --- drivers/staging/media/zoran/zoran.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

On Tue, Apr 02 2019, Christian Lütke-Stetzkamp wrote: > On Wed, Apr 03, 2019 at 06:51:49AM +1100, NeilBrown wrote: >> People keep telling me that drivers/mmc/host/mtk-sd.c should be able to >> handle the same hardware as this driver, with a little bit of work. >> Unfortunately they haven't told me

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

On Wed, Apr 03, 2019 at 06:51:49AM +1100, NeilBrown wrote: > People keep telling me that drivers/mmc/host/mtk-sd.c should be able to > handle the same hardware as this driver, with a little bit of work. > Unfortunately they haven't told me what the little bit of work involves. > > Have you explore

[PATCH] staging: iio: frequency: ad9834: Remove unnecessary parentheses

Remove unneeded parentheses around the arguments of ||. This reduces clutter and code behave in the same way. Change suggested by checkpatch.pl. CHECK: Unnecessary parentheses around 'st->devid == ID_AD9833' CHECK: Unnecessary parentheses around 'st->devid == ID_AD9837' Signed-off-by: Melissa Wen

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

On Tue, Apr 02 2019, George Hilliard wrote: > On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman > wrote: > >> The license text in this driver is "interesting" and not really obvious >> that it is supposed to be able to be distributed in the kernel source >> tree. Yes, the MODULE_LICENSE() text say

Your Outward Payment Advice, ACC: 01XXXXX3404 dated 02-April-2019

Dear Customer, Thank you for banking with Standard Chartered Bank Attached is your Debit Advice as per your request. Kindly note that your e-Advice is in PDF format. If you are unable to open the attachment please download Adobe Acrobat Reader by clicking at: www.adobe.com The PDF file is passw

Re: [PATCH 15/16] staging: media: imx: add proper SPDX identifiers on files that did not have them.

Acked-by: Steve Longerbeam On 4/2/19 3:32 AM, Greg Kroah-Hartman wrote: There were a few files for the imx media drivers that did not have SPDX identifiers on them, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for

[driver-core:driver-core-testing 4/14] arch/ia64/kernel/acpi.c:669:38: error: passing argument 2 of 'acpi_table_parse' from incompatible pointer type

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing head: 5e29ef654e7be73a579b96c1b912dac5cea33046 commit: 088d0b345be1952be1a5004fb78cfffa0835cbe1 [4/14] acpi: Create subtable parsing infrastructure config: ia64-allmodconfig (attached as .config)

Re: [PATCH 4/4] staging: iio: ad9832: add devicetree documentation

On 04/02, Alexandru Ardelean wrote: > On Mon, Apr 1, 2019 at 5:38 PM Marcelo Schmitt > wrote: > > > > Add a devicetree documentation for the ad9832 direct digital > > synthesizer, waveform generator. > > > > Signed-off-by: Marcelo Schmitt > > --- > > .../bindings/iio/frequency/ad9832.txt

Re: Work on iio: stating: frequency: ad9832

On 04/02, Alexandru Ardelean wrote: > On Mon, Apr 1, 2019 at 7:13 PM Jonathan Cameron > wrote: > > > > On Mon, 1 Apr 2019 11:25:29 -0300 > > Marcelo Schmitt wrote: > > > > > Hello, > > > > > > I was looking for some work on staging: iio: ad9832 and made some > > > observations while reading the d

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

On 04/01, Greg KH wrote: > On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > > > Signed-off-by: Marcelo Schmitt > > > --- > > > drivers/staging/iio/frequency/ad983

Re: [PATCH 16/16] staging: media: tegra-vde: add proper SPDX identifiers on file that did not have it.

On Tue, Apr 02, 2019 at 12:32:03PM +0200, Greg Kroah-Hartman wrote: > There was a single file for the tegra-vde driver that did not have SPDX > identifiers on it, so fix that up. At the same time, remove the "free > form" text that specified the license of the file, as that is impossible > for any

[PATCH 1/3] iio: adc: ad7606: Move oversampling options in chip info and rework *_avail attributes

From: Stefan Popa Available oversampling ratios and scales can be shown by calling a common ad7606_show_avail function which takes as parameters the array which stores the values, together with the size of the array. Oversampling options are now defined in chip info structure and they are loaded

Your Outward Payment Advice, ACC: 01XXXXX3404 dated 02-April-2019

Dear Customer, Thank you for banking with Standard Chartered Bank Attached is your Debit Advice as per your request. Kindly note that your e-Advice is in PDF format. If you are unable to open the attachment please download Adobe Acrobat Reader by clicking at: www.adobe.com The PDF file is passw

Your Outward Payment Advice, ACC: 01XXXXX3404 dated 02-April-2019

Dear Customer, Thank you for banking with Standard Chartered Bank Attached is your Debit Advice as per your request. Kindly note that your e-Advice is in PDF format. If you are unable to open the attachment please download Adobe Acrobat Reader by clicking at: www.adobe.com The PDF file is passw

[PATCH] staging: pi433: Return thread immediately when kthread_should_stop() call.

When kthread_stop() called by removing module, running thread should return immediately. Otherwise, It is very dangerous that thread may access any released data like struct pi433_device. Signed-off-by: Sidong Yang --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH 02/16] staging: add missing SPDX lines to Makefile files

On 4/2/2019 4:01 PM, Greg Kroah-Hartman wrote: There are a few remaining drivers/staging/*/Makefile files that do not have SPDX identifiers in them. Add the correct GPL-2.0 identifier to them to make scanning tools happy. Signed-off-by: Greg Kroah-Hartman Lesson learnt :-) Reviewed-by: Mu

Re: [PATCH v3 1/2] media: v4l: Add definitions for the HEVC slice format and controls

On 2/14/19 10:53 AM, Paul Kocialkowski wrote: > This introduces the required definitions for HEVC decoding support with > stateless VPUs. The controls associated to the HEVC slice format provide > the required meta-data for decoding slices extracted from the bitstream. > > This interface comes wit

[PATCH] staging: most: core: use device description as name

This patch uses the device description to clearly identity a device attached to the bus. It is needed as the currently useed mdevX notation is not sufficiant in case more than one network interface controller is being used at the same time. Cc: sta...@vger.kernel.org Signed-off-by: Christian Gromm

[PATCH 3/3] dt-bindings: iio: adc: Add AD7616 ADC documentation

Document support for AD7616 Analog to Digital Converter. Signed-off-by: Beniamin Bia --- Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt b/Documentation/devicetree/bindings/iio/

[PATCH 2/3] iio: adc: ad7616: Add support for AD7616 ADC

The AD7616 is a 12-bit ADC with 16 channels. The AD7616 can be configured to work in hardware mode by controlling it via gpio pins and read data via spi. No support for software mode yet, but it is a work in progress. This device requires a reset in order to update oversampling, so chip info has

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

On Tue, Apr 02, 2019 at 06:16:47AM -0500, George Hilliard wrote: > On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman > wrote: > > > The license text in this driver is "interesting" and not really obvious > > that it is supposed to be able to be distributed in the kernel source > > tree. Yes, the M

Re: [PATCH 05/16] staging: vc04_services: add proper SPDX identifier for dual licensed files

Am 02.04.19 um 12:31 schrieb Greg Kroah-Hartman: > There are a number of vc04_services files that are dual licensed under > the GPL2 and BSD-3 licenses. They currently do not have a SPDX > identifier on them, so fix that up and add the proper identifier so that > tools can pick it up easily. > > C

Re: [PATCH 06/16] staging: vc04_services: remove remaining redundant license text

Am 02.04.19 um 12:31 schrieb Greg Kroah-Hartman: > Now that the SPDX tag is in all vc04_services files, that identifies the > license in a specific and legally-defined manner. So the extra GPL and > BSD text wording can be removed as it is no longer needed at all. > > This is done on a quest to re

Re: [PATCH v3 07/14] staging: most: core: use device description as name

On Tue, Apr 02, 2019 at 09:21:09AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 11:00 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Tue, Apr 02, 2019 at 08:10:25AM +, Christian.Gromm@microchip.c > > om wrote: > > > > > > On Di, 2019-04-02 at 09:24 +0200, Greg

[PATCH 05/16] staging: vc04_services: add proper SPDX identifier for dual licensed files

There are a number of vc04_services files that are dual licensed under the GPL2 and BSD-3 licenses. They currently do not have a SPDX identifier on them, so fix that up and add the proper identifier so that tools can pick it up easily. Cc: Eric Anholt Cc: Stefan Wahren Cc: Tuomas Tynkkynen Cc:

[PATCH 08/16] staging: iio: add proper SPDX identifiers to remaining driver files

There are a number of IIO staging drivers that do not have a proper SPDX identifier on it. So fix that up and at the same time, remove the "free form" license text, as that's pretty much impossible for any tool to parse. Cc: Lars-Peter Clausen Cc: Michael Hennerich Cc: Jonathan Cameron Cc: Har

[PATCH 11/16] staging: rtl8192e: add proper SPDX identifiers on files that did not have them.

There were a few files for the rtl8192e driver that did not have SPDX identifiers on them, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Signed-off-by: Greg Kroah-Hartman --- .../stagin

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

On Tue, Apr 02, 2019 at 09:45:35AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 11:01 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Tue, Apr 02, 2019 at 08:17:02AM +, Christian.Gromm@microchip.c > > om wrote: > > > > > > On Di, 2019-04-02 at 09:25 +0200, Greg

[PATCH 06/16] staging: vc04_services: remove remaining redundant license text

Now that the SPDX tag is in all vc04_services files, that identifies the license in a specific and legally-defined manner. So the extra GPL and BSD text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel desc

[PATCH 09/16] staging: rtl8192u: add proper SPDX identifiers on files that did not have them.

There were a few files for the rtl8192u driver that did not have SPDX identifiers on them, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Cc: John Whitmore Cc: Bhanusree Pola Cc: Sanjana

[PATCH 07/16] staging: comedi: quatec_daqp_cs: add proper SPDX identifier to driver

By default all files without license information are under the default license of the kernel, which is GPL version 2. Because of this, add the GPL-2.0 identifier to the quatec_daqp_cs driver which did not have any license identifiers in it at all. Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Brent

[PATCH 12/16] staging: rtl8192e: delete license file.

There is no need for yet-another-copy of the gpl to be in the kernel source tree, especially for just a single driver. This got added as part of the import of the driver from when it was a stand-along chunk of code. Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/license | 339 --

[PATCH 16/16] staging: media: tegra-vde: add proper SPDX identifiers on file that did not have it.

There was a single file for the tegra-vde driver that did not have SPDX identifiers on it, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Cc: Dmitry Osipenko Cc: Mauro Carvalho Chehab Cc

[PATCH 15/16] staging: media: imx: add proper SPDX identifiers on files that did not have them.

There were a few files for the imx media drivers that did not have SPDX identifiers on them, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Cc: Steve Longerbeam Cc: Philipp Zabel Cc: Mau

[PATCH 02/16] staging: add missing SPDX lines to Makefile files

There are a few remaining drivers/staging/*/Makefile files that do not have SPDX identifiers in them. Add the correct GPL-2.0 identifier to them to make scanning tools happy. Signed-off-by: Greg Kroah-Hartman --- drivers/staging/android/Makefile | 1 + drivers/staging/ax

[PATCH 13/16] staging: media: zoran: add proper SPDX identifiers on files that did not have them.

There were a few files for the zoran driver that did not have SPDX identifiers on them, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: linu

[PATCH 04/16] staging: sm750fb: add proper SPDX identifier to driver

By default all files without license information are under the default license of the kernel, which is GPL version 2. Because of this, add the GPL-2.0 identifier to the sm750fb driver which did not have any license identifiers in it at all. Cc: Sudip Mukherjee Cc: Teddy Wang Signed-off-by: Greg

[PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the license

[PATCH 14/16] staging: media: soc_camera: add proper SPDX identifiers on files that did not have them.

There were a few files for the soc_camera drivers that did not have SPDX identifiers on them, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Cc: Mauro Carvalho Chehab Cc: Shawn Guo Cc: S

[PATCH 01/16] staging: add missing SPDX lines to Kconfig files

There are a few remaining drivers/staging/*/Kconfig files that do not have SPDX identifiers in them. Add the correct GPL-2.0 identifier to them to make scanning tools happy. Signed-off-by: Greg Kroah-Hartman --- drivers/staging/Kconfig | 1 + drivers/staging/android

[PATCH 10/16] staging: ralink-gdma: add proper SPDX identifiers on ralink-gdma file

The ralink-gdma.c driver did not have a SPDX identifier on it, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Cc: Lars-Peter Clausen Signed-off-by: Greg Kroah-Hartman --- drivers/stagin

[PATCH 00/16] staging: fix up remaining SPDX problems in drivers/staging

There are still some remaining SPDX file identifiers missing in the drivers/staging/ tree. When a new-developer comes along and tries to fix up checkpatch.pl issues, and sends in a SPDX change, it is almost always wrong as the developer doesn't really know the meaning behind the tags or what needs

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

On Di, 2019-04-02 at 11:01 +0200, Greg KH wrote: > External E-Mail > > > On Tue, Apr 02, 2019 at 08:17:02AM +, Christian.Gromm@microchip.c > om wrote: > > > > On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote: > > > > > > External E-Mail > > > > > > > > > On Mon, Apr 01, 2019 at 02:05:38PM

Re: [PATCH v3 07/14] staging: most: core: use device description as name

On Di, 2019-04-02 at 11:00 +0200, Greg KH wrote: > External E-Mail > > > On Tue, Apr 02, 2019 at 08:10:25AM +, Christian.Gromm@microchip.c > om wrote: > > > > On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote: > > > > > > External E-Mail > > > > > > > > > On Mon, Apr 01, 2019 at 02:05:32PM

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

On Tue, Apr 02, 2019 at 08:17:02AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote: > > > > > > This patch introduces attribute names that are more self

Re: [PATCH v3 07/14] staging: most: core: use device description as name

On Tue, Apr 02, 2019 at 08:10:25AM +, christian.gr...@microchip.com wrote: > On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote: > > External E-Mail > > > > > > On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote: > > > > > > This patch uses the device description to clearly identit

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote: > External E-Mail > > > On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote: > > > > This patch introduces attribute names that are more self > > explaining. > > > > Signed-off-by: Christian Gromm > > --- > > v2: > > - follow-up

Re: [PATCH v3 07/14] staging: most: core: use device description as name

On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote: > External E-Mail > > > On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote: > > > > This patch uses the device description to clearly identity a device > > attached to the bus. It is needed as the currently useed mdevX > > notation is

Re: [PATCH v3 05/14] staging: most: enable configfs support

On Di, 2019-04-02 at 09:20 +0200, Greg KH wrote: > External E-Mail > > > On Mon, Apr 01, 2019 at 02:05:30PM +0200, Christian Gromm wrote: > > > > This patch enables the configfs functionality of the driver by > > registering the configfs subsystems and compiling the configfs > > part of the sour

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote: > This patch introduces attribute names that are more self explaining. > > Signed-off-by: Christian Gromm > --- > v2: > - follow-up adaptions due to changes introduced w/ [PATCH v2 01/14] > v3: > > drivers/staging/most/confi

Re: [PATCH v3 07/14] staging: most: core: use device description as name

On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote: > This patch uses the device description to clearly identity a device > attached to the bus. It is needed as the currently useed mdevX > notation is not sufficiant in case more than one network > interface controller is being used at

Re: [PATCH v3 05/14] staging: most: enable configfs support

On Mon, Apr 01, 2019 at 02:05:30PM +0200, Christian Gromm wrote: > This patch enables the configfs functionality of the driver by > registering the configfs subsystems and compiling the configfs > part of the sources. > > Signed-off-by: Christian Gromm > --- > v2: > - remove call to configf

Re: Work on iio: stating: frequency: ad9832

On Mon, Apr 1, 2019 at 7:13 PM Jonathan Cameron wrote: > > On Mon, 1 Apr 2019 11:25:29 -0300 > Marcelo Schmitt wrote: > > > Hello, > > > > I was looking for some work on staging: iio: ad9832 and made some > > observations while reading the driver. > > > > Apparently it had no devicetree documenta