Re: [PATCH net-next] switchdev: Remove unused transaction item queue

2019-02-27 Thread Jiri Pirko
Thu, Feb 28, 2019 at 01:29:16AM CET, f.faine...@gmail.com wrote: >There are no more in tree users of the >switchdev_trans_item_{dequeue,enqueue} or switchdev_trans_item structure >in the kernel since commit 00fc0c51e35b ("rocker: Change world_ops API >and implementation to be switchdev independant"

[PATCH net-next] switchdev: Remove unused transaction item queue

2019-02-27 Thread Florian Fainelli
There are no more in tree users of the switchdev_trans_item_{dequeue,enqueue} or switchdev_trans_item structure in the kernel since commit 00fc0c51e35b ("rocker: Change world_ops API and implementation to be switchdev independant"). Remove this unused code and update the documentation accordingly

Re: [PATCH net-next v3 0/8] net: Remove switchdev_ops

2019-02-27 Thread David Miller
From: Florian Fainelli Date: Wed, 27 Feb 2019 11:44:24 -0800 > This patch series completes the removal of the switchdev_ops by > converting switchdev_port_attr_set() to use either the blocking > (process) or non-blocking (atomic) notifier since we typically need to > deal with both depending on w

[PATCH 1/2] staging: rtl8188eu: remove unused enum P2P_PROTO_WK_ID

2019-02-27 Thread Michael Straube
Enumeration P2P_PROTO_WK_ID is not used in the driver code, so remove it from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/wifi.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/i

[PATCH 2/2] staging: rtl8188eu: remove unused P2P_PRIVATE_IOCTL_SET_LEN

2019-02-27 Thread Michael Straube
Defined P2P_PRIVATE_IOCTL_SET_LEN is not used in the driver code, so remove it from wifi.h. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/wifi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/inclu

Re: [PATCH net-next v3 0/8] net: Remove switchdev_ops

2019-02-27 Thread Ido Schimmel
On Wed, Feb 27, 2019 at 11:44:24AM -0800, Florian Fainelli wrote: > Hi all, > > This patch series completes the removal of the switchdev_ops by > converting switchdev_port_attr_set() to use either the blocking > (process) or non-blocking (atomic) notifier since we typically need to > deal with bot

Re: [PATCH net-next v3 8/8] net: Remove switchdev_ops

2019-02-27 Thread Ido Schimmel
On Wed, Feb 27, 2019 at 11:44:32AM -0800, Florian Fainelli wrote: > Now that we have converted all possible callers to using a switchdev > notifier for attributes we do not have a need for implementing > switchdev_ops anymore, and this can be removed from all drivers the > net_device structure. >

Re: [PATCH net-next v3 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-27 Thread Ido Schimmel
On Wed, Feb 27, 2019 at 11:44:31AM -0800, Florian Fainelli wrote: > Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field > from all clients, which were migrated to use switchdev notification in > the previous patches. > > Add a new function switchdev_port_attr_notify() that send

Re: [PATCH] staging: mt7621-pci: Tidy whitespace

2019-02-27 Thread Sergio Paracuellos
Hi Mikhail, On Wed, Feb 27, 2019 at 8:54 PM Mikhail Gusarov wrote: > > Fix missing whitespace around punctuation and beginning-of-line spaces > in pci-mt7621.c. > > Signed-off-by: Mikhail Gusarov > --- > drivers/staging/mt7621-pci/pci-mt7621.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 de

[PATCH] staging: mt7621-pci: Tidy whitespace

2019-02-27 Thread Mikhail Gusarov
Fix missing whitespace around punctuation and beginning-of-line spaces in pci-mt7621.c. Signed-off-by: Mikhail Gusarov --- drivers/staging/mt7621-pci/pci-mt7621.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/

[PATCH net-next v3 5/8] net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Florian Fainelli
Following patches will change the way we communicate setting a port's attribute and use notifiers to perform those tasks. Ocelot does not currently have an atomic notifier registered for switchdev events, so we need to register one in order to deal with atomic context SWITCHDEV_PORT_ATTR_SET event

[PATCH net-next v3 4/8] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Florian Fainelli
Following patches will change the way we communicate setting a port's attribute and use a notifier to perform those tasks. Prepare mlxsw to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_SET and utilize the switchdev_handle_port_attr_set() to handle stacking of devices. Reviewed-

[PATCH net-next v3 0/8] net: Remove switchdev_ops

2019-02-27 Thread Florian Fainelli
Hi all, This patch series completes the removal of the switchdev_ops by converting switchdev_port_attr_set() to use either the blocking (process) or non-blocking (atomic) notifier since we typically need to deal with both depending on where in the bridge code we get called from. This was tested w

[PATCH net-next v3 2/8] rocker: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Florian Fainelli
Following patches will change the way we communicate setting a port's attribute and use notifiers towards that goal. Prepare rocker to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_SET from both atomic and process context and use a small helper to translate the event notifier int

[PATCH net-next v3 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Florian Fainelli
In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel Reviewed-by: Ido Schimmel Signed-off-by: Florian Fainelli --- include/net/swi

[PATCH net-next v3 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-27 Thread Florian Fainelli
Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field from all clients, which were migrated to use switchdev notification in the previous patches. Add a new function switchdev_port_attr_notify() that sends the switchdev notifications SWITCHDEV_PORT_ATTR_SET and calls the blocking

[PATCH net-next v3 6/8] staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Florian Fainelli
Following patches will change the way we communicate setting a port's attribute and use a blocking notifier to perform those tasks. Prepare ethsw to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_SET and simply translate that into the existing swdev_port_attr_set() call. Signed-o

[PATCH net-next v3 8/8] net: Remove switchdev_ops

2019-02-27 Thread Florian Fainelli
Now that we have converted all possible callers to using a switchdev notifier for attributes we do not have a need for implementing switchdev_ops anymore, and this can be removed from all drivers the net_device structure. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/mellanox/mlxsw/sp

[PATCH net-next v3 3/8] net: dsa: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Florian Fainelli
Following patches will change the way we communicate setting a port's attribute and use notifiers towards that goal. Prepare DSA to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_SET from both atomic and process context and use a small helper to translate the event notifier into s

Re: [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-27 Thread Ira Weiny
On Tue, Feb 19, 2019 at 09:30:33PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > Resending these as I had only 1 minor comment which I believe we have covered > in this series. I was anticipating these going through the mm tree as they > depend on a cleanup patch there and the IB changes are v

RE: [PATCH V6 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-02-27 Thread Michael Kelley
From: Tianyu Lan Sent: Wednesday, February 27, 2019 6:54 AM > > Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, > set x2apic destination mode to physcial mode when x2apic is available > and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs have > 8-bit APIC id.

Re: [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset

2019-02-27 Thread Lorenzo Pieralisi
On Wed, Feb 27, 2019 at 04:53:37PM +0100, Vitaly Kuznetsov wrote: > Maya Nakamura writes: > > > Remove a duplicate definition of VP set (hv_vp_set) and use the common > > definition (hv_vpset) that is used in other places. > > > > Change the order of the members in struct hv_pcibus_device so that

[PATCH] staging: rtl8712: Fix indentation issue

2019-02-27 Thread Prashanth Kumar KR
Fix indentation warning reported by checkpatch Signed-off-by: Prashanth Kumar KR --- drivers/staging/rtl8712/rtl871x_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_recv.c b/drivers/staging/rtl8712/rtl871x_recv.c index 0271ccf25f25..28f

Re: [PATCH v3 1/2] PCI: hv: Replace hv_vp_set with hv_vpset

2019-02-27 Thread Vitaly Kuznetsov
Maya Nakamura writes: > Remove a duplicate definition of VP set (hv_vp_set) and use the common > definition (hv_vpset) that is used in other places. > > Change the order of the members in struct hv_pcibus_device so that the > declaration of retarget_msi_interrupt_params is the last member. Struct

[PATCH] media: imx7_mipi_csis: remove internal ops

2019-02-27 Thread Rui Miguel Silva
Remove code that is not called anywhere, just remove the internal ops. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx7-mipi-csis.c | 27 -- 1 file changed, 27 deletions(-) diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx

Re: [PATCH] staging: rtl8712: fix indentation issues

2019-02-27 Thread Greg KH
On Wed, Feb 27, 2019 at 08:37:51PM +0530, Prashanth Kumar KR wrote: > Fix indentation warnings reported by checkpatch > > Signed-off-by: Prashanth Kumar KR > --- > drivers/staging/rtl8712/ieee80211.c| 3 ++- > drivers/staging/rtl8712/rtl871x_recv.c | 2 +- > 2 files changed, 3 insertions(+),

[PATCH] staging: rtl8712: fix indentation issues

2019-02-27 Thread Prashanth Kumar KR
Fix indentation warnings reported by checkpatch Signed-off-by: Prashanth Kumar KR --- drivers/staging/rtl8712/ieee80211.c| 3 ++- drivers/staging/rtl8712/rtl871x_recv.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/stagi

Re: [RFC PATCH] x86, hyperv: fix kernel panic when kexec on HyperV VM

2019-02-27 Thread Kairui Song
On Wed, Feb 27, 2019 at 8:02 PM Peter Zijlstra wrote: > > On Tue, Feb 26, 2019 at 11:56:15PM +0800, Kairui Song wrote: > > arch/x86/hyperv/hv_init.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > > index 7abb09e2eeb8..922

[PATCH V6 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available

2019-02-27 Thread lantianyu1986
From: Lan Tianyu Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, set x2apic destination mode to physcial mode when x2apic is available and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs have 8-bit APIC id. Reviewed-by: Thomas Gleixner Reviewed-by: Michael K

[PATCH V2] staging: wilc1000: fix incorrent type in initializer

2019-02-27 Thread Bo YU
Fix sparse warning: drivers/staging/wilc1000//host_interface.c:444:49: warning: incorrect type in initializer (different address spaces) drivers/staging/wilc1000//host_interface.c:444:49:expected struct cfg80211_bss_ies const *ies drivers/staging/wilc1000//host_interface.c:444:49:got str

Re: [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()

2019-02-27 Thread Lorenzo Pieralisi
On Wed, Feb 27, 2019 at 01:34:44PM +0100, Vitaly Kuznetsov wrote: > Maya Nakamura writes: > > > Remove the duplicate implementation of cpumask_to_vpset() and use the > > shared implementation. Export hv_max_vp_index, which is required by > > cpumask_to_vpset(). > > > > Apply changes to hv_irq_unm

Re: [PATCH net-next v2 8/8] net: Remove switchdev_ops

2019-02-27 Thread Ido Schimmel
On Tue, Feb 26, 2019 at 05:14:27PM -0800, Florian Fainelli wrote: > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > index b00f6f74f91a..995426ea9a43 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > +++ b/drivers/net/et

Re: [PATCH net-next v2 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Ido Schimmel
On Tue, Feb 26, 2019 at 05:14:20PM -0800, Florian Fainelli wrote: > In preparation for allowing switchdev enabled drivers to veto specific > attribute settings from within the context of the caller, introduce a > new switchdev notifier type for port attributes. > > Suggested-by: Ido Schimmel > Si

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-27 Thread Ido Schimmel
On Mon, Feb 25, 2019 at 11:47:12AM -0800, Florian Fainelli wrote: > On 2/25/19 1:49 AM, Ido Schimmel wrote: > > On Sun, Feb 24, 2019 at 08:47:27AM -0800, Florian Fainelli wrote: > >> Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : > >>> On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote:

Re: [PATCH 1/3] staging: erofs: compressed_pages should not be accessed again after freed

2019-02-27 Thread Chao Yu
On 2019/2/27 13:33, Gao Xiang wrote: > This patch resolves the following page use-after-free issue, > z_erofs_vle_unzip: > ... > for (i = 0; i < nr_pages; ++i) { > ... > z_erofs_onlinepage_endio(page); (1) > } > > for (i = 0; i < clusterpages; ++i) { > page

Re: [PATCH 2/3] staging: erofs: fix illegal address access under memory pressure

2019-02-27 Thread Chao Yu
On 2019/2/27 13:33, Gao Xiang wrote: > Considering a read request with two decompressed file pages, > If a decompression work cannot be started on the previous page > due to memory pressure but in-memory LTP map lookup is done, > builder->work should be still NULL. > > Moreover, if the current pag

Re: [PATCH net-next v2 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-27 Thread Ido Schimmel
On Tue, Feb 26, 2019 at 05:14:26PM -0800, Florian Fainelli wrote: > diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c > index af57c4a2b78a..b7988d49d708 100644 > --- a/net/bridge/br_switchdev.c > +++ b/net/bridge/br_switchdev.c > @@ -67,12 +67,17 @@ int br_switchdev_set_port_flag(s

Re: [PATCH 3/3] staging: erofs: fix mis-acted TAIL merging behavior

2019-02-27 Thread Chao Yu
On 2019/2/27 13:33, Gao Xiang wrote: > EROFS has an optimized path called TAIL merging, which is designed > to merge multiple reads and the corresponding decompressions into > one if these requests read continuous pages almost at the same time. > > In general, it behaves as follows: > ___

Re: [PATCH v3 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()

2019-02-27 Thread Vitaly Kuznetsov
Maya Nakamura writes: > Remove the duplicate implementation of cpumask_to_vpset() and use the > shared implementation. Export hv_max_vp_index, which is required by > cpumask_to_vpset(). > > Apply changes to hv_irq_unmask() based on feedback. > I just noticed an issue with this patch, sorry I've

Re: [PATCH net-next v2 8/8] net: Remove switchdev_ops

2019-02-27 Thread Ido Schimmel
On Tue, Feb 26, 2019 at 05:14:27PM -0800, Florian Fainelli wrote: > Now that we have converted all possible callers to using a switchdev > notifier for attributes we do not have a need for implementing > switchdev_ops anymore, and this can be removed from all drivers the > net_device structure. >

Re: [PATCH net-next v2 4/8] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-27 Thread Ido Schimmel
On Tue, Feb 26, 2019 at 05:14:23PM -0800, Florian Fainelli wrote: > Following patches will change the way we communicate setting a port's > attribute and use a notifier to perform those tasks. > > Prepare mlxsw to support receiving notifier events targeting > SWITCHDEV_PORT_ATTR_SET and utilize th

Re: [RFC PATCH] x86, hyperv: fix kernel panic when kexec on HyperV VM

2019-02-27 Thread Peter Zijlstra
On Tue, Feb 26, 2019 at 11:56:15PM +0800, Kairui Song wrote: > arch/x86/hyperv/hv_init.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > index 7abb09e2eeb8..92291c18d716 100644 > --- a/arch/x86/hyperv/hv_init.c > +++ b/arch/x86/