Re: [PATCH 15/18] staging: mt7621-pinctrl: refactor rt2880_pinctrl_dt_node_to_map function

2018-12-29 Thread Sergio Paracuellos
Hi again, Sorry, Too early in the morning and I misunderstood the problem :-) On Sun, Dec 30, 2018 at 8:24 AM Sergio Paracuellos wrote: > > Hi Neil, > > On Sun, Dec 30, 2018 at 4:58 AM NeilBrown wrote: > > > > On Thu, Jun 07 2018, Sergio Paracuellos wrote: > > > > > Using 'function' and 'groups

Re: [PATCH 15/18] staging: mt7621-pinctrl: refactor rt2880_pinctrl_dt_node_to_map function

2018-12-29 Thread Sergio Paracuellos
Hi Neil, On Sun, Dec 30, 2018 at 4:58 AM NeilBrown wrote: > > On Thu, Jun 07 2018, Sergio Paracuellos wrote: > > > Using 'function' and 'groups' bindings in the device tree give the > > posibility of refactor 'rt2880_pinctrl_dt_node_to_map' and simplify > > it a lot. Make use of the 'of_property_

Re: [PATCH 15/18] staging: mt7621-pinctrl: refactor rt2880_pinctrl_dt_node_to_map function

2018-12-29 Thread NeilBrown
On Thu, Jun 07 2018, Sergio Paracuellos wrote: > Using 'function' and 'groups' bindings in the device tree give the > posibility of refactor 'rt2880_pinctrl_dt_node_to_map' and simplify > it a lot. Make use of the 'of_property_count_strings' function to get > number of groups for the node and iter

[PATCH] staging: comedi: cb_pcimdas.c: fixed an alignment coding style issue

2018-12-29 Thread William Mitchell Jr
Fixed a coding style issue. Signed-off-by: William Mitchell Jr --- drivers/staging/comedi/drivers/cb_pcimdas.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b/drivers/staging/comedi/drivers/cb_pcimdas.c index 4e72a0778086..

Re: [PATCH] Staging: vt6655: Fix camel case of variable

2018-12-29 Thread Joe Perches
On Sat, 2018-12-29 at 23:59 +0100, Petr Sedlák wrote: > Replace variable uDelayUnit with u_delay_unit. Issue found by > checkpatch. probably better as a static inline too. > diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h [] > @@ -42,15 +42,15 @@ > #define VNSvOutPortD(d

[PATCH] Staging: vt6655: Fix camel case of variable

2018-12-29 Thread Petr Sedlák
Replace variable uDelayUnit with u_delay_unit. Issue found by checkpatch. Signed-off-by: Petr Sedlák --- drivers/staging/vt6655/upc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h index 61b3e568ff9a..384af2