On Tue, Nov 27, 2018 at 07:29:07AM +, Yang Xiao wrote:
> From: Young_X
Please use your "full" name like you did in your from: line of your
email
>
> The error at line 3267 was the result of an off-by-one error in
> a for loop in line 3253.
> If condition in line 3254 never satis
From: Young_X
The error at line 3267 was the result of an off-by-one error in
a for loop in line 3253.
If condition in line 3254 never satisfies, then the value of
pstat->aid is NUM_STA+1. This will lead to out-of-bound access
in line 3267.
Signed-off-by: Young_X
---
driver
On Tue, Nov 27, 2018 at 01:12:42PM +1100, NeilBrown wrote:
> On Tue, Nov 27 2018, Dan Carpenter wrote:
>
> > On Mon, Nov 26, 2018 at 08:57:09PM +0100, Sergio Paracuellos wrote:
> >> On Mon, Nov 26, 2018 at 10:57 AM Dan Carpenter
> >> wrote:
> >> >
> >> > On Sat, Nov 24, 2018 at 06:54:54PM +0100,
On Mon, Nov 26, 2018 at 08:56:50PM +, Michael Kelley wrote:
> From: Greg KH Monday, November 26, 2018 11:57 AM
>
> > > > You created "null" hooks that do nothing, for no one in this patch
> > > > series, why?
> > > >
> > >
> > > hv_enable_vmbus_irq() and hv_disable_vmbus_irq() have non-null
This patch adds RIFFA PCIe linux driver for
https://github.com/promach/riffa/tree/full_duplex/driver/linux
This staging driver is modified from this upstream driver at
https://github.com/KastnerRG/riffa/tree/master/driver/linux
For further details, please refer to https://github.com/KastnerRG/r
> -Original Message-
> From: Greg KH
> Sent: Monday, November 26, 2018 11:35 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; Stephen
> Hemminger ; Michael Kelley
> ; vkuznets ; Haiyang
>
On Tue, 20 Nov 2018, Brian Starkey wrote:
> Hi Liam,
>
> I'm missing a bit of context here, but I did read the v1 thread.
> Please accept my apologies if I'm re-treading trodden ground.
>
> I do know we're chasing nebulous ion "problems" on our end, which
> certainly seem to be related to what y
> -Original Message-
> From: Greg KH
> Sent: Monday, November 26, 2018 11:18 AM
> To: KY Srinivasan
> Cc: will.dea...@arm.com; catalin.mari...@armm.com;
> mark.rutl...@arm.com; marc.zyng...@arm.com; linux-arm-
> ker...@lists.infradead.org; linux-ker...@vger.kernel.org;
> de...@linuxdri
On Tue, Nov 27 2018, Dan Carpenter wrote:
> On Mon, Nov 26, 2018 at 08:57:09PM +0100, Sergio Paracuellos wrote:
>> On Mon, Nov 26, 2018 at 10:57 AM Dan Carpenter
>> wrote:
>> >
>> > On Sat, Nov 24, 2018 at 06:54:54PM +0100, Sergio Paracuellos wrote:
>> > > Depending of chip revision reset lines
On Fri, 23 Nov 2018 22:23:09 -0200, Matheus Tavares wrote:
> This patch adds the device tree binding documentation for the ad2s90
> resolver-to-digital converter.
>
> Signed-off-by: Matheus Tavares
> ---
> Changes in v3:
> - Added reference to spi-bus documentation after spi properties, as
> su
On Tue, Nov 27, 2018 at 12:19:09AM +0100, Cristian Sicilia wrote:
> Replace the IO_ADDRESS call with a temporary variable.
>
> Signed-off-by: Cristian Sicilia
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 18 ++
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a
On Mon, Nov 26, 2018 at 07:18:20PM +0100, Michael Straube wrote:
> If cdev_add() fails, cdev_del() should be called.
> Add the missing cdev_del() call as pointed out by
> Dan Carpenter.
>
> Signed-off-by: Michael Straube
> ---
Thanks! Looks good.
regards,
dan carpenter
___
On Mon, Nov 26, 2018 at 08:57:09PM +0100, Sergio Paracuellos wrote:
> On Mon, Nov 26, 2018 at 10:57 AM Dan Carpenter
> wrote:
> >
> > On Sat, Nov 24, 2018 at 06:54:54PM +0100, Sergio Paracuellos wrote:
> > > Depending of chip revision reset lines are inverted. It is also
> > > necessary to read P
--
Guten Tag, Wir sind eine registrierte private Geldverleiher. Wir geben
Kredite an Firmen, Einzelpersonen, die ihre finanzielle Status auf der
ganzen Welt aktualisieren müssen, mit minimalen jährlichen Zinsen von
2% .reply, wenn nötig.
Good Day, We are a registered private money lender. We give
Align parameters with parenthesis and removed
open parenthesis at the end of line.
Signed-off-by: Cristian Sicilia
---
drivers/staging/emxx_udc/emxx_udc.c | 270 ++--
1 file changed, 107 insertions(+), 163 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_
Replace the IO_ADDRESS call with a temporary variable.
Signed-off-by: Cristian Sicilia
---
drivers/staging/emxx_udc/emxx_udc.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index
In the first patch there is a fix of some parenthesis that terminate
on end of line and some parameters that are not aligned with
previous parenthesis.
The second patch is a proposal that avoid the long line refactoring
code and using a temporary parameter that will be passed to the
function on ne
From: Greg KH Monday, November 26, 2018 11:57 AM
> > > You created "null" hooks that do nothing, for no one in this patch
> > > series, why?
> > >
> >
> > hv_enable_vmbus_irq() and hv_disable_vmbus_irq() have non-null
> > implementations in the ARM64 code in patch 2 of this series. The
> > impl
Reported by checkpatch.
Signed-off-by: Lukas Walter
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 1 +
drivers/staging/gs_fpgaboot/gs_fpgaboot.h | 1 +
drivers/staging/gs_fpgaboot/io.c | 1 +
drivers/staging/gs_fpgaboot/io.h | 1 +
4 files changed, 4 insertions(+)
diff --git
> From: devel On Behalf Of
> Greg KH
> Sent: Monday, November 26, 2018 11:35 AM
> As Sasha pointed out, this patch does not even apply :(
Sorry, I'll rebase to char-misc's char-misc-testing branch, which has had one
of the patches, i.e.
4d3c5c69191f ("Drivers: hv: vmbus: Remove the useless API
From: Greg KH Monday, November 26, 2018 11:21 AM
> > diff --git a/arch/x86/include/asm/mshyperv.h
> > b/arch/x86/include/asm/mshyperv.h
> > index 0d6271cce198..8d97bd3a13a6 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -109,6 +109,10 @@ void h
That's
https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/reference/tlfs
Thanks, --jrp
On Mon, Nov 26, 2018 at 11:18 AM Greg KH wrote:
>
> On Thu, Nov 22, 2018 at 03:10:56AM +, k...@linuxonhyperv.com wrote:
> > --- /dev/null
> > +++ b/arch/arm64/include/asm/hyperv-tlfs.h
> >
On Mon, Nov 26, 2018 at 8:58 PM Greg KH wrote:
>
> On Mon, Nov 26, 2018 at 08:46:10PM +0100, Sergio Paracuellos wrote:
> > On Mon, Nov 26, 2018 at 4:28 PM Greg KH wrote:
> > >
> > > On Sun, Nov 25, 2018 at 07:59:48AM +0100, Sergio Paracuellos wrote:
> > > > On Sat, Nov 24, 2018 at 9:05 PM NeilBro
On Mon, Nov 26, 2018 at 08:46:10PM +0100, Sergio Paracuellos wrote:
> On Mon, Nov 26, 2018 at 4:28 PM Greg KH wrote:
> >
> > On Sun, Nov 25, 2018 at 07:59:48AM +0100, Sergio Paracuellos wrote:
> > > On Sat, Nov 24, 2018 at 9:05 PM NeilBrown wrote:
> > > >
> > > > On Sat, Nov 24 2018, Sergio Parac
On Mon, Nov 26, 2018 at 07:47:41PM +, Michael Kelley wrote:
> From: Greg KH Monday, November 26, 2018 11:21 AM
>
> > > diff --git a/arch/x86/include/asm/mshyperv.h
> > > b/arch/x86/include/asm/mshyperv.h
> > > index 0d6271cce198..8d97bd3a13a6 100644
> > > --- a/arch/x86/include/asm/mshyperv
On Mon, Nov 26, 2018 at 10:57 AM Dan Carpenter wrote:
>
> On Sat, Nov 24, 2018 at 06:54:54PM +0100, Sergio Paracuellos wrote:
> > Depending of chip revision reset lines are inverted. It is also
> > necessary to read PCIE_FTS_NUM register before enabling the phy.
> > Hence update the code to achiev
On Mon, Nov 26, 2018 at 11:01 AM Dan Carpenter wrote:
>
> On Sat, Nov 24, 2018 at 06:54:55PM +0100, Sergio Paracuellos wrote:
> > There is no clock driver for ralink mips and clk_enable
> > are no-ops for this architecture. This has been also tested
> > without using clocks and seems to work so av
On Mon, Nov 26, 2018 at 4:28 PM Greg KH wrote:
>
> On Sun, Nov 25, 2018 at 07:59:48AM +0100, Sergio Paracuellos wrote:
> > On Sat, Nov 24, 2018 at 9:05 PM NeilBrown wrote:
> > >
> > > On Sat, Nov 24 2018, Sergio Paracuellos wrote:
> > >
> > > > Previous cleanup series was added to the staging tre
To comply with checkpatch.
CHECK: Lines should not end with a '('
+u8 rtl_mrate_idx_to_arfr_id(
Signed-off-by: Ricardo Silva
---
drivers/staging/rtlwifi/base.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtlwifi/base.h b/drivers/staging/rtlwifi/base
> Nicolas Saenz Julienne hat am 20. November 2018 um
> 15:53 geschrieben:
>
>
> Hi All,
>
> This series was written in parallel with reading and understanding the
> vchiq code. So excuse me for the lack of logic in the sequence of
> patches.
>
> The main focus was to delete as much code as po
On Mon, Nov 26, 2018 at 02:29:57AM +, k...@linuxonhyperv.com wrote:
> From: Dexuan Cui
>
> vmbus_process_offer() mustn't call channel->sc_creation_callback()
> directly for sub-channels, because sc_creation_callback() ->
> vmbus_open() may never get the host's response to the
> OPEN_CHANNEL m
Hi, thank you for the review
> On Thu, 22 Nov 2018 11:01:00 +
> "Popa, Stefan Serban" wrote:
> > I think that instead of setting the gain directly, we should use
> > the IIO_CHAN_INFO_SCALE attribute. At page 12 of the ad7780 datasheet there
> > is a formula from which the output code can be
On Thu, Nov 22, 2018 at 03:10:58AM +, k...@linuxonhyperv.com wrote:
> From: Michael Kelley
>
> Add hooks to enable/disable a per-CPU IRQ for VMbus. These hooks
> are in the architecture independent setup and shutdown paths for
> Hyper-V, and are needed by Linux guests on Hyper-V on ARM64. Th
On Thu, Nov 22, 2018 at 03:10:57AM +, k...@linuxonhyperv.com wrote:
> --- /dev/null
> +++ b/arch/arm64/hyperv/hv_hvc.S
> @@ -0,0 +1,54 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
Using SPDX is good, but:
> +
> +/*
> + * Microsoft Hyper-V hypervisor invocation routines
> + *
> + * Copyright (
On Thu, Nov 22, 2018 at 03:10:56AM +, k...@linuxonhyperv.com wrote:
> --- /dev/null
> +++ b/arch/arm64/include/asm/hyperv-tlfs.h
> @@ -0,0 +1,338 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +/*
> + * This file contains definitions from the Hyper-V Hypervisor Top-Level
> + * Functional Sp
On 11/26/18 6:39 PM, Laura Abbott wrote:
> On 11/25/18 2:02 PM, Alexey Skidanov wrote:
>>
>>
>> On 11/25/18 11:40 PM, Laura Abbott wrote:
>>> On 11/25/18 1:22 PM, Alexey Skidanov wrote:
On 11/25/18 10:51 PM, Laura Abbott wrote:
> On 11/11/18 11:29 AM, Alexey Skidanov wrote:
>>>
If cdev_add() fails, cdev_del() should be called.
Add the missing cdev_del() call as pointed out by
Dan Carpenter.
Signed-off-by: Michael Straube
---
v1 -> v2
Use goto and label.
drivers/staging/pi433/pi433_if.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/stag
On 11/26/18 7:01 PM, Dan Carpenter wrote:
On Mon, Nov 26, 2018 at 06:53:55PM +0100, Michael Straube wrote:
retval = cdev_add(device->cdev, device->devt, 1);
if (retval) {
dev_dbg(device->dev, "register of cdev failed");
+ cdev_del(device->cdev);
On Mon, Nov 26, 2018 at 06:53:55PM +0100, Michael Straube wrote:
> If cdev_add() fails, cdev_del() should be called.
> Add the missing cdev_del() call as pointed out by
> Dan Carpenter.
>
> Signed-off-by: Michael Straube
> ---
> drivers/staging/pi433/pi433_if.c | 1 +
> 1 file changed, 1 inserti
If cdev_add() fails, cdev_del() should be called.
Add the missing cdev_del() call as pointed out by
Dan Carpenter.
Signed-off-by: Michael Straube
---
drivers/staging/pi433/pi433_if.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43
Hello,
My name is ms. Reem Al-Hashimi. The UAE minister of state for international
cooparation. I got your contact from an email database from your country. I
have a financial transaction i would like to discuss with you. Please reply to
reem2...@daum.net, for more details if you are interested
On Mon, 2018-11-26 at 16:26 +0300, Dan Carpenter wrote:
> On Mon, Nov 26, 2018 at 02:10:09PM +0100, Nicholas Mc Guire wrote:
> > On Mon, Nov 26, 2018 at 04:00:32PM +0300, Dan Carpenter wrote:
> > > On Mon, Nov 26, 2018 at 10:39:04AM +0100, Nicholas Mc Guire wrote:
> > > > devm_kasprintf() may retur
On 11/25/18 2:02 PM, Alexey Skidanov wrote:
On 11/25/18 11:40 PM, Laura Abbott wrote:
On 11/25/18 1:22 PM, Alexey Skidanov wrote:
On 11/25/18 10:51 PM, Laura Abbott wrote:
On 11/11/18 11:29 AM, Alexey Skidanov wrote:
Create chunk heap of specified size and base address by adding
"ion_chun
On 26.11.18 15:20, Michal Suchánek wrote:
> On Mon, 26 Nov 2018 14:33:29 +0100
> David Hildenbrand wrote:
>
>> On 26.11.18 13:30, David Hildenbrand wrote:
>>> On 23.11.18 19:06, Michal Suchánek wrote:
>
If we are going to fake the driver information we may as well add the
type a
On Sun, Nov 25, 2018 at 07:59:48AM +0100, Sergio Paracuellos wrote:
> On Sat, Nov 24, 2018 at 9:05 PM NeilBrown wrote:
> >
> > On Sat, Nov 24 2018, Sergio Paracuellos wrote:
> >
> > > Previous cleanup series was added to the staging tree without any
> > > testing. After get testing feedback some i
On Mon, 26 Nov 2018 14:33:29 +0100
David Hildenbrand wrote:
> On 26.11.18 13:30, David Hildenbrand wrote:
> > On 23.11.18 19:06, Michal Suchánek wrote:
> >>
> >> If we are going to fake the driver information we may as well add the
> >> type attribute and be done with it.
> >>
> >> I think the
On 26.11.18 13:30, David Hildenbrand wrote:
> On 23.11.18 19:06, Michal Suchánek wrote:
>> On Fri, 23 Nov 2018 12:13:58 +0100
>> David Hildenbrand wrote:
>>
>>> On 28.09.18 17:03, David Hildenbrand wrote:
How to/when to online hotplugged memory is hard to manage for
distributions because
On Mon, Nov 26, 2018 at 02:10:09PM +0100, Nicholas Mc Guire wrote:
> On Mon, Nov 26, 2018 at 04:00:32PM +0300, Dan Carpenter wrote:
> > On Mon, Nov 26, 2018 at 10:39:04AM +0100, Nicholas Mc Guire wrote:
> > > devm_kasprintf() may return NULL on failure of internal allocation thus
> > > the assignme
On Mon, Nov 26, 2018 at 04:00:32PM +0300, Dan Carpenter wrote:
> On Mon, Nov 26, 2018 at 10:39:04AM +0100, Nicholas Mc Guire wrote:
> > devm_kasprintf() may return NULL on failure of internal allocation thus
> > the assignments to attr.name are not safe if not checked. On error
> > ad7280_attr_in
On Mon, Nov 26, 2018 at 10:39:04AM +0100, Nicholas Mc Guire wrote:
> devm_kasprintf() may return NULL on failure of internal allocation thus
> the assignments to attr.name are not safe if not checked. On error
> ad7280_attr_init() returns a negative return so -ENOMEM should be
> OK here (passed o
On 23.11.18 19:06, Michal Suchánek wrote:
> On Fri, 23 Nov 2018 12:13:58 +0100
> David Hildenbrand wrote:
>
>> On 28.09.18 17:03, David Hildenbrand wrote:
>>> How to/when to online hotplugged memory is hard to manage for
>>> distributions because different memory types are to be treated different
On Sun, Nov 25, 2018 at 04:56:29PM +0530, Nishad Kamdar wrote:
> This switches the flexfb.c to use GPIO descriptors
> rather than numerical gpios.
>
> Signed-off-by: Nishad Kamdar
> ---
> drivers/staging/fbtft/flexfb.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> dif
On Sat, Nov 24, 2018 at 06:54:55PM +0100, Sergio Paracuellos wrote:
> There is no clock driver for ralink mips and clk_enable
> are no-ops for this architecture. This has been also tested
> without using clocks and seems to work so avoid to use them
> in this driver.
>
> Fixes: ad9c87e129d1: "stag
On Sat, Nov 24, 2018 at 06:54:54PM +0100, Sergio Paracuellos wrote:
> Depending of chip revision reset lines are inverted. It is also
> necessary to read PCIE_FTS_NUM register before enabling the phy.
> Hence update the code to achieve this.
>
> Fixes: 745eeeac68d7: "staging: mt7621-pci: factor ou
On Sun, Nov 25, 2018 at 10:22:25AM +0100, Michael Straube wrote:
> Add a test for successful call to cdev_alloc() to avoid
> potential null dereference. Issue reported by smatch.
>
Fixes: 874bcba65f9a ("staging: pi433: New driver")
> Signed-off-by: Michael Straube
> ---
> drivers/staging/pi43
sed. Not
sure if there are objections against this (checkpatch.pl issues
a CHECK on this).
Patch was compile tested with: x86_64_defconfig + STAGING=y
SPI=y, IIO=y, AD7280=m
Patch is against 4.20-rc4 (localversion-next is next-20181126)
drivers/staging/iio/adc/ad7280a.c | 6 ++
1 fi
On Mon, 2018-11-26 at 11:10 +0300, Dan Carpenter wrote:
> The devm_ioremap_resource() function doesn't return NULL pointers, it
> returns error pointers.
Good catch and thanks for the patch!
> Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
> Signed-off-by: Dan Carpenter
The devm_ioremap_resource() function doesn't return NULL pointers, it
returns error pointers.
Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
Signed-off-by: Dan Carpenter
---
drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
58 matches
Mail list logo
