Re: [PATCH v2 2/2] stagin: vchi: Add SPDX-License-Identifier

Hi Andre, Am 13.11.2018 um 01:37 schrieb andrealm...@riseup.net: > From: André Almeida > > As pointed by Stefan Wahren in v1, this file is dual licensed > as GPL-2 and BSD-3. please avoid references to old versions in the commit log, because after applying this patch the context get lost. Looks

Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

On Mon, 2018-11-12 at 19:45 -0500, Arnold Chand wrote: > Corrected warnings and checks provided by scripts/checkpatch.pl which > includes: alignment of parenthesis, lines over 80 characters and mutex > definition without comment. [] > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

> On 12 Nov 2018, at 8:40 PM, Greg Kroah-Hartman wrote: > > On Mon, Nov 12, 2018 at 04:49:30PM +0800, wahahab wrote: >> >>> On 10 Nov 2018, at 1:15 AM, Dan Carpenter >> > wrote: >>> >>> On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: Add a attri

[[PATCH v2]] staging: rtl8723bs: Correct errors from checkpatch

Correct following errors reported by checkpath.pl: ERROR: space required before the open parenthesis '(' #265: FILE: drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c:265: +   if(!precvframe) ')' Also similar errors on line 274 and 283. Signed-off-by: Josenivaldo Benito Jr ---

Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

On Mon, Nov 12, 2018 at 07:45:00PM -0500, Arnold Chand wrote: > Corrected warnings and checks provided by scripts/checkpatch.pl which > includes: alignment of parenthesis, lines over 80 characters and mutex > definition without comment. > > Signed-off-by: Arnold Chand > --- > .../vc04_services/b

Re: [PATCH] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

On Mon, Nov 12, 2018 at 07:29:09PM -0500, Arnold Chand wrote: > Corrected warnings and checks issued by scripts/checkpatch.pl which includes: > alignment of > parenthesis, lines over 80 characters and mutex definition without comment. > Signed-off-by: Arnold Chand --- > .../vc04_services/bcm2835-au

[PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

Corrected warnings and checks provided by scripts/checkpatch.pl which includes: alignment of parenthesis, lines over 80 characters and mutex definition without comment. Signed-off-by: Arnold Chand --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +++--- .../vc04_services/bcm2835-audio/bcm2

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

Hi Greg, On 2018/11/13 7:46, Greg Kroah-Hartman wrote: > On Tue, Nov 13, 2018 at 12:31:58AM +0100, Cristian Sicilia wrote: >> On Mon, Nov 12, 2018 at 11:46 PM Greg Kroah-Hartman < >> gre...@linuxfoundation.org> wrote: >> >>> On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: Re

[PATCH v2 0/2] Staging: vchi: Add license id and change int type

From: André Almeida Fix the following checkpatch issues: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 CHECK: Prefer kernel type 's32' over 'int32_t' Changes in v2: - Splits commits in a patch set - Fixes licenses in SPDX identifier - Adds a more descriptive commit message

[PATCH v2 2/2] stagin: vchi: Add SPDX-License-Identifier

From: André Almeida As pointed by Stefan Wahren in v1, this file is dual licensed as GPL-2 and BSD-3. Using multiple license representation as shown here [1]. [1] https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf Signed-off-by: André Almeida -

[PATCH v2 1/2] staging: vchi: change type 'int32_t' to 's32'

From: André Almeida As one can see in a typedef at linux/types.h:103, s32 and int32_t are both a 32 bits signed integer. s32 is preferred because it is defined by the kernel maintainers and it prevents portability issues. Changed to meet checkpatch criteria. Signed-off-by: André Almeida --- d

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

Hi Cristian, On 2018/11/13 4:43, Cristian Sicilia wrote: > Replace equal to NULL with logic unary operator, > and removing not equal to NULL comparison. > > Signed-off-by: Cristian Sicilia Indeed, I have several pending changes for this file... But these coding style fixes looks good to me. I w

Re: [PATCH] staging: vc04_services: bcm2835-audio: Fixed warnings

On Mon, Nov 12, 2018 at 07:00:20PM -0500, Arnold Chand wrote: > Fixed warnings provided by checkpatch.pl Please be much more specific as to what you changed or "fixed". Please fix this up and resend. thanks, greg k-h ___ devel mailing list de...@linux

Re: [PATCH 2/3] staging: erofs: unzip_vle.c: Constant in comparison on right side

On 2018/11/13 4:43, Cristian Sicilia wrote: > Comparisons should place the constant > on the right side of the test. > > Signed-off-by: Cristian Sicilia Reviewed-by: Gao Xiang Thanks, Gao Xiang > --- > drivers/staging/erofs/unzip_vle.c | 8 > 1 file changed, 4 insertions(+), 4 de

Re: [PATCH 3/3] staging: erofs: unzip_vle.c: Align parameter to the parentesis

On 2018/11/13 4:43, Cristian Sicilia wrote: > Align parameters to the opened parentesis. > > Signed-off-by: Cristian Sicilia Reviewed-by: Gao Xiang Thanks, Gao Xiang > --- > drivers/staging/erofs/unzip_vle.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --g

[PATCH] staging: vc04_services: bcm2835-audio: Fixed warnings

Fixed warnings provided by checkpatch.pl Signed-off-by: Arnold Chand --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +++--- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 25 .../bcm2835-audio/bcm2835-vchiq.c | 59 ++- .../vc04_services/bcm2835-audio

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

On Tue, Nov 13, 2018 at 12:31:58AM +0100, Cristian Sicilia wrote: > On Mon, Nov 12, 2018 at 11:46 PM Greg Kroah-Hartman < > gre...@linuxfoundation.org> wrote: > > > On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: > > > Replace equal to NULL with logic unary operator, > > > and re

Re: [PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters

On Tue, Nov 13, 2018 at 12:18:56AM +0100, Cristian Sicilia wrote: > The parameter is sent to next line to stay in 80 > characters > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/rtlwifi/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > You sent two 1/1 patches, sho

[PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters

The parameter is sent to next line to stay in 80 characters Signed-off-by: Cristian Sicilia --- drivers/staging/rtlwifi/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c index ca37f75..a990281 100644 --- a

[PATCH 1/1] staging: rtlwifi: Add spaces to match open parenthesis

Added before parameters some spaces to match open parenthesis on previous line. Signed-off-by: Cristian Sicilia --- drivers/staging/rtlwifi/ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtlwifi/ps.c b/drivers/staging/rtlwifi/ps.c index 0ca0532..5118

Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

On Mon, Nov 12, 2018 at 09:43:57PM +0100, Cristian Sicilia wrote: > Replace equal to NULL with logic unary operator, > and removing not equal to NULL comparison. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/erofs/unzip_vle.c | 86 > +++ > 1 fil

[PATCH] staging: gasket: formatting fixes

Reformat arguments in a few functions in gasket_page_table.c to better follow linux kernel formatting standards. Signed-off-by: Robert Deal --- drivers/staging/gasket/gasket_page_table.c | 24 ++ 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/staging/

[PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

Replace equal to NULL with logic unary operator, and removing not equal to NULL comparison. Signed-off-by: Cristian Sicilia --- drivers/staging/erofs/unzip_vle.c | 86 +++ 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/erofs/un

[PATCH 2/3] staging: erofs: unzip_vle.c: Constant in comparison on right side

Comparisons should place the constant on the right side of the test. Signed-off-by: Cristian Sicilia --- drivers/staging/erofs/unzip_vle.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c index 1ffe

[PATCH 0/3] Clean up some syntax issue on unzip_vle.c

This patch will do some syntax fix on unzip_vle.c file. The first patch will produce the removeal of all comparison with NULL constant prepending not operator for equals comparision. The second patch move the constant comparison to the right side. The third align some parameter with the previous pa

[PATCH 3/3] staging: erofs: unzip_vle.c: Align parameter to the parentesis

Align parameters to the opened parentesis. Signed-off-by: Cristian Sicilia --- drivers/staging/erofs/unzip_vle.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c index 35add4e..6a283f6 100644 --

Re: [PATCH V4] binder: ipc namespace support for android binder

On November 12, 2018 8:45:07 AM PST, Todd Kjos wrote: >+christ...@brauner.io +Martijn Coenen > >Christian, > >Does this patch work for your container use-cases? If not, please >comment on this thread. Let's discuss at LPC this week. I have not received an answer to my questions in the last versio

Re: [PATCH V4] binder: ipc namespace support for android binder

+christ...@brauner.io +Martijn Coenen Christian, Does this patch work for your container use-cases? If not, please comment on this thread. Let's discuss at LPC this week. -Todd On Mon, Nov 12, 2018 at 1:38 AM chouryzhou(周威) wrote: > > Currently android's binder is not isolated by ipc namespace

[PATCH v2] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- Changes in v2: - Resolved compilation errors. --- drivers/staging/greybus/arche-apb-ctrl.c | 159 +-- 1 file changed, 65 insertions(+), 94 deletions(-) diff --gi

Re: [PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

On Mon, Nov 12, 2018 at 04:17:39PM +0100, Johan Hovold wrote: > On Sun, Nov 11, 2018 at 11:14:14AM +0530, Nishad Kamdar wrote: > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > > > Signed-off-by: Nishad Kamdar > > --- > > drivers/staging/greybus/arche-ap

Re: [PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

On Sun, Nov 11, 2018 at 11:36:51AM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 11, 2018 at 11:14:14AM +0530, Nishad Kamdar wrote: > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > > > Signed-off-by: Nishad Kamdar > > --- > > drivers/staging/greybus/ar

Re: [PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

On Sun, Nov 11, 2018 at 11:14:14AM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar > --- > drivers/staging/greybus/arche-apb-ctrl.c | 158 ++- > 1 file changed, 65 insertions(+),

Re: [PATCH] greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. Thanks for picking this up. Linus W took a stab at it a couple of years ago, but it was never completed. You may want to ta

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

On Mon, Nov 12, 2018 at 04:49:30PM +0800, wahahab wrote: > > > On 10 Nov 2018, at 1:15 AM, Dan Carpenter > > wrote: > > > > On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: > >> Add a attribute called permissions under vsoc device node for examining > >

Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller

Hi Carmeli, CC Magnus (staging drivers receive so may janitorial changes that the original author is lost in the git shortlog noise) On Wed, Nov 7, 2018 at 9:46 PM Carmeli Tamir wrote: > Added static modifier to the udc_controller, since it's only > required within emxx_udc.c. > > Signed-off-b

[PATCH V4] binder: ipc namespace support for android binder

Currently android's binder is not isolated by ipc namespace. Since binder is a form of IPC and therefore should be tied to ipc namespace. With this patch, we can run multiple instances of android container on one host. This patch move "binder_procs" and "binder_context" into ipc_namespace, driv