Re: [PATCH] staging: mt7621-pinctrl: fix uninitialized variable ngroups

On Sat, Nov 10, 2018 at 11:28:06PM +, Colin King wrote: > From: Colin Ian King > > Currently the for_each_node_with_property loop us incrementing variable > ngroups however it was not initialized and hence will contain garbage. > Fix this by initializing ngroups to zero. > > Detected with st

[PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- drivers/staging/greybus/arche-apb-ctrl.c | 158 ++- 1 file changed, 65 insertions(+), 93 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/dri

RE: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

> From: gre...@linuxfoundation.org > Sent: Thursday, November 1, 2018 21:54 > To: Dexuan Cui > Cc: Michael Kelley ; KY Srinivasan > ; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; Stephen Hemminger ; > vkuznets ; Sasha Lev

Re: [PATCH 3.16] staging: usbip stub_rx fix static checker warning on unnecessary checks

On Mon, 2018-02-26 at 14:12 -0700, Shuah Khan wrote: > Upstream commit 10c901209306 > ("usbip: stub_rx: fix static checker warning on unnecessary checks") > > Back-port fix for static checker warning on unnecessary checks > > smatch warnings: > drivers/staging/usbip/stub_rx.c:360 get_pipe() warn:

[PATCH] staging: mt7621-pinctrl: fix uninitialized variable ngroups

From: Colin Ian King Currently the for_each_node_with_property loop us incrementing variable ngroups however it was not initialized and hence will contain garbage. Fix this by initializing ngroups to zero. Detected with static analysis with cppcheck: drivers/staging/mt7621-pinctrl/pinctrl-rt288

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

On Sat, Nov 10, 2018 at 11:23 AM Fabio Estevam wrote:> > Hi Matheus, > > On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino > wrote: > > > Got it, thanks for the explanation! I'll correct this in v2. > > One more suggestion: in v2 you could also consider to remove the legal > text that sa

[PATCH 3/3] staging: rtl8188eu: remove unnecessary parentheses in recv_linux.c

Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_l

[PATCH 2/3] staging: rtl8188eu: add spaces around '*' in recv_linux.c

Add spaces around '*' to conform with kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging

[PATCH 1/3] staging: rtl8188eu: use __func__ in recv_linux.c

Use __func__ instead of hardcoded function name. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl81

Re: [PATCH] Staging: vchi: Add license id and change int type

Hi Andre, > Stefan Wahren hat am 7. November 2018 um 09:30 > geschrieben: > > > > > > Signed-off-by: André Almeida > > > > --- > > > > Hello! This is my first patch to Linux Kernel. Let me know any feedback > > --- > > drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 6 +++--- > > 1

Re: [PATCH v2] staging: vchiq_arm: fix compat VCHIQ_IOC_AWAIT_COMPLETION

> Ben Wolsieffer hat am 4. November 2018 um 00:32 > geschrieben: > > > The compatibility ioctl wrapper for VCHIQ_IOC_AWAIT_COMPLETION assumes that > the native ioctl always uses a message buffer and decrements msgbufcount. > Certain message types do not use a message buffer and in this case >

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

Hi Matheus, On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino wrote: > Got it, thanks for the explanation! I'll correct this in v2. One more suggestion: in v2 you could also consider to remove the legal text that says GPL v2, as you are adding the SPDX tag.