Re: [Outreachy kernel] Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-30 Thread Julia Lawall
On Tue, 30 Oct 2018, Shayenne Moura wrote: > On 10/30, Greg Kroah-Hartman wrote: > > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > > > Remove unneeded parentheses around the arguments of ||. This reduces > > > clutter and code behave in the same way. > > > Change sugg

Re: [Outreachy kernel] Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-30 Thread Sasha Levin
On Tue, Oct 30, 2018 at 08:17:57PM -0300, Shayenne Moura wrote: On 10/30, Greg Kroah-Hartman wrote: On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > Remove unneeded parentheses around the arguments of ||. This reduces > clutter and code behave in the same way. > Change su

Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-30 Thread Shayenne Moura
On 10/30, Greg Kroah-Hartman wrote: > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > > Remove unneeded parentheses around the arguments of ||. This reduces > > clutter and code behave in the same way. > > Change suggested by checkpatch.pl. > > > > vbox_main.c:119: CHECK:

Re: [PATCH] staging: comedi: change do_insn*_ioctl to allow more samples

2018-10-30 Thread Spencer Olson
On Tue, Oct 30, 2018 at 6:21 AM Ian Abbott wrote: > > On 25/10/18 02:36, Spencer E. Olson wrote: > > Changes do_insn*_ioctl functions to allow for data lengths for each > > comedi_insn of up to 2^16. This patch also changes these functions to only > > allocate as much memory as is necessary for e

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
On 10/30, Julia Lawall wrote: > > On Tue, 30 Oct 2018, Shayenne Moura wrote: > > > Hi, > > > > > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > > > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > > > The "possible alignement issues" in CHECK report is difficult to > > >

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Julia Lawall
On Tue, 30 Oct 2018, Shayenne Moura wrote: > Hi, > > > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > > The "possible alignement issues" in CHECK report is difficult to > > > > > figure > > > > > out by just doing a glan

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
Hi, > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > The "possible alignement issues" in CHECK report is difficult to figure > > > > out by just doing a glance analysis. :) > > > > > > > > Linus also suggested to use bool as th

[PATCH] staging: comedi: ni_labpc_common: Use insn->n in AO insn_write handler

2018-10-30 Thread Ian Abbott
The `insn_write` handler for the AO subdevice (`labpc_ao_insn_write()`) currently ignores `insn->n` (the number of samples to write) and assumes a single sample is to be written. But `insn->n` could be 0, meaning no samples should be written, in which case `data[0]` is invalid. Follow the usual C

Re: [PATCH 2/3] staging: comedi: cb_pcidas64: Use insn->n in EEPROM insn_read handler

2018-10-30 Thread Ian Abbott
On 30/10/18 15:34, Hartley Sweeten wrote: On Tuesday, October 30, 2018 7:17 AM, Ian Abbott wrote: The `insn_read` handler for the EEPROM subdevice (`eeprom_insn_read()`) currently ignores `insn->n` (the number of samples to be read) and assumes a single sample is to be read. But `insn->n` cou

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-30 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:52 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 22:59:59 -0300 > Matheus Tavares wrote: > > > This patch set adds scale info to ad2s90's single channel, improve > > error handling in it's functions and fix a possible race condition > > issue. > > > > The goal with

RE: [PATCH 2/3] staging: comedi: cb_pcidas64: Use insn->n in EEPROM insn_read handler

2018-10-30 Thread Hartley Sweeten
On Tuesday, October 30, 2018 7:17 AM, Ian Abbott wrote: > The `insn_read` handler for the EEPROM subdevice (`eeprom_insn_read()`) > currently > ignores `insn->n` (the number of samples to be read) and assumes a single > sample is > to be read. But `insn->n` could be 0, meaning no samples should

[PATCH] staging: comedi: cb_pcidda: Use insn->n in AO insn_write handler

2018-10-30 Thread Ian Abbott
The `insn_write` handler for the AO subdevice (`cb_pcidda_ao_insn_write()`) currently ignores `insn->n` (the number of samples to write) and assumes a single sample is to be written. But `insn->n` could be 0, meaning no samples should be written, in which case `data[0]` is invalid. Follow the usu

[PATCH 2/3] staging: comedi: cb_pcidas64: Use insn->n in EEPROM insn_read handler

2018-10-30 Thread Ian Abbott
The `insn_read` handler for the EEPROM subdevice (`eeprom_insn_read()`) currently ignores `insn->n` (the number of samples to be read) and assumes a single sample is to be read. But `insn->n` could be 0, meaning no samples should be read, in which case `data[0]` ought not to be written. (The come

[PATCH 3/3] staging: comedi: Check length of INSN_CONFIG_TIMER_1 instruction

2018-10-30 Thread Ian Abbott
The contents of the Comedi configuration instruction `INSN_CONFIG_TIMER_1` instruction are not very well defined, but the one driver that uses it (the "cb_pcidas64" driver for the PCI-DAS4020/12 card) assumes its `insn->n` is 5. Add a check in `check_insn_config_length()` to verify that `insn->n` i

[PATCH 1/3] staging: comedi: cb_pcidas64: Use insn->n in AO insn_write handler

2018-10-30 Thread Ian Abbott
The `insn_write` handler for the AO subdevice (`ao_winsn()` currently ignores `insn->n` (the number of samples to write) and assumes a single sample is to be written. But `insn->n` could be 0, meaning no samples should be written, in which case `data[0]` is invalid. Follow the usual Comedi guidel

[PATCH 0/3] staging: comedi: cb_pcidas64: Fix insn->n assumptions

2018-10-30 Thread Ian Abbott
Fix some assumptions about the length of Comedi instructions in the "cb_pcidas64" driver. 1) staging: comedi: cb_pcidas64: Use insn->n in AO insn_write handler 2) staging: comedi: cb_pcidas64: Use insn->n in EEPROM insn_read handler 3) staging: comedi: Check length of INSN_CONFIG_TIMER_1 instructi

Re: [PATCH] staging: comedi: change do_insn*_ioctl to allow more samples

2018-10-30 Thread Ian Abbott
On 25/10/18 02:36, Spencer E. Olson wrote: Changes do_insn*_ioctl functions to allow for data lengths for each comedi_insn of up to 2^16. This patch also changes these functions to only allocate as much memory as is necessary for each comedi_insn, rather than allocating a fixed-sized scratch spa

Re: [PATCH] staging: speakup: clean up few indentation issues

2018-10-30 Thread Samuel Thibault
Colin King, le mar. 30 oct. 2018 11:09:59 +, a ecrit: > From: Colin Ian King > > Trivial fix to clean up indentation issues across the driver > > Signed-off-by: Colin Ian King Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 2 +- > drivers/staging/speakup/

Transaction

2018-10-30 Thread Maria Lucas
Dear Sir, My Name is Ms Maria Lucas ; Manager Of BOA Bank Abidjan Ci ; On the course of 2013/2014 Financial Annual Report, A Surplus Profit of Eleven Million Nine Hundred and Fifty Thousand Us Dollars , [ $ 11,950,000.00 ] Was Discovered and Placed in a SUSPENSE ACCOUNT Without Any Beneficia

[PATCH] staging: xgifb: clean an indentation issue

2018-10-30 Thread Colin King
From: Colin Ian King Trivial fix to clean up an indentation issue Signed-off-by: Colin Ian King --- drivers/staging/xgifb/XGI_main_26.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index eca0

[PATCH] staging: vt6656: clean up few indentation issues

2018-10-30 Thread Colin King
From: Colin Ian King Trivial fix to clean up indentation issues Signed-off-by: Colin Ian King --- drivers/staging/vt6656/firmware.c | 2 +- drivers/staging/vt6656/main_usb.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/firmware.c b/driver

[PATCH] staging: speakup: clean up few indentation issues

2018-10-30 Thread Colin King
From: Colin Ian King Trivial fix to clean up indentation issues across the driver Signed-off-by: Colin Ian King --- drivers/staging/speakup/kobjects.c | 2 +- drivers/staging/speakup/speakup_decpc.c | 6 +++--- drivers/staging/speakup/speakup_keypc.c | 2 +- 3 files changed, 5 insertions(

Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses

2018-10-30 Thread Greg Kroah-Hartman
On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote: > Remove unneeded parentheses around the arguments of ||. This reduces > clutter and code behave in the same way. > Change suggested by checkpatch.pl. > > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 < >