Hi Marcin,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-164230
smatch warnings:
drivers/staging/nrf24/nrf24_if.c:538 nrf24_create_pipe() error: 'p
On Thu, 11 Oct 2018 09:55:03 +0200 Michal Hocko wrote:
> > > > > This is now not called anymore, although the xen/hv variants still do
> > > > > it. The function seems empty these days, maybe remove it as a followup
> > > > > cleanup?
> > > > >
> > > > > > - __online_page_increment_counters(pag
Hello Mike,
On 10/18/18 12:57, Mike Brady wrote:
> + ktime_t now = ktime_get();
> +
> + /* Give userspace better delay reporting by interpolating between GPU
> + * notifications, assuming audio speed is close enough to the clock
> + * used for ktime
> + */
> +
> + if ((k
On Thu, Oct 18, 2018 at 07:19:36PM +0200, Lars-Peter Clausen wrote:
> On 10/18/2018 02:55 PM, Dan Carpenter wrote:
> > On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote:
> >> +static int ad7606_read_samples(struct ad7606_state *st)
> >> +{
> >> + unsigned int num = st->chip_info->num_cha
> Nicolas Saenz Julienne hat am 17. Oktober 2018 um
> 21:01 geschrieben:
>
>
> Hi,
>
> I just received a RPi3B+ and decided to have a go at fixing stuff in the
> audio driver. The changes are mostly cosmetic. I also took the liberty
> to update the TODO file.
>
> The series was developed on
Hi Hans.
Just a bunch of random observations that I hope you find use of.
Sam
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index cb88528e7b10..6b4d6c957da8 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -315,6 +315,8 @@ source "drivers/g
On 10/18/2018 02:55 PM, Dan Carpenter wrote:
> On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote:
>> +static int ad7606_read_samples(struct ad7606_state *st)
>> +{
>> +unsigned int num = st->chip_info->num_channels;
>> +u16 *data = st->data;
>> +int ret;
>> +
>> +/*
>> +
On Thu, 18 Oct 2018 15:32:35 +
Michael Kelley wrote:
> From Olaf Hering Sent: Thursday, October 18, 2018 8:20 AM
> >
> > > This extends existing vmbus related sysfs structure to provide per-channel
> > > state information. This is useful when diagnosing issues with multiple
> > > queues in
On Thu, 18 Oct 2018 17:19:53 +0200
Olaf Hering wrote:
> Am Sun, 17 Sep 2017 20:54:18 -0700
> schrieb k...@exchange.microsoft.com:
>
> > This extends existing vmbus related sysfs structure to provide per-channel
> > state information. This is useful when diagnosing issues with multiple
> > queues
Now that it has been converted to use atomic-modesetting and all other
known issues have addressed too, the vboxvideo driver can be moved out of
staging.
Signed-off-by: Hans de Goede
---
Note this commit only adds the driver to drivers/gpu/drm, it disables, but
does not remove the old version in
Hi All,
Here is a patch wich adds a copy of the vboxvideo driver from staging
(as it will look like after the cleanup series I just posted).
The purpose of posting this as a copy rather then a patch just moving
the files is to give the DRM maintainers a chance to do a review before
it gets merged
>From Olaf Hering Sent: Thursday, October 18, 2018 8:20 AM
>
> > This extends existing vmbus related sysfs structure to provide per-channel
> > state information. This is useful when diagnosing issues with multiple
> > queues in networking and storage.
>
> > +++ b/drivers/hv/vmbus_drv.c
> > +stat
Am Sun, 17 Sep 2017 20:54:18 -0700
schrieb k...@exchange.microsoft.com:
> This extends existing vmbus related sysfs structure to provide per-channel
> state information. This is useful when diagnosing issues with multiple
> queues in networking and storage.
> +++ b/drivers/hv/vmbus_drv.c
> +stati
From: Dan Carpenter
> Sent: 18 October 2018 07:33
>
> On Thu, Oct 18, 2018 at 05:09:32AM +, k...@linuxonhyperv.com wrote:
> > From: Dexuan Cui
> >
> > The patch fixes:
> >
> > hv_kvp_daemon.c: In function 'kvp_set_ip_info':
> > hv_kvp_daemon.c:1305:2: note: 'snprintf' output between 41 and 41
Userspace mode-setting (and thus also VESA) is not supported together with
modesetting. KMS userspace apps not properly marking the framebuffer as
dirty are also not supported.
So stop trying to accommodate this and simply enable accel
once at driver init.
Signed-off-by: Hans de Goede
---
drive
All the files contain a MIT license header, replace this with:
SPDX-License-Identifier: MIT
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/hgsmi_base.c | 23 ++--
drivers/staging/vboxvideo/hgsmi_ch_setup.h | 23 ++--
drivers/staging/vboxvideo/hgs
Some comments where still using docbook style comments, move these
either over to kerneldoc, or just make them regular comments.
Also remove a bunch of obsolete comments.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/hgsmi_base.c | 72 +---
drivers/staging/vboxvideo/h
On DPMS off we get a call to vbx_crtc_atomic_disable, followed by
a call to vbox_primary_atomic_update, at which point crtc_state->enable
is 0 and crtc_state->mode has been zero-ed. On a 0 width/height
vbox_do_modeset() falls back to 640x480, so this causes the guest Window
(its "monitor") to resiz
Switch to the more complete vbox_err.h file from include/linux which got
added with the merging of the vboxguest driver.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/hgsmi_base.c | 4 +-
drivers/staging/vboxvideo/modesetting.c | 4 +-
drivers/staging/vboxvideo/vbox_err.h| 50
Atomic modesetting drivers should never check crtc_state->active directly,
instead check crtc_state->enable.
Signed-off-by: Hans de Goede
---
drivers/staging/vboxvideo/vbox_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c
b/drivers
On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote:
> +static int ad7606_read_samples(struct ad7606_state *st)
> +{
> + unsigned int num = st->chip_info->num_channels;
> + u16 *data = st->data;
> + int ret;
> +
> + /*
> + * The frstdata signal is set to high while and
Move ad7606 ADC driver out of staging and into the mainline.
Signed-off-by: Stefan Popa
---
MAINTAINERS | 7 +
drivers/iio/adc/Kconfig | 34 +++
drivers/iio/adc/Makefile | 3 +
drivers/iio/adc/ad7606.c | 565 +
My Name is Ethan James Mbuya, Director of operations; Standard Bank of South
Africa (SBSA) This message might meet you in utmost surprise. However, it's
just my
urgent need for a foreign partner that prompted me to contact you for this
transaction.
An account was opened in my bank by a cu
Cleanup extra line found by checkpatch.pl
Signed-off-by: Jeeeun Evans
---
drivers/staging/ks7010/michael_mic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/michael_mic.c
b/drivers/staging/ks7010/michael_mic.c
index e6bd70846e98..3acd79615f98 100644
--- a/drivers/sta
When the BCM2835 audio output is used, userspace sees a jitter up to 10ms
in the audio position, aka "delay" -- the number of frames that must
be output before a new frame would be played.
Make this a bit nicer for userspace by interpolating the position
using the CPU clock.
The overhead is small -
On Thu, 18 Oct 2018 12:57:15 +0200,
Mike Brady wrote:
>
> When the BCM2835 audio output is used, userspace sees a jitter up to 10ms
> in the audio position, aka "delay" -- the number of frames that must
> be output before a new frame would be played.
> Make this a bit nicer for userspace by interp
Am 18.10.2018 um 11:22 schrieb Dave Stevenson:
> On Wed, 17 Oct 2018 at 17:51, Peter Robinson wrote:
>> Drop various pieces of dead code from here and there to get rid of
>> the remaining users of VCHI_CONNECTION_T. After that we get to drop
>> entire header files worth of unused code.
Hello NeilBrown,
The patch 0853c7a53eb3: "staging: mt7621-dma: ralink: add rt2880 dma
engine" from Mar 15, 2018, leads to the following static checker
warning:
drivers/staging/mt7621-dma/mtk-hsdma.c:344 mtk_hsdma_start_transfer()
error: potentially dereferencing uninitialized 'tx_
From: Stefan Popa
To: ji...@kernel.org
Cc: michael.henner...@analog.com,
knaac...@gmx.de,
l...@metafoo.de,
pme...@pmeerw.net,
gre...@linuxfoundation.org,
linux-ker...@vger.kernel.org,
linux-...@vger.kernel.org,
de...@driverdev.osuosl.org,
On Wed, 17 Oct 2018 at 17:51, Peter Robinson wrote:
>
> > >> > Drop various pieces of dead code from here and there to get rid of
> > >> > the remaining users of VCHI_CONNECTION_T. After that we get to drop
> > >> > entire header files worth of unused code.
> > >> >
> > >> > I've tested on a Raspb
My Name is Ethan James Mbuya, Director of operations; Standard Bank of South
Africa (SBSA) This message might meet you in utmost surprise. However, it's
just my
urgent need for a foreign partner that prompted me to contact you for this
transaction.
An account was opened in my bank by a cu
On 10/18/2018 09:28 AM, Phil Reid wrote:
[...]
>> + chip->rdwr_pin = devm_gpiod_get(&spi_dev->dev, "rdwr", GPIOD_IN);
>> + if (IS_ERR(chip->rdwr_pin)) {
>> + ret = PTR_ERR(chip->rdwr_pin);
>> + dev_err(&spi_dev->dev, "Failed to request rdwr GPIO: %d\n",
>> + ret);
>>
On 17/10/2018 10:47 PM, Nishad Kamdar wrote:
Use the gpiod interface for rdwr_pin, convert_pin and busy_pin
instead of the deprecated old non-descriptor interface.
Signed-off-by: Nishad Kamdar
---
Changes in v2:
- Correct the error messages as pin number being showed
has now been replaced
33 matches
Mail list logo