Re: [PATCH v3] staging: nrf24: add new driver for 2.4GHz radio transceiver

2018-10-18 Thread Dan Carpenter
Hi Marcin, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-164230 smatch warnings: drivers/staging/nrf24/nrf24_if.c:538 nrf24_create_pipe() error: 'p

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-18 Thread Andrew Morton
On Thu, 11 Oct 2018 09:55:03 +0200 Michal Hocko wrote: > > > > > This is now not called anymore, although the xen/hv variants still do > > > > > it. The function seems empty these days, maybe remove it as a followup > > > > > cleanup? > > > > > > > > > > > - __online_page_increment_counters(pag

Re: [PATCH] staging: bcm2835-audio: interpolate audio delay

2018-10-18 Thread Kirill Marinushkin
Hello Mike, On 10/18/18 12:57, Mike Brady wrote: > + ktime_t now = ktime_get(); > + > + /* Give userspace better delay reporting by interpolating between GPU > + * notifications, assuming audio speed is close enough to the clock > + * used for ktime > + */ > + > + if ((k

Re: [PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Dan Carpenter
On Thu, Oct 18, 2018 at 07:19:36PM +0200, Lars-Peter Clausen wrote: > On 10/18/2018 02:55 PM, Dan Carpenter wrote: > > On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote: > >> +static int ad7606_read_samples(struct ad7606_state *st) > >> +{ > >> + unsigned int num = st->chip_info->num_cha

Re: [PATCH v2 0/7] staging: bcm2835-audio: Cleanups and upgrades

2018-10-18 Thread Stefan Wahren
> Nicolas Saenz Julienne hat am 17. Oktober 2018 um > 21:01 geschrieben: > > > Hi, > > I just received a RPi3B+ and decided to have a go at fixing stuff in the > audio driver. The changes are mostly cosmetic. I also took the liberty > to update the TODO file. > > The series was developed on

Re: [PATCH] drm/vboxvideo: Move vboxvideo driver out of staging

2018-10-18 Thread Sam Ravnborg
Hi Hans. Just a bunch of random observations that I hope you find use of. Sam > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index cb88528e7b10..6b4d6c957da8 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -315,6 +315,8 @@ source "drivers/g

Re: [PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Lars-Peter Clausen
On 10/18/2018 02:55 PM, Dan Carpenter wrote: > On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote: >> +static int ad7606_read_samples(struct ad7606_state *st) >> +{ >> +unsigned int num = st->chip_info->num_channels; >> +u16 *data = st->data; >> +int ret; >> + >> +/* >> +

Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

2018-10-18 Thread Stephen Hemminger
On Thu, 18 Oct 2018 15:32:35 + Michael Kelley wrote: > From Olaf Hering Sent: Thursday, October 18, 2018 8:20 AM > > > > > This extends existing vmbus related sysfs structure to provide per-channel > > > state information. This is useful when diagnosing issues with multiple > > > queues in

Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

2018-10-18 Thread Stephen Hemminger
On Thu, 18 Oct 2018 17:19:53 +0200 Olaf Hering wrote: > Am Sun, 17 Sep 2017 20:54:18 -0700 > schrieb k...@exchange.microsoft.com: > > > This extends existing vmbus related sysfs structure to provide per-channel > > state information. This is useful when diagnosing issues with multiple > > queues

[PATCH] drm/vboxvideo: Move vboxvideo driver out of staging

2018-10-18 Thread Hans de Goede
Now that it has been converted to use atomic-modesetting and all other known issues have addressed too, the vboxvideo driver can be moved out of staging. Signed-off-by: Hans de Goede --- Note this commit only adds the driver to drivers/gpu/drm, it disables, but does not remove the old version in

[PATCH 0/1] drm/vboxvideo: Move vboxvideo driver out of staging

2018-10-18 Thread Hans de Goede
Hi All, Here is a patch wich adds a copy of the vboxvideo driver from staging (as it will look like after the cleanup series I just posted). The purpose of posting this as a copy rather then a patch just moving the files is to give the DRM maintainers a chance to do a review before it gets merged

RE: [PATCH V2 3/4] vmbus: add per-channel sysfs info

2018-10-18 Thread Michael Kelley
>From Olaf Hering Sent: Thursday, October 18, 2018 8:20 AM > > > This extends existing vmbus related sysfs structure to provide per-channel > > state information. This is useful when diagnosing issues with multiple > > queues in networking and storage. > > > +++ b/drivers/hv/vmbus_drv.c > > +stat

Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

2018-10-18 Thread Olaf Hering
Am Sun, 17 Sep 2017 20:54:18 -0700 schrieb k...@exchange.microsoft.com: > This extends existing vmbus related sysfs structure to provide per-channel > state information. This is useful when diagnosing issues with multiple > queues in networking and storage. > +++ b/drivers/hv/vmbus_drv.c > +stati

RE: [PATCH V2 5/5] Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1

2018-10-18 Thread David Laight
From: Dan Carpenter > Sent: 18 October 2018 07:33 > > On Thu, Oct 18, 2018 at 05:09:32AM +, k...@linuxonhyperv.com wrote: > > From: Dexuan Cui > > > > The patch fixes: > > > > hv_kvp_daemon.c: In function 'kvp_set_ip_info': > > hv_kvp_daemon.c:1305:2: note: 'snprintf' output between 41 and 41

[PATCH 6/6] staging: vboxvideo: Stop disabling/enabling accel support on master set / drop

2018-10-18 Thread Hans de Goede
Userspace mode-setting (and thus also VESA) is not supported together with modesetting. KMS userspace apps not properly marking the framebuffer as dirty are also not supported. So stop trying to accommodate this and simply enable accel once at driver init. Signed-off-by: Hans de Goede --- drive

[PATCH 5/6] staging: vboxvideo: Change licence headers over to SPDX

2018-10-18 Thread Hans de Goede
All the files contain a MIT license header, replace this with: SPDX-License-Identifier: MIT Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/hgsmi_base.c | 23 ++-- drivers/staging/vboxvideo/hgsmi_ch_setup.h | 23 ++-- drivers/staging/vboxvideo/hgs

[PATCH 4/6] staging: vboxvideo: Cleanup the comments

2018-10-18 Thread Hans de Goede
Some comments where still using docbook style comments, move these either over to kerneldoc, or just make them regular comments. Also remove a bunch of obsolete comments. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/hgsmi_base.c | 72 +--- drivers/staging/vboxvideo/h

[PATCH 2/6] staging: vboxvideo: Keep old mode when disable crtc

2018-10-18 Thread Hans de Goede
On DPMS off we get a call to vbx_crtc_atomic_disable, followed by a call to vbox_primary_atomic_update, at which point crtc_state->enable is 0 and crtc_state->mode has been zero-ed. On a 0 width/height vbox_do_modeset() falls back to 640x480, so this causes the guest Window (its "monitor") to resiz

[PATCH 3/6] staging: vboxvideo: Drop duplicate vbox_err.h file

2018-10-18 Thread Hans de Goede
Switch to the more complete vbox_err.h file from include/linux which got added with the merging of the vboxguest driver. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/hgsmi_base.c | 4 +- drivers/staging/vboxvideo/modesetting.c | 4 +- drivers/staging/vboxvideo/vbox_err.h| 50

[PATCH 1/6] staging: vboxvideo: Stop accessing crtc_state->active

2018-10-18 Thread Hans de Goede
Atomic modesetting drivers should never check crtc_state->active directly, instead check crtc_state->enable. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers

Re: [PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Dan Carpenter
On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote: > +static int ad7606_read_samples(struct ad7606_state *st) > +{ > + unsigned int num = st->chip_info->num_channels; > + u16 *data = st->data; > + int ret; > + > + /* > + * The frstdata signal is set to high while and

[PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Stefan Popa
Move ad7606 ADC driver out of staging and into the mainline. Signed-off-by: Stefan Popa --- MAINTAINERS | 7 + drivers/iio/adc/Kconfig | 34 +++ drivers/iio/adc/Makefile | 3 + drivers/iio/adc/ad7606.c | 565 +

Your attention is required

2018-10-18 Thread Myself
My Name is Ethan James Mbuya, Director of operations; Standard Bank of South Africa (SBSA) This message might meet you in utmost surprise. However, it's just my urgent need for a foreign partner that prompted me to contact you for this transaction. An account was opened in my bank by a cu

[PATCH] staging: ks7010: remove unnecessary blank line

2018-10-18 Thread Jeeeun Evans
Cleanup extra line found by checkpatch.pl Signed-off-by: Jeeeun Evans --- drivers/staging/ks7010/michael_mic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index e6bd70846e98..3acd79615f98 100644 --- a/drivers/sta

[PATCH] staging: bcm2835-audio: interpolate audio delay

2018-10-18 Thread Mike Brady
When the BCM2835 audio output is used, userspace sees a jitter up to 10ms in the audio position, aka "delay" -- the number of frames that must be output before a new frame would be played. Make this a bit nicer for userspace by interpolating the position using the CPU clock. The overhead is small -

Re: [PATCH] staging: bcm2835-audio: interpolate audio delay

2018-10-18 Thread Takashi Iwai
On Thu, 18 Oct 2018 12:57:15 +0200, Mike Brady wrote: > > When the BCM2835 audio output is used, userspace sees a jitter up to 10ms > in the audio position, aka "delay" -- the number of frames that must > be output before a new frame would be played. > Make this a bit nicer for userspace by interp

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-18 Thread Stefan Wahren
Am 18.10.2018 um 11:22 schrieb Dave Stevenson: > On Wed, 17 Oct 2018 at 17:51, Peter Robinson wrote: >> Drop various pieces of dead code from here and there to get rid of >> the remaining users of VCHI_CONNECTION_T. After that we get to drop >> entire header files worth of unused code.

[bug report] staging: mt7621-dma: ralink: add rt2880 dma engine

2018-10-18 Thread Dan Carpenter
Hello NeilBrown, The patch 0853c7a53eb3: "staging: mt7621-dma: ralink: add rt2880 dma engine" from Mar 15, 2018, leads to the following static checker warning: drivers/staging/mt7621-dma/mtk-hsdma.c:344 mtk_hsdma_start_transfer() error: potentially dereferencing uninitialized 'tx_

[no subject]

2018-10-18 Thread stefan.popa
From: Stefan Popa To: ji...@kernel.org Cc: michael.henner...@analog.com, knaac...@gmx.de, l...@metafoo.de, pme...@pmeerw.net, gre...@linuxfoundation.org, linux-ker...@vger.kernel.org, linux-...@vger.kernel.org, de...@driverdev.osuosl.org,

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-18 Thread Dave Stevenson
On Wed, 17 Oct 2018 at 17:51, Peter Robinson wrote: > > > >> > Drop various pieces of dead code from here and there to get rid of > > >> > the remaining users of VCHI_CONNECTION_T. After that we get to drop > > >> > entire header files worth of unused code. > > >> > > > >> > I've tested on a Raspb

It is for your attention

2018-10-18 Thread Myself
My Name is Ethan James Mbuya, Director of operations; Standard Bank of South Africa (SBSA) This message might meet you in utmost surprise. However, it's just my urgent need for a foreign partner that prompted me to contact you for this transaction. An account was opened in my bank by a cu

Re: [PATCH v2] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-10-18 Thread Lars-Peter Clausen
On 10/18/2018 09:28 AM, Phil Reid wrote: [...] >> +    chip->rdwr_pin = devm_gpiod_get(&spi_dev->dev, "rdwr", GPIOD_IN); >> +    if (IS_ERR(chip->rdwr_pin)) { >> +    ret = PTR_ERR(chip->rdwr_pin); >> +    dev_err(&spi_dev->dev, "Failed to request rdwr GPIO: %d\n", >> +    ret); >>

Re: [PATCH v2] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-10-18 Thread Phil Reid
On 17/10/2018 10:47 PM, Nishad Kamdar wrote: Use the gpiod interface for rdwr_pin, convert_pin and busy_pin instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- Changes in v2: - Correct the error messages as pin number being showed has now been replaced