Re: [PATCH 2/7] staging: erofs: code cleanup for option parsing of fault_injection

2018-09-12 Thread cgxu519
On 09/13/2018 10:15 AM, Chao Yu wrote: On 2018/9/12 13:10, Chengguang Xu wrote: Define a dummpy function of erofs_build_fault_attr() when macro CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to check the macro in calling place. Based on above adjustment, do proper code cleanup f

Re: [PATCH 1/7] staging: erofs: code cleanup for erofs_kmalloc()

2018-09-12 Thread cgxu519
On 09/13/2018 10:04 AM, Chao Yu wrote: On 2018/9/12 13:10, Chengguang Xu wrote: Define a dummy function of time_to_inject(), so that we don't have to check macro CONFIG_EROFS_FAULT_INJECTION in calling place. Base on above adjustment, do proper code cleanup for erofs_kmalloc(). Signed-off-by: C

Re: [PATCH 2/7] staging: erofs: code cleanup for option parsing of fault_injection

2018-09-12 Thread Chao Yu
On 2018/9/12 13:10, Chengguang Xu wrote: > Define a dummpy function of erofs_build_fault_attr() when macro > CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to > check the macro in calling place. Based on above adjustment, > do proper code cleanup for option parsing of fault_injecti

Re: [PATCH 1/7] staging: erofs: code cleanup for erofs_kmalloc()

2018-09-12 Thread Chao Yu
On 2018/9/12 13:10, Chengguang Xu wrote: > Define a dummy function of time_to_inject(), so that we don't > have to check macro CONFIG_EROFS_FAULT_INJECTION in calling place. > Base on above adjustment, do proper code cleanup for erofs_kmalloc(). > > Signed-off-by: Chengguang Xu > --- > drivers/s

Re: [PATCH v2] staging: Convert to using %pOFn instead of device_node.name

2018-09-12 Thread Rob Herring
On Wed, Sep 12, 2018 at 4:07 PM Mauro Carvalho Chehab wrote: > > Em Wed, 12 Sep 2018 15:26:48 -0500 > Rob Herring escreveu: > > > +Joe P > > > > On Wed, Sep 12, 2018 at 10:17 AM Mauro Carvalho Chehab > > wrote: > > > > > > Em Tue, 28 Aug 2018 10:44:33 -0500 > > > Rob Herring escreveu: > > > > >

Re: [PATCH v2] staging: Convert to using %pOFn instead of device_node.name

2018-09-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Sep 2018 15:26:48 -0500 Rob Herring escreveu: > +Joe P > > On Wed, Sep 12, 2018 at 10:17 AM Mauro Carvalho Chehab > wrote: > > > > Em Tue, 28 Aug 2018 10:44:33 -0500 > > Rob Herring escreveu: > > > > > In preparation to remove the node name pointer from struct device_node, > > > c

Re: [PATCH v2] staging: Convert to using %pOFn instead of device_node.name

2018-09-12 Thread Rob Herring
+Joe P On Wed, Sep 12, 2018 at 10:17 AM Mauro Carvalho Chehab wrote: > > Em Tue, 28 Aug 2018 10:44:33 -0500 > Rob Herring escreveu: > > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Steve Longerbe

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 12, 2018 at 05:08:52PM +0200, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architect

Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Signed-off-by: Arnd Berg

Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Arnd Bergmann
On Wed, Sep 12, 2018 at 5:33 PM Jason Gunthorpe wrote: > > On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > > Each of these drivers has a copy of the same trivial helper function to > > convert the pointer argument and then call the native ioctl handler. > > > > We now have a gener

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Daniel Vetter
On Wed, Sep 12, 2018 at 5:08 PM, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architecture, wher

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Jason Gunthorpe
On Wed, Sep 12, 2018 at 05:08:52PM +0200, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architect

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Sep 2018 17:08:52 +0200 Arnd Bergmann escreveu: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architectur

Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Jason Gunthorpe
On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Signed-off-by: Arnd Berg

Re: [PATCH v2] staging: Convert to using %pOFn instead of device_node.name

2018-09-12 Thread Mauro Carvalho Chehab
Em Tue, 28 Aug 2018 10:44:33 -0500 Rob Herring escreveu: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Steve Longerbeam > Cc: Philipp Zabel > Cc: Mauro Carvalho Chehab > Cc: Greg Kroah-Hartman > Cc:

[PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Arnd Bergmann
The .ioctl and .compat_ioctl file operations have the same prototype so they can both point to the same function, which works great almost all the time when all the commands are compatible. One exception is the s390 architecture, where a compat pointer is only 31 bit wide, and converting it into a

[PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Arnd Bergmann
Each of these drivers has a copy of the same trivial helper function to convert the pointer argument and then call the native ioctl handler. We now have a generic implementation of that, so use it. Signed-off-by: Arnd Bergmann --- drivers/char/ppdev.c | 12 +- drivers/char/

Re: [PATCH 00/25] Change tty_port(standard)_install's return type

2018-09-12 Thread Alan Cox
On Tue, 4 Sep 2018 11:44:26 +0900 Jaejoong Kim wrote: > Many drivers with tty use the tty_stand_install(). But, there is no > need to handle the error, since it always returns 0. And what happens if another change means it can fail again. It's just a property of the current implementation that

Re: [PATCH 3/7] staging: erofs: introduce a new helper __erofs_build_fault_attr()

2018-09-12 Thread cgxu519
On 09/12/2018 10:50 PM, Gao Xiang wrote: On 2018/9/12 22:23, cgxu519 wrote: On 09/12/2018 07:22 PM, Gao Xiang wrote: Hi Chengguang, On 2018/9/12 13:10, Chengguang Xu wrote: Introduce a new helper __erofs_build_fault_attr() to handle set/clear erofs_fault_info, we need this funciton for inter

Re: [PATCH 3/7] staging: erofs: introduce a new helper __erofs_build_fault_attr()

2018-09-12 Thread Gao Xiang
On 2018/9/12 22:23, cgxu519 wrote: > On 09/12/2018 07:22 PM, Gao Xiang wrote: >> Hi Chengguang, >> >> On 2018/9/12 13:10, Chengguang Xu wrote: >>> Introduce a new helper __erofs_build_fault_attr() to handle set/clear >>> erofs_fault_info, we need this funciton for internal use case. >>> for examp

Re: [PATCH 4/7] staging: erofs: return -EINVAL when specifying fault rate to 0

2018-09-12 Thread cgxu519
On 09/12/2018 10:25 PM, Dan Carpenter wrote: On Wed, Sep 12, 2018 at 10:05:26PM +0800, cgxu519 wrote: On 09/12/2018 05:16 PM, Dan Carpenter wrote: On Wed, Sep 12, 2018 at 01:10:31PM +0800, Chengguang Xu wrote: Set fault rate to 0 is useless and confusable, so add check to avoid it. I would h

Re: [PATCH 4/7] staging: erofs: return -EINVAL when specifying fault rate to 0

2018-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2018 at 10:05:26PM +0800, cgxu519 wrote: > On 09/12/2018 05:16 PM, Dan Carpenter wrote: > > On Wed, Sep 12, 2018 at 01:10:31PM +0800, Chengguang Xu wrote: > > > Set fault rate to 0 is useless and confusable, so add check to > > > avoid it. > > > > > I would have assumed setting rat

Re: [PATCH 3/7] staging: erofs: introduce a new helper __erofs_build_fault_attr()

2018-09-12 Thread cgxu519
On 09/12/2018 07:22 PM, Gao Xiang wrote: Hi Chengguang, On 2018/9/12 13:10, Chengguang Xu wrote: Introduce a new helper __erofs_build_fault_attr() to handle set/clear erofs_fault_info, we need this funciton for internal use case. for example, reset fault_injection option in remount. Signed-off

Re: [PATCH 4/7] staging: erofs: return -EINVAL when specifying fault rate to 0

2018-09-12 Thread cgxu519
On 09/12/2018 05:16 PM, Dan Carpenter wrote: On Wed, Sep 12, 2018 at 01:10:31PM +0800, Chengguang Xu wrote: Set fault rate to 0 is useless and confusable, so add check to avoid it. I would have assumed setting rate to zero just disabled it. I think currently it is useless because we have not

Re: [PATCH 1/13] KVM: Add tlb_remote_flush_with_range callback in kvm_x86_ops

2018-09-12 Thread Tianyu Lan
Hi Sean: Thanks for your review. On 9/10/2018 10:21 PM, Sean Christopherson wrote: > On Mon, 2018-09-10 at 08:38 +, Tianyu Lan wrote: >> Add flush range call back in the kvm_x86_ops and platform can use it >> to register its associated function. The parameter "kvm_tlb_range" >> accepts

Re: [PATCH 10/13] x86/hyper-v: Add HvFlushGuestAddressList hypercall support

2018-09-12 Thread Tianyu Lan
Hi Michael: Thanks for your review. On 9/12/2018 8:22 AM, Michael Kelley (EOSG) wrote: > From: Tianyu Lan Sent: Monday, September 10, 2018 1:39 AM >> + >> +int hyperv_flush_guest_mapping_range(u64 as, struct kvm_tlb_range *range) > > I'm really concerned about defining the Hyper-V functi

Re: [PATCH 3/7] staging: erofs: introduce a new helper __erofs_build_fault_attr()

2018-09-12 Thread Gao Xiang
Hi Chengguang, On 2018/9/12 13:10, Chengguang Xu wrote: > Introduce a new helper __erofs_build_fault_attr() to handle set/clear > erofs_fault_info, we need this funciton for internal use case. > for example, reset fault_injection option in remount. > > Signed-off-by: Chengguang Xu > --- > drive

Re: [PATCH 4/7] staging: erofs: return -EINVAL when specifying fault rate to 0

2018-09-12 Thread Dan Carpenter
On Wed, Sep 12, 2018 at 01:10:31PM +0800, Chengguang Xu wrote: > Set fault rate to 0 is useless and confusable, so add check to > avoid it. > I would have assumed setting rate to zero just disabled it. regards, dan carpenter ___ devel mailing list de.

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

2018-09-12 Thread Chao Yu
Hi Stephen, On 2018/9/12 15:34, Stephen Rothwell wrote: > Hi Chao, > > On Wed, 12 Sep 2018 15:19:16 +0800 Chao Yu wrote: >> >> To make sure, did -next tree enable erofs compiling now? > > Yes, from yesterday. Great, thanks for your help. :) > >> Xiang has made two patches to fix integration

Re: [PATCH 1/4] staging: vboxvideo: Fix modeset / page_flip error handling

2018-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 12, 2018 at 09:54:51AM +0200, Hans de Goede wrote: > Hi, > > On 11-09-18 20:46, Greg Kroah-Hartman wrote: > > On Tue, Sep 11, 2018 at 09:15:41AM +0200, Hans de Goede wrote: > > > The default settings for Linux vms created in VirtualBox allocate only > > > 16M of videomem. When running

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-12 Thread Hans Verkuil
On 09/12/2018 09:23 AM, Maxime Ripard wrote: > On Tue, Sep 11, 2018 at 12:46:25PM -0300, Mauro Carvalho Chehab wrote: >> Em Fri, 7 Sep 2018 00:24:38 +0200 >> Paul Kocialkowski escreveu: >> >>> From: Paul Kocialkowski >>> >>> This introduces the Cedrus VPU driver that supports the VPU found in >>

Re: [PATCH 1/4] staging: vboxvideo: Fix modeset / page_flip error handling

2018-09-12 Thread Hans de Goede
Hi, On 11-09-18 20:46, Greg Kroah-Hartman wrote: On Tue, Sep 11, 2018 at 09:15:41AM +0200, Hans de Goede wrote: The default settings for Linux vms created in VirtualBox allocate only 16M of videomem. When running fullscreen on a 1920x1080 (or bigger) monitor this is not a lot. When using GNOME

Re: [PATCH] staging: wilc1000: fix null checks on wilc

2018-09-12 Thread Claudiu Beznea
On 11.09.2018 20:38, Colin King wrote: > From: Colin Ian King > > Currently the pointer wilc is being null checked several times > and yet not checked for the final workqueue flush and destroy > (which can lead to a null pointer dereference if wilc is null); > these missing null checks were ov

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

2018-09-12 Thread Stephen Rothwell
Hi Chao, On Wed, 12 Sep 2018 15:19:16 +0800 Chao Yu wrote: > > To make sure, did -next tree enable erofs compiling now? Yes, from yesterday. > Xiang has made two patches to fix integration issue with other vfs changes, > and Greg and David have already picked them in their tree. > > staging: e

Re: [PATCH v9 5/9] media: platform: Add Cedrus VPU decoder driver

2018-09-12 Thread Maxime Ripard
On Tue, Sep 11, 2018 at 12:46:25PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 7 Sep 2018 00:24:38 +0200 > Paul Kocialkowski escreveu: > > > From: Paul Kocialkowski > > > > This introduces the Cedrus VPU driver that supports the VPU found in > > Allwinner SoCs, also known as Video Engine. It

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

2018-09-12 Thread Chao Yu
Hi Stephen, To make sure, did -next tree enable erofs compiling now? Xiang has made two patches to fix integration issue with other vfs changes, and Greg and David have already picked them in their tree. staging: erofs: rename superblock flags (MS_xyz -> SB_xyz) staging: erofs: update .mount and

Re: KASAN: null-ptr-deref Write in binder_update_page_range

2018-09-12 Thread Greg KH
On Fri, Sep 07, 2018 at 12:34:19PM +0900, Minchan Kim wrote: > Thanks, Martijn, > > Greg, could you have a look to pick up? Now queued up, thanks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mail