Re: [PATCH] staging: Convert to using %pOFn instead of device_node.name

Hi, On 28/08/2018 02:52, Rob Herring wrote: In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Steve Longerbeam Cc: Philipp Zabel Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: linux-me...@vger.kernel.org

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

Hi Greg, On 2018/8/28 13:44, Greg Kroah-Hartman wrote: > On Tue, Aug 28, 2018 at 11:39:48AM +0800, Gao Xiang wrote: >> This reverts commit 156c3df8d4db4e693c062978186f44079413d74d. >> >> Since XArray and the new mount apis aren't merged in 4.19-rc1 >> merge window, the BROKEN mark can be reverted

Re: [PATCH] Revert "staging: erofs: disable compiling temporarile"

On Tue, Aug 28, 2018 at 11:39:48AM +0800, Gao Xiang wrote: > This reverts commit 156c3df8d4db4e693c062978186f44079413d74d. > > Since XArray and the new mount apis aren't merged in 4.19-rc1 > merge window, the BROKEN mark can be reverted directly without > any problems. > > Fixes: 156c3df8d4db ("s

Trade Inquiry

Dear Sir/Madam, We are a USA based company interested in your product. I'm writing to you after seeing your catalog. We want to purchase this items like in the attachments. Please quote for us good prices including shipping charges by sea CIF port of New York. Waiting for quote. Thank you.

Re: [PATCH] staging: pi433: Fix style issues 'line over 80 characters'

On Mon, Aug 27, 2018 at 10:58:48PM -0500, Luke Cesarz wrote: > This patch corrects the lines extending over 80 characters, fixing the > checkpatch.pl warnings in rf69.c: 'WARNING: line over 80 characters' > > Signed-off-by: Luke Cesarz > --- > drivers/staging/pi433/rf69.c | 103 +

Re: [PATCH 00/24] staging: wilc1000: avoid use of static and global variable

Hi Greg, On Mon, 27 Aug 2018 19:10:47 +0200 Greg KH wrote: > On Tue, Aug 14, 2018 at 12:19:52PM +0530, Ajay Singh wrote: > > This patch set mainly contains changes to avoid the use of static > > and global variables. Also contains few patch to avoid the > > checkpatch warning arise due to code r

Re: [PATCH 20/24] staging: wilc1000: avoid line over 80 chars in tcp_process()

Hi Dan, On Mon, 27 Aug 2018 15:00:50 +0300 Dan Carpenter wrote: > On Mon, Aug 27, 2018 at 10:54:38AM +0530, Ajay Singh wrote: > > Hi Claudiu, > > > > On Fri, 24 Aug 2018 12:31:28 +0300 > > Claudiu Beznea wrote: > > > > > On 23.08.2018 13:33, Ajay Singh wrote: > > > > On Thu, 23 Aug 2018 1

[PATCH] staging: pi433: Fix style issues 'line over 80 characters'

This patch corrects the lines extending over 80 characters, fixing the checkpatch.pl warnings in rf69.c: 'WARNING: line over 80 characters' Signed-off-by: Luke Cesarz --- drivers/staging/pi433/rf69.c | 103 ++- 1 file changed, 64 insertions(+), 39 deletions(-) di

[PATCH] Revert "staging: erofs: disable compiling temporarile"

This reverts commit 156c3df8d4db4e693c062978186f44079413d74d. Since XArray and the new mount apis aren't merged in 4.19-rc1 merge window, the BROKEN mark can be reverted directly without any problems. Fixes: 156c3df8d4db ("staging: erofs: disable compiling temporarile") Cc: Matthew Wilcox Cc: Da

[PATCH] staging: Convert to using %pOFn instead of device_node.name

In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Cc: Steve Longerbeam Cc: Philipp Zabel Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: linux-me...@vger.kernel.org Cc: de...@driverdev.osuosl.org Signed-off-by:

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

On Mon, Aug 27, 2018 at 08:21:36PM +0100, John Whitmore wrote: > On Mon, Aug 27, 2018 at 07:27:19PM +0200, Greg KH wrote: > > On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > > > Remove a number of unused constant definitions. > > > > > > This is a coding style change which should

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

On Mon, Aug 27, 2018 at 07:27:19PM +0200, Greg KH wrote: > On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > > Remove a number of unused constant definitions. > > > > This is a coding style change which should have no impact on runtime > > code execution. > > > > Signed-off-by: Joh

[PATCH v2 2/2] staging: rtl8712u: Fix compiler warning about strncpy

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. Using strlcpy() rather than strncpy() forces a null at the end and quiets the warning. Signed-off-by: Larry Finger --- v2 - No changes. --- drivers/staging/rtl8712/

[PATCH v2 0/2] staging: Fix some warnings from strncpy()

When the size argument in a call to strncpy() is the size of the destimation, gcc8 issues a warning. These patches fix the potential problem. Signed-off-by: Larry Finger v2 - The code is changed to implement the comments of David Laight. Larry Finger (2): staging: rtl8192e: Fix compiler warni

[PATCH v2 1/2] staging: rtl8192e: Fix compiler warning from strncpy()

When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. This section is completely reworked to use the known lengths of the strings. Signed-off-by: Larry Finger --- v2 - David Laight's comments are implemented. --- driv

Re: [PATCH] Staging: fsl-dpaa2: ethsw: dpsw: Use correct SPDX-License-Identifier comment

On Sun, Aug 19, 2018 at 06:21:36PM +0200, Jannis Nawroth wrote: > Use correct comment for SPDX-License-Identifier > > Signed-off-by: Jannis Nawroth > --- > drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/fsl-dpaa2

Re: [PATCH] Staging: sm750fb: sm750: add SPDX-License-Identifier

On Sun, Aug 19, 2018 at 01:59:15PM +0200, Jannis Nawroth wrote: > Adding missing SPDX-License-Identifier > > Signed-off-by: Jannis Nawroth > --- > drivers/staging/sm750fb/sm750.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/s

Re: [PATCH v2] staging: netlogic: Fixed comments to include SPDX-License-Identifier

On Sat, Aug 11, 2018 at 06:36:43PM +0200, Michael Anckaert wrote: > This patch fixes some issues with missing SPDX-License-Identifier comments. Never add SPDX identifiers unless you REALLY know what you are doing. It is VERY dangerous to add incorrect identifiers, which is what you did here :( N

Re: [PATCH] Staging: One Laptop Per Child: add function argument names

On Thu, Aug 09, 2018 at 06:23:59PM +0200, Arkadiusz Lis wrote: > Add function argument names to pointers to functions > in struct dcon_platform_data: init, set_dconload and read_status > This commit removes checkpatch.pl warning. > > Signed-off-by: Arkadiusz Lis > --- > drivers/staging/olpc_dcon

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote: > Splits definition of function programModeRegisters into two lines such > that each line is less than 80 characters. > > Signed-off-by: Abishek V Ashok > --- > drivers/staging/sm750fb/ddk750_mode.c | 4 ++-- > 1 file changed, 2 in

Re: [PATCH 0/2] staging: Fix some warnings from strncpy()

On Mon, Aug 20, 2018 at 12:51:22PM -0500, Larry Finger wrote: > When the size argument in a call to strncpy() is the size of the > destimation, gcc8 issues a warning. These patches fix the potential > problem by replacing the strncpy() with strlcpy(). > > Signed-off-by: Larry Finger > > > Larry

Re: [PATCH] Staging: rtlwifi: efuse: fixed a line length coding style issue

On Mon, Aug 13, 2018 at 10:11:21PM +0100, Tom Todd wrote: > Fixed a code style issue. Line length over 80 characters. > > Signed-off-by: Tom Todd > --- > drivers/staging/rtlwifi/efuse.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtlwifi/efuse.c b/

Re: [PATCH] ddk750_mode.c: Wraps line to 80 charecters

On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote: > Splits definition of function programModeRegisters into two lines such > that each line is less than 80 characters. > > Signed-off-by: Abishek V Ashok > --- > drivers/staging/sm750fb/ddk750_mode.c | 4 ++-- > 1 file changed, 2 in

Re: [PATCH v5 1/4] staging: mt7621-mmc: Remove commented code for N_MSG

On Thu, Aug 23, 2018 at 10:58:09PM +0530, Nishad Kamdar wrote: > This patch removes the dead code for N_MSG(). > > Signed-off-by: Nishad Kamdar > --- > Changes in v5: > - Remove commented code for N_MSG() > --- > drivers/staging/mt7621-mmc/dbg.h | 8 > 1 file changed, 8 deletions(-) >

Re: [PATCH 01/17] staging:rtl8192u: Remove unused defines - Style

On Tue, Aug 21, 2018 at 06:15:21PM +0100, John Whitmore wrote: > Remove a number of unused constant definitions. > > This is a coding style change which should have no impact on runtime > code execution. > > Signed-off-by: John Whitmore > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h |

Re: [PATCH 00/24] staging: wilc1000: avoid use of static and global variable

On Tue, Aug 14, 2018 at 12:19:52PM +0530, Ajay Singh wrote: > This patch set mainly contains changes to avoid the use of static > and global variables. Also contains few patch to avoid the checkpatch > warning arise due to code refactor. I'm dropping this whole series from my review queue as I hav

Re: KASAN: null-ptr-deref Write in binder_update_page_range

Thanks Minchan! On Thu, Aug 23, 2018 at 7:29 AM, Minchan Kim wrote: > Signed-off-by: Todd Kjos > Signed-off-by: Minchan Kim Reviewed-by: Martijn Coenen > --- > drivers/android/binder_alloc.c | 43 +++--- > 1 file changed, 35 insertions(+), 8 deletions(-) > > diff

Re: [PATCH 20/24] staging: wilc1000: avoid line over 80 chars in tcp_process()

On Mon, Aug 27, 2018 at 10:54:38AM +0530, Ajay Singh wrote: > Hi Claudiu, > > On Fri, 24 Aug 2018 12:31:28 +0300 > Claudiu Beznea wrote: > > > On 23.08.2018 13:33, Ajay Singh wrote: > > > On Thu, 23 Aug 2018 11:12:08 +0300 > > > Claudiu Beznea wrote: > > > > > >> On 14.08.2018 09:50, Ajay Si

[PATCH] staging: pi433: eliminate a temporary variable

We can just get rid of the "spi_address". It's not clear what the "address" part of the name means, and the type should have been a u8. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 085272fb393f..4fa6c0237e59 100644 --- a/drivers/sta