RE: [PATCH 2/5] vmbus: add driver_override support

2018-08-14 Thread Michael Kelley (EOSG)
From: Stephen Hemminger Sent: Tuesday, August 14, 2018 9:35 AM > On Mon, 13 Aug 2018 19:30:50 + > "Michael Kelley (EOSG)" wrote: > > > > +/* > > > + * Return a matching hv_vmbus_device_id pointer. > > > + * If there is no match, return NULL. > > > + */ > > > +static const struct hv_vmbus_

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread Takashi Iwai
On Tue, 14 Aug 2018 19:29:32 +0200, David Miller wrote: > > From: Takashi Iwai > Date: Tue, 14 Aug 2018 19:10:50 +0200 > > > The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback > > to single queue mode") tried to fix the fallback behavior to a single > > queue mode, but it chang

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread David Miller
From: Takashi Iwai Date: Tue, 14 Aug 2018 19:10:50 +0200 > The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback > to single queue mode") tried to fix the fallback behavior to a single > queue mode, but it changed the function to return zero incorrectly, > while the function should

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread Stephen Hemminger
On Tue, 14 Aug 2018 19:10:50 +0200 Takashi Iwai wrote: > The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback > to single queue mode") tried to fix the fallback behavior to a single > queue mode, but it changed the function to return zero incorrectly, > while the function should r

[PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread Takashi Iwai
The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback to single queue mode") tried to fix the fallback behavior to a single queue mode, but it changed the function to return zero incorrectly, while the function should return an object pointer. Eventually this leads to a NULL derefer

Re: [PATCH 2/5] vmbus: add driver_override support

2018-08-14 Thread Stephen Hemminger
On Mon, 13 Aug 2018 19:30:50 + "Michael Kelley (EOSG)" wrote: > > +/* > > + * Return a matching hv_vmbus_device_id pointer. > > + * If there is no match, return NULL. > > + */ > > +static const struct hv_vmbus_device_id *hv_vmbus_get_id(struct hv_driver > > *drv, > > +

Re: [PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

2018-08-14 Thread Dmitry Osipenko
On Tuesday, 14 August 2018 18:05:51 MSK Dmitry Osipenko wrote: > On Tuesday, 14 August 2018 17:21:24 MSK Thierry Reding wrote: > > On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote: > > > On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote: > > > > From: Thierry Reding > > >

Re: [PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

2018-08-14 Thread Dmitry Osipenko
On Tuesday, 14 August 2018 17:21:24 MSK Thierry Reding wrote: > On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote: > > On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote: > > > From: Thierry Reding > > > > > > The BSEV clock has a separate gate bit and can not be assumed to

We are ready to work for you

2018-08-14 Thread Jessica Parker
Shooting pictures is easy. However,the most important part often involves the editing part after the shooting. For many professional photographers, post processing photo editing has become a necessity. They may have shot good pictures yes but they still need to make them great. It is at this point

Re: [PATCH 01/14] staging: media: tegra-vde: Support BSEV clock and reset

2018-08-14 Thread Thierry Reding
On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote: > On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote: > > From: Thierry Reding > > > > The BSEV clock has a separate gate bit and can not be assumed to be > > always enabled. Add explicit handling for the BSEV clock and res

Re: [PATCH v2 12/20] staging: mt7621-pci: rewrite pcie phy related functions

2018-08-14 Thread Sergio Paracuellos
On Tue, Aug 14, 2018 at 12:51 PM, Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 08:45:57PM +0200, Sergio Paracuellos wrote: >> @@ -561,15 +660,13 @@ static int mt7621_pci_probe(struct platform_device >> *pdev) >> >> mdelay(100); >> >> - list_for_each_entry_safe(port, tmp, &pcie->ports,

Re: [PATCH v2 04/20] staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2018-08-14 Thread Sergio Paracuellos
On Tue, Aug 14, 2018 at 12:43 PM, Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 08:45:49PM +0200, Sergio Paracuellos wrote: >> Driver probe function is a mess and shall be refactored a lot. At first >> make use of assert and deassert control factoring out a new function >> called 'mt7621_pcie_ena

Re: [PATCH v2 11/20] staging: mt7621-pci: show N_FTS status using a loop

2018-08-14 Thread Sergio Paracuellos
On Tue, Aug 14, 2018 at 12:46 PM, Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 08:45:56PM +0200, Sergio Paracuellos wrote: >> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c >> b/drivers/staging/mt7621-pci/pci-mt7621.c >> index ec1d822..f499c108 100644 >> --- a/drivers/staging/mt7621-pci/p

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-14 Thread Arend van Spriel
On 8/14/2018 12:56 PM, Dan Carpenter wrote: On Sun, Aug 12, 2018 at 05:48:52PM +0530, Ajay Singh wrote: Yes, currently only code to read and writing for "wilc_debug_level" exists. The main purpose for this file was to configure(enable/disable) specific level debug logs to print. The kernel's

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-14 Thread Ajay Singh
Hi Dan, On Tue, 14 Aug 2018 13:56:21 +0300 Dan Carpenter wrote: > On Sun, Aug 12, 2018 at 05:48:52PM +0530, Ajay Singh wrote: > > Yes, currently only code to read and writing for "wilc_debug_level" > > exists. > > > > The main purpose for this file was to configure(enable/disable) > > specific

Re: [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error

2018-08-14 Thread Dan Carpenter
On Sun, Aug 12, 2018 at 05:48:52PM +0530, Ajay Singh wrote: > Yes, currently only code to read and writing for "wilc_debug_level" > exists. > > The main purpose for this file was to configure(enable/disable) > specific level debug logs to print. > The kernel's dev_dbg() macros are really very cle

Re: [PATCH v2 12/20] staging: mt7621-pci: rewrite pcie phy related functions

2018-08-14 Thread Dan Carpenter
On Sun, Aug 12, 2018 at 08:45:57PM +0200, Sergio Paracuellos wrote: > @@ -561,15 +660,13 @@ static int mt7621_pci_probe(struct platform_device > *pdev) > > mdelay(100); > > - list_for_each_entry_safe(port, tmp, &pcie->ports, list) > - mt7621_pcie_enable_port(port); > - >

Re: [PATCH v2 11/20] staging: mt7621-pci: show N_FTS status using a loop

2018-08-14 Thread Dan Carpenter
On Sun, Aug 12, 2018 at 08:45:56PM +0200, Sergio Paracuellos wrote: > diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c > b/drivers/staging/mt7621-pci/pci-mt7621.c > index ec1d822..f499c108 100644 > --- a/drivers/staging/mt7621-pci/pci-mt7621.c > +++ b/drivers/staging/mt7621-pci/pci-mt7621.c >

Re: [PATCH v2 04/20] staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

2018-08-14 Thread Dan Carpenter
On Sun, Aug 12, 2018 at 08:45:49PM +0200, Sergio Paracuellos wrote: > Driver probe function is a mess and shall be refactored a lot. At first > make use of assert and deassert control factoring out a new function > called 'mt7621_pcie_enable_port'. > > Signed-off-by: Sergio Paracuellos > --- > d

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-08-14 Thread gregkh
On Tue, Aug 14, 2018 at 10:34:27AM +0200, Arnd Bergmann wrote: > On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh wrote: > > > > Hi Arnd, > > > > On Mon, 13 Aug 2018 23:20:33 +0200 > > Arnd Bergmann wrote: > > > > > The TODO item named "make spi and sdio components coexist in one > > > build" was appar

Re: [PATCH] staging: wilc1000: revert "fix TODO to compile spi and sdio components in single module"

2018-08-14 Thread Arnd Bergmann
On Tue, Aug 14, 2018 at 7:22 AM Ajay Singh wrote: > > Hi Arnd, > > On Mon, 13 Aug 2018 23:20:33 +0200 > Arnd Bergmann wrote: > > > The TODO item named "make spi and sdio components coexist in one > > build" was apparently addressed a long time ago, but never removed > > from the TODO file. Howeve

Braces not required

2018-08-14 Thread Kidega Moses
___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel