On 2018/7/30 9:51, Gao Xiang wrote:
> Just clean up and logic doesn't change.
>
> Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050766.html
> Fixes: d72d1ce60174 ("staging: erofs: add namei functions")
> Reported-by: kbuild test robot
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
On Mon, Jul 30, 2018 at 03:20:47PM +1000, NeilBrown wrote:
> On Fri, Jul 27 2018, Sergio Paracuellos wrote:
>
> > map_bus callback is called before every .read/.write operation.
> > Implement it and change custom read write operations for the
> > pci subsystem generics. Make the probe function to
On Mon, Jul 30, 2018 at 03:20:47PM +1000, NeilBrown wrote:
> On Fri, Jul 27 2018, Sergio Paracuellos wrote:
>
> > map_bus callback is called before every .read/.write operation.
> > Implement it and change custom read write operations for the
> > pci subsystem generics. Make the probe function to
On Fri, Jul 27 2018, Sergio Paracuellos wrote:
> map_bus callback is called before every .read/.write operation.
> Implement it and change custom read write operations for the
> pci subsystem generics. Make the probe function to don't use
> legacy stuff and request bus resources directly. Get pci
On 2018/7/30 11:07, Chao Yu wrote:
>> It seems that Greg merged this patch to staging-next yesterday, since it is
>> a urgent fix
>> (otherwise erofs cannot be compiled properly without CONFIG_EROFS_FS_ZIP,
>> that is my fault).
>>
>> I wrote in a patch yesterday becuase all the modifications h
Hi Xiang,
On 2018/7/30 10:32, Gao Xiang wrote:
> Hi Chao,
>
> On 2018/7/30 10:07, Chao Yu wrote:
>> On 2018/7/29 13:34, Gao Xiang via Linux-erofs wrote:
>>> This patch fixes incorrect code snippets due to spilt code
>>> into small patches by mistake.
>>>
>>> Link: https://lists.01.org/pipermail/k
Hi Chao,
On 2018/7/30 10:07, Chao Yu wrote:
> On 2018/7/29 13:34, Gao Xiang via Linux-erofs wrote:
>> This patch fixes incorrect code snippets due to spilt code
>> into small patches by mistake.
>>
>> Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050747.html
>> Link: https://lists.01.o
On 2018/7/29 13:37, Gao Xiang via Linux-erofs wrote:
> This patch adds error handling code for
> z_erofs_map_blocks_iter to fix the compiler blame.
>
> Signed-off-by: Gao Xiang
Reviewed-by: Chao Yu
Thanks,
___
devel mailing list
de...@linuxdriverpro
On 2018/7/29 13:34, Gao Xiang via Linux-erofs wrote:
> This patch fixes incorrect code snippets due to spilt code
> into small patches by mistake.
>
> Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050747.html
> Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050750.html
> Rep
Hi,
On 2018/7/30 5:37, kbuild test robot wrote:
> Hi Gao,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: b9f13084580c9032ba7c505da2c6c075f176472a
> commit: fd68c6a20fcfac78b70465ec2e858403dc2
Just clean up and logic doesn't change.
Link: https://lists.01.org/pipermail/kbuild-all/2018-July/050766.html
Fixes: d72d1ce60174 ("staging: erofs: add namei functions")
Reported-by: kbuild test robot
Signed-off-by: Gao Xiang
---
drivers/staging/erofs/namei.c | 2 +-
1 file changed, 1 insertion
Thank you, i found a few case on this module i will try to fix them
and send a new patch series.
On Sun, 29 Jul 2018 at 20:33, Joe Perches wrote:
>
> On Sun, 2018-07-29 at 17:43 +0300, Georgios Tsotsos wrote:
> > Fixing coding style for a few lines that were reported to check from
> > checkpatch.p
Replaced -1 with defined error code EINVAL
Signed-off-by: Georgios Tsotsos
---
v2: Apply coding style to function cvmx_usb_poll_channel
v3: Break down function cvmx_usb_poll_channel
v4: Return defined error code and applying coding style for function calls
v5: Fixing wrong patch applied before wi
Replacing CVMX_WAIT_FOR_FIELD32 macro with equivalent function, and used
simpler approach for new function's parameters.
Signed-off-by: Georgios Tsotsos
---
v3: Changed CVMX_WAIT_FOR_FIELD32 macro to function according as refereed in
commit message and suggested by Greg Kroah-Hartman
v4: Added pa
Hi Gao,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: b9f13084580c9032ba7c505da2c6c075f176472a
commit: fd68c6a20fcfac78b70465ec2e858403dc200056 [546/628] staging: erofs:
update Kconfig and Makefile
co
On Sun, Jul 29, 2018 at 10:05:11PM +0100, John Whitmore wrote:
> Second attempt correcting my initial attempt where I left '_t'
> and '_e' trailing the structures defined. These have now been
> corrected.
>
> John Whitmore (15):
> staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
>
Hi,
Indeed there was a mix-up with patches i will send correction asap.
On Sun, 29 Jul 2018 at 23:21, Aaro Koskinen wrote:
>
> Hi,
>
> On Sun, Jul 29, 2018 at 05:33:38PM +0300, Georgios Tsotsos wrote:
> > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
> > b/drivers/staging/octeon-usb/octeo
On Sun, Jul 29, 2018 at 10:05:15PM +0100, John Whitmore wrote:
> Rename the union ACI_AIFSN to aci_aifsn and remove the typedef directive.
>
> The removal of the typedef clears the checkpatch issue with defining
> new types. The renaming is to adhere to the coding style where types
> are name in l
On Sun, Jul 29, 2018 at 10:05:17PM +0100, John Whitmore wrote:
> Rename the member variables of union aci_aifsn, which should be named
> in lowercase. The only member variable, of this union, which is
> actually used is 'acm'.
>
> This are coding style changes which should have no impact on runtim
Remove the typedef of the structure cmpk_txfb_t. This clears the
checkpatch issue with defining new types.
Additionally the type is renamed from cmpk_txfb_t to cmd_pkt_tx_feedback
removing the '_t' as the typedef has been removed.
These changes are purely coding style in nature and should have no
Refactor the use of the enumerated type dm_dig_sta_e, which is not
actually used for type checking by the compiler.
The typedef of dm_dig_sta_e is removed to clear the checkpatch issue
with defining new types, and the enumerated type is left with the name
enum dynamic_init_gain_state
The enumerat
The enumerated type dm_dig_connect_e is only used to group constant
values, as the actual type is never used as the type for the variables
which use the defined constants (cur_connect_state and pre_connect_state).
These two member variables have had there defined types changed to
properly reflect
The enumerated type dm_dig_dbg_e is never used in code so has simply
been removed from the source code.
this is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 6 --
1 file changed, 6 deleti
The enumerated type DM_CCK_Rx_Path_Method is used as a container for
constant definitions, rather then an enumerated type enabling compiler
type checking. To correct this, the variable which uses the constants,
defined by the enumeration, has had its type changed from a u8 to the
enumeration.
Addi
The enumerated type dm_dig_alg_e is only used by one variable in the
code, 'dig_algorithm', a member variable of the structure dig. That
member variable was defined to be of type 'u8' thus negating any
advantage of the use of an enumerated type, (compiler type-checking).
The type of the variable '
The enumerated type dm_dig_cs_ratio_e is never actually used as a type,
but only as a collection of related constants. This is because the
variables, which use the defined constant values, are defined as being
of type u8 rather then tne enumerated type. This omission negates the
possibility of taki
The enumerated type dm_dig_pd_th_e is never actually used as
the type for the two variables which use the constants, which the
enumeration defines. This omission removes the possibility of taking
advantage of compiler type checking.
To correct this the two member variables, (curpd_thstate & prepd_
Second attempt correcting my initial attempt where I left '_t'
and '_e' trailing the structures defined. These have now been
corrected.
John Whitmore (15):
staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE - Style
staging:r
The enumerated type dm_ratr_sta_e was defined in the file
drivers/staging/rtl8192u/r8192U_dm.h but never actually used in that
file. The only variable which uses this enumerated type is 'ratr_state',
a member variable of the _rate_adaptive structure defined in the file
drivers/staging/rtl8192u/r819
Remove the typedef of struct cmpk_intr_sta_t, the name of the structure
has been left as cmd_pkt_interrupt_status. This clears the checkpatch
issue with creating new types in code. The change is purely a coding
style change and should have no impact on runtime code execution.
Signed-off-by: John W
Remove the typedef from cmpk_set_cfg_t, leaving the structure as
struct cmd_pkt_set_configuration. This change clears the checkpatch
issue with defining new types. The change is purely a coding
style change which should have no impact on runtime code execution.
Signed-off-by: John Whitmore
---
d
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a
coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819
Remove the enumerated type dm_dig_op_e. The type is only used as a
parameter to the function dm_change_dynamic_initgain_thresh(), but
that function is never referenced in the code at all.
I would consider this to be a coding style change as the function is
never referenced and as a result the enum
Correct the spelling of a number of comments, which cause a checkpatch
issue. This is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style
change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
b/
Rename the member variables of union aci_aifsn, which should be named
in lowercase. The only member variable, of this union, which is
actually used is 'acm'.
This are coding style changes which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl
Correct the spelling of a number of comments, which cause a checkpatch
issue. This is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
Add the required spaces around '+' and '*' operators. This is a
coding style change to clear the checkpatch issue. There should be
no impact on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 2 +-
1 file changed, 1 insertion(+), 1 dele
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style
change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
b/
Rename the union ACI_AIFSN to aci_aifsn and remove the typedef directive.
The removal of the typedef clears the checkpatch issue with defining
new types. The renaming is to adhere to the coding style where types
are name in lower case.
These changes are coding style changes which should have no i
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a
coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819
Remove the typedef of the structure cmpk_txfb_t. This clears the
checkpatch issue with defining new types.
Additionally the type is renamed from cmpk_txfb_t to cmd_pkt_tx_feedback
removing the '_t' as the typedef has been removed.
These changes are purely coding style in nature and should have no
Second attempt correcting my initial attempt where I left '_t'
and '_e' trailing the structures defined. These have now been
corrected.
John Whitmore (15):
staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE - Style
staging:r
Hi,
On Sun, Jul 29, 2018 at 05:33:38PM +0300, Georgios Tsotsos wrote:
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
> b/drivers/staging/octeon-usb/octeon-hcd.c
> index 3f44ac260eff..edf87d1b3609 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/oct
On Sun, 2018-07-29 at 20:21 +0200, Michael Straube wrote:
> On 07/29/18 19:59, Joe Perches wrote:
> > On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote:
> > > On 07/29/18 19:21, Joe Perches wrote:
> > > > On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
> > > > > Use is_broadcast_et
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
> Use is_broadcast_ether_addr instead of checking each byte of the
> address array for 0xff. Shortens the code and improves readability.
You should show in the commit log that sta_addr is __aligned(2)
as required by is_broadcast_ether_addr,
From: Todd Poynor
Remove the TODO entry for simplifying kernel doc style comments for
static functions, now that this has been addressed.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gasket/TODO b/drivers/staging/
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 151 ++-
1 file changed, 31 insertions(+), 1
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 64 +---
1 file changed, 10 insertions(+), 5
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_interrupt.c | 18 +-
1 file changed, 1 insertion(+), 17 delet
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 51 +--
1 file changed, 9 insertions(+), 42
From: Todd Poynor
Remove forward declarations of static functions, move code to avoid
forward references, for kernel style.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 416 ---
1 file changed, 190 insertions(+), 226 deletions(-)
diff --git a/d
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 28 ---
1 file changed, 4 insertions(+), 24
From: Todd Poynor
Fix multi-line alignment formatting to look like:
int ret = long_function_name(device, VARIABLE1, VARIABLE2,
VARIABLE3, VARIABLE4);
Many of these TODO items were previously cleaned up during the conversion
to standard logging functions.
From: Todd Poynor
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line. Remove extraneous text.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 323 +++--
1 file changed, 48 insertions(+), 2
From: Todd Poynor
Use user namespace to determine whether gasket device file opener is
root, allowing root access to containers, if necessary.
Reported-by: Dmitry Torokhov
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 10 --
1 file changed, 8 insertions(+), 2 d
From: Todd Poynor
Hold references to the struct device and the pci_dev for the page table
while the data structures contian pointers to these.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/dri
From: Todd Poynor
Hold a reference to the struct device while a gasket sysfs mapping
exists for the device and a pointer to the struct is kept in the mapping
data structures.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_sysfs.c | 11 +--
1 file changed, 5 insertions(+),
From: Todd Poynor
Hold a reference on the struct pci_dev while a pointer to it is held in
the gasket data structures.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core.c
From: Todd Poynor
Fixes for device reference counting and root access based on user
namespace for containers, plus cleanups of comments, forward
declarations for static functions (more forthcoming) and multi-line
continuation style (more to come).
Todd Poynor (13):
staging: gasket: core: hold
Hi,
On Sun, Jul 29, 2018 at 02:40:35PM +0300, Georgios Tsotsos wrote:
> +/**
> + * Loop through register until txfflsh or rxfflsh become zero.
> + *
> + * @usb: USB block
> + * @address: 64bit address to read
> + * @timeout_usec: Timeout
> + * @fflsh_type:Indicates fflsh type,
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu/hal/hal_intf.c
index c43e7b438058..b21ba01abc5
Both osdep_service.h and drv_types.h are included from hal_intf.h,
so remove the redundant includes from hal_intf.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/driver
The function rtw_handle_tkip_mic_err() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/recv_osdep.h| 2 --
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 36 ---
2 files changed, 38 deletions(-)
diff --g
Replace tabs with spaces in function definition and variable
declarations.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu/h
The function dump_txrpt_ccx_88e() is nerver used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
v2: removed last patch (8/8) from the series
drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c | 22 ---
.../staging/rtl8188eu/include/rtl8188e_xmit.h | 1 -
2
The function should_forbid_n_rate() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 35 ---
.../staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 36 deletions(-)
diff --git a
Remove unnecessary parentheses, also clears checkpatch issues about
missing spaces around '-'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers
On 07/29/18 20:21, Michael Straube wrote:
On 07/29/18 19:59, Joe Perches wrote:
On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote:
On 07/29/18 19:21, Joe Perches wrote:
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
Use is_broadcast_ether_addr instead of checking each byte o
On 07/29/18 19:59, Joe Perches wrote:
On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote:
On 07/29/18 19:21, Joe Perches wrote:
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
Use is_broadcast_ether_addr instead of checking each byte of the
address array for 0xff. Shortens the
On Sun, 2018-07-29 at 19:42 +0200, Michael Straube wrote:
> On 07/29/18 19:21, Joe Perches wrote:
> > On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
> > > Use is_broadcast_ether_addr instead of checking each byte of the
> > > address array for 0xff. Shortens the code and improves readabi
On Sun, 2018-07-29 at 17:43 +0300, Georgios Tsotsos wrote:
> Fixing coding style for a few lines that were reported to check from
> checkpatch.pl in minor cases for alignment and ending with parenthesis.
>
> Signed-off-by: Georgios Tsotsos
> ---
> drivers/staging/octeon/ethernet.c | 10 +
On 07/29/18 19:21, Joe Perches wrote:
On Sun, 2018-07-29 at 19:08 +0200, Michael Straube wrote:
Use is_broadcast_ether_addr instead of checking each byte of the
address array for 0xff. Shortens the code and improves readability.
You should show in the commit log that sta_addr is __aligned(2)
a
Both osdep_service.h and drv_types.h are included from hal_intf.h,
so remove the redundant includes from hal_intf.c.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/driver
Use if(x) instead of if(x == true).
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu/hal/hal_intf.c
index c43e7b438058..b21ba01abc5
Remove unnecessary parentheses, also clears checkpatch issues about
missing spaces around '-'.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers
Replace tabs with spaces in function definition and variable
declarations.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu/h
The function dump_txrpt_ccx_88e() is nerver used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/hal/rtl8188e_xmit.c | 22 ---
.../staging/rtl8188eu/include/rtl8188e_xmit.h | 1 -
2 files changed, 23 deletions(-)
diff --git a/
Use is_broadcast_ether_addr instead of checking each byte of the
address array for 0xff. Shortens the code and improves readability.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/os_dep/ioctl_linux.c| 34 ++-
1 file changed, 10 insertions(+), 24 deletions(-)
diff
The function rtw_handle_tkip_mic_err() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/include/recv_osdep.h| 2 --
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 36 ---
2 files changed, 38 deletions(-)
diff --g
The function should_forbid_n_rate() is never used, so remove it.
Discovered by cppcheck.
Signed-off-by: Michael Straube
---
.../staging/rtl8188eu/core/rtw_wlan_util.c| 35 ---
.../staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
2 files changed, 36 deletions(-)
diff --git a
Hello,
Regarding your latest comment, i have notice many functions in this module
using kerneldoc and not been global, also there are various erroneous
situations that functions return not defined error codes.
I will try to fix them all and a new patch series for those two issues after
this one is
Fixing coding style for a few lines that were reported to check from
checkpatch.pl in minor cases for alignment and ending with parenthesis.
Signed-off-by: Georgios Tsotsos
---
drivers/staging/octeon/ethernet.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/driver
Replaced -1 with defined error code EINVAL
Signed-off-by: Georgios Tsotsos
---
v2: Apply coding style to function cvmx_usb_poll_channel
v3: Break down function cvmx_usb_poll_channel
v4: Return defined error code and applying coding style for function calls
drivers/staging/octeon-usb/octeon-hcd.c
Assign to variable the result of CVMX_USBCX_GRSTCTL instead of multiple
calling a macro.
Signed-off-by: Georgios Tsotsos
---
v2: It wasn't exist in this or earlier versions of patch series
v3: It seems a logical to avoid multiple calls of CVMX_USBCX_GRSTCTL that will
also help cleaning up calls
Replacing CVMX_WAIT_FOR_FIELD32 macro with equivalent function.
Signed-off-by: Georgios Tsotsos
---
v2: Changed CVMX_WAIT_FOR_FIELD32 syntax to avoid checkpatch check notice and
tried to make the macro more readable.
v3: Changed CVMX_WAIT_FOR_FIELD32 macro to function according as refereed in
co
From: sepehrdad sh
Fixed and cleaned up checkpatch coding style errors.
Signed-off-by: Sepehrdad Sh
---
drivers/staging/emxx_udc/emxx_udc.c | 309 +---
1 file changed, 146 insertions(+), 163 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/stagi
On Sun, Jul 29, 2018 at 02:40:34PM +0300, Georgios Tsotsos wrote:
> Assign to variable the result of CVMX_USBCX_GRSTCTL instead of multiple
> calling a macro.
>
> Signed-off-by: Georgios Tsotsos
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 20 ++--
> 1 file changed, 10 inser
On Sun, Jul 29, 2018 at 02:41:53PM +0300, Georgios Tsotsos wrote:
> In order to make this function more clear a new function created that controls
> channels halt on no DMA mode.
>
> Signed-off-by: Georgios Tsotsos
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 81
> +
In order to make this function more clear a new function created that controls
channels halt on no DMA mode.
Signed-off-by: Georgios Tsotsos
---
drivers/staging/octeon-usb/octeon-hcd.c | 81 +
1 file changed, 53 insertions(+), 28 deletions(-)
diff --git a/drivers
Changed the function in order to use only values instead passing unions
i think its better than passing pointers there.
Georgios Tsotsos (1):
Staging: octeon-usb: Breaks down cvmx_usb_poll_channel().
drivers/staging/octeon-usb/octeon-hcd.c | 81 +
1 file changed
Assign to variable the result of CVMX_USBCX_GRSTCTL instead of multiple
calling a macro.
Signed-off-by: Georgios Tsotsos
---
drivers/staging/octeon-usb/octeon-hcd.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
Replying to previous message, i changed CVMX_WAIT_FOR_FIELD32 macro to function
and altered a multiple calling of CVMX_USBCX_GRSTCTL call to single call and
stored to variable.
Georgios Tsotsos (2):
Staging: octeon-usb: Change multiple calling of CVMX_USBCX_GRSTCTL
Staging: octeon-usb: Changes
Replacing CVMX_WAIT_FOR_FIELD32 macro with equivalent function.
Signed-off-by: Georgios Tsotsos
---
drivers/staging/octeon-usb/octeon-hcd.c | 65 +++--
1 file changed, 38 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/s
From: kbuild test robot
drivers/staging/axis-fifo/axis-fifo.c:1081:3-8: No need to set .owner here. The
core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 4a965c5f89de ("staging: add driver
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 8cc7be34c6385dc04e01bc7c25868782e4d2fbd0
commit: 4a965c5f89decd636129cddc47e5f2c61e8f13e6 [521/627] staging: add driver
for Xilinx AXI-Stream FIFO v4.1 IP core
coccinelle warnings: (new ones prefi
On Sun, Jul 29, 2018 at 10:17:26AM +0200, Greg KH wrote:
> On Sat, Jul 28, 2018 at 12:28:18AM +0100, John Whitmore wrote:
> > Refactor the use of the enumerated type dm_dig_sta_e, which is not
> > actually used for type checking by the compiler.
> >
> > The enumerated type defines values for the e
On Sun, Jul 29, 2018 at 10:10:55AM +0200, Greg KH wrote:
> On Wed, Jul 25, 2018 at 11:16:21PM +0100, John Whitmore wrote:
> > -typedef struct tag_cmd_pkt_tx_feedback {
> > +struct cmpk_txfb_t {
> > /* DWORD 0 */
> > u8 element_id; /* Command packet type. */
> >
On Sat, Jul 28, 2018 at 12:28:18AM +0100, John Whitmore wrote:
> Refactor the use of the enumerated type dm_dig_sta_e, which is not
> actually used for type checking by the compiler.
>
> The enumerated type defines values for the enumeration, which are used
> by both dig_state and dig_highpwr_stat
On Wed, Jul 25, 2018 at 11:16:21PM +0100, John Whitmore wrote:
> -typedef struct tag_cmd_pkt_tx_feedback {
> +struct cmpk_txfb_t {
> /* DWORD 0 */
> u8 element_id; /* Command packet type. */
> u8 length; /* Command packet lengt
1 - 100 of 102 matches
Mail list logo
