Re: [PATCH 4.17 REGRESSION fix] Revert "staging:r8188eu: Use lib80211 to support TKIP"

2018-07-15 Thread Ivan Safonov
On 07/14/2018 09:31 PM, Hans de Goede wrote: Commit b83b8b1881c4 ("staging:r8188eu: Use lib80211 to support TKIP") is causing 2 problems for me: 1) One boot the wifi on a laptop with a r8188eu wifi device would not connect and dmesg contained an oops about scheduling while atomic pointin

Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-15 Thread Jacob Feder
On Sun, Jul 15, 2018 at 09:44:58PM +0200, Greg KH wrote: > On Sun, Jul 15, 2018 at 12:34:28PM -0400, Jacob Feder wrote: > > Hi, > > I have updated this with the recommended changes. I haven't tried out the > > UIO though. It will be a pretty significant undertaking and I don't want > > to spend the

Re: [RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-15 Thread Greg KH
On Sun, Jul 15, 2018 at 12:34:28PM -0400, Jacob Feder wrote: > Hi, > I have updated this with the recommended changes. I haven't tried out the > UIO though. It will be a pretty significant undertaking and I don't want > to spend the time on it unless there is a specific reason you think it > will b

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 11:15:26AM -0700, Todd Poynor wrote: > On Sun, Jul 15, 2018 at 3:03 AM, Greg Kroah-Hartman > wrote: > > On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote: > >> > I can't wait for people to just realize this whole "new" subsystem can > >> > be replaced with UIO

Re: [PATCH resend] staging: gasket: remove X86 Kconfig restriction

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 11:25:45AM -0700, Todd Poynor wrote: > From: Todd Poynor > > The gasket and apex drivers are to be used on other architectures > besides X86. > > Signed-off-by: Todd Poynor > --- > drivers/staging/gasket/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) W

Re: [PATCH resend] staging: gasket: don't release coherent mappings

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 11:24:41AM -0700, Todd Poynor wrote: > From: Todd Poynor > > coherent address mappings aren't backed by a struct page, don't need to > be released, and don't count as an active page in the page table > bookkeeping. > > Signed-off-by: Simon Que > Signed-off-by: Todd Poyno

[PATCH resend] staging: gasket: convert gasket_mmap_has_permissions to bool return

2018-07-15 Thread Todd Poynor
From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b

[PATCH resend] staging: gasket: remove unnecessary code in coherent allocator

2018-07-15 Thread Todd Poynor
From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/stagi

[PATCH resend] staging: gasket: fix class create bug handling

2018-07-15 Thread Todd Poynor
From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH resend] staging: gasket: gasket_open use container_of()

2018-07-15 Thread Todd Poynor
From: Todd Poynor Use container_of(), drop unnecessary NULL check. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket/gask

[PATCH resend] staging: gasket: remove X86 Kconfig restriction

2018-07-15 Thread Todd Poynor
From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig ind

[PATCH resend] staging: gasket: don't release coherent mappings

2018-07-15 Thread Todd Poynor
From: Todd Poynor coherent address mappings aren't backed by a struct page, don't need to be released, and don't count as an active page in the page table bookkeeping. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Todd Poynor
On Sun, Jul 15, 2018 at 3:03 AM, Greg Kroah-Hartman wrote: > On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote: >> > I can't wait for people to just realize this whole "new" subsystem can >> > be replaced with UIO, but that's a topic for a different thread... >> >> Yes, that is true

Re: [PATCH 12/18] staging: gasket: annotate ioctl arg with __user

2018-07-15 Thread Todd Poynor
Yes you're right, I see the entry now. Thanks -- Todd On Sun, Jul 15, 2018 at 2:00 AM, Greg Kroah-Hartman wrote: > On Sat, Jul 14, 2018 at 12:20:51PM -0700, Todd Poynor wrote: >> >> I think I'm following >> >> http://www.kroah.com/log/linux/linux-staging-update.html, >> >> but if I'm off in the

[RFC PATCH v2] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-15 Thread Jacob Feder
Hi, I have updated this with the recommended changes. I haven't tried out the UIO though. It will be a pretty significant undertaking and I don't want to spend the time on it unless there is a specific reason you think it will be faster. Thanks all. Cheers, Jacob This IP core has read and write

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote: > > I can't wait for people to just realize this whole "new" subsystem can > > be replaced with UIO, but that's a topic for a different thread... > > Yes, that is true and that is why I am not sure why we are going > through all this

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 12:32 PM Greg Kroah-Hartman wrote: > > On Sun, Jul 15, 2018 at 12:11:47PM +0300, Dmitry Torokhov wrote: > > On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman > > wrote: > > > > > > On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > > > > From: Todd Poynor >

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 12:11:47PM +0300, Dmitry Torokhov wrote: > On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman > wrote: > > > > On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > > > From: Todd Poynor > > > > > > Always allow root to open device for writing. > > > > > > Drop s

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Dmitry Torokhov
On Sun, Jul 15, 2018 at 12:05 PM Greg Kroah-Hartman wrote: > > On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > > From: Todd Poynor > > > > Always allow root to open device for writing. > > > > Drop special-casing of ioctl permissions for root vs. owner. > > > > Reported-by: Dmitry

Re: [PATCH 11/18] staging: gasket: always allow root open for write

2018-07-15 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:09PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Always allow root to open device for writing. > > Drop special-casing of ioctl permissions for root vs. owner. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > ---

Re: [PATCH 12/18] staging: gasket: annotate ioctl arg with __user

2018-07-15 Thread Greg Kroah-Hartman
On Sat, Jul 14, 2018 at 12:20:51PM -0700, Todd Poynor wrote: > >> I think I'm following > >> http://www.kroah.com/log/linux/linux-staging-update.html, > >> but if I'm off in the weeds do clue me in, thanks. > > > > That's something I wrote 9 years ago :) > > Still the top search result for how to

[PATCH] ks7010_sdio:Fix checkpatch out of memory warning

2018-07-15 Thread RAGHU Halharvi
* Patch fixes checkpatch warning "Possible unnecessary 'out of memory' message" Signed-off-by: RAGHU Halharvi --- drivers/staging/ks7010/ks7010_sdio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7

Re: [PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line

2018-07-15 Thread Greg Kroah-Hartman
On Sun, Jul 15, 2018 at 12:19:18PM +0530, Nishad Kamdar wrote: > Bring function argument 'struct comedi_subdevice *s' to the > previous line to avoid ending the line with open parenthesis. > Issue found by checkpatch. But now the code has another checkpatch violation, too long of a line. You can g