[PATCH 3/4] staging: wilc1000: remove 'rxq_entries' from 'wilc' struct

Removed unnecessary 'rxq_entries' element from 'wilc' struct, as its value is not used. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - drivers/staging/wilc1000/wilc_wlan.c | 7 ++- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/dri

[PATCH 4/4] staging: wilc1000: move 'txq_spinlock_flags' from 'wilc' structure to local variable

Cleanup patch to remove 'txq_spinlock_flags' element in 'wilc' and used local variable 'flag' in wilc_wlan_txq_filter_dup_tcp_ack(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 -- drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- 2 files changed, 3 ins

[PATCH 2/4] staging: wilc1000: use list_head to maintain 'rxq_entry_t elements in rx queue

Make use of 'list_head' data structure to maintain the rx buffer queue. Modified wilc_wlan_rxq_add() to add the element at the tail by using list_head API and wilc_wlan_rxq_remove() to remove the element from head. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 1

[PATCH 0/4] staging: wilc1000: modification to use list_head data structure

Instead of having own linked list implementation to maintain buffer queue change to use list_head. Also removed the few elements from 'wilc' struct as it's not required to be part of 'wilc' struct. Ajay Singh (4): staging: wilc1000: use list_head to maintain 'txq_entry_t' elements of tx queu

[PATCH 1/4] staging: wilc1000: use list_head to maintain 'txq_entry_t' elements of tx queue

Use list_head data structure for the doubly linked list instead of own implementation. Only 'txq_head' is required, so removed the txq_tail pointer from 'wilc' structure. Following functions are modified to provide data using list_head API's wilc_wlan_txq_remove() wilc_wlan_txq_remove_from_head()

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

Thank you for submitting the patches. The modification in this patch looks okay to me. Please resend this by including changes as suggested by Dan. I can do the modification and resubmit this patch by including review comments, if its okay with you. Regards, Ajay

Re: [lustre-devel] [PATCH] staging: lustre: delete the filesystem from the tree.

On Jun 3, 2018, at 9:59 PM, Alexey Lyashkov wrote: > >> On Sun, Jun 03 2018, Dilger, Andreas wrote: >> >>> LNet is originally based on a high-performance networking stack called >>> Portals (v3, http://www.cs.sandia.gov/Portals/), with additions for LNet >>> routing to allow cross-network bridgi

Re: [lustre-devel] [PATCH] staging: lustre: delete the filesystem from the tree.

> 4 июня 2018 г., в 7:15, Andreas Dilger написал(а): > > On Jun 3, 2018, at 9:59 PM, Alexey Lyashkov wrote: >> >>> On Sun, Jun 03 2018, Dilger, Andreas wrote: >>> LNet is originally based on a high-performance networking stack called Portals (v3, http://www.cs.sandia.gov/Portals/),

Re: [lustre-devel] [PATCH] staging: lustre: delete the filesystem from the tree.

> 4 июня 2018 г., в 6:54, NeilBrown написал(а): > > On Sun, Jun 03 2018, Dilger, Andreas wrote: > >> On Jun 1, 2018, at 17:19, NeilBrown wrote: >>> >>> On Fri, Jun 01 2018, Doug Oucharek wrote: >>> Would it makes sense to land LNet and LNDs on their own first? Get the networking h

Re: [lustre-devel] [PATCH] staging: lustre: delete the filesystem from the tree.

On Sun, Jun 03 2018, Dilger, Andreas wrote: > On Jun 1, 2018, at 17:19, NeilBrown wrote: >> >> On Fri, Jun 01 2018, Doug Oucharek wrote: >> >>> Would it makes sense to land LNet and LNDs on their own first? Get >>> the networking house in order first before layering on the file >>> system? >>

Re: [PATCH v3 0/5] staging: mt7621-spi: Fix C Coding style issues.

On Sun, Jun 03 2018, Sankalp Negi wrote: > This patch series lists different changes for coding style fixes > as reported by checkpatch.pl, changes can be broken down as : > > 1. Indent switch and case labels at the same level. > 2. Fix a line over 80 columns by refactoring. > 3. Use tabs for inde

Re: [PATCH 0/7] staging: mt7621-pci: Fix coding style issues

On Sun, Jun 03 2018, Abdun Nihaal wrote: > This patchset fixes the following set of coding style > issues found using checkpatch. > > ERROR: space prohibited after that open parenthesis '(' > ERROR: trailing whitespace > ERROR: space required before the open parenthesis '(' > ERROR: space require

Re: [lustre-devel] [PATCH] staging: lustre: delete the filesystem from the tree.

On Jun 1, 2018, at 17:19, NeilBrown wrote: > > On Fri, Jun 01 2018, Doug Oucharek wrote: > >> Would it makes sense to land LNet and LNDs on their own first? Get >> the networking house in order first before layering on the file >> system? > > I'd like to turn that question on it's head: > Do

Re: [PATCH] staging:r8188eu: Use lib80211 to encrypt (WEP) tx frames

On 05/28/2018 04:53 PM, Dan Carpenter wrote: On Mon, May 28, 2018 at 09:18:21AM +0300, Ivan Safonov wrote: Put data to skb, decrypt with lib80211_crypt_wep, and place back to tx buffer. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_security.c | 72 ---

[PATCH 4/7] staging: mt7621-pci: add space after comma symbol

This patch fixes the following checkpatch error: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Abdun Nihaal --- drivers/staging/mt7621-pci/pci-mt7621.c | 36 - 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-

[PATCH 3/7] staging: mt7621-pci: add space before open parenthesis

This fixes the following checkpatch error: ERROR: space required before the open parenthesis '(' Signed-off-by: Abdun Nihaal --- drivers/staging/mt7621-pci/pci-mt7621.c | 28 - 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci

[PATCH 5/7] staging: mt7621-pci: add spaces around equal symbol

This fixes the following checkpatch error: ERROR: spaces required around that '=' (ctx:VxW) Signed-off-by: Abdun Nihaal --- drivers/staging/mt7621-pci/pci-mt7621.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/stagin

[PATCH 1/7] staging: mt7621-pci: Remove space after open parenthesis

This fixes the following checkpatch error: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Abdun Nihaal --- drivers/staging/mt7621-pci/pci-mt7621.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drive

[PATCH 6/7] staging: mt7621-pci: add space after '==' symbol

This fixes the following checkpatch error: ERROR: spaces required around that '==' (ctx:WxV) Signed-off-by: Abdun Nihaal --- drivers/staging/mt7621-pci/pci-mt7621.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/stagi

[PATCH 2/7] staging: mt7621-pci: remove trailing whitespace

This fixes the following checkpatch error: ERROR: trailing whitespace Signed-off-by: Abdun Nihaal --- drivers/staging/mt7621-pci/pci-mt7621.c | 32 - 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/stagin

[PATCH 7/7] staging: mt7621-pci: fix coding style error

This fixes the following checkpatch error: ERROR: that open brace { should be on the previous line Signed-off-by: Abdun Nihaal --- drivers/staging/mt7621-pci/pci-mt7621.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers

[PATCH 0/7] staging: mt7621-pci: Fix coding style issues

This patchset fixes the following set of coding style issues found using checkpatch. ERROR: space prohibited after that open parenthesis '(' ERROR: trailing whitespace ERROR: space required before the open parenthesis '(' ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required aroun

Re: [PATCH net-next] hv_netvsc: fix error return code in netvsc_probe()

From: Wei Yongjun Date: Thu, 31 May 2018 02:04:43 + > Fix to return a negative error code from the failover register fail > error handling case instead of 0, as done elsewhere in this function. > > Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use > the failover fra

Re: [PATCH v5 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

On Sun, Jun 03, 2018 at 01:04:13PM +0100, John Whitmore wrote: > Signed-off-by: John Whitmore > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) I can not take patches without any changelog text at all :( _

[PATCH v5 2/8] staging: rtl8192e: Addition of prefered spacing - Coding style

Added spaces around various operators, as preferred by coding style. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/dri

[PATCH v5 5/8] staging: rtl8192e: Remove unrequired space at start of line - Coding Style

Function HTIOTActIsDisableMCS14 contained spurious space at start of line. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/stagi

[PATCH v5 8/8] staging: rtl8192e: remove unnecessary parentheses - Coding Style

Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 9cca4a8f1cf5..fad7

[PATCH v5 7/8] staging: rtl8192e: Optimise Comparison to NULL tests - Coding Style

Change comparison to NULL to better adhere to coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/stagin

[PATCH v5 4/8] staging: rtl8192e: Correct alignment of if statements - Coding Style

Function HTIOTPeerDetermine used incorrect indentation in if statements. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/d

[PATCH v5 6/8] staging: rtl8192e: Correct declaration of HTResetIOTSetting - Coding Style

Declaration of function was spread over three lines. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee802

[PATCH v5 3/8] staging: rtl8192e: Remove unnecessary return statements - Coding style

Return statments from void functions are not required by the coding standard. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192

[PATCH v5 1/8] staging: rtl8192e: Add and remove blank lines - Coding style

Simple addition & removal of blank lines as required Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 64 +-- 1 file changed, 16 insertions(+), 48 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl

staging: rtl8192e: Series of coding style changes

Another attempt at cleaning up some of the coding style issues with this file. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel