Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On 04/23/18 15:50, Greg Kroah-Hartman wrote: > On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: >> In the current implementation, vchi_instance is inited during the first >> call of bcm2835_audio_open_connection(), and is never freed. It causes a >> memory leak when the module `s

Re: [PATCH 0/3] stagging:iio:meter: Add essential IIO API structures for ADE7854

Hi Jonathan, Thanks for all the feedbacks and sorry for some basic mistakes, I will work on the second version based on all your comments. Best Regards Rodrigo Siqueira On 04/21, Jonathan Cameron wrote: > On Sat, 21 Apr 2018 08:54:45 -0300 > Rodrigo Siqueira wrote: > > > This patchset aims to

Re: [PATCH] staging: lustre: Change return type to vm_fault_t

On Mon, Apr 23, 2018 at 11:38:17PM +0530, Souptick Joarder wrote: > On Mon, Apr 23, 2018 at 11:05 PM, Matthew Wilcox wrote: > > I think you need to check your setup ... I get this: > > > > drivers/staging/lustre/lustre/llite/llite_mmap.c:277:31: warning: incorrect > > type in return expression (d

Re: [PATCH] staging: lustre: Change return type to vm_fault_t

On Mon, Apr 23, 2018 at 11:05 PM, Matthew Wilcox wrote: > On Mon, Apr 23, 2018 at 10:12:30PM +0530, Souptick Joarder wrote: >> On Sun, Apr 22, 2018 at 8:50 AM, Matthew Wilcox wrote: >> > On Sun, Apr 22, 2018 at 03:47:24AM +0530, Souptick Joarder wrote: >> >> @@ -261,7 +261,7 @@ static inline int

[PATCH RESEND] staging: pi433: break long lines in pi433_if.c

Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings: "WARNING: line over 80 characters" Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/

Re: [PATCH] staging: lustre: Change return type to vm_fault_t

On Mon, Apr 23, 2018 at 10:12:30PM +0530, Souptick Joarder wrote: > On Sun, Apr 22, 2018 at 8:50 AM, Matthew Wilcox wrote: > > On Sun, Apr 22, 2018 at 03:47:24AM +0530, Souptick Joarder wrote: > >> @@ -261,7 +261,7 @@ static inline int to_fault_error(int result) > >> * \retval VM_FAULT_ERROR on

Re: [PATCH] staging: lustre: Change return type to vm_fault_t

On Sun, Apr 22, 2018 at 8:50 AM, Matthew Wilcox wrote: > On Sun, Apr 22, 2018 at 03:47:24AM +0530, Souptick Joarder wrote: >> @@ -261,7 +261,7 @@ static inline int to_fault_error(int result) >> * \retval VM_FAULT_ERROR on general error >> * \retval NOPAGE_OOM not have memory for allocate new p

[RESEND 19/33] staging: wilc1000: fix line over 80 chars in change_station()

Fix 'line over 80 chars' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[RESEND 33/33] staging: wilc1000: rename pu32InactiveTime to avoid camelCase issue

Avoid camelCase issues found by checkpatch.pl script. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/hos

[RESEND 25/33] staging: wilc1000: remove the use of goto label in spi_cmd_complete()

In spi_cmd_complete() remove the use of goto label '_error_'. Changes were done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_spi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers

[RESEND 32/33] staging: wilc1000: remove the use of goto label in wilc_spi_clear_int_ext()

Remove goto label '_fail_' used in wilc_spi_clear_int_ext(), to avoid the label name starting with '_'. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_spi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1

[RESEND 27/33] staging: wilc1000: remove the use of goto label in wilc_spi_read_int()

In wilc_spi_read_int() remove the use of goto label '_fail_'. Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/stagi

[RESEND 30/33] staging: wilc1000: rename goto label '_fail_' linux naming convension

Rename '_fail_' goto label to have name as per linux coding style. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/linux_wlan.c | 92 +-- drivers/staging/wilc1000/wilc_sdio.c | 84 drivers/stagi

[RESEND 29/33] staging: wilc1000: remove the use of goto label in wilc_init()

Added direct return in wilc_init() instead of goto label. Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff

[RESEND 31/33] staging: wilc1000: rename goto labels starting with '_' in wilc1000_wlan_init()

Rename goto labels starting with '_' in wilc1000_wlan_init() to follow linux coding style. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/linux_wlan.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/sta

[RESEND 28/33] staging: wilc1000: remove goto label '_done_' in handle_listen_state_expired()

Remove the use of goto label '_done_' in handle_listen_state_expired(). Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[RESEND 23/33] staging: wilc1000: remove multiple define used for MAX_SSID_LEN

Cleanup patch to have commonly used macro in common header file to avoid same defination in mulitple file. Removed MAX_SSID_LEN macro from coreconfigurator.h header as its already defined in wilc_wlan_if.h. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/corec

[RESEND 20/33] staging: wilc1000: rename WID_LOGTerminal_Switch to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h b/drivers/staging/wilc1000/wi

[RESEND 22/33] staging: wilc1000: remove unused macros in wilc module

Cleanup patch to remove the macros which are defined by not used. Below mentioned macros are removed: SCAN_DONE SCAN_EVENT_DONE_ABORTED WILC_WFI_RX_INTR WILC_WFI_TX_INTR WILC_WFI_TIMEOUT WILC_WFI_DWELL_PASSIVE WILC_WFI_DWELL_ACTIVE MAX_SURVEY_RESULT_FRAG_SIZE SURVEY_RESULT_LENGTH NUM_BASIC_SWITCHES

[RESEND 26/33] staging: wilc1000: remove the use of goto label in wilc_spi_read_size()

In wilc_spi_read_size() remove the use of goto label '_fail_'. Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/stag

[RESEND 21/33] staging: wilc1000: added identifiers name in function definations

Fix identifier names required for functions definition issues reported by checkpatch.pl script. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wlan.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers

[RESEND 18/33] staging: wilc1000: use sizeof(variable) for memory allocated to store key info

Changes to fix below checkpatch reported issues. CHECK: Prefer kmalloc(sizeof(*priv->wilc_gtk[idx])...) over kmalloc(sizeof(struct wilc_wfi_key)...) CHECK: Prefer kmalloc(sizeof(*priv->wilc_ptk[idx])...) over kmalloc(sizeof(struct wilc_wfi_key)...) Signed-off-by: Ajay Singh Reviewed-by: Claudiu

[RESEND 05/33] staging: wilc1000: rename WILC_WFI_p2p_rx & s32Freq to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 18 +- drivers/staging/

[RESEND 24/33] staging: wilc1000: remove multiple define for mac connect and disconnect

Cleanup patch to have commonly used macro in common header file to avoid same defination in mulitple file. Removed MAC_CONNECTED & MAC_DISCONNECTED macro from coreconfigurator.h header. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/coreconfigurator.h | 3 ---

[RESEND 04/33] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

Fix 'line over 80 characters' issue found by checkpatch.pl script. Refactor and split the function to avoid the checkpatch reported issues. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 145 -

[RESEND 17/33] staging: wilc1000: handle error condition in add_key() and remove auth_type variable

Added the code to return correct error code in add_key() and also removed 'auth_type' variable. Now passing diretly to function instead of using the 'auth_type' variable. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 52 +++

[RESEND 14/33] staging: wilc1000: split add_key() to avoid line over 80 chars

Cleanup changes to fix 'line over 80 chars' issue found by checkpatch.pl script by spliting the function. Also make use of kzalloc() instead kmalloc(). Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 108 +- 1 fil

[RESEND 02/33] staging: wilc1000: removed unused static variables for gtk and ptk information

Removed the unnecessary static variables used to store gtk and ptk information. Key data stored in the params was never access using these variables. Variables given below are removed g_add_gtk_key_params; g_key_gtk_params; g_add_ptk_key_params; g_key_ptk_params; g_key_wep_params; g_ptk_keys_save

[RESEND 07/33] staging: wilc1000: rename hAgingTimer to avoid camelCase issue

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1

[RESEND 12/33] staging: wilc1000: rename WILC_WFI_wep_key & WILC_WFI_wep_key_len

Cleanup patch to use lower case for variable name as per linux coding style. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 30 +++ drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 +-- 2 files changed, 17

[RESEND 08/33] staging: wilc1000: fix line over 80 char issue in clear_shadow_scan()

Remove 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/dri

[RESEND 06/33] staging: wilc1000: refactor mgmt_tx to fix line over 80 chars

Refactor mgmt_tx() to fix line over 80 characters issue. Split the function to avoid the checkpatch.pl warning. Returning the same error code in case of memory allocation failure. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/wilc

[RESEND 03/33] staging: wilc1000: remove line over 80 char warnings in set_wiphy_params()

Fix 'line over 80 character' issue reported by checkpatch.pl script in set_wiphy_params(). Directly used the 'wiphy' pointer received as function argument instead of using 'priv->dev->ieee80211_ptr->wiphy'. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- dr

[RESEND 16/33] staging: wilc1000: refactor add_key() to avoid duplicated code

Cleanup fixes by removing the duplicated code in actor add_key(). Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 64 --- 1 file changed, 23 insertions(+), 41 deletions(-) diff --git a/drivers/staging/wilc1000/wi

[RESEND 15/33] staging: wilc1000: remove inner block {} and resetting of mode variable

Cleanup fixes to remove the uncessary inner block { /* */ } and setting of 'mode' variable. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 43 +++ 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/d

[RESEND 10/33] staging: wilc1000: remove unused 'struct add_key_params'

Cleanup patch to remove unused struct data structure. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.

[RESEND 13/33] staging: wilc1000: rename variable using datatype in their name in add_key()

Cleanup changes to use variable name as per linux coding style. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 32 +++ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/wilc1000/wilc

[RESEND 09/33] staging: wilc1000: remove line over 80 char in cfg_connect_result()

Fix 'line over 80 characters' issues reported by checkpatch.pl script in cfg_connect_result(). Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 34 +++ 1 file changed, 22 insertions(+),

[RESEND 01/33] staging: wilc1000: refactor scan() to free kmalloc memory on failure cases

Added changes to free the allocated memory in scan() for error condition. Also added 'NULL' check validation before accessing allocated memory. Copied the SSID information in consecutive slots to avoid inbetween holes while filling into array. Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea

[RESEND 11/33] staging: wilc1000: remove line over 80 char warning in few functions

Remove 'line over 80 characters' issues found by checkpatch.pl script for following functions. disconnect() del_pmksa() wilc_create_wiphy() del_pmksa() Signed-off-by: Ajay Singh Reviewed-by: Claudiu Beznea Reviewed-by: Dan Carpenter --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 +

[RESEND 00/33] staging: wilc1000: code cleanup and checkpatch fixes

This resend patch series contains patches from [1] & [2] clubbed together. [1] https://www.mail-archive.com/linux-wireless@vger.kernel.org/msg43998.html [2] https://www.mail-archive.com/linux-wireless@vger.kernel.org/msg45006.html Ajay Singh (33): staging: wilc1000: refactor scan() to free kmal

[PATCH v2] android: binder: Change return type to vm_fault_t

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f422059ae ("mm: change r

Re: [PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem

On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > Add imx7 capture subsystem to imx-media core to allow the use some of the > existing modules for i.MX5/6 with i.MX7 SoC. > > Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate > some runtime behaviors. > > Sign

Re: [PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > This patch adds the device tree nodes for csi, video multiplexer and mipi-csi > besides the graph connecting the necessary endpoints to make the media capture > entities to work in imx7 Warp board. > > Also add the pin control related wi

[PATCH] Revert "staging: nvec: Augment TODO file with GPIO work item"

This reverts commit 5a3e59ce3acf2f52c8b4a6fc656c3b1e4a329f06, because the necessary changes were applied in the "staging: nvec: convert to use GPIO descriptors" patch. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/stagi

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

Hi Ajay, You can add: Reviewed-by: Claudiu Beznea On 23.04.2018 16:01, Ajay Singh wrote: > On Mon, 23 Apr 2018 15:45:38 +0200 > Greg KH wrote: > >> On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: >>> This patch series is based on top of >>> "[PATCH 00/11] staging: wilc1000: fix for

Re: [PATCH] staging: wilc1000: fix NULL pointer exception in host_int_parse_assoc_resp_info()

Reviewed-by: Claudiu Beznea On 12.04.2018 10:21, Ajay Singh wrote: > Commit fe014d4e6b55 (staging: wilc1000: free memory allocated for general info > message from firmware) introduced a bug by using wrong source address in > kmemdup(). 'conn_info.req_ies' is used for source address in kempdup() >

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

On Mon, Apr 23, 2018 at 07:31:38PM +0530, Ajay Singh wrote: > On Mon, 23 Apr 2018 15:45:38 +0200 > Greg KH wrote: > > > On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > > > This patch series is based on top of > > > "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled > >

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

On Mon, 23 Apr 2018 15:45:38 +0200 Greg KH wrote: > On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > > This patch series is based on top of > > "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled > > malloc memory properly" and its not applied yet.[1] > > I don't have

Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed. > > Here is how this comm

[PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva ---

[PATCH v2 13/15] ARM: dts: imx7s-warp: add ov2680 sensor node

Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch

[PATCH v2 15/15] media: staging/imx: add i.MX7 entries to TODO file

Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324 100644 --- a/drivers/stagi

[PATCH v2 14/15] media: imx7.rst: add documentation for i.MX7 media driver

Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers/index.rst | 1 + 2 files c

Re: [PATCH 05/21] staging: ks7010: change if-else condition assignment to use ternary operator

On Mon, Apr 23, 2018 at 3:30 PM, Dan Carpenter wrote: > To be honest, it wasn't even the right thing for me to comment this > patch. If you think it makes the code nicer then go ahead, you've > earned that. The patchset is nice and makes a bunch of tricky > improvements to the code. I reviewed

[PATCH v2 10/15] ARM: dts: imx7s: add multiplexer controls

The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file changed, 8 insertions(+), 1

Re: [PATCH 04/11] staging: vchiq_arm: Clear VLA warning

On Wed, Apr 04, 2018 at 09:25:54PM +0200, Stefan Wahren wrote: > > > kbuild test robot hat am 1. April 2018 um 01:36 > > geschrieben: > > > > > > Hi Stefan, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on staging/staging-testing] > > [also build t

[PATCH v2 07/15] ARM: dts: increase default cma size to 40MB

To support camera in i.MX7 the cma heap is used to allocate frame buffers. The default size of CMA is 16MB which is not enough for higher resolutions (ex: 1600x1200). So, increase the default CMA size to 40MB. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 14 ++

[PATCH v2 12/15] ARM: dts: imx7s: add capture subsystem

Add media capture subsystem device to i.MX7 definitions. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 6b49b73053f9..333d9fe6b989 100644 --- a/arch/arm/bo

[PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root

To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Cc: linux-...@vger.kernel.org Signed-off-by: Rui Miguel Silv

[PATCH v2 08/15] media: dt-bindings: add bindings for i.MX7 media driver

Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7.txt| 158 ++ 1 file changed, 158 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt diff --git a/Documentation/devic

[PATCH v2 09/15] ARM: dts: imx7s: add mipi phy power domain

Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 142ea709d296..d913c3f9c284 100644 --- a/arch/arm/b

[PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem

Add imx7 capture subsystem to imx-media core to allow the use some of the existing modules for i.MX5/6 with i.MX7 SoC. Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate some runtime behaviors. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-dev

[PATCH v2 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1149 2 files changed, 1150 insertions(+) create mode

[PATCH v2 01/15] media: staging/imx: add support to media dev for no IPU systems

Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of systems that do not have internal subdevices besides the CSI. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-dev.c | 18 +- .

[PATCH v2 02/15] media: staging/imx7: add imx7 CSI subdev driver

This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7-media-csi.c | 1345 +++

[PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent

Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock countcountcountrate accuracy phase -

[PATCH v2 00/15] media: staging/imx7: add i.MX7 media driver

Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case. T

[PATCH 24/24] staging: ks7010: remove KSC_OPNOTSUPP related code

This commit reviews KSC_OPNOTSUPP related code. The preprocessor KSC_OPNOTSUPP is defined by default so related wext functions are not being used. Just clean code removing all of this stuff. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan_net.c | 79 -

[PATCH 23/24] staging: ks7010: use IW_HANDLER macro in ks_wlan_handler

This commit make use of IW_HANDLER to set wext operations of the device. Using this, comments are not neccessary anymore and also NULL entries so readability is clearly increased. In order to avoid casting because of the use of a different prototype in all related functions, those which are affecte

Re: [PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

On Wed, Apr 18, 2018 at 05:09:02PM +0530, Ajay Singh wrote: > This patch series is based on top of > "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled > malloc memory properly" and its not applied yet.[1] I don't have that patch set in my queue. So please resend all outstanding pat

[PATCH 19/24] staging: ks7010: avoid blank line between definitions in hostif_data_request

This commit removes a blank line between definition in hostif_data_request function. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index cf79ba3.

[PATCH 16/24] staging: ks7010: avoid one level indentation in devio_rec_ind function

This commit changes logic to handle with the status of the device at first checking for close state to return directly instead of just do the stuff when device is open. This improves readability avoiding one level indentation. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hosti

[PATCH 12/24] staging: ks7010: fix error paths in ks7010_sdio_remove function

This commit reviews and fixes error paths in ks7010_sdio_remove driver function. It change logic to handle error directly after priv dereference to avoid one level indentation. It also removes a temporal netdev variable which wasn't being used in all of the function calls. Also if send_stop_request

[PATCH 10/24] staging: ks7010: replace create_workqueue with alloc_workqueue

This commit replaces deprecated create_workqueue call with the alloc_workqueue one which is the one to be used now for this purpose. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks70

[PATCH 18/24] staging: ks7010: fix warning aout long line in init_request

This commit fix length of the definition line of init_request function. Warning from checkpatch script for this is fixed. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hosti

[PATCH 15/24] staging: ks7010: change name and type for device_open_status field

This commit changes type for device_open_status field of ks_wlan_private structure from int to bool. This variable is only be set to 1 on ks_wlan_net_start and set to 0 on ks_wlan_net_stop. For this purpose it is not necessary at all to use an integer because a bool is enough. This also renames fie

[PATCH 20/24] staging: ks7010: remove two fields of ks_wlan_private struct

This commit removes l2_dev and l2_fd fields of ks_wlan_private struct because they are not being used at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_w

[PATCH 02/24] staging: ks7010: move ROM_FILE definition into source file

This commit moves ROM_FILE from header to source file because there is not being used outside this. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 1 + drivers/staging/ks7010/ks7010_sdio.h | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH 08/24] staging: ks7010: avoid one extra level indentation in ks_wlan_hw_rx function

This commit use an and operator in a if condition to avoid one indentation level which is not needed at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c

[PATCH 07/24] staging: ks7010: review debug and error messages in ks7010_sdio source

This commit reviews debug and error messages in code located in ks7010_sdio source file avoiding to use 'error' or 'ks7010' because this file is using netdev_* functions and has non sense to repeat information in log messages. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_s

[PATCH 14/24] staging: ks7010: assign dev_alloc_name() result to variable before check it

This commit assigns dev_alloc_name() call to 'ret' variable to check it after instead of check directly the call in the if condition. This improves a bit readability. It also add an empty line before the new assignment to separate it from the previous check statement block. Signed-off-by: Sergio P

[PATCH 03/24] staging: ks7010: move sdio specific register definitions into source file

This commit moves SDIO related register definitions from header to source file. There is no need to have those into the header because they are only being used in specific SDIO code. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 72 +

[PATCH 01/24] staging: ks7010: avoid casts in michael_mic_function calls

This commit removes casts in calls to michael_mic_function. Most of them are nosense because types match perfectly function parameters. To avoid also int casting for len parameter just pass unsigned len to function which makes sense because is only being called with unsigned int len parameters. Si

[PATCH 13/24] staging: ks7010: use u8 instead of unsigned char for firmware buffers

This commit replaces type unsigned char which is the one which is being used for firmware buffers with u8 type which is preferred. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/

[PATCH 11/24] staging: ks7010: check sdio_set_block_size return value

This commit checks sdio_set_block_size function return value. If it fails abort driver initialization. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/

[PATCH 09/24] staging: ks7010: move MODULE_DEVICE_TABLE related code

This commit moves MODULE_DEVICE_TABLE related code to the end of the file. This is not necessary at all but moving it just before its use improves readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 14 +++--- 1 file changed, 7 insertions(+), 7 delet

[PATCH 22/24] staging: ks7010: review includes of ks_hostif file

This commit reviews includes of ks_hostif.c source file. Those which are not being used at all have been removed. Driver header includes have been moved after the kernel header includes to make style consistent in different files of the driver. The need of ks_wlan.h header include is only because o

[PATCH 17/24] staging: ks7010: remove superfluous comments in ks_hostif source file

This commit removes some comments which are not necessary at all because code is clear enough to understand its intention. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_hostif.c | 39 +++--- 1 file changed, 7 insertions(+), 32 deletions(-) diff

[PATCH 21/24] staging: ks7010: removes data_buff field of ks_wlan_private struct

This commit removes data_buff array field of ks_wlan_private which is not being used at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks_wlan.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index a4d0

[PATCH 04/24] staging: ks7010: delete not used definitions in ks7010_sdio source

This commit removes two definitions inside ks7010_sdio source file because they are not being used at all. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks70

[PATCH 06/24] staging: ks7010: review comment style in ks7010_sdio source file

This commit reviews comment style used in ks7010_sdio source file in order to be coherent with the rest of the code. Most comments in this source are before definitions but only two of them have been written at the right. So, be coherent moving this two to the top of definitions. Also fix one multi

[PATCH 00/24] staging: ks7010: remaining cleanups from previous series

This patch series contains those patches which wasn't be applied from previous series. Just rebase and resend them to be applied. Sergio Paracuellos (24): staging: ks7010: avoid casts in michael_mic_function calls staging: ks7010: move ROM_FILE definition into source file staging: ks7010: m

[PATCH 05/24] staging: ks7010: add REG suffix to sdio register definitions

This commit adds REG suffix to register definitions related with SDIO in order to improve readability. Signed-off-by: Sergio Paracuellos --- drivers/staging/ks7010/ks7010_sdio.c | 96 ++-- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/sta

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

On Wed, Apr 04, 2018 at 10:45:25AM +0530, Ajay Singh wrote: > Hi Greg, > > On Wed, 28 Mar 2018 13:31:01 +0200 > Greg KH wrote: > > > On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote: > > > > > > Please let me know, in case I have to rework and resubmit this > > > patch series to make

Re: [PATCH] staging: pi433: break long lines in pi433_if.c

On Fri, Apr 06, 2018 at 10:48:17PM +0200, Simon Sandström wrote: > Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings: > "WARNING: line over 80 characters" > > Signed-off-by: Simon Sandström > --- > drivers/staging/pi433/pi433_if.c | 19 ++- > 1 file changed, 14 inser

Re: [PATCH 2/2] staging: nvec: convert to use GPIO descriptors

On Thu, Apr 19, 2018 at 1:01 PM, Marc Dietrich wrote: > Use GPIO descriptors instead of relying on the old method. > > Cc: Linus Walleij > Signed-off-by: Marc Dietrich > --- > This obsolets the ToDo reminder sent by Linus a few hours ago. Awesome :) Reviewed-by: Linus Walleij Yours, Linus W

Re: [PATCH 00/31] staging: mt7621-mmc: Next cleanups

On Wed, Apr 18, 2018 at 05:27:19PM +0200, Christian Lütke-Stetzkamp wrote: > Here are the next cleanups for the mt7621-mmc driver. Most of them > just remove some unused code, but there are also some other cleanups > and fixes. This also changes the default to always using DMA for data > transfer,

Re: [PATCH v2 06/10] staging: mt7621-mmc: Fix dereference before check in msdc_drv_pm

On Sat, Apr 07, 2018 at 10:16:21AM +0200, Christian Lütke-Stetzkamp wrote: > In the msdc_drv_pm function the variable mmc is dereferenced before > checked. Reordering fixes that. > > Reported-by: Dan Carpenter > Signed-off-by: Christian Lütke-Stetzkamp > Reviewed-by: NeilBrown > --- > drivers/

Re: [PATCH 05/21] staging: ks7010: change if-else condition assignment to use ternary operator

To be honest, it wasn't even the right thing for me to comment this patch. If you think it makes the code nicer then go ahead, you've earned that. The patchset is nice and makes a bunch of tricky improvements to the code. I reviewed it pretty carefully and couldn't find any new bugs. regards, d

  1   2   >