[PATCH] staging: mt7621-gpio: prefer unsigned int to bare unsigned

2018-04-01 Thread Sergio Paracuellos
This commit replaces some bare unsigned definitions in some function parameters in favour of 'unsigned int' which is preferred. This also fix checkpatch warnings about this. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 12 ++-- 1 file changed, 6 inse

[PATCH] staging: mt7621-gpio: prefer unsigned int to bare unsigned

2018-04-01 Thread Sergio Paracuellos
This commit replaces some bare unsigned definitions in some function parameters in favour of 'unsigned int' which is preferred. This also fix checkpatch warnings about this. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 12 ++-- 1 file changed, 6 inse

Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

2018-04-01 Thread NeilBrown
On Mon, Apr 02 2018, Sean Wang wrote: > On Mon, 2018-04-02 at 09:34 +1000, NeilBrown wrote: >> On Thu, Mar 29 2018, Chris Coffey wrote: >> >> > This fixes the following sparse warning: >> > >> > drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol >> > 'mtk_set_ethtool_ops' was not declare

Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

2018-04-01 Thread Sean Wang
On Mon, 2018-04-02 at 09:34 +1000, NeilBrown wrote: > On Thu, Mar 29 2018, Chris Coffey wrote: > > > This fixes the following sparse warning: > > > > drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol > > 'mtk_set_ethtool_ops' was not declared. Should it be static? > > > > Signed-off-by:

[PATCH] staging: mt7621-pci: Hack 2 more PCI interrupts for gnubee1

2018-04-01 Thread NeilBrown
The mt7621-pci support 3 pci devices and has 3 interrupts. Each of these need to be enabled by the same sort of hack to map hwirq number to virq number. This is a hack which will go as soon as I understand how this is supposed to work. Signed-off-by: NeilBrown --- drivers/staging/mt7621-pci/pci

Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

2018-04-01 Thread NeilBrown
On Thu, Mar 29 2018, Chris Coffey wrote: > This fixes the following sparse warning: > > drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol > 'mtk_set_ethtool_ops' was not declared. Should it be static? > > Signed-off-by: Chris Coffey Reviewed-by: NeilBrown Thanks, NeilBrown > --- >