Braces aren't required for a single line if statement.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 00b97e8e9b4f..2de4dbbcd
There is no reason for comment describing the BSSID check for loop
to be spaced so far to the right. Move it above the for loop.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_h
Some cases in the switch statement in get_ap_information() are indented
as much as five levels, which makes the code difficult to read because
of all the wrapping. Factor them out into helper methods.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 46
The code to initialize various different types of request structs
is repeated multiple times. Factor this code out into a macro
called INIT_REQUEST.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 55 +++---
1 file changed, 16 insertions(+)
Remove unnecessary parentheses highlighted by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 948d45280d18..00b9
Some of the code for reading IEs is replicated multiple times in the
switch statement for get_ap_information(). Factor that code out into
read_ie().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 48 +-
1 file changed, 22 insertions(+)
There is no failure checking on the param value which will be allocated
memory by kmalloc. Add a null pointer checking statement. Then goto error:
and return -ENOMEM error code when kmalloc is failed.
Signed-off-by: Ji-Hun Kim
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 8
1
On Thu, 15 Mar 2018 16:52:23 -0700
Long Li wrote:
> From: Long Li
>
> Unlike SCSI and FC, we don't use multiple channels for IDE. So set queue depth
> correctly for IDE.
>
> Also set the correct cmd_per_lun for all devices.
>
> Signed-off-by: Long Li
Looks correct.
Acked-by: Stephen Hemming
On 03/15, Dan Carpenter wrote:
> On Wed, Mar 14, 2018 at 03:12:18PM -0300, Rodrigo Siqueira wrote:
> > There is some improper error handling for IRQ and device register. This
> > patch adds a proper verification. The IRQ correction was extracted from
> > John Syne patches.
> >
> > Signed-off-by:
Hi,
I will fixes all of these things here and in the other patches and send a
v2.
Thanks for the review.
On 03/15, Dan Carpenter wrote:
> On Wed, Mar 14, 2018 at 03:10:18PM -0300, Rodrigo Siqueira wrote:
> > The write operation using I2C has many code duplications and four
> > different interfac
On Thu, Mar 15, 2018 at 01:56:42PM +0300, Dan Carpenter wrote:
> On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote:
> > On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote:
> > > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs
> > > with DPAA2 (Dat
From: Long Li
Unlike SCSI and FC, we don't use multiple channels for IDE. So set queue depth
correctly for IDE.
Also set the correct cmd_per_lun for all devices.
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/d
On Thu, Mar 15 2018, John Crispin wrote:
> On 15/03/18 21:12, NeilBrown wrote:
>> On Thu, Mar 15 2018, John Crispin wrote:
>>
>>> On 15/03/18 11:48, Dan Carpenter wrote:
This all seems fine. Generally the requirements for staging are that it
has a TODO, someone to work on it, and it doe
OPA driver optimizations are based on the MPI model where it is
expected to have multiple endpoints between two given nodes. To
enable this optimization for Lustre, we need to make it possible,
via an LND-specific tuneable, to create multiple endpoints and to
balance the traffic over them.
Both si
On 16 March 2018 00:31:53 GMT+05:30, Shreeya Patel
wrote:
>On Sat, 2018-03-10 at 15:57 +, Jonathan Cameron wrote:
>
>Hi Jonathan,
>
>> On Sat, 10 Mar 2018 15:50:23 +0530
>> Shreeya Patel wrote:
>>
>> >
>> > Move the adis16209 driver out of staging directory and merge to the
>> > mainline
On 15/03/18 21:12, NeilBrown wrote:
On Thu, Mar 15 2018, John Crispin wrote:
On 15/03/18 11:48, Dan Carpenter wrote:
This all seems fine. Generally the requirements for staging are that it
has a TODO, someone to work on it, and it doesn't break the build. But
some of the patches don't have
On Thu, Mar 15 2018, John Crispin wrote:
> On 15/03/18 11:48, Dan Carpenter wrote:
>> This all seems fine. Generally the requirements for staging are that it
>> has a TODO, someone to work on it, and it doesn't break the build. But
>> some of the patches don't have commit message and those are r
On Thu, Mar 15 2018, Dan Carpenter wrote:
> On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote:
>> On Thu, Mar 15 2018, Dan Carpenter wrote:
>>
>> > This all seems fine. Generally the requirements for staging are that it
>> > has a TODO, someone to work on it, and it doesn't break the bui
Resending the email because it was sent only to Greg.
Context:
In my previous patch, I had removed an extra newline
at the end of the code.
My Reply:
It was unintentional, but does it violate any coding or
other standard?
___
devel mailing list
de..
Changing return type from int to loff_t. Actual return type of the
function (vfs_llseek) is loff_t (long long). Here due to implicit
converion from long long to int, result will be implementation defined.
Signed-off-by: Rohit Kumar
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 i
de...@driverdev.osuosl.org
Bcc:
Subject: [PATCH v2] drivers:staging:android:ashmem: Changing return type from
int to loff_t
Reply-To:
Changing return type from int to loff_t. Actual return type of the
function (vfs_llseek) is loff_t (long long). Here due to implicit
converion from long long to
- enables gstreamer v4l2src lost frame detection, e.g:
0:00:08.685185668 348 0x54f520 WARN v4l2src
gstv4l2src.c:970:gst_v4l2src_create: lost frames detected: count =
141 - ts: 0:00:08.330177332
- fixes v4l2-compliance test failure:
Streaming ioctls:
test read/write: OK (Not Su
- fixes gstreamer v4l2src warning:
0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool
gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf: Driver
should never set v4l2_buffer.field to ANY
- fixes v4l2-compliance test failure:
Streaming ioctls:
test read/write: OK (Not Support
This patch fix the following checkpatch warning:
braces {} are not necessary for single statement blocks
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/driver
The following patch series includes some cleanups of useless traces as well
as some replaces in order to use preferred macros for debugging and others.
v2:
* Review deleted DPRINTK traces
* Minor checkpatch warning cleanup
Sergio Paracuellos (4):
staging: ks7010: remove useless DPRINTK traces
This commit removes some useless traces in some source files
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 58 --
drivers/staging/ks7010/ks_hostif.c | 147 +++
drivers/staging/ks7010/ks_wlan_net.c | 56 +
This commit removes custom defined DPRINTK macro and replaces all the
associated debug and other traces for preferred ones netdev_*.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 84 ++---
drivers/staging/ks7010/ks_hostif.c | 138
This commit replaces custom KS_WLAN_DEBUG which is not being used anymore
in favour of DEBUG which is the one included when debugging is enabled.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
Fixed coding style issue.
Signed-off-by: Pratik Jain
---
drivers/staging/comedi/drivers/ni_atmio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
b/drivers/staging/comedi/drivers/ni_atmio.c
index b9e9ab548c4b..4e27a2959b64 10064
> From: Dexuan Cui
> > From: Lorenzo Pieralisi
> > I need to know either what commit you are fixing (ie Fixes: tag - which
> > is preferrable) or you tell me which kernel versions we are targeting
> > for the stable backport.
> > Lorenzo
>
> Sorry. Here I was hesitant to add a "Fixes:" because t
Apologies for not aligning my reply, I just realized after looking into
the mail archive in LKML. I have aligned the replay now.
On 3/15/18, 10:56 AM, "Sridhar Pitchai" wrote:
Hi Lorenzo,
Answering the question inline.
Kindly let me know if it clarifies. I will send out another patch after we
Changes the usage of the word 'Chose' to 'Choose' in the ION
Memory Manager Kconfig.
Signed-off-by: Phillip Potter
---
--- a/drivers/staging/android/ion/Kconfig
+++ b/drivers/staging/android/ion/Kconfig
@@ -4,7 +4,7 @@ menuconfig ION
select GENERIC_ALLOCATOR
select DMA_SHARED_BUFF
Hi Lorenzo,
Answering the question inline.
Kindly let me know if it clarifies. I will send out another patch after we
agree on the clarification.
Thanks
Sridhar Pitchai
-Original Message-
From: Lorenzo Pieralisi
Sent: Thursday, March 15, 2018 5:05 AM
To: Sridhar Pitchai
Cc: Bjorn Helg
> From: Lorenzo Pieralisi
> Sent: Thursday, March 15, 2018 10:02
> On Thu, Mar 15, 2018 at 02:20:53PM +, Dexuan Cui wrote:
> > When we hot-remove the device, we first receive a PCI_EJECT message and
> > then receive a PCI_BUS_RELATIONS message with bus_rel->device_count ==
> 0.
> >
> > The fir
On Thu, 15 Mar 2018 17:24:13 +0100
Mohammed Gamal wrote:
> On Wed, 2018-03-14 at 10:22 +0100, Mohammed Gamal wrote:
> > On Tue, 2018-03-13 at 12:35 -0700, Stephen Hemminger wrote:
> > > On Tue, 13 Mar 2018 20:06:50 +0100
> > > Mohammed Gamal wrote:
> > >
> > > > Dring high network traffic c
On Thu, Mar 15, 2018 at 11:00:40PM +0530, Pratik Jain wrote:
> Fixed coding style issue.
>
> Signed-off-by: Pratik Jain
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
> b/
Fixed coding style issue.
Signed-off-by: Pratik Jain
---
drivers/staging/comedi/drivers/ni_atmio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
b/drivers/staging/comedi/drivers/ni_atmio.c
index b9e9ab548c4b..e82fbe987dd8 1006
From: Palle Christensen
For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits
are necessary to address the correct page.
Signed-off-by: Palle Christensen
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/stagin
On Thu, Mar 15, 2018 at 02:20:53PM +, Dexuan Cui wrote:
> When we hot-remove the device, we first receive a PCI_EJECT message and
> then receive a PCI_BUS_RELATIONS message with bus_rel->device_count == 0.
>
> The first message is offloaded to hv_eject_device_work(), and the second
> is offloa
On Wed, 2018-03-14 at 10:22 +0100, Mohammed Gamal wrote:
> On Tue, 2018-03-13 at 12:35 -0700, Stephen Hemminger wrote:
> > On Tue, 13 Mar 2018 20:06:50 +0100
> > Mohammed Gamal wrote:
> >
> > > Dring high network traffic changes to network interface
> > > parameters
> > > such as number of channe
On Thu, Mar 15, 2018 at 12:44:37AM +0100, Andrew Lunn wrote:
> On Wed, Mar 14, 2018 at 10:55:52AM -0500, Razvan Stefanescu wrote:
> > This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs
> > with DPAA2 (DataPath Acceleration Architecture v2). The driver manages
> > switch obje
If there is a pending work, we just need to add the new dr into
the dr_list.
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c | 15 +++
Since we serialize the present/eject work items now, we don't need the
semaphore any more.
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c |
When we're in the function, hpdev->state must be hv_pcichild_ejecting:
see hv_pci_eject_device().
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Jack Morgenstein
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hype
No functional change.
Fixes: bdd74440d9e8 ("PCI: hv: Add explicit barriers to config space access")
Signed-off-by: Dexuan Cui
Acked-by: Haiyang Zhang
Cc: Vitaly Kuznetsov
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
drivers/pci/host/pci-hyperv.c | 2 +-
1 file changed, 1 insertion(+), 1 de
The 4 patches should go in v4.16.
There is no code change since v3:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1628496.html
I just split the original 6 patches to 2 series, and this is series 2.
I fixed the order of Signed-off-by/Tested-by/Cc, etc., and fixed the
other format i
1. With the patch "x86/vector/msi: Switch to global reservation mode",
the recent v4.15 and newer kernels always hang for 1-vCPU Hyper-V VM
with SR-IOV. This is because when we reach hv_compose_msi_msg() by
request_irq() -> request_threaded_irq() ->__setup_irq()->irq_startup()
-> __irq_startup() ->
When we hot-remove the device, we first receive a PCI_EJECT message and
then receive a PCI_BUS_RELATIONS message with bus_rel->device_count == 0.
The first message is offloaded to hv_eject_device_work(), and the second
is offloaded to pci_devices_present_work(). Both the paths can be running
list_
The 2 patches should go in v4.16.
They should go in old stable kernels too, especially this one should go in
v4.15:
PCI: hv: Fix 2 hang issues in hv_compose_msi_msg()
Otherwise, a UP v4.15 VM can 100% hang when we pass through a VF
to the VM that runs on Hyper-V.
There is no code change since v
On Wed, Mar 14, 2018 at 03:12:18PM -0300, Rodrigo Siqueira wrote:
> There is some improper error handling for IRQ and device register. This
> patch adds a proper verification. The IRQ correction was extracted from
> John Syne patches.
>
> Signed-off-by: Rodrigo Siqueira
> Signed-off-by: John Syn
On Wed, Mar 14, 2018 at 03:10:18PM -0300, Rodrigo Siqueira wrote:
> The write operation using I2C has many code duplications and four
> different interfaces per data size. This patch introduces a single
> function that centralizes the main tasks.
>
> The central function inserted by this patch can
On Thu, Mar 15, 2018 at 12:03:07AM +, Sridhar Pitchai wrote:
> Whenever PCI bus is added, HyperV guarantees the BUS id is unique. Even
"Whenever a PCI bus is added"
> with that when a first device is added to the bus, it overrides bus domain
> ID with the device serial number. Sometime this c
On 15/03/18 11:48, Dan Carpenter wrote:
This all seems fine. Generally the requirements for staging are that it
has a TODO, someone to work on it, and it doesn't break the build. But
some of the patches don't have commit message and those are required and
some of the commit messages are just
On Thu, Mar 15, 2018 at 12:07:26PM +0100, John Crispin wrote:
> None of the stuff posted is anywhere near ready to be
> upstreamed.
Yeah. This is staging so we accept any quality...
The rest of the information is very useful. Thanks!
regards,
dan carpenter
___
On Thu, Mar 15, 2018 at 10:04:33PM +1100, NeilBrown wrote:
> On Thu, Mar 15 2018, Dan Carpenter wrote:
>
> > This all seems fine. Generally the requirements for staging are that it
> > has a TODO, someone to work on it, and it doesn't break the build. But
> > some of the patches don't have commi
On Thu, Mar 15 2018, Dan Carpenter wrote:
> This all seems fine. Generally the requirements for staging are that it
> has a TODO, someone to work on it, and it doesn't break the build. But
> some of the patches don't have commit message and those are required and
> some of the commit messages ar
This all seems fine. Generally the requirements for staging are that it
has a TODO, someone to work on it, and it doesn't break the build. But
some of the patches don't have commit message and those are required and
some of the commit messages are just the changes you have made not don't
describe
These patches need better changelogs. Some of them don't have a
changelog at all. Like just say this what kind of device this is or
something?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
From: Frank Mori Hess
Ack ai fifo error interrupts in interrupt handler to clear interrupt
after fifo overflow. It should prevent lock-ups after the ai fifo
overflows.
Cc: # v4.2+
Signed-off-by: Frank Mori Hess
Signed-off-by: Ian Abbott
---
I have not tested this patch on hardware. -- Frank
On Thu, Mar 15, 2018 at 3:51 AM, Deepa Dinamani wrote:
> On Wed, Mar 14, 2018 at 1:52 PM, Arnd Bergmann wrote:
>> On Wed, Mar 14, 2018 at 4:50 AM, Deepa Dinamani
>> wrote:
>>> The file arch/arm64/kernel/process.c needs asm/compat.h also to be
>>> included directly since this is included conditi
60 matches
Mail list logo
