Please check all these again, right? I've glanced at this and it seems
wrong, but I'm too stupid to sure immediately and too lazy to be
thourough.
regards,
dan caprenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote:
> Use existing macro GENMASK to get the bitmask value. Moved the code to
> get the bitmask value outside the loop, as its only required one time.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_spi.c | 3 +--
> 1 fil
On Wed, Feb 21, 2018 at 09:42:09PM +0530, Ajay Singh wrote:
> Modified wilc_spi_read_int() by removing unnecessary use of "happened"
> variable.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/wilc_spi.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --g
Another ancient patch
On Sun, Oct 02 2016, James Simmons wrote:
> From: John L. Hammond
>
> During development a new api, cl_object_obd_info_get()
> and cl_object_data_version() which then were later
> replaced by a better solution CIT_DATA_VERSION. For
> the case of the upstream client th
This commit adds driver support for the pre-release Xilinx M2M Video
Scaler IP. There are three parts to this driver :
- The Hardware/IP layer that reads and writes register of the IP
contained in the scaler_hw_xm2m.c
- The set of ioctls that applications would need to know contained
in io
This patch series has three commits :
- Driver support for the Xilinx M2M Video Scaler IP
- TODO document
- DT binding doc
Changes in HW register map is expected as the IP undergoes changes.
This is a first attempt at the driver as an early prototype.
This is a M2M Video Scaler IP that uses po
This commit adds the binding doc for the DT that the driver expects.
Driver has been tested against Zynq US+ board.
Signed-off-by: Rohit Athavale
---
.../devicetree/bindings/xm2mvscaler.txt| 25 ++
1 file changed, 25 insertions(+)
create mode 100644
drivers/stag
This commit highlights the key functionalities that will be
improved upon in a future patch set.
Signed-off-by: Rohit Athavale
---
drivers/staging/xm2mvscale/TODO | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 drivers/staging/xm2mvscale/TODO
diff --git a/drivers/s
Hi Dan,
Thanks for taking a look. I have added a tweak to add to the patch series.
Will CC linux-media on the V2 and add a note about this in the cover letter.
Best Regards,
Rohit
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Wednesday, February
There's no need to print messages each time we alloc and free. Remove them.
Signed-off-by: Laura Abbott
---
v2: No changes
---
tools/testing/selftests/android/ion/ionutils.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/tools/testing/selftests/android/ion/ionutils.c
b/tools/testing/
Ion is designed to be a framework used by other clients who perform
operations on the buffer. Use the DRM vgem client as a simple consumer.
In conjunction with the dma-buf sync ioctls, this tests the full attach/map
path for the system heap.
Reviewed-by: Daniel Vetter
Signed-off-by: Laura Abbott
Hi,
This is v2 of the series to add a unit test to Ion with VGEM. From v1:
Ion hasn't had much in the way of unit tests and fixing that is
something that needs to happen before it can move out of staging. The
difficult part of testing parts of Ion is that it relies on having a
kernel driver to ac
This patch fixes the checkpatch.pl warning:
drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition
argument 'struct device *' should also have an identifier name...
This commit adds arguments names to the signature declared in the
ade7854_state struct. For consistency reason, It al
Hi Ajay,
Sure, I will take a look.
Thank you,
Claudiu
On 21.02.2018 18:25, Ajay Singh wrote:
> Hi Claudiu,
>
> On Mon, 19 Feb 2018 15:33:09 +0200
> Claudiu Beznea wrote:
>
>> Since you re-factor this, as I suggested in patch:
>> "[PATCH 6/6] staging: wilc1000: fix line over 80 chars in
>> wil
Hi Claudiu,
On Mon, 19 Feb 2018 15:33:09 +0200
Claudiu Beznea wrote:
> Since you re-factor this, as I suggested in patch:
> "[PATCH 6/6] staging: wilc1000: fix line over 80 chars in
> wilc_spi_clear_int_ext()" form your previous series:
> "fix line over 80 char & coding style in wilc_spi.c",
> f
Use GENMASK macro in sdio_clear_int_ext function to get the required
bitmask value. Simplified the logic by making use of GENMASK
macro.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_sdio.c | 74 +++-
1 file changed, 31 insertions(+), 43 deletions(-)
Use available macro GENMASK to get the bitmask value of specific value.
Simplified the logic by adding expected_irqs & unexpected_irqs to check
the interrupt bits.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 46 +++--
1 file changed, 18 ins
Use existing macro GENMASK to get the bitmask value. Moved the code to
get the bitmask value outside the loop, as its only required one time.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wi
Modified wilc_spi_read_int() by removing unnecessary use of "happened"
variable.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_spi.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c
b/drivers/staging/wilc1000/wilc_spi.
This patch series contains changes to refactor functions by making use of
GENMASK macro and also removed unnecessary variable from
wilc_spi_read_int().
Ajay Singh (4):
staging: wilc1000: remove use of 'happened' variable in
wilc_spi_read_int()
staging: wilc1000: modified wilc_spi_read_int(
On Wed, Feb 21, 2018 at 05:12:36AM -0800, Quytelda Kahja wrote:
> Since the testing for host endianness and in-driver conversion were
> removed in 77e8a50149a2, the gdm_endian struct contains only one member,
> and can therefore be simplified to a single u8 variable.
>
> Signed-off-by: Quytelda Ka
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --
Since the testing for host endianness and in-driver conversion were
removed in 77e8a50149a2, the gdm_endian struct contains only one member,
and can therefore be simplified to a single u8 variable.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_endian.c | 24 --
On Wed, Feb 21, 2018 at 03:15:54AM -0800, Quytelda Kahja wrote:
> That could be the case, though I'm not sure where to find any specs.
> Though looking through the history of this driver, it seems that some
> of the variable names have been slowly changing from camel case to
> snake case.
>
Actua
That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.
Thanks,
Quytelda Kahja
On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter wrote:
>
On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> Changed a variable name from camel to snake case to fix a coding style
> issue.
>
> Signed-off-by: Quytelda Kahja
> ---
> drivers/staging/gdm724x/hci_packet.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
This patch is fine.
Acked-by: Dan Carpenter
But I have a some comments for later.
On Wed, Feb 21, 2018 at 02:20:17AM -0800, Quytelda Kahja wrote:
> @@ -509,8 +511,9 @@ static struct net_device_stats *gdm_lte_stats(struct
> net_device *dev)
>
> static int gdm_lte_event_send(struct net_device
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x/hci_packet.h
in
Fix lines with a trailing open parenthesis, which is a coding style issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/gdm_lte.c | 44 +++
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/driver
This feels like a media driver. Can you CC linux-me...@vger.kernel.org?
Someone needs to review the interface to see if it makes sense.
regard,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/ma
30 matches
Mail list logo
