[PATCH] staging: lustre: lnet: return of an error code should be negative

2018-01-27 Thread Sumit Pundir
Return value of error codes should typically be negative. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir --- drivers/staging/lustre/lnet/selftest/framework.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drive

[PATCH] staging: lustre: llite: replace variable length array

2018-01-27 Thread Sven Dziadek
The functionality of the removed variable length array is already implemented by the function xattr_full_name in fs/xattr.c This fixes the sparse warning: warning: Variable length array is used. Signed-off-by: Sven Dziadek --- drivers/staging/lustre/lustre/llite/xattr.c | 12 1 fil

Re: [staging:staging-next 446/587] drivers/staging/lustre/lnet/lnet/lib-socket.c:212:16-19: ERROR: reference preceded by free on line 198 (fwd)

2018-01-27 Thread Dan Carpenter
On Sat, Jan 27, 2018 at 03:09:11PM +0100, Julia Lawall wrote: > > > On Sat, 27 Jan 2018, Dan Carpenter wrote: > > > On Sat, Jan 27, 2018 at 02:37:49PM +0100, Julia Lawall wrote: > > > Please check whether line 212 is reachable from line 198. > > > > > > > No. It's not. > > > > > d7e09d039 drive

Re: [staging:staging-next 446/587] drivers/staging/lustre/lnet/lnet/lib-socket.c:212:16-19: ERROR: reference preceded by free on line 198 (fwd)

2018-01-27 Thread Julia Lawall
On Sat, 27 Jan 2018, Dan Carpenter wrote: > On Sat, Jan 27, 2018 at 02:37:49PM +0100, Julia Lawall wrote: > > Please check whether line 212 is reachable from line 198. > > > > No. It's not. > > > d7e09d039 drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c Peng Tao > > 2013-05-

Re: [staging:staging-next 446/587] drivers/staging/lustre/lnet/lnet/lib-socket.c:212:16-19: ERROR: reference preceded by free on line 198 (fwd)

2018-01-27 Thread Dan Carpenter
On Sat, Jan 27, 2018 at 02:37:49PM +0100, Julia Lawall wrote: > Please check whether line 212 is reachable from line 198. > No. It's not. > d7e09d039 drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c Peng Tao > 2013-05-02 192 nfound = ifc.ifc_len / sizeof(*ifr

[staging:staging-next 446/587] drivers/staging/lustre/lnet/lnet/lib-socket.c:212:16-19: ERROR: reference preceded by free on line 198 (fwd)

2018-01-27 Thread Julia Lawall
Please check whether line 212 is reachable from line 198. julia -- Forwarded message -- Date: Sat, 27 Jan 2018 16:00:47 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [staging:staging-next 446/587] drivers/staging/lustre/lnet/lnet/lib-socket.c:212:

[PATCH 8/8] staging: pi433: fix CamelCase for DIONumber

2018-01-27 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 42

[PATCH 6/8] staging: pi433: fix CamelCase for newValue

2018-01-27 Thread Valentin Vidic
Local variable storing the new value for bandwidth register so replace with bandwidth. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH 7/8] staging: pi433: fix CamelCase for regValue

2018-01-27 Thread Valentin Vidic
Local variable storing the new value for dio register so replace with dio_value. Update regaddr to dio_addr to match. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 24 1 file changed, 12 insertio

[PATCH 4/8] staging: pi433: fix CamelCase for Ohm identifiers

2018-01-27 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/stagin

[PATCH 5/8] staging: pi433: fix CamelCase for currentValue

2018-01-27 Thread Valentin Vidic
Local variable storing the value for modulation register so replace with modulation_reg. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/stagin

[PATCH 3/8] staging: pi433: fix CamelCase for antennaImpedance

2018-01-27 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH 1/8] staging: pi433: fix CamelCase for syncValues

2018-01-27 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 18 +- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi4

[PATCH 2/8] staging: pi433: fix CamelCase for powerLevel

2018-01-27 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c inde