[PATCH-next] hal_com_phycfg: Remove unneeded semicolons

Trivial fix removes unneeded semicolons after switch blocks. This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/

[PATCH v2] staging: fsl-mc: Add SPDX license identifiers

The fsl-mc bus and dpio driver files use a combination of GPL-2.0 and GPL-2.0+ OR BSD-3-Clause licenses. Add SPDX tags and delete the full license text, keeping the existing license for each file. Add GPL-2.0 for Kconfig / Makefile, where not present. Signed-off-by: Bogdan Purcareata Reviewed-by:

Re: [PATCH] staging: lustre: lnet: avoid uninitialized return value

> gcc warns that the latest workqueue change leads to returning an > uninitialized variable: > > drivers/staging/lustre/lnet/selftest/module.c: In function > 'lnet_selftest_init': > drivers/staging/lustre/lnet/selftest/module.c:98:10: error: 'rc' may be used > uninitialized in this function [-W

Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

On Wed, Jan 17, 2018 at 03:56:19PM +, Bogdan Purcareata wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, January 16, 2018 5:13 PM > > To: Bogdan Purcareata > > Cc: Laurentiu Tudor ; Ruxandra Ioana Ciocoi > > Radulescu > > ; de...@d

Re: [PATCH v2 0/4] Remove checkpatch warnings

On Wed, Jan 17, 2018 at 09:06:50PM +0530, Shreeya Patel wrote: > On Wed, 2018-01-17 at 14:58 +0100, Greg KH wrote: > > On Wed, Jan 17, 2018 at 12:24:50AM +0530, Shreeya Patel wrote: > > > > > > This patchset removes some warnings generated by checkpatch > > > for cleanup of the rtl8723bs driver. A

RE: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, January 16, 2018 5:13 PM > To: Bogdan Purcareata > Cc: Laurentiu Tudor ; Ruxandra Ioana Ciocoi Radulescu > ; de...@driverdev.osuosl.org; r...@kernel.org; > stuyo...@gmail.com; a...@arndb.de; marc.zyng

Re: [PATCH v2 0/4] Remove checkpatch warnings

On Wed, 2018-01-17 at 14:58 +0100, Greg KH wrote: > On Wed, Jan 17, 2018 at 12:24:50AM +0530, Shreeya Patel wrote: > > > > This patchset removes some warnings generated by checkpatch > > for cleanup of the rtl8723bs driver. Also some additional > > cleanups are introduced in the *[1/4] and *[3/4]

[PATCH v3 5/8] staging: greybus: audio_codec.c: Logical continuations should be on the previous line

Fix the following error found by checkpatch.pl: CHECK: Logical continuations should be on the previous line Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers

[PATCH v3 7/8] staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t'

Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/sta

[PATCH v3 1/8] staging: greybus: authentication.c: Fix alignment should match open parenthesis

Fix the following error found by checkpatch.pl: CHECK: Alignment should match open parenthesis +static int cap_ioctl(struct gb_cap *cap, unsigned int cmd, +void __user *buf) Signed-off-by: Kamal Heib --- drivers/staging/greybus/authentication.c | 2 +- 1 file changed, 1 i

[PATCH v3 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c ind

[PATCH v3 6/8] staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t'

Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/

[PATCH v3 0/8] staging: greybus: Fix few issues reported by checkpatch

This patch set include multiple fixes for the issues reported by checkpatch.pl Cc: greybus-...@lists.linaro.org Cc: Viresh Kumar Cc: Vaibhav Agarwal Cc: Greg Kroah-Hartman Changes from v2: - [2/8] Restore the original alignment. Changes from v1: - Rebase the changes on top staging-next. - Add

[PATCH v3 4/8] staging: greybus: audio_codec.c: Space required around ':'

Space is required when using the question mark operator around ':' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 98dd

[PATCH v3 3/8] staging: greybus: audio_codec.c: Cleanup blank lines

Remove the blank lines. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index c4b6584eb1be..98ddb7e5b78b 100644 --- a/drivers/staging/greybus/a

[PATCH v3 8/8] staging: greybus: audio_codec.h Fix alignment should match open parenthesis

Fix "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index fd7b893

Re: [PATCH v2 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

On Wed, Jan 17, 2018 at 3:42 PM, Dan Carpenter wrote: > On Wed, Jan 17, 2018 at 03:29:33PM +0200, Kamal Heib wrote: >> Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. >> >> Signed-off-by: Kamal Heib >> --- >> drivers/staging/greybus/audio_codec.c | 14 +++--- >> 1

Re: [PATCH] staging: most: replace function name to __func__

On Tue, Jan 16, 2018 at 04:49:01PM +, Sidong Yang wrote: > Fix checkpatch.pl warning message about logging code. Previous code > contains hard coded function name. Fix this code by using __func__ > macro. > > Signed-off-by: Sidong Yang > --- > drivers/staging/most/dim2/dim2.c | 2 +- > dr

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

On Wed, Jan 17, 2018 at 12:36:19AM +, Dilger, Andreas wrote: > > > On Jan 16, 2018, at 09:56, Greg Kroah-Hartman > > wrote: > > > > On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: > >> In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 > > > > Please use the do

Re: [PATCH v2 0/4] Remove checkpatch warnings

On Wed, Jan 17, 2018 at 12:24:50AM +0530, Shreeya Patel wrote: > This patchset removes some warnings generated by checkpatch > for cleanup of the rtl8723bs driver. Also some additional > cleanups are introduced in the *[1/4] and *[3/4] patches > to make the code according to the kernel coding style

Re: [PATCH v2 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

On Wed, Jan 17, 2018 at 03:29:33PM +0200, Kamal Heib wrote: > Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. > > Signed-off-by: Kamal Heib > --- > drivers/staging/greybus/audio_codec.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git

[PATCH v2 6/8] staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t'

Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/

[PATCH v2 7/8] staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t'

Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/sta

[PATCH v2 4/8] staging: greybus: audio_codec.c: Space required around ':'

Space is required when using the question mark operator around ':' Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 3f90

[PATCH v2 1/8] staging: greybus: authentication.c: Fix alignment should match open parenthesis

Fix the following error found by checkpatch.pl: CHECK: Alignment should match open parenthesis +static int cap_ioctl(struct gb_cap *cap, unsigned int cmd, +void __user *buf) Signed-off-by: Kamal Heib --- drivers/staging/greybus/authentication.c | 2 +- 1 file changed, 1 i

[PATCH v2 8/8] staging: greybus: audio_codec.h Fix alignment should match open parenthesis

Fix "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index fd7b893

[PATCH v2 5/8] staging: greybus: audio_codec.c: Logical continuations should be on the previous line

Fix the following error found by checkpatch.pl: CHECK: Logical continuations should be on the previous line Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers

[PATCH v2 3/8] staging: greybus: audio_codec.c: Cleanup blank lines

Remove the blank lines. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 0dae31f39a2b..3f9088607ea7 100644 --- a/drivers/staging/greybus/a

[PATCH v2 2/8] staging: greybus: audio_codec.c: Fix alignment should match open parenthesis

Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib --- drivers/staging/greybus/audio_codec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_co

[PATCH v2 0/8] staging: greybus: Fix few issues reported by checkpatch

This patch set include multiple fixes for the issues reported by checkpatch.pl Cc: greybus-...@lists.linaro.org Cc: Viresh Kumar Cc: Vaibhav Agarwal Cc: Greg Kroah-Hartman Changes from v1: - Rebase the changes on top staging-next. - Add greybus-dev mailing list. Kamal Heib (8): staging: gre

[PATCH][next] staging: fsl-mc: make function its_fsl_mc_msi_init static

From: Colin Ian King The function its_fsl_mc_msi_init is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'its_fsl_mc_msi_init' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/staging/fsl-mc/bus/i

Re: [PATCH v2 3/4] Staging: rtl8723bs: Change condition to assignment

On Wed, Jan 17, 2018 at 12:33:23AM +0530, Shreeya Patel wrote: > Change the conditional operator to assignment as it is > not a conditional statement. > > Signed-off-by: Shreeya Patel > --- > > Changes in v2 > -Rebase and resend. > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- > 1 file