From: Randy Dunlap
Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.
Signed-off-by: Randy Dunlap
Cc: David Kershner
Cc: sparmaintai...@unisys.com (Unisys i
On Sun, 2018-01-14 at 20:10 +, Al Viro wrote:
> On Sun, Jan 14, 2018 at 11:47:11PM +0530, Naveen Panwar wrote:
> > Removed '(' from the end of line, coding style issue.
>
> The one and only reason for warnings is that they point to
> places more likely to be dodgy. There is no inherent value
On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote:
> +static int hv_cpu_die(unsigned int cpu)
> +{
> + struct hv_reenlightenment_control re_ctrl;
> + int i;
> + static DEFINE_SPINLOCK(lock);
> +
> + if (hv_reenlightenment_cb == NULL)
> + return 0;
> +
> + /* Make sure the
On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote:
> +void hyperv_reenlightenment_intr(struct pt_regs *regs)
Lacks __visible and __irq_entry annotations.
Thanks,
tglx
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpro
On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote:
> This is going to be used from KVM code where we need to get both
> TSC and TSC page value.
>
> When Hyper-V code is compiled out just return rdtsc(), this will allow us
> to avoid ugly ifdefs in non-Hyper-V code.
That's not what the patch implements
On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote:
> In hyperv_init() we presume we always have access to VP index and hypercall
> MSRs while according to the specification we should check if we're allowed
> to access the corresponding MSRs before accessing them.
>
> Signed-off-by: Vitaly Kuznetsov
On Sun, Jan 14, 2018 at 11:47:11PM +0530, Naveen Panwar wrote:
> Removed '(' from the end of line, coding style issue.
The one and only reason for warnings is that they point to
places more likely to be dodgy. There is no inherent value
in having e.g. checkpatch.pl STFU, all wanking about uniform
On Sun, 2018-01-14 at 23:47 +0530, Naveen Panwar wrote:
> Removed '(' from the end of line, coding style issue.
[]
> diff --git a/drivers/staging/netlogic/platform_net.c
> b/drivers/staging/netlogic/platform_net.c
[]
> @@ -107,8 +107,8 @@ static struct platform_device *gmac_controller2_init(void
Hi Stefan,
I'm really glad to review my commit!
I think that your suggestion that changes subject is good.
> i'm okay with the changes, but the subject is too general. We get fixes for
> checkpach warning nearly once a week. Suggestion:
>
> staging: vchiq_version: Use tabs for identation
>
>
Hi Sidong,
> Sidong Yang hat am 14. Januar 2018 um 09:11 geschrieben:
>
>
> Replace spaces to tabs for indents in beginning of statements.
>
> Signed-off-by: Sidong Yang
i'm okay with the changes, but the subject is too general. We get fixes for
checkpach warning nearly once a week. Suggest
Replace spaces to tabs for indents in beginning of statements.
Signed-off-by: Sidong Yang
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_vers
11 matches
Mail list logo
