Hi folks,
With the enormous help of people in the to and CCed lists I've gotten
the ccree driver to a point I believe it is ready to graduate out of
the staging tree:
- The code base has been reduced by something by 30% and is *much*
more readable and manageable.
- The very few checkpatch warnin
> Christoph,
>
> > Ok. If the stable maintainers are ok with your small fix I'm not
> > going to complain too loudly. But I'm always worried about stable
> > trees divering too much from mainline.
>
> The seemingly innocuous transition from SG_GAPS to virt boundary has
> caused several data cor
On Tue, 2018-01-09 at 20:28 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 09, 2018 at 11:21:37AM -0800, Joe Perches wrote:
> > On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote:
> > > > Fixes checkpatch warnings:
> > >
When host rescinds the device, the UIO driver will clear the interrupt
state and notify application. The read (or write) on the interrupt FD
will then fail with -EIO. This is simpler than adding lots extra uevent
stuff inside UIO.
Signed-off-by: Stephen Hemminger
---
Documentation/driver-api/uio
Describe the regions present with uio_hv_generic in documentation for
driver API.
Signed-off-by: Stephen Hemminger
---
Documentation/driver-api/uio-howto.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/driver-api/uio-howto.rst
b/Documentation/driver-api/uio-howto.rst
In order for userspace application to signal host, it needs the
host to support the monitor page property. Check for the flag
and fail if this is not supported.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/ui
Use sysfs to allow supporting sub-channels. The userspace application
makes request to host to create sub-channels and the UIO kernel
driver populates the sysfs per-channel directory with a binary
attribute file that can be used to read/write ring.
Signed-off-by: Stephen Hemminger
---
Documentat
Map in receive and send buffers for networking in UIO device.
These buffers are special and need to be setup by kernel
API's; userspace can not do it.
Signed-off-by: Stephen Hemminger
---
Documentation/driver-api/uio-howto.rst | 2 +
drivers/uio/uio_hv_generic.c | 71 +
These patches extend uio_hv_generic driver to make it usable
for DPDK networking. The original version did not enough
functionality to support userspace network drivers. Needed support
of send/receive buffers and sub channels.
Patches against current char-misc-next
v3
- rebase on current char-m
The vmbus sysfs file names changed in
commit f6b2db084b65 ("vmbus: make sysfs names consistent with PCI")
and the uio documenatation does not match the current names.
Signed-off-by: Stephen Hemminger
---
Documentation/driver-api/uio-howto.rst | 15 ---
1 file changed, 8 insertions(+
On Tue, Jan 09, 2018 at 09:04:50PM +0100, Valentin Vidic wrote:
> On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote:
> > > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc)
> > > {
> > > switch (dagc) {
> > > - case normalMode: return rf69_write_reg(spi,
> > >
Am 09.01.2018 um 21:04 schrieb Valentin Vidic:
> On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote:
>>> int rf69_set_dagc(struct spi_device *spi, enum dagc dagc)
>>> {
>>> switch (dagc) {
>>> - case normalMode: return rf69_write_reg(spi,
>>> REG_TESTDAGC, DAGC_N
On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote:
> > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc)
> > {
> > switch (dagc) {
> > - case normalMode: return rf69_write_reg(spi,
> > REG_TESTDAGC, DAGC_NORMAL);
> > - case improve:re
On Tue, Jan 09, 2018 at 07:45:33PM +, Harsh Shandilya wrote:
> On Tue 9 Jan, 2018, 10:32 PM Greg Kroah-Hartman,
> wrote:
>
> > On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote:
> > > From: Harsh Shandilya
> > >
> > > Several methods in the driver were hardcoding
> > > the func
On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote:
> > Fixes checkpatch warnings:
> > CHECK: Unnecessary parentheses around 'mantisse != mantisse16'
> > CHECK: Unnecessary parentheses around 'mantisse != mantisse20'
> >
On Tue, Jan 09, 2018 at 11:21:37AM -0800, Joe Perches wrote:
> On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote:
> > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote:
> > > Fixes checkpatch warnings:
> > > CHECK: Unnecessary parentheses around 'mantisse != mantisse16'
> >
On Tue, Jan 09, 2018 at 11:14:11AM -0800, Stephen Hemminger wrote:
> On Tue, 9 Jan 2018 19:58:34 +0100
> Greg KH wrote:
>
> > On Tue, Jan 09, 2018 at 10:53:10AM -0800, Stephen Hemminger wrote:
> > > On Tue, 9 Jan 2018 19:42:40 +0100
> > > Greg KH wrote:
> > >
> > > > On Thu, Jan 04, 2018 at 0
On Tue, 9 Jan 2018 19:58:34 +0100
Greg KH wrote:
> On Tue, Jan 09, 2018 at 10:53:10AM -0800, Stephen Hemminger wrote:
> > On Tue, 9 Jan 2018 19:42:40 +0100
> > Greg KH wrote:
> >
> > > On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen Hemminger wrote:
> > > > Allow setting size of ring buff
On Tue, Jan 09, 2018 at 10:53:10AM -0800, Stephen Hemminger wrote:
> On Tue, 9 Jan 2018 19:42:40 +0100
> Greg KH wrote:
>
> > On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen Hemminger wrote:
> > > Allow setting size of ring buffer for host communication via
> > > module parameter.
> > >
> > >
On Tue, 9 Jan 2018 19:42:40 +0100
Greg KH wrote:
> On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen Hemminger wrote:
> > Allow setting size of ring buffer for host communication via
> > module parameter.
> >
> > Signed-off-by: Stephen Hemminger
> > ---
> > drivers/uio/uio_hv_generic.c | 25 ++
On Tue, Jan 09, 2018 at 10:29:03AM -0800, Stephen Hemminger wrote:
> These patches improve vmbus sysfs support for better management and
> make the UIO hyperv driver usable. The original version did not enough
> functionality to support userspace network drivers. Needed support
> of send/receive bu
On Thu, Jan 04, 2018 at 02:13:32PM -0800, Stephen Hemminger wrote:
> In order for userspace application to signal host, it needs the
> host to support the monitor page property. Check for the flag
> and fail if this is not supported.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/uio/uio_h
On Thu, Jan 04, 2018 at 02:13:30PM -0800, Stephen Hemminger wrote:
> Map in receive and send buffers for networking in UIO device.
> These buffers are special and need to be setup by kernel
> API's.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/uio/uio_hv_generic.c | 114
> ++
On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen Hemminger wrote:
> Allow setting size of ring buffer for host communication via
> module parameter.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/uio/uio_hv_generic.c | 25 +
> 1 file changed, 21 insertions(+), 4 de
The UIO IRQ handler doesn't need to be called from a tasklet.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
index 0d945eb6efbb..18735731206e 100644
Allow setting size of ring buffer for host communication via
module parameter.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generi
When host rescinds the device, the UIO driver will clear the interrupt
state and notify application. The read (or write) on the interrupt FD
will then fail with -EIO. This is simpler than adding lots extra uevent
stuff inside UIO.
Signed-off-by: Stephen Hemminger
---
Documentation/driver-api/uio
In order for userspace application to signal host, it needs the
host to support the monitor page property. Check for the flag
and fail if this is not supported.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 20 ++--
1 file changed, 14 insertions(+), 6 deleti
Use sysfs to allow supporting sub-channels. The userspace application
makes request to host to create sub-channels and the UIO kernel
driver populates the sysfs per-channel directory with a binary
attribute file that can be used to read/write ring.
Signed-off-by: Stephen Hemminger
---
Documentat
The generic UIO mmap should work for us.
Signed-off-by: Stephen Hemminger
---
drivers/uio/uio_hv_generic.c | 33 +++--
1 file changed, 7 insertions(+), 26 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
index 4fea9a578990..8d5f52
Map in receive and send buffers for networking in UIO device.
These buffers are special and need to be setup by kernel
API's.
Signed-off-by: Stephen Hemminger
---
Documentation/driver-api/uio-howto.rst | 2 +
drivers/uio/uio_hv_generic.c | 114 +++--
2 fil
Fixes to vmbus ABI document including:
- make it clear that relid is numeric value in sub directory
- clarify interrupt mask description
- spelling fixes
- document regions
Signed-off-by: Stephen Hemminger
---
Documentation/ABI/stable/sysfs-bus-vmbus | 39
The suggested method for configuration does not work with
current kernels. Paths and ids changed.
Signed-off-by: Stephen Hemminger
---
Documentation/driver-api/uio-howto.rst | 20 +---
drivers/uio/uio_hv_generic.c | 8 +---
2 files changed, 18 insertions(+), 10 del
Useful to identify which network queue is associated with
which vmbus channel.
Signed-off-by: Stephen Hemminger
---
Documentation/ABI/stable/sysfs-bus-vmbus | 14 ++
drivers/hv/vmbus_drv.c | 17 +
2 files changed, 31 insertions(+)
diff --git a/Docum
These channel attribute data structures are only used by
vmbus_drv sysfs routines.
Signed-off-by: Stephen Hemminger
---
drivers/hv/vmbus_drv.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 610223f0e945
These patches improve vmbus sysfs support for better management and
make the UIO hyperv driver usable. The original version did not enough
functionality to support userspace network drivers. Needed support
of send/receive buffers and sub channels.
Patches against current char-misc-next
v2
- rev
From: Colin Ian King
Casting a value returned by memory an allocation function is
not required and can be removed. Also add in a newline after before
the first statement. Code clean up as suggested by coccinelle.
Signed-off-by: Colin Ian King
---
drivers/staging/ncpfs/inode.c | 3 ++-
1 file c
On Thu, Jan 04, 2018 at 02:13:26PM -0800, Stephen Hemminger wrote:
> Useful to identify which network queue is associated with
> which vmbus channel.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/hv/vmbus_drv.c | 17 +
> 1 file changed, 17 insertions(+)
No Documentation/A
On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote:
> From: Harsh Shandilya
>
> Several methods in the driver were hardcoding
> the function name in their logging calls which
> is a checkpatch violation. Utilise the __func__
> macro to avoid needing to add the function name
> as is t
On 01/09/2018 04:46 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 09, 2018 at 04:17:01PM +, Luis de Bethencourt wrote:
>> Fix trailing semicolon.
>
> Please be more explicit. That says what it does, but not _why_ :)
>
After walking around with my head down in shame I sent a new version.
Than
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi all,
Testing the waters with this cleanup patch. If it is OK to send these there are
two very similar ones, plus more in general. Happy to sen
On Tue, Jan 09, 2018 at 05:11:52PM +0100, Hans de Goede wrote:
> Hi,
>
> On 09-01-18 17:02, Luis de Bethencourt wrote:
> > On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote:
> > > > Signed-off-by: Luis de Bethencourt
> > >
On Tue, Jan 09, 2018 at 04:17:01PM +, Luis de Bethencourt wrote:
> Fix trailing semicolon.
Please be more explicit. That says what it does, but not _why_ :)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/
This patch changes the indentation of the statements after case labels.
The linux coding guidelines do not explicitly mentiond this but pretty
much all existing code doesn't put any statements into the same line of
their belonging case labels. Therefore this adapts to the more usual style.
Please
Fix trailing semicolon.
Signed-off-by: Luis de Bethencourt
---
Changes since v1:
- Added a changelog body to the commit message
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b
On 01/09/2018 04:11 PM, Hans de Goede wrote:
> Hi,
>
> On 09-01-18 17:02, Luis de Bethencourt wrote:
>> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
>>> On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote:
Signed-off-by: Luis de Bethencourt
---
>>>
>>> I can't take
Hi,
On 09-01-18 17:02, Luis de Bethencourt wrote:
On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote:
Signed-off-by: Luis de Bethencourt
---
I can't take patches without any changelog text, sorry :(
Hi Greg,
I have done
On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote:
>> Signed-off-by: Luis de Bethencourt
>> ---
>
> I can't take patches without any changelog text, sorry :(
>
Hi Greg,
I have done some research around previous patches to th
On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote:
> Hi Joe,
>
> On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote:
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > index a1c81c12718c..4338b8a
On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote:
> Signed-off-by: Luis de Bethencourt
> ---
I can't take patches without any changelog text, sorry :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpro
Signed-off-by: Luis de Bethencourt
---
Hi all,
Testing the waters with this cleanup patch. If it is OK to send these there are
two very similar ones, plus more in general. Happy to send them.
I have a C.H.I.P. board, which is why this driver is interesting for me to play
with.
Thanks,
Luis
Fixes checkpatch warnings:
CHECK: Alignment should match open parenthesis
Signed-off-by: Valentin Vidic
---
v2: add missing Signed-off-by
drivers/staging/pi433/pi433_if.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/driver
On Mon, Jan 08, 2018 at 06:39:33PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warnings:
>
> CHECK: Alignment should match open parenthesis
> ---
> drivers/staging/pi433/pi433_if.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
No signed-off-by line :(
_
On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warnings:
>
> CHECK: Unnecessary parentheses around 'mantisse != mantisse16'
> CHECK: Unnecessary parentheses around 'mantisse != mantisse20'
> CHECK: Unnecessary parentheses around 'mantisse != mantisse24'
>
On Tue, Jan 09, 2018 at 02:37:42PM +0530, Ajay Singh wrote:
> This patch removes typedef from enum BSSTYPE_T and
> rename it to bss_types.
>
> It fixes "WARNING: do not add new typdefs" warning
> reported by checkpatch.pl.
>
> Signed-off-by: ajaysk
Hi,
This is the friendly patch-bot of Greg Kr
>-邮件原件-
>发件人: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>发送时间: 2018年1月9日 17:14
>收件人: Chenfeng (puck)
>抄送: Zengtao (B) ; labb...@redhat.com;
>sumit.sem...@linaro.org; gre...@linuxfoundation.org; a...@android.com;
>tk...@android.com; m...@android.com; de...@driverdev.osuosl.org;
>linux
The dma mask var was defined as dma_addr_t but should be
u64. This showed as a sparse warning when building for 32 bit.
Fix it by changing type to u64 and drop the cast.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-
The debugfs interface defines stub function if debugfs is not
enabled, which were missing the 'static inline' qualifiers causing
sparse warnings.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_debugfs.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dri
The ccree driver source files were using an inconsistent
naming convention stemming from what the company was called
when they were added.
Move to a single consistent naming convention for better
code readability.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Makefile
Add the missing include of include file with function declarations.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/ccree/cc_debugfs.c
b/drivers/staging/ccree/cc_debugfs.c
index f927a73..08f8db4 100644
--
File name consistency renames, include files diet and address
some sparse warnings.
Gilad Ben-Yossef (5):
staging: ccree: use a consistent file naming convention
staging: ccree: remove unneeded includes
staging: ccree: add missing include
staging: ccree: make stub function static inline
Remove include files not needed for compilation.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_aead.c| 7 ---
drivers/staging/ccree/cc_buffer_mgr.c | 6 --
drivers/staging/ccree/cc_cipher.c | 4
drivers/staging/ccree/cc_driver.c | 31
This patch removes enum typedef BUS_RELEASE_T and define
"enum bus_release" to use instead of typedef.
checkpatch.pl not to add new typedef warning is fixed with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4
This patch removes enum typedef BUS_ACQUIRE_T and define
enum bus_acquire to use instead of typedef.
checkpatch.pl not to add new typedef warning is fixed with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4 +
On Mon, Jan 08, 2018 at 10:20:15PM +0530, Sumit Pundir wrote:
> Fixed coding style issue regarding null comparison at multiple lines.
> Issue reported by checkpatch.pl
>
> Signed-off-by: Sumit Pundir
> ---
> v2:
> Updated the patch title and description.
Thanks for the update.
Acked-by: Johan
This patch removes enum typedef CHIP_PS_STATE_T and introduce
enum chip_ps_states to use instead of typedef.
checkpatch.pl not to add new typedef warning is fixed with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
drivers/staging/wilc1000/wilc_wlan_if
This patch removed the unnecessary enum typedef for BEACON_IE &
TX_RATE_T
It fix "WARNING: do not add new typedefs" reported by checkpatch.pl
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/
This patch removes following N_OPERATING_MODE_T,N_OBSS_DETECTION_T,
N_PROTECTION_TYPE_T,N_SMPS_MODE_T,TX_ABORT_OPTION_T, typedef enum.
Now, these enums are used as anonymous-enums for constants.
checkpatch.pl warning to not add new typedef is fixes with this patch.
Signed-off-by: Ajay Singh
---
This patch removes following RSNA_REKEY_POLICY_T,SCAN_CLASS_FITLER_T,
SCAN_PRI_T,CH_FILTER_T,N_PROTECTION_MODE_T,G_PROTECTION_MODE_T typedef
enum.
Now, these enums are used as anonymous-enums for constants.
checkpatch.pl warning to avoid new typedef is fixes with this patch.
Signed-off-by: Ajay S
This patch removes following G_PREAMBLE_T,SCANTYPE_T,
USER_PS_MODE_T,SECURITY_T,ACK_POLICY_T,RESET_REQ_T typedef enum.
Now, these enums are used as anonymous-enums for constants.
checkpatch.pl warning to avoid new typedef is fixes with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/
This patch has removed G_OPERATING_MODE_T typedef enum.
Now, its used as anonymous-enums for constants.
checkpatch.pl warning to avoid new typedef is fixed with this patch.
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
This patch removes typedef from enum BSSTYPE_T and
rename it to bss_types.
It fixes "WARNING: do not add new typdefs" warning
reported by checkpatch.pl.
Signed-off-by: ajaysk
---
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
2 files change
On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote:
>
>
> On 2018/1/9 18:43, Zeng Tao wrote:
> > This issue is introduced by the commit ("ION: Sys_heap:
> > Add cached pool to spead up cached buffer alloc"),
Use the Fixes tag.
Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spea
73 matches
Mail list logo
