Re: [lustre-devel] [PATCH v4] staging: lustre: Replace 'uint32_t' with 'u32' and 'uint64_t' with 'u64'

2017-12-24 Thread Dilger, Andreas
On Dec 19, 2017, at 10:56, Roman Storozhenko wrote: > > There are two reasons for replacing 'uint32_t' with 'u32' > and 'uint64_t' with 'u64': > > 1) As Linus Torvalds have said we should use kernel types: > http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html > > 2) There are only few

[PATCH] Staging: vt6656: Fix unnecessary parantheses

2017-12-24 Thread Sumit Pundir
This patch fixes a few coding style issues as noted by checkpatch.pl related to unnecessary parantheses. This patch fixes the following checkpatch.pl warnings: WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1' WARNING: Unnecessary parentheses around 'priv->eeprom[EE

[PATCH] Staging: vt6656: Fix unnecessary 'out of memory' message

2017-12-24 Thread Sumit Pundir
This patch fixes one of the warnings as noted by checkpatch.pl related to unnecessary 'out of memory' message. This patch fixes the following checkpatch.pl error: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Sumit Pundir --- drivers/staging/vt6656/main_usb.c | 5 +

Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache

2017-12-24 Thread Yisheng Xie
On 2017/12/23 21:45, Greg KH wrote: > On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote: >> --- a/lib/devres.c >> +++ b/lib/devres.c >> @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, >> resource_size_t offset, >> EXPORT_SYMBOL(devm_ioremap); >> >> /** >> - * devm

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2017-12-24 Thread Yisheng Xie
On 2017/12/24 17:05, christophe leroy wrote: > > > Le 23/12/2017 à 14:48, Greg KH a écrit : >> On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: >>> Hi all, >>> >>> When I tried to use devm_ioremap function and review related code, I found >>> devm_ioremap and devm_ioremap_nocache is

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2017-12-24 Thread Yisheng Xie
hi Christophe and Greg, On 2017/12/24 16:55, christophe leroy wrote: > > > Le 23/12/2017 à 16:57, Guenter Roeck a écrit : >> On 12/23/2017 05:48 AM, Greg KH wrote: >>> On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: Hi all, When I tried to use devm_ioremap function an

[PATCH v2] staging: vc04_services: Prefer WARN_ON_ONCE instead of if condition followed by BUG.

2017-12-24 Thread kishore . p
From: Kishore KP Coccinelle suggested to use BUG_ON instead of if condition followed by BUG but BUG_ON should be used in situations where integrity of the system is no longer guaranteed. In this case, as suggested by Stefan Wahren, vchiq isn't critical. Since it is not critical, BUG_ON should be

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2017-12-24 Thread Marcus Wolf
Am 24.12.2017 um 04:38 schrieb Michael Panzlaff: > To be applied on: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > Branch: > staging-next > > This patch changes the indentation of the statements after case labels. > The linux coding guidelines do not explicitly mentiond th

[PATCH] staging: rtl8192u: Replace mdelay with msleep in rtl8192_usb_probe

2017-12-24 Thread Jia-Ju Bai
rtl8192_usb_probe is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to avoid busy wait. Signed-off-by: Jia-Ju Bai --- drivers/staging/rtl8192u/r8192U_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2017-12-24 Thread christophe leroy
Le 23/12/2017 à 16:57, Guenter Roeck a écrit : On 12/23/2017 05:48 AM, Greg KH wrote: On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: Hi all, When I tried to use devm_ioremap function and review related code, I found devm_ioremap and devm_ioremap_nocache is almost the same with

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2017-12-24 Thread christophe leroy
Le 23/12/2017 à 14:48, Greg KH a écrit : On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: Hi all, When I tried to use devm_ioremap function and review related code, I found devm_ioremap and devm_ioremap_nocache is almost the same with each other, except one use ioremap while the o

[PATCH] staging: comedi: adv_pci1760: fix typo in comments

2017-12-24 Thread Richard Sudaryono
Changed 'firware' to 'firmware' Signed-off-by: Richard Sudaryono --- drivers/staging/comedi/drivers/adv_pci1760.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1760.c b/drivers/staging/comedi/drivers/adv_pci1760.c index e692be371f29..f