Cathy,
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise the
> I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
> s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444
Fix "Alignment should match open parenthesis" checkpatch.pl error.
Signed-off-by: Kamal Heib
---
drivers/staging/greybus/authentication.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/authentication.c
b/drivers/staging/greybus/authentication.c
index
This patch set fixes multiple error found by checkpatch.pl in the
greybus drivers.
Kamal Heib (4):
staging: greybus: authentication.c: Fix alignment should match open
parenthesis
staging: greybus: bootrom.c: Fix alignment should match open
parenthesis
staging: greybus: bundle.c: Fix
Fix "Alignment should match open parenthesis" checkpatch.pl error.
Signed-off-by: Kamal Heib
---
drivers/staging/greybus/bootrom.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/greybus/bootrom.c
b/drivers/staging/greybus/bootrom
CHECK: Comparison to NULL could be written "!bundle->state"
+ if (bundle->state == NULL)
CHECK: Alignment should match open parenthesis
+static struct gb_bundle *gb_bundle_find(struct gb_interface *intf,
+ u8 bundle_id)
Signed-off-by: Ka
Fix the following error found by checkpatch.pl:
CHECK: Please use a blank line after function/struct/union/enum declarations
+};
+#define to_gb_bundle(d) container_of(d, struct gb_bundle, dev)
Signed-off-by: Kamal Heib
---
drivers/staging/greybus/bundle.h | 1 +
1 file changed, 1 insertion(+)
"Rafael J. Wysocki" writes:
> On Tuesday, December 19, 2017 7:15:08 PM CET Joe Perches wrote:
>> Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible.
>>
>> Done with perl script:
>>
>> $ git grep -w --name-only DEVICE_ATTR | \
>> xargs perl -i -e 'local $/; while (<>) {
>> s/\bDEVICE_A
for the NVMe bits,
Acked-by: Sagi Grimberg
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Dec 12, 2017 at 03:26:10AM +0300, Dmitry Osipenko wrote:
> Add Video Decoder Engine device node.
>
> Signed-off-by: Dmitry Osipenko
> ---
> arch/arm/boot/dts/tegra20.dtsi | 27 +++
> 1 file changed, 27 insertions(+)
Applied, thanks.
Thierry
signature.asc
Descr
On Tue, Dec 12, 2017 at 03:26:09AM +0300, Dmitry Osipenko wrote:
> From: Vladimir Zapolskiy
>
> All Tegra20 SoCs contain 256KiB IRAM, which is used to store
> resume code and by a video decoder engine.
>
> Signed-off-by: Vladimir Zapolskiy
> Signed-off-by: Dmitry Osipenko
> ---
> arch/arm/boo
On Tuesday, December 19, 2017 7:15:08 PM CET Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
> s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO
This patch corrects the type of the size argument in __dump_byte_array()
from unsigned long to size_t as done only in drivers/staging/ccree/ssi_driver.c
This fix also a build error:
drivers/staging/ccree/ssi_driver.c:82:6: error: conflicting types for
'__dump_byte_array'
Fixes: 3f268f5d6669 ("st
From: Greg Kroah-Hartman
Date: Wed, 20 Dec 2017 08:13:55 +0100
> On Tue, Dec 19, 2017 at 09:14:10PM +0200, Andy Shevchenko wrote:
>> Some drivers are getting MAC from user space. Make a helper for them.
>>
>> Signed-off-by: Andy Shevchenko
>> ---
>> include/linux/kernel.h | 1 +
>> lib/net_ut
The following functions:
* rf69_set_dc_cut_off_frequency,
* rf69_set_dc_cut_off_frequency_intern,
* rf69_set_dc_cut_off_frequency_during_afc
are unused and should be removed along with type enum dcc_percent which
was used only by these functions.
Signed-off-by: Marcin Ciupak
---
drivers/staging/
Function rf69_set_ook_threshold_type is unused and should be removed
along with type enum thresholdType which was used only by that function.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
drivers/staging/pi433/rf69
Function rf69_set_ook_threshold_step is unused and should be removed
along with type enum thresholdStep which was used only by that function.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 17 -
drivers/staging/pi433/rf69.h | 1 -
drivers/staging/pi433
Function rf69_reset_flag is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e3d0a4b
Function rf69_set_rssi_timeout is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 7 ---
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 33a0e0085
Function rf69_set_rx_start_timeout is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 7 ---
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 25dfd
Function rf69_set_sync_tolerance is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index
Function rf69_get_payload_length is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 5 -
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 043139730
Following functions:
* rf69_get_modulation
* rf69_read_reg
* rf69_write_reg
are used locally only and should be declared as static
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 94 ++--
drivers/staging/pi433/rf69.h | 3 --
2 files change
These patches make local functions static and remove unused ones. Each
function is removed by separate patch in order to make it easier to
revert patch in future if the function will be needed in later version
of the driver.
Marcin Ciupak (9):
staging: pi433: make local functions static
stagin
Hi Mauro,
Thanks for the patch.
On Tue, Dec 19, 2017 at 11:18 AM, Mauro Carvalho Chehab
wrote:
> The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
> struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
> match criteria requires just a device name.
>
> So, it doesn'
This removes checkpatch.pl warnings:
WARNING: line over 80 characters
Signed-off-by: Mikhail Shvetsov
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vch
This removes useless comments duplicate function names.
Signed-off-by: Mikhail Shvetsov
---
.../interface/vchiq_arm/vchiq_kern_lib.c | 35 --
1 file changed, 35 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_kern_lib.c
b/drivers/
This removes checkpatch.pl warnings:
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments should align the * on each line
WARNING: Block comments use * on subsequent lines
Signed-off-by: Mikhail Shvetsov
---
.../vc04_services/interface/vchiq_arm/vchiq_kern_lib.c
On 12/20/2017 01:06 PM, Greg KH wrote:
> On Wed, Dec 20, 2017 at 10:52:52AM +, Laurentiu Tudor wrote:
>>
>>
>> On 12/20/2017 12:42 PM, Greg KH wrote:
>>> On Wed, Dec 20, 2017 at 10:26:49AM +, Laurentiu Tudor wrote:
On 12/19/2017 06:10 PM, Greg KH wrote:
>>> But all of these .h fi
On Wed, Dec 20, 2017 at 10:52:52AM +, Laurentiu Tudor wrote:
>
>
> On 12/20/2017 12:42 PM, Greg KH wrote:
> > On Wed, Dec 20, 2017 at 10:26:49AM +, Laurentiu Tudor wrote:
> >> On 12/19/2017 06:10 PM, Greg KH wrote:
> > But all of these .h files are only used by the code in this specif
Hi Mauro,
On 2017-12-19 09:18:19 -0200, Mauro Carvalho Chehab wrote:
> The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
> struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
> match criteria requires just a device name.
>
> So, it doesn't make sense to enclose tho
On 12/20/2017 12:42 PM, Greg KH wrote:
> On Wed, Dec 20, 2017 at 10:26:49AM +, Laurentiu Tudor wrote:
>> On 12/19/2017 06:10 PM, Greg KH wrote:
> But all of these .h files are only used by the code in this specific
> directory, no where else.
They are also used by our ethern
On Wed, 20 Dec 2017, Dan Carpenter wrote:
> On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote:
> > @@ -914,9 +904,7 @@ static int lm3554_probe(struct i2c_client *client)
> > dev_err(&client->dev, "gpio request/direction_output fail");
> > goto fail2;
> >
On Wed, Dec 20, 2017 at 10:26:49AM +, Laurentiu Tudor wrote:
> On 12/19/2017 06:10 PM, Greg KH wrote:
> >>> But all of these .h files are only used by the code in this specific
> >>> directory, no where else.
> >>
> >> They are also used by our ethernet driver, see:
> >> drivers/staging/fsl
On 12/19/2017 06:10 PM, Greg KH wrote:
> On Tue, Dec 19, 2017 at 03:39:44PM +, Laurentiu Tudor wrote:
>> On 12/19/2017 05:29 PM, Greg KH wrote:
>>> On Tue, Dec 19, 2017 at 03:21:19PM +, Laurentiu Tudor wrote:
On 12/19/2017 04:48 PM, Greg KH wrote:
> On Wed, Nov 29, 2017
On Wed, Dec 20, 2017 at 6:54 AM, Dan Carpenter wrote:
> On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote:
>> @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct i2c_client *client)
>> if (ret)
>> gc2235_remove(client);
>
> This error handling is probably wrong.
Hi,
Joe Perches writes:
> drivers/usb/phy/phy-tahvo.c| 2 +-
Acked-by: Felipe Balbi
--
balbi
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote:
> @@ -914,9 +904,7 @@ static int lm3554_probe(struct i2c_client *client)
> dev_err(&client->dev, "gpio request/direction_output fail");
> goto fail2;
> }
> - if (ACPI_HANDLE(&client->dev))
> -
38 matches
Mail list logo
