On Wed, Dec 13, 2017 at 01:23:38PM -0800, Stephen Hemminger wrote:
> On Wed, 13 Dec 2017 09:54:19 +0100
> Vincent Legoll wrote:
>
> > Hello,
> >
> > On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger
> > wrote:
> > > Will this break existing configs?
> >
> > I don't think so. Last time I did
On Wed, Dec 13, 2017 at 6:07 AM, Greg Kroah-Hartman
wrote:
> On Wed, Dec 13, 2017 at 05:16:13PM +0530, Aniruddha Shastri wrote:
>> On Wed, Dec 13, 2017 at 4:20 PM, Greg Kroah-Hartman
>> wrote:
>> >
>> > On Wed, Dec 13, 2017 at 04:01:04AM -0600, Aniruddha Shastri wrote:
>> > > Fix checkpatch warni
Am 13.12.2017 um 21:51 schrieb Tomas Marek:
This patch fix brace on next line coding style errors reported by
checkpatch.
Signed-off-by: Tomas Marek
Acked-by: Stefan Wahren
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
Two of these warnings are now line-too-long warnings. I think these
warnings are preferable to the ones listed below. The longest line is
only 85 chars wide, which is reasonable.
Warnings fixed:
ni_atmio.c:239: WARNING: Avoid multiple line dereference
- prefer 'ni_boards[i].isapnp_id'
ni_
On Wed, Dec 13, 2017 at 11:31:15AM -0800, Tomas Marek wrote:
> On 12/13/2017 03:55 AM, Greg KH wrote:
>
> > On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
> >> This patch fix several brace on next line, braces not necessary, space
> >> around =/<, and space before/after open/close pa
On Thu, Dec 14, 2017 at 11:51:17AM +0530, Aishwarya Pant wrote:
> On Wed, Dec 13, 2017 at 12:50:00PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 11, 2017 at 03:24:30PM +0530, Aishwarya Pant wrote:
> > > This is a clean-up patch which replaces the uses of raw __ATTR(...)
> > > macro with the mo
Three of these warnings are now line-too-long warnings. I think these
warnings are preferable to the ones listed below. The longest line
is only 87 chars wide, which is reasonable.
Warnings fixed:
ni_670x.c:212: WARNING: struct comedi_lrange should normally be const
ni_atmio.c:239: WARNING: Avoi
On Wed, Dec 13, 2017 at 12:50:00PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 11, 2017 at 03:24:30PM +0530, Aishwarya Pant wrote:
> > This is a clean-up patch which replaces the uses of raw __ATTR(...)
> > macro with the more conventional DEVICE_ATTR(...) for defining device
> > attributes.
> >
staging: comedi: s626.c - fix the following checkpatch issues:
WARNING: Avoid multiple line dereference - prefer
'devpriv->rps_buf.logical_base'
#1380: FILE: drivers/s626.c:1380:
+ (unsigned long)devpriv->
+ rps_buf.l
From: Xiongwei Song
The function binder_alloc_new_buf_locked() is only used in this file, so
make it static. Also clean up sparse warning:
drivers/android/binder_alloc.c:330:23: warning: no previous prototype
for ‘binder_alloc_new_buf_locked’ [-Wmissing-prototypes]
In addition, the line of the
On Wed, 2017-12-13 at 15:21 +0100, Valentin Vidic wrote:
> WARNING: Missing a blank line after declarations
[]
> diff --git a/drivers/staging/pi433/pi433_if.c
> b/drivers/staging/pi433/pi433_if.c
[]
> @@ -565,6 +565,7 @@ pi433_tx_thread(void *data)
> bool rx_interrupted = false;
>
On Wed, 13 Dec 2017 09:54:19 +0100
Vincent Legoll wrote:
> Hello,
>
> On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger
> wrote:
> > Will this break existing configs?
>
> I don't think so. Last time I did some similar changes, the kbuild
> test robot found some warnings on some configuratio
Removing the extra spaces before tabs, checkpatch:
WARNING: please, no space before tabs
Signed-off-by: SUNIL KALLUR RAMEGOWDA
---
drivers/staging/ks7010/ks_wlan_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
b/drivers/staging/
From: Stephen Hemminger
Date: Tue, 12 Dec 2017 16:48:34 -0800
> This includes minor cleanup of code in send and receive path and
> also a new statistic to check for allocation failures. This also
> eliminates some of the extra RCU when not needed.
>
> There is a theoritical bug where buffered da
This patch fix brace on next line coding style errors reported by
checkpatch.
Signed-off-by: Tomas Marek
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchi
On Tue, Dec 12, 2017 at 10:25 PM, kbuild test robot
wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-linus
> head: d98e6dbf42f73101128885a1e0ae672cd92b2e1a
> commit: d98e6dbf42f73101128885a1e0ae672cd92b2e1a [3/3] staging: ion: Fix
> ion_cma_heap all
Fixes checkpatch warning:
CHECK: Avoid CamelCase:
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/rf69.c | 30 +++---
drivers/staging/pi433/rf69.h | 6 +++---
drivers/staging/pi433/rf69_enum.h | 18 +-
3 files changed, 27 insertions(
Fix variable naming and checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Valentin Vidic
---
v2: use a better variable name
v3: keep the variable scope
drivers/staging/pi433/pi433_if.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
On 12/13/2017 03:55 AM, Greg KH wrote:
> On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
>> This patch fix several brace on next line, braces not necessary, space
>> around =/<, and space before/after open/close parenthesis coding style
>> errors find by checkpatch in pi433_if.c.
>>
>
This patch fixes this checkpatch.pl errors:
ERROR: space prohibited after that open parenthesis '('
+ if ( IS_ERR(device->gpiod[i]) )
ERROR: space prohibited before that close parenthesis ')'
+ if ( IS_ERR(device->gpiod[i]) )
ERROR: space prohibited before that close
This patch fixes this checkpatch.pl errors:
ERROR: that open brace { should be on the previous line
+ if (device->rx_active) + {
ERROR: that open brace { should be on the previous line
+ else
+ {
ERROR: else should follow close brace '}'
+ }
+ else
Signed-of
This patch fixes this checkpatch.pl error:
ERROR: that open brace { should be on the previous line
+ if (rx_interrupted) +
Signed-off-by: Oliver Graute
---
drivers/staging/pi433/pi433_if.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/stagi
This patch fixes this checkpatch.pl errors:
ERROR: that open brace { should be on the previous line
+ for (i=0; i
---
drivers/staging/pi433/pi433_if.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
in
This patch fixes this checkpatch.pl error:
ERROR: spaces required around that '+=' (ctx:WxV) +
position +=temp;
Signed-off-by: Oliver Graute
---
drivers/staging/pi433/pi433_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/
This patch fixes this checkpatch.pl errors:
ERROR: that open brace { should be on the previous line
+ if ( IS_ERR(device->gpiod[i]) ) + {
ERROR: space prohibited after that open parenthesis '('
+ if ( IS_ERR(device->gpiod[i]) )
ERROR: space prohibited be
rearranged the patches and summarized them
Oliver Graute (6):
staging: pi433: pi433_if.c codestyle space required
staging: pi433: pi433_if.c style fix wrong placed brace
staging: pi433: pi433_if.c style open brace
staging: pi433: pi433_if.c space required in for loop
staging: pi433: pi43
From: Stephen Hemminger
Date: Mon, 11 Dec 2017 08:56:56 -0800
> The default for receive buffer descriptors is not correct, it should
> match the default receive buffer size and the upper limit of receive
> buffer size is too low. Also, for older versions of Window servers
> hosts, different lowe
Am 13.12.2017 um 19:44 schrieb Valentin Vidic:
Avoid shifting by magic numbers and use defines instead.
Signed-off-by: Valentin Vidic
---
v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE
- move shifting to the header file
v3: - drop auto case
- use CURRENT suffix
- precomp
Avoid shifting by magic numbers and use defines instead.
Signed-off-by: Valentin Vidic
---
v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE
- move shifting to the header file
v3: - drop auto case
- use CURRENT suffix
- precompute define values
drivers/staging/pi433/rf69.c
Am 13.12.2017 um 18:55 schrieb Valentin Vidic:
Avoid shifting by magic numbers and use defines instead.
Signed-off-by: Valentin Vidic
---
v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE
- move shifting to the header file
drivers/staging/pi433/rf69.c | 16 --
On Wed, Dec 13, 2017 at 05:32:28PM +0200, Marcus Wolf wrote:
> Am 13.12.2017 um 16:21 schrieb Valentin Vidic:
> > Avoid shifting by magic numbers and use defines instead:
> >
> >SHIFT_DATAMODUL_MODULATION_TYPE
> >SHIFT_LNA_CURRENT_GAIN
> >
> > Signed-off-by: Valentin Vidic
> > ---
> >
Avoid shifting by magic numbers and use defines instead.
Signed-off-by: Valentin Vidic
---
v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE
- move shifting to the header file
drivers/staging/pi433/rf69.c | 16
drivers/staging/pi433/rf69_registers.h | 8 +
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-linus
head: d98e6dbf42f73101128885a1e0ae672cd92b2e1a
commit: d98e6dbf42f73101128885a1e0ae672cd92b2e1a [3/3] staging: ion: Fix
ion_cma_heap allocations
config: sparc64-allyesconfig (attached as .config)
compiler:
On Wed, Dec 13, 2017 at 03:49:12PM +0100, Hans de Goede wrote:
> Hi,
>
> On 13-12-17 12:47, Greg Kroah-Hartman wrote:
> > On Sun, Dec 10, 2017 at 08:35:12PM +0100, Nicolas Iooss wrote:
> > > rtw_pm_set() uses memcmp() with 5-chars strings and a length of 4 when
> > > parsing extra, and then parses
Hi,
On 13-12-17 16:12, Rasmus Villemoes wrote:
On 2017-12-13 15:49, Hans de Goede wrote:
Hi,
On 13-12-17 12:47, Greg Kroah-Hartman wrote:
On Sun, Dec 10, 2017 at 08:35:12PM +0100, Nicolas Iooss wrote:
rtw_pm_set() uses memcmp() with 5-chars strings and a length of 4 when
parsing extra, and t
Fixes checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Valentin Vidic
---
v2: use a better variable name
drivers/staging/pi433/pi433_if.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/s
Am 13.12.2017 um 16:21 schrieb Valentin Vidic:
Avoid shifting by magic numbers and use defines instead:
SHIFT_DATAMODUL_MODULATION_TYPE
SHIFT_LNA_CURRENT_GAIN
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/rf69.c | 4 ++--
drivers/staging/pi433/rf69_registers.h |
Am 13.12.2017 um 16:21 schrieb Valentin Vidic:
Fixes checkpatch warning:
WARNING: Possible precedence defect with mask then right shift - may need
parentheses
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/rf69.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On Wed, Dec 13, 2017 at 05:52:36PM +0300, Dan Carpenter wrote:
> On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote:
> > drivers/staging/pi433/pi433_if.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/pi433/pi433_if.c
> > b/drivers/
On 2017-12-13 15:49, Hans de Goede wrote:
> Hi,
>
> On 13-12-17 12:47, Greg Kroah-Hartman wrote:
>> On Sun, Dec 10, 2017 at 08:35:12PM +0100, Nicolas Iooss wrote:
>>> rtw_pm_set() uses memcmp() with 5-chars strings and a length of 4 when
>>> parsing extra, and then parses extra+4 as an int:
>>>
>>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-linus
head: d98e6dbf42f73101128885a1e0ae672cd92b2e1a
commit: d98e6dbf42f73101128885a1e0ae672cd92b2e1a [3/3] staging: ion: Fix
ion_cma_heap allocations
config: i386-randconfig-x019-12132053 (attached as .config)
c
When we run nested KVM on Hyper-V guests we need to update masterclocks for
all guests when L1 migrates to a host with different TSC frequency.
Implement the procedure in the following way:
- Pause all guests.
- Tell our host (Hyper-V) to stop emulating TSC accesses.
- Update our gtod copy, recompu
It is very unlikely for CPUs to get offlined when we run on Hyper-V as
we have a protection in vmbus module which prevents it when we have any
VMBus devices assigned. This, however, may change in future if an option
to reassign an already active channel will be added. It is also possible
to run wi
Currently, KVM is able to work in 'masterclock' mode passing
PVCLOCK_TSC_STABLE_BIT to guests when the clocksource we use on the host
is TSC. When running nested on Hyper-V we normally use a different one:
TSC page which is resistant to TSC frequency changes on event like L1
migration. Add support
Hyper-V supports Live Migration notification. This is supposed to be used
in conjunction with TSC emulation: when we are migrated to a host with
different TSC frequency for some short period host emulates our accesses
to TSC and sends us an interrupt to notify about the event. When we're
done updat
Hyper-V reenlightenment interrupts arrive when the VM is migrated, we're
not supposed to see many of them. However, it may be important to know
that the event has happened in case we have L2 nested guests.
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/hyperv/hv_init.c | 2 ++
arch/x86/includ
In hyperv_init() we presume we always have access to VP index and hypercall
MSRs while according to the specification we should check if we're allowed
to access the corresponding MSRs before accessing them.
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/hyperv/hv_init.c | 9 -
1 file chang
This is going to be used from KVM code where we need to get both
TSC and TSC page value.
When Hyper-V code is compiled out just return rdtsc(), this will allow us
to avoid ugly ifdefs in non-Hyper-V code.
Signed-off-by: Vitaly Kuznetsov
---
arch/x86/hyperv/hv_init.c | 1 +
arch/x86/inclu
Changes since v1:
- PATCH5 "x86/irq: Count Hyper-V reenlightenment interrupts" added
[Michael Kelley]
- PATCH3 "x86/hyper-v: reenlightenment notifications support" changes:
- rename register_hv_tsc_update/unregister_hv_tsc_update() to
set_hv_tscchange_cb()/clear_hv_tscchange_cb() to avoid t
On Wed, Dec 13, 2017 at 03:21:53PM +0100, Valentin Vidic wrote:
> Reading from the spec, allowed values for modulation scheme
> after the shift are:
>
> 00 FSK
> 01 OOK
> 10 - 11 reserved
>
> Signed-off-by: Valentin Vidic
> ---
> drivers/staging/pi433/rf69_registers.h | 2 +-
> 1 file cha
From: Markus Elfring
Date: Wed, 13 Dec 2017 15:46:07 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 5 +
1 fil
On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote:
> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c
> b/drivers/staging/pi433/pi433_if.c
> index 9e558154a143..02a5ba019801 100644
> --- a/
On Wed, Dec 13, 2017 at 03:21:52PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warning:
>
> WARNING: Possible precedence defect with mask then right shift - may need
> parentheses
>
> Signed-off-by: Valentin Vidic
Please do your work against linux-next or staging-next. There have been
a
Hi,
On 13-12-17 12:47, Greg Kroah-Hartman wrote:
On Sun, Dec 10, 2017 at 08:35:12PM +0100, Nicolas Iooss wrote:
rtw_pm_set() uses memcmp() with 5-chars strings and a length of 4 when
parsing extra, and then parses extra+4 as an int:
if (!memcmp(extra, "lps =", 4)) {
sscanf(extra+
On Wed, Dec 13, 2017 at 03:21:50PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warning:
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Valentin Vidic
> ---
> drivers/staging/pi433/pi433_if.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
From: Markus Elfring
Date: Wed, 13 Dec 2017 15:15:45 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/vt6656/main_usb.c | 5 +
1 file changed, 1 inserti
Fixes checkpatch warning:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/pi433_if.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 8
Fixes checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/pi433_if.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 0288798
Fixes checkpatch warning:
WARNING: Possible precedence defect with mask then right shift - may need
parentheses
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/rf69.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/stagin
Fixes checkpatch warning:
WARNING: printk() should include KERN_ facility level
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index
Avoid shifting by magic numbers and use defines instead:
SHIFT_DATAMODUL_MODULATION_TYPE
SHIFT_LNA_CURRENT_GAIN
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/rf69.c | 4 ++--
drivers/staging/pi433/rf69_registers.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
Reading from the spec, allowed values for modulation scheme
after the shift are:
00 FSK
01 OOK
10 - 11 reserved
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/rf69_registers.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69_registers
Fixes checkpatch warning:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/pi433_if.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 0
Fixes checkpatch warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Valentin Vidic
---
drivers/staging/pi433/pi433_if.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi43
On Wed, Dec 13, 2017 at 12:02:11AM +0200, Kari Argillander wrote:
> Case: SHAPING_0_5 is writing DATAMODUL_MODLATION_SHAPE_0_3 value and
> vice versa
>
> Signed-off-by: Kari Argillander
> ---
> I have checked that defines are correct accounting to the datasheet.
Looks good.
Fixes: 874bcba65f9a
From: Markus Elfring
Date: Wed, 13 Dec 2017 13:41:41 +0100
Replace two calls of the function "kfree" by a jump to the same statements
at the end of this function so that the generated object code could become
a bit smaller.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/prism2fw.c |
From: Markus Elfring
Date: Wed, 13 Dec 2017 13:28:15 +0100
Omit an extra message for a memory allocation failure in this function.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/prism2fw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/dr
From: Markus Elfring
Date: Wed, 13 Dec 2017 13:20:10 +0100
Make a memory allocation failure clearer by using the error code "-ENOMEM"
(instead of the constant "1") in this function.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/prism2fw.c | 2 +-
1 file changed, 1 insertion(+), 1 d
From: Markus Elfring
Date: Wed, 13 Dec 2017 12:57:13 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/wlan-ng/prism2fw.c | 5 ++---
1 file changed, 2 insert
From: Markus Elfring
Date: Wed, 13 Dec 2017 14:03:02 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Delete an error message for a failed memory allocation in mkimage()
Use a known error code after a failed kzalloc() in mkimage()
Fixes checkpatch warning for multiple blank lines in source.
Signed-off-by: Valentin Vidic
---
v2: refresh patch for staging-testing
drivers/staging/pi433/pi433_if.c | 11 ---
drivers/staging/pi433/pi433_if.h | 8
drivers/staging/pi433/rf69.h | 2 --
dri
On Wed, Dec 13, 2017 at 05:16:13PM +0530, Aniruddha Shastri wrote:
> On Wed, Dec 13, 2017 at 4:20 PM, Greg Kroah-Hartman
> wrote:
> >
> > On Wed, Dec 13, 2017 at 04:01:04AM -0600, Aniruddha Shastri wrote:
> > > Fix checkpatch warnings by shortening lines and reorganizing code where
> > > needed..
On Sun, Dec 10, 2017 at 03:31:16PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warning for multiple blank lines in source.
>
> Signed-off-by: Valentin Vidic
> ---
> drivers/staging/pi433/pi433_if.c | 11 ---
> drivers/staging/pi433/pi433_if.h | 8
> drivers/stag
On Sun, Dec 10, 2017 at 03:31:14PM +0100, Valentin Vidic wrote:
> Fixes checkpatch warning for whitespace before a quoted newline.
>
> Signed-off-by: Valentin Vidic
> ---
> drivers/staging/pi433/rf69.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/
On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
> This patch fix several brace on next line, braces not necessary, space
> around =/<, and space before/after open/close parenthesis coding style
> errors find by checkpatch in pi433_if.c.
>
> Signed-off-by: Tomas Marek
> ---
> Changes
On Fri, Dec 08, 2017 at 05:22:49PM +0100, Oliver Graute wrote:
> ERROR: space prohibited before that close parenthesis
> ')' +kthread_should_stop() );
>
> Signed-off-by: Oliver Graute
> ---
> drivers/staging/pi433/pi433_if.c | 2 +-
> 1 file changed, 1 in
On Mon, Dec 11, 2017 at 03:24:30PM +0530, Aishwarya Pant wrote:
> This is a clean-up patch which replaces the uses of raw __ATTR(...)
> macro with the more conventional DEVICE_ATTR(...) for defining device
> attributes.
>
> Done using coccinelle-
>
> @r@
> identifier foo, n;
> @@
>
> struct devi
On Sun, Dec 10, 2017 at 08:35:12PM +0100, Nicolas Iooss wrote:
> rtw_pm_set() uses memcmp() with 5-chars strings and a length of 4 when
> parsing extra, and then parses extra+4 as an int:
>
> if (!memcmp(extra, "lps =", 4)) {
> sscanf(extra+4, "%u", &mode);
> /* ... */
> } else
On Wed, Dec 13, 2017 at 4:20 PM, Greg Kroah-Hartman
wrote:
>
> On Wed, Dec 13, 2017 at 04:01:04AM -0600, Aniruddha Shastri wrote:
> > Fix checkpatch warnings by shortening lines and reorganizing code where
> > needed..
> > Re-phrase the assert messages in ni_mio_common.c. This was done to meet th
On Fri, Dec 08, 2017 at 09:27:54PM +0100, SUNIL KALLUR RAMEGOWDA wrote:
> Removing the extra spaces before tabs, checkpatch:
> WARNING: please, no space before tabs
>
> Signed-off-by: SUNIL KALLUR RAMEGOWDA
> ---
> drivers/staging/ks7010/ks_wlan_net.c | 4 ++--
> 1 file changed, 2 insertions(+),
On Tue, Dec 12, 2017 at 12:46:16PM -0800, Roman Lakeev wrote:
>staging: comedi: s626.c - fix the following checkpatch issues:
>WARNING: Avoid multiple line dereference - prefer
> 'devpriv->rps_buf.logical_base'
>#1380: FILE: drivers/s626.c:1380:
>+
Fixed sparse warning by making 'dtrace_dot' function static.
Signed-off-by: Sergiy Redko
---
.../media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_d
On Wed, Dec 13, 2017 at 04:01:04AM -0600, Aniruddha Shastri wrote:
> Fix checkpatch warnings by shortening lines and reorganizing code where
> needed..
> Re-phrase the assert messages in ni_mio_common.c. This was done to meet the
> character limit for the message.
And yet this line is over the c
"Michael Kelley (EOSG)" writes:
> On Fri, Dec 08, 2017 at 11:49:57AM +0100, Vitaly Kuznetsov wrote:
>
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Friday, December 8, 2017 2:50 AM
>> To: k...@vger.kernel.org; x...@kernel.org
>> Cc: Paolo Bonzini ;
Fix checkpatch warnings by shortening lines and reorganizing code where needed..
Re-phrase the assert messages in ni_mio_common.c. This was done to meet the
character limit for the message.
Signed-off-by: Aniruddha Shastri
---
drivers/staging/comedi/drivers/ni_670x.c | 3 +-
drivers/st
Hello,
On Sun, Dec 10, 2017 at 6:50 AM, Stephen Hemminger
wrote:
> Will this break existing configs?
I don't think so. Last time I did some similar changes, the kbuild
test robot found some warnings on some configurations, I hope
it will find problems (if any) for that series too (this one is no
86 matches
Mail list logo
