Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Greg KH
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Unit Testing: > > - build successful > - LTP testsuite passes. > - checkpatch.pl pas

Re: [PATCH] staging: vc04_services: Fix trivial style issues

2017-12-03 Thread Greg Kroah-Hartman
On Mon, Dec 04, 2017 at 01:17:36AM -0500, Genki Sky wrote: > In bcm2835-camera, handle the following checkpatch.pl types: > - EMBEDDED_FUNCTION_NAME > - MULTILINE_DEREFERENCE > - SPLIT_STRING > > [ note: this is for Task 10 of http://eudyptula-challenge.org/ ] > > Signed-off-by: Genki Sky

[PATCH] staging: vc04_services: Fix trivial style issues

2017-12-03 Thread Genki Sky
In bcm2835-camera, handle the following checkpatch.pl types: - EMBEDDED_FUNCTION_NAME - MULTILINE_DEREFERENCE - SPLIT_STRING [ note: this is for Task 10 of http://eudyptula-challenge.org/ ] Signed-off-by: Genki Sky --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 23 +-

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Joe Perches
On Mon, 2017-12-04 at 03:19 +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. Can you list the duplicates that were not removed as well please? _

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Luis R. Rodriguez
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Unit Testing: > > - build successful > - LTP testsuite passes. > - checkpatch.pl pas

[PATCH] treewide: remove duplicate includes

2017-12-03 Thread Pravin Shedge
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Unit Testing: - build successful - LTP testsuite passes. - checkpatch.pl passes Signed-off-by: Pravin Shedge --- arch/arm/crypto/aes-ce-glue.c

[PATCH] Make ANDROID a menuconfig to ease disabling it all

2017-12-03 Thread Vincent Legoll
No need to get into the submenu to disable all ANDROID-related config entries Signed-off-by: Vincent Legoll --- drivers/android/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig index 7dce3795b887..e9434777acba 1006

Re: [PATCH] staging: lustre: check result of register_shrinker

2017-12-03 Thread ak
On 12/03/2017 03:47 AM, Dilger, Andreas wrote: On Dec 2, 2017, at 11:40, Aliaksei Karaliou wrote: Lustre code lacks checking the result of register_shrinker() in several places. register_shrinker() was tagged __must_check recently so that sparse has started reporting it. Thank you for your pa

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-03 Thread Marcus Wolf
Am 03.12.2017 um 17:17 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 +

[PATCH 0/6] Fix indentation and CamelCase issues in staging/pi433

2017-12-03 Thread Simon Sandström
These patches fixes a bunch of code style issues in staging/pi433. The first patch fixes indentation in rf69_enum.h and the rest of the patches fixes CamelCase issues in all of staging/pi433. In total the patches get rids of around 140 warnings generated by checkpatch.pl. - Simon --- Simon Sand

[PATCH 3/6] staging: pi433: Rename variable in struct pi433_rx_cfg

2017-12-03 Thread Simon Sandström
Renames variable thresholdDecrement in struct pi433_rx_cfg to threshold_decrement to get rid of checkpatch.pl warning "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- 2 files changed, 2 insertions(+), 2 dele

[PATCH 2/6] staging: pi433: Capitalize constant definitions

2017-12-03 Thread Simon Sandström
Fixes checkpatch.pl warnings "Avoid CamelCase ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 32 - drivers/staging/pi433/rf69_registers.h | 44 +- 2 files changed, 38 insertions(+), 38 deletions(-) diff --gi

[PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames enum dataMode and its values packet, continuous, continuousNoSync to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes checkpatch.pl warnings: "Avoid CamelCase: , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c

[PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames enum modShaping and its values to get rid of checkpatch.pl warnings: "Avoid CamelCase: ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 21 +++-- drivers/staging

[PATCH 1/6] staging: pi433: Fix indentation in rf69_enum.h

2017-12-03 Thread Simon Sandström
Basically just 's//\t/', to fix checkpatch.pl warnings: "please, no spaces at the start of a line". Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69_enum.h | 207 +++--- 1 file changed, 103 insertions(+), 104 deletions(-) diff --git a/drivers/sta

[PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-03 Thread Simon Sandström
Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 ++--- drivers/staging/pi433/p

Re: [PATCH net-next 0/6] hv_netvsc: minor optimizations

2017-12-03 Thread David Miller
From: Stephen Hemminger Date: Fri, 1 Dec 2017 11:01:43 -0800 > These are a set of local optimizations the Hyper-V networking driver. > Also include a vmbus patch in this set, because it depends on the > netvsc that last used that function. Series applied. For the ring percentage stuff, I would

[PATCH 10/10] staging: ccree: amend aead func def for readability

2017-12-03 Thread Gilad Ben-Yossef
Func definitions in the aead implementation were did not adhere to coding style. Fix them for better readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 141 ++- 1 file changed, 51 insertions(+), 90 deletions(-) diff --git a/dr

[PATCH 09/10] staging: ccree: fix AEAD func naming convention

2017-12-03 Thread Gilad Ben-Yossef
The aead files was using a func naming convention which was inconsistent (ssi vs. cc), included a useless prefix (ssi_aead) and often used too long function names producing monster func names such as ssi_aead_gcm_setup_ghash_desc() that made the call site code hard to read. Make the code more read

[PATCH 01/10] staging: ccree: remove inline qualifiers

2017-12-03 Thread Gilad Ben-Yossef
The ccree drivers was marking a lot of big functions in C file as static inline for no good reason. Remove the inline qualifier from any but the few truly single line functions. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 40 - dr

[PATCH 08/10] staging: ccree: NULLify backup_info when unused

2017-12-03 Thread Gilad Ben-Yossef
backup_info field is only allocated for decrypt code path. The field was not nullified when not used causing a kfree in an error handling path to attempt to free random addresses as uncovered in stress testing. Fixes: 737aed947f9b ("staging: ccree: save ciphertext for CTS IV") Cc: sta...@vger.kern

[PATCH 03/10] staging: ccree: remove more unnecessary parentheses

2017-12-03 Thread Gilad Ben-Yossef
The removal of likely/unlikely unearthed some more unnecessary parentheses. Remove them for better readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 4 ++-- drivers/staging/ccree/ssi_driver.c | 6 +++--- drivers/staging/ccree/ssi_request_mgr.c | 2 +-

[PATCH 00/10] staging: ccree: cleanups & fixes

2017-12-03 Thread Gilad Ben-Yossef
Another batch of ccree work. Includes the usual mix of mostly cleanups and one fix. Also includes an updated TODO to reflect recent progress and removal of interim documentation of device tree strings as the official string and documentation thereof got blessed into the crypto tree. Gilad Ben-Yoss

[PATCH 07/10] staging: ccree: update TODO list

2017-12-03 Thread Gilad Ben-Yossef
Update the ccree staging TODO list in light of recent work. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/TODO | 23 ++- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/drivers/staging/ccree/TODO b/drivers/staging/ccree/TODO index c9f5754..f44edcd 1

[PATCH 05/10] staging: ccree: remove braces for single statement blocks

2017-12-03 Thread Gilad Ben-Yossef
Remove braces from single statement if clause. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_request_mgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c index e890cb6..5f343

[PATCH 04/10] staging: ccree: fix indentation of var assignment

2017-12-03 Thread Gilad Ben-Yossef
Fix indentation of var assignment split across lines for better readability. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index 0b08

[PATCH 06/10] staging: ccree: remove interim DT docs

2017-12-03 Thread Gilad Ben-Yossef
As proper DT bindings doc where submitted and ACKed, remove the interim one. Signed-off-by: Gilad Ben-Yossef --- .../devicetree/bindings/crypto/arm-cryptocell.txt | 27 -- 1 file changed, 27 deletions(-) delete mode 100644 drivers/staging/ccree/Documentation/devicetree/bin

[PATCH 02/10] staging: ccree: remove unproven likely/unlikely

2017-12-03 Thread Gilad Ben-Yossef
The ccree code made a lot of use of likely/unlikely qualifiers without proven measurements showing any benefits. Remove them all until we see what is justified and what is not. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 57 ++-- drivers/staging/ccree/s

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-03 Thread Marcus Wolf
Am 03.12.2017 um 11:56 schrieb Marcin Ciupak: On Sat, Dec 02, 2017 at 08:46:15AM -0800, Joe Perches wrote: On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote: rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only. Therefore removed the function from header and declared it sta

Re: [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

2017-12-03 Thread Jeremy Sowden
On 2017-12-03, at 08:39:21 +0300, Dan Carpenter wrote: > On Sat, Dec 02, 2017 at 08:41:48PM +, Jeremy Sowden wrote: > > On 2017-12-02, at 10:35:06 +, Jeremy Sowden wrote: > > > On 2017-12-02, at 13:20:09 +0300, Dan Carpenter wrote: > > > > On Fri, Dec 01, 2017 at 05:19:37PM +, Jeremy So

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

2017-12-03 Thread Marcin Ciupak
On Sat, Dec 02, 2017 at 08:46:15AM -0800, Joe Perches wrote: > On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote: > > rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only. > > Therefore removed the function from header and declared it staic in > > the implemtation. > > Signed-o

Re: [PATCH] Staging: pi433: fix brace coding style issues in pi433_if.c

2017-12-03 Thread Marek Tomas
On 12/02/2017 10:50 PM, Joe Perches wrote: > On Sat, 2017-12-02 at 22:05 +0100, Tomas Marek wrote: >> This patch fix several brace on next line, braces not necessary, space >> around =/<, and space before/after open/close parenthesis coding style >> errors find by checkpatch in pi433_if.c. >> >> Si