Re: [PATCHi v2] dt-bindings: add device tree binding for Arm TrustZone CryptoCell crypto engine

2017-11-28 Thread Herbert Xu
On Thu, Nov 16, 2017 at 06:15:28AM +, Gilad Ben-Yossef wrote: > The Arm TrustZone CryptoCell is a hardware security engine. This patch > adds DT bindings for its Rich Execution Environment crypto engine. > > A driver supporting this device is already present in the staging tree. > > Signed-of

Re: [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
On 11/28/2017 06:01 PM, Andrew Lunn wrote: On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

Re: [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread Andrew Lunn
On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote: > From: Carlos Munoz > > Add bindings for Common Ethernet Interface (BGX) block. > > Acked-by: Rob Herring > Signed-off-by: Carlos Munoz > Signed-off-by: Steven J. Hill > Signed-off-by: David Daney > --- > .../devicetree/bindings/

[PATCH v4 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-28 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52fd76..e9239ff3cf05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3249,6 +3249,12 @@ W: http://www.cavium.com S: Supported F: drivers/mmc/ho

[PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney --- .../devicetree/bindings/net/cavium-bgx.txt | 61 ++ 1 file changed, 61 insert

[PATCH v4 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-28 Thread David Daney
From: Carlos Munoz >From the hardware user manual: "The FPA is a unit that maintains pools of pointers to free L2/DRAM memory. To provide QoS, the pools are referenced indirectly through 1024 auras. Both core software and hardware units allocate and free pointers." Signed-off-by: Carlos Munoz S

[PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-28 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data to the I/O device and

[PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-28 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

[PATCH v4 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-28 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions addit

[PATCH v4 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-28 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c | 25 - drivers

[PATCH v4 0/8] Cavium OCTEON-III network driver.

2017-11-28 Thread David Daney
We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? The first six patches add the SoC support needed by the

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-28 Thread Dan Carpenter
On Tue, Nov 28, 2017 at 11:33:37PM +, Jeremy Sowden wrote: > On 2017-11-28, at 17:15:24 +0300, Dan Carpenter wrote: > > On Mon, Nov 27, 2017 at 12:44:48PM +, Jeremy Sowden wrote: > > > The "address" member of struct ia_css_host_data is a > > > pointer-to-char, so define default as NULL. > >

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-28 Thread Jeremy Sowden
On 2017-11-28, at 17:15:24 +0300, Dan Carpenter wrote: > On Mon, Nov 27, 2017 at 12:44:48PM +, Jeremy Sowden wrote: > > The "address" member of struct ia_css_host_data is a > > pointer-to-char, so define default as NULL. > > > > --- > > a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runt

Re: [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2017-11-28 Thread Deepa Dinamani
On Tue, Nov 28, 2017 at 6:17 AM, Arnd Bergmann wrote: > On Mon, Nov 27, 2017 at 11:29 PM, Deepa Dinamani > wrote: I decided against using LEGACY_TIME_SYSCALLS to conditionally compile legacy time syscalls such as sys_nanosleep because this will need to enclose compat_sys_nanosleep

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 05:37:53PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > > > I think it's reasonable to ask for userspace, I'm querying why it needs > > > to specifically be Android. >

[PATCH Resend] staging: media: lirc: style fix - replace hard-coded function names

2017-11-28 Thread Martin Homuth
This patch fixes the remaining coding style warnings in the lirc module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'read', this function's name, in a string Signe

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > I think it's reasonable to ask for userspace, I'm querying why it needs > > to specifically be Android. > Does anyone other than Android use this interface? There's plenty o

[PATCH] staging: pi433: pi433_if.c codestyle space prohibited

2017-11-28 Thread Oliver Graute
This patch fixes the following checkpatch.pl error: ERROR: space prohibited after that open parenthesis '(' #973: FILE: pi433_if.c:973: + if ( IS_ERR(device->gpiod[i]) ) ERROR: space prohibited after that open parenthesis '(' #19: FILE: drivers/staging/pi433/pi433_if.c:954: +

Re: [PATCH 1/2] vmbus: unregister device_obj->channels_kset

2017-11-28 Thread Stephen Hemminger
On Tue, 28 Nov 2017 16:56:05 +0100 Greg KH wrote: > On Tue, Nov 14, 2017 at 06:53:32AM -0700, k...@exchange.microsoft.com wrote: > > From: Dexuan Cui > > > > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") > > > > Without the patch, a device can't be thoroughly destroyed, because > >

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:08:22PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > > > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > > > call you added? What did you do to test t

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 06:08:22PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > call you added? What did you do to test this out? Where are the AOSP > > > patches to use this? Happen to hav

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > Where is the documentation for the new sysfs files and the new ioctl > > Didn't see any sysfs files in there? New struct devices were created and registered. Why would th

RE: [PATCH 2/2] vmbus: make hv_get_ringbuffer_availbytes local

2017-11-28 Thread Stephen Hemminger
This patch required a patch that is still going through net-next. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > Where is the documentation for the new sysfs files and the new ioctl Didn't see any sysfs files in there? > call you added? What did you do to test this out? Where are the AOSP > patches to use this? Happen to have a VTS test for it?

Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging

2017-11-28 Thread Andrew Lunn
On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: > diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dpmcp.h > rename to drivers/bus/fsl-mc/dpmcp.h > diff --git a/drivers/staging/fsl-

RE: [PATCH 2/2] vmbus: make hv_get_ringbuffer_availbytes local

2017-11-28 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, November 28, 2017 7:35 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; lean

Re: [PATCH 1/2] vmbus: unregister device_obj->channels_kset

2017-11-28 Thread Greg KH
On Tue, Nov 14, 2017 at 06:53:32AM -0700, k...@exchange.microsoft.com wrote: > From: Dexuan Cui > > Fixes: c2e5df616e1a ("vmbus: add per-channel sysfs info") > > Without the patch, a device can't be thoroughly destroyed, because > vmbus_device_register() -> kset_create_and_add() still holds a re

Re: [PATCH 2/2] vmbus: make hv_get_ringbuffer_availbytes local

2017-11-28 Thread Greg KH
On Tue, Nov 14, 2017 at 10:52:08AM -0700, k...@exchange.microsoft.com wrote: > From: Stephen Hemminger > > hv_get_ringbuffer_availbytes is only used by the debug info > routine so make it static. Also, add READ_ONCE() to avoid any > possible issues with potentially volatile index values. > > Sig

Re: [PATCH 1/2] Drivers: hv: vmbus: Remove x86-isms from arch independent drivers

2017-11-28 Thread Greg KH
On Tue, Nov 14, 2017 at 10:52:07AM -0700, k...@exchange.microsoft.com wrote: > From: Michael Kelley > > hv_is_hypercall_page_setup() is used to check if Hyper-V is > initialized, but a 'hypercall page' is an x86 implementation detail > that isn't necessarily present on other architectures. Rename

[PATCH v3] staging: fsl-mc: move bus driver out of staging

2017-11-28 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

Re: [PATCH] staging: lustre: Fix line over 80 characters

2017-11-28 Thread Dan Carpenter
On Tue, Nov 28, 2017 at 03:18:59PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 05:13:55PM +0300, Dan Carpenter wrote: > > On Mon, Nov 27, 2017 at 03:36:58PM +0200, Talat Batheesh wrote: > > > This patch fix the line over 80 characters warning that was detected > > > using checkpatch.pl script.

Re: [PATCH] staging: lustre: Fix line over 80 characters

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 05:13:55PM +0300, Dan Carpenter wrote: > On Mon, Nov 27, 2017 at 03:36:58PM +0200, Talat Batheesh wrote: > > This patch fix the line over 80 characters warning that was detected > > using checkpatch.pl script. > > > > Signed-off-by: Talat Batheesh > > --- > > drivers/stag

Re: [PATCH v2 00/10] posix_clocks: Prepare syscalls for 64 bit time_t conversion

2017-11-28 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 11:29 PM, Deepa Dinamani wrote: >>> I decided against using LEGACY_TIME_SYSCALLS to conditionally compile >>> legacy time syscalls such as sys_nanosleep because this will need to >>> enclose compat_sys_nanosleep as well. So, defining it as >>> >>> config LEGACY_TIME_SYSCALL

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-28 Thread Dan Carpenter
On Mon, Nov 27, 2017 at 12:44:48PM +, Jeremy Sowden wrote: > The "address" member of struct ia_css_host_data is a pointer-to-char, so > define default as NULL. > > Signed-off-by: Jeremy Sowden > --- > .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h| 2 > +- > 1 fil

Re: [PATCH] staging: lustre: Fix line over 80 characters

2017-11-28 Thread Dan Carpenter
On Mon, Nov 27, 2017 at 03:36:58PM +0200, Talat Batheesh wrote: > This patch fix the line over 80 characters warning that was detected > using checkpatch.pl script. > > Signed-off-by: Talat Batheesh > --- > drivers/staging/lustre/lustre/obdclass/class_obd.c | 3 ++- > 1 file changed, 2 insertion

Re: [PATCH] staging: fsl-mc: fix uninitialized variable use

2017-11-28 Thread Dan Carpenter
On Mon, Nov 27, 2017 at 09:31:21AM +, Laurentiu Tudor wrote: > I did but it didn't show up on my version of powerpc toolchain (gcc > 4.8.1). Maybe it's too old ... > Smatch has new uninitialized variable warnings these days. In theory, it should be smarter and more strict than GCC. regards

Re: [bug report] staging: lustre: remove unnecessary NULL checks in kernel_comm.c

2017-11-28 Thread Dan Carpenter
Sorry for the bad subject line. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: unisys: visorbus: address theoretical int overflows

2017-11-28 Thread Dan Carpenter
> --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > @@ -581,7 +581,8 @@ static void *parser_name_get(struct parser_context *ctx) > struct visor_controlvm_parameters_header *phdr; > > phdr = &ctx->data; > - if (phdr->name_

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-28 Thread Laurentiu Tudor
On 11/28/2017 02:59 PM, Greg KH wrote: > On Mon, Nov 27, 2017 at 03:32:28PM +, Laurentiu Tudor wrote: >> >> >> On 11/03/2017 05:17 PM, Greg KH wrote: >>> On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote:

Re: [PATCH v2] Staging: sm750fb: Fix coding style issue in ddk750_sii164.c

2017-11-28 Thread Jeremy Lacomis
On Tue, Nov 28, 2017 at 02:14:11PM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 25, 2017 at 08:04:52PM -0500, Jeremy Lacomis wrote: > > This is a patch to the ddk750_sii164.c file that fixes line length warnings > > found by the checkpatch.pl script > > That's not all this patch did :( > Sorry

Re: [PATCH v2] staging: sm750b: Fix coding style issues in sm750_accel.c

2017-11-28 Thread Jeremy Lacomis
On Tue, Nov 28, 2017 at 02:13:31PM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 25, 2017 at 05:48:11PM -0500, Jeremy Lacomis wrote: > > This is a patch to sm750_accel.c that fixes 80-character line length > > warnings found by checkpatch.pl. It also fixes some grammatical errors > > in comments a

[bug report] staging: lustre: remove unnecessary NULL checks in kernel_comm.c

2017-11-28 Thread Dan Carpenter
Hi Lustre devs, Smatch generates this warning: drivers/staging/lustre/lustre/obdclass/kernelcomm.c:146 libcfs_kkuc_group_rem() error: buffer overflow 'kkuc_groups' 3 <= u32max drivers/staging/lustre/lustre/obdclass/kernelcomm.c 142 int libcfs_kkuc_group_rem(int uid, unsigned

Re: [PATCH v6 1/2] staging: ion: reorder include

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 02:34:00PM +0100, Benjamin Gaignard wrote: > 2017-11-28 14:20 GMT+01:00 Greg KH : > > On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: > >> Put include in alphabetic order > > > > Why??? > > Mainly because the next patch in the series adds new includes and

Re: [PATCH v6 1/2] staging: ion: reorder include

2017-11-28 Thread Benjamin Gaignard
2017-11-28 14:20 GMT+01:00 Greg KH : > On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: >> Put include in alphabetic order > > Why??? Mainly because the next patch in the series adds new includes and I have decide to split clean-up and new feature patches > > That should not mat

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones

Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse

2017-11-28 Thread Andrii
On 11/28/2017 3:05 PM, Greg KH wrote: On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote: Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in irlan_seq_stop() for sparse Signed-off-by: Andrii Vladyka https://e.mail.ru/compose?To=tu...@mail.ru>> Something went really

Re: [PATCH 0/4] hv_balloon: fixes for num_pages_onlined accounting and misc improvements

2017-11-28 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > While doing routing code review I noticed that commit 6df8d9aaf3af > ("Drivers: hv: balloon: Correctly update onlined page count") introduced > an issue with num_pages_onlined accounting on memory offlining. Deeper look > showed that the accounting was always buggy. Thi

Re: [PATCH 4/4] staging: most: Remove a attribute group from a kobject

2017-11-28 Thread Greg KH
On Sat, Nov 25, 2017 at 12:09:31PM +0530, Arvind Yadav wrote: > All attribute group created during dim2_sysfs_probe() should be removed > in dim2_sysfs_destroy(). > > Signed-off-by: Arvind Yadav > --- > drivers/staging/most/hdm-dim2/dim2_sysfs.c | 1 + This file is not in the tree anymore. _

Re: [PATCH v6 1/2] staging: ion: reorder include

2017-11-28 Thread Greg KH
On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: > Put include in alphabetic order Why??? That should not matter at all. I'll take this, but really, ick ick ick ick ick. ___ devel mailing list de...@linuxdriverproject.org http://driv

Re: [PATCH] staging/media: lirc: style fix - replace hard-coded function names

2017-11-28 Thread Greg KH
On Sun, Nov 26, 2017 at 08:49:42PM +0100, Martin Homuth wrote: > This patch fixes the remaining coding style warnings in the lirc module. > > It fixes the following checkpatch.pl warning: > > WARNING: Prefer using '"%s...", __func__' to using 'read', this > function's name, in a string > >From f

Re: [PATCH V2] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID

2017-11-28 Thread Greg KH
On Sat, Nov 25, 2017 at 01:32:38PM -0600, Larry Finger wrote: > When not associated with an AP, wifi device drivers should respond to the > SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the > behavior expected by dhcpcd. > > Currently, this driver returns an error code (-1) f

Re: [PATCH] staging: rtl8188eu:

2017-11-28 Thread Greg KH
On Sat, Nov 25, 2017 at 11:59:51AM -0600, Larry Finger wrote: > When not associated with an AP, wifi device drivers should respond to the > SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the > behavior expected by dhcpcd. > > Currently, this driver returns an error code (-1) f

Re: [PATCH v2] Staging: sm750fb: Fix coding style issue in ddk750_sii164.c

2017-11-28 Thread Greg Kroah-Hartman
On Sat, Nov 25, 2017 at 08:04:52PM -0500, Jeremy Lacomis wrote: > This is a patch to the ddk750_sii164.c file that fixes line length warnings > found by the checkpatch.pl script That's not all this patch did :( ___ devel mailing list de...@linuxdriverpr

Re: [PATCH v2] staging: sm750b: Fix coding style issues in sm750_accel.c

2017-11-28 Thread Greg Kroah-Hartman
On Sat, Nov 25, 2017 at 05:48:11PM -0500, Jeremy Lacomis wrote: > This is a patch to sm750_accel.c that fixes 80-character line length > warnings found by checkpatch.pl. It also fixes some grammatical errors > in comments and moves parameter-specific comments from inline to before > the function. >

Re: [PATCH 0/6] staging: pi433: pi433_if.c: coding style fixes

2017-11-28 Thread Greg KH
On Wed, Nov 15, 2017 at 04:35:47PM -0800, Chase Metzger wrote: > Fixes some of the coding style violations to comply with the kernel > coding style. > > Chase Metzger (6): > staging: pi433: pi433_if.c: fix opening curly brace coding style > issues > staging: pi433: pi433_if.c: fix else if/

Re: [PATCH 4/6] staging: pi433: pi433_if.c: fix space prohibited coding style issues

2017-11-28 Thread Greg KH
On Wed, Nov 15, 2017 at 04:35:51PM -0800, Chase Metzger wrote: > Remove unnecessary spaces before and after parenthesis' to comply > with the kernel coding style. > > Signed-off-by: Chase Metzger > --- > drivers/staging/pi433/pi433_if.c | 34 +- > 1 file changed,

Re: [PATCH 1/6] staging: pi433: pi433_if.c: fix opening curly brace coding style issues

2017-11-28 Thread Greg KH
On Wed, Nov 15, 2017 at 04:35:48PM -0800, Chase Metzger wrote: > Put opening curly braces for if/else/else if statements and for/while loops > on the same line as the statements or loops to comply with the kernel > coding style. > > Signed-off-by: Chase Metzger > --- > drivers/staging/pi433/pi43

Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote: > Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in > irlan_seq_stop() for sparse > > Signed-off-by: Andrii Vladyka > Something went really wrong here with your email addr

Re: [PATCH] staging: pi433: pi433_if.c: fix if/else if and brace coding style issues

2017-11-28 Thread Greg KH
On Tue, Nov 14, 2017 at 12:03:51PM -0800, Chase Metzger wrote: > Fix if/else if and braces in function DIO0_irq_handler to comply with > the kernel coding style. > > Signed-off-by: Chase Metzger > --- > drivers/staging/pi433/pi433_if.c | 11 +++ > 1 file changed, 3 insertions(+), 8 delet

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-28 Thread Greg KH
On Mon, Nov 27, 2017 at 03:32:28PM +, Laurentiu Tudor wrote: > > > On 11/03/2017 05:17 PM, Greg KH wrote: > > On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: > >> On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote: > >>> From: Stuart Yoder > >>> > >>> Move the s

Re: [PATCH 1/2] staging: sm750fb: Fix coding style in ddk750_sii164.h

2017-11-28 Thread Greg KH
On Mon, Nov 27, 2017 at 09:37:27AM -0500, Jeremy Lacomis wrote: > On Mon, Nov 27, 2017 at 11:45:00AM +0100, Geert Uytterhoeven wrote: > > On Mon, Nov 27, 2017 at 10:46 AM, Dan Carpenter > > wrote: > > > On Sat, Nov 25, 2017 at 01:26:35PM -0500, Jeremy Lacomis wrote: > > >> This patch to ddk750_sii

[PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse

2017-11-28 Thread Andrii Vladyka
Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in irlan_seq_stop() for sparse Signed-off-by: Andrii Vladyka > diff --git a/drivers/staging/irda/net/irlan/irlan_common.c b/drivers/staging/irda/net/irlan/irlan_common.c index fdcd714..

Re: [PATCH] staging: most: Fix build errors

2017-11-28 Thread Greg Kroah-Hartman
On Tue, Nov 28, 2017 at 12:12:47PM +, Chris Coffey wrote: > On Tue, Nov 28, 2017 at 08:26:07AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 27, 2017 at 09:12:39PM +, Chris Coffey wrote: > > > This patch fixes build errors that occur when trying to build the > > > MOST modules. For examp

Re: [PATCH] staging: most: Fix build errors

2017-11-28 Thread Chris Coffey
On Tue, Nov 28, 2017 at 08:26:07AM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 27, 2017 at 09:12:39PM +, Chris Coffey wrote: > > This patch fixes build errors that occur when trying to build the > > MOST modules. For example, the cdev module build fails with: > > > > make[3]: *** No rule to

[PATCH v3 2/2] media: staging: atomisp: fixes for "symbol was not declared. Should it be static?" sparse warnings.

2017-11-28 Thread Jeremy Sowden
Defined some const arrays as static since they don't need external linkage. Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2

[PATCH v3 1/2] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-28 Thread Jeremy Sowden
The "address" member of struct ia_css_host_data is a pointer-to-char, so define default as NULL. Signed-off-by: Jeremy Sowden --- .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/at

[PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver

2017-11-28 Thread Jeremy Sowden
Fixed some sparse warnings in the Atom ISP staging driver. This time with longer commit messages. :) I've chosen to ignore checkpatch.pl's suggestion to change the types of the arrays in the second patch from int16_t to s16. Jeremy Sowden (2): media: staging: atomisp: fix for sparse "using pla

Re: [PATCH v3] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-28 Thread kbuild test robot
://github.com/0day-ci/linux/commits/ishraq-i-ashraf-gmail-com/staging-rtl8188eu-Fix-private-WEXT-IOCTL-calls/20171128-130403 coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3379:36-43: WARNING: kzalloc >> should be used for pwep, instead

[PATCH] staging: rtl8188eu: fix kzalloc-simple.cocci warnings

2017-11-28 Thread kbuild test robot
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3379:36-43: WARNING: kzalloc should be used for pwep, instead of kmalloc/memset Use kzalloc rather than kmalloc followed by memset with 0 This considers some simple cases that are common and easy to validate Note in particular that there are no