drivers/staging/unisys/visorbus/visorchipset.c
588 static void *parser_name_get(struct parser_context *ctx)
589 {
590 struct visor_controlvm_parameters_header *phdr;
591
592 phdr = &ctx->data;
593 if (phdr->name_offset + phdr->name_length > ctx->par
This driver really needs proper structs and datatypes so this doesn't
happen again and so that you and Colin stop reverting each other's
*pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 8) & 0xFF);
assignments:
regards,
dan carpenter
___
devel
> -Original Message-
> From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net]
> Sent: Friday, November 3, 2017 3:50 PM
> To: de...@driverdev.osuosl.org; *S-Par-Maintainer
> ; Thompson, Bryan E.
> ; Binder, David Anthony
> ; Kershner, David A
> ; Greg Kroah-Hartman
> ; Sameer Wadgaon
Hi Michael,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/master]
url:
https://github.com/0day-ci/linux/commits/mikelley-exchange-microsoft-com/Drivers-hv-vmbus-Implement-Direct-Mode-for-stimer0/20171103-214519
config: x86_64-randconfig-h0
From: Michael Kelley
hv_is_hypercall_page_setup() is used to check if Hyper-V is
initialized, but a 'hypercall page' is an x86 implementation detail
that isn't necessarily present on other architectures. Rename to the
architecture independent hv_is_hyperv_initialized() and add check
that x86_hype
On Fri, Nov 3, 2017 at 2:49 PM, Bryan O'Donoghue
wrote:
>
>
> On 03/11/17 20:21, Kees Cook wrote:
>>
>> On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote:
>>>
>>> On Mon, Oct 30, 2017 at 5:01 PM, wrote:
There's a separate change to loopback.c an old patch ARAIR that will
subtract
On 03/11/17 20:21, Kees Cook wrote:
On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote:
On Mon, Oct 30, 2017 at 5:01 PM, wrote:
There's a separate change to loopback.c an old patch ARAIR that will subtract
use of the timer from loopback.c so you can skip that bit.
Okay, cool. Since the op
Commit 46949b48568b ("staging: wilc1000: New cfg packet
format in handle_set_wfi_drv_handler") updated the frame
format sent from host to the firmware. The code to update
the bssid offset in the new frame was part of a second
patch in the series which did not make it in and thus
causes connection p
On Mon, Oct 30, 2017 at 5:05 PM, Kees Cook wrote:
> On Mon, Oct 30, 2017 at 5:01 PM, wrote:
>> There's a separate change to loopback.c an old patch ARAIR that will
>> subtract use of the timer from loopback.c so you can skip that bit.
>
> Okay, cool. Since the operation.c change is trivial, I'l
From: Markus Elfring
Date: Fri, 3 Nov 2017 20:37:03 +0100
* Add a jump target so that a specific error message is stored only once
at the end of this function implementation.
* Replace four calls of the function "dev_err" by goto statements.
This issue was detected by using the Coccinelle sof
From: Markus Elfring
Date: Fri, 3 Nov 2017 20:02:22 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace two calls by goto statements.
This issue was detected by using the Coccinelle software.
Signed-off-by: M
> FYI, you are responding to someone who is on my blacklist
I am curious if this communication setting will ever be adjusted.
> and I never accept patches from.
The history shows that our collaboration style changed over time.
I got a few update suggestions integrated (also by you) because
othe
>> @@ -838,6 +834,10 @@ static int usbduxfast_ai_insn_read(struct comedi_device
>> *dev,
>> mutex_unlock(&devpriv->mut);
>> return insn->n;
>
> Minor niggle: You could also remove that call to mutex_unlock() by replacing
> the above three lines with:
>
> ret = insn->n;
>
> wh
Cathy,
> When running multipath on a VM if all available paths go down the
> driver can schedule large amounts of storvsc_remove_lun work items to
> the same lun. In response to the failing paths typically storvsc
> responds by taking host->scan_mutex and issuing a TUR per lun. If
> there has bee
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on char-misc/master]
url:
https://github.com/0day-ci/linux/commits/mikelley-exchange-microsoft-com/Drivers-hv-vmbus-Implement-Direct-Mode-for-stimer0/20171103-214519
config: x86_64-rhel (attached as
Hi Greg,
On 11/03/2017 05:17 PM, Greg KH wrote:
> On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote:
>> On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote:
>>> From: Stuart Yoder
>>>
>>> Move the source files out of staging into their final locations:
>>>-include fi
On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote:
> On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote:
> > From: Stuart Yoder
> >
> > Move the source files out of staging into their final locations:
> > -include files in drivers/staging/fsl-mc/include go to include/
On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote:
> On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote:
> > Hey Greg, we think the code for visorbus is ready to be moved out
> > of staging, can you review it to see if we have missed anything?
>
> I think yo
A caller should never care about a debugfs error return value, and it
should never abort its normal operation if something "odd" goes on. Fix
up the unisys init code to not care if the root debugfs directory for
the subsystem is created or not, as no place it is used will matter.
Cc: David Kershn
On Fri, Nov 03, 2017 at 02:00:18PM +, Ian Abbott wrote:
> On 02/11/17 19:40, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Thu, 2 Nov 2017 20:30:31 +0100
> >
> > * Add a jump target so that a call of the function "mutex_unlock" is stored
> >only twice in this function implem
On 02/11/17 20:23, SF Markus Elfring wrote:
From: Markus Elfring
Date: Thu, 2 Nov 2017 21:16:50 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in these function implementations.
* Replace seven calls by goto statements.
This issue was detected
On 02/11/17 19:40, SF Markus Elfring wrote:
From: Markus Elfring
Date: Thu, 2 Nov 2017 20:30:31 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace five calls by goto statements.
This issue was detected by
From: Colin Ian King
The pointer buf is being set on each iteration of a for-loop and
so the initialization of buf at declaration time is redundant and
can be removed. Cleans up clang warning:
drivers/staging/fbtft/fb_uc1701.c:130:6: warning: Value stored
to 'buf' during its initialization is n
On Fri, Nov 03, 2017 at 12:46:18PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Oct 29, 2017 at 08:58:39PM +0300, Roman Storozhenko wrote:
> > There are two reasons for that:
> > 1) As Linus Torvalds said we should use kernel types:
> > http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
> >
Makefiles usually come with 'install' target included so each distro
doesn't need to implement the procedure from scratch. Add it to tools/hv.
Signed-off-by: Vitaly Kuznetsov
---
tools/hv/Makefile | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/tools/h
On Sun, Oct 29, 2017 at 08:58:39PM +0300, Roman Storozhenko wrote:
> There are two reasons for that:
> 1) As Linus Torvalds said we should use kernel types:
> http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
>
> 2) There are only few places in the lustre codebase that use such types.
>
On 02-11-17, 15:32, Arnd Bergmann wrote:
> As of commit 8e1d6c336d74 ("greybus: loopback: drop bus aggregate
> calculation"), nothing ever reads from kfifo_ts, so there is no
> reason to write to it or even allocate it any more.
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/staging/greybus/lo
On 02/11/17 14:32, Arnd Bergmann wrote:
This driver is the only one using the deprecated timeval_to_ns()
helper. Changing it from do_gettimeofday() to ktime_get() makes
the code more efficient, more robust against concurrent
settimeofday(), more accurate and lets us get rid of that helper
in the
On 02/11/17 14:32, Arnd Bergmann wrote:
As of commit 8e1d6c336d74 ("greybus: loopback: drop bus aggregate
calculation"), nothing ever reads from kfifo_ts, so there is no
reason to write to it or even allocate it any more.
Signed-off-by: Arnd Bergmann
---
drivers/staging/greybus/loopback.c | 2
From: Markus Elfring
Date: Fri, 3 Nov 2017 10:45:31 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/media/davinci_vpfe/vpfe
From: Markus Elfring
Date: Fri, 3 Nov 2017 09:26:28 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace two calls by goto statements.
This issue was detected by using the Coccinelle software.
Signed-off-by: M
From: Markus Elfring
Date: Fri, 3 Nov 2017 09:00:25 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace two calls by goto statements.
This issue was detected by using the Coccinelle software.
Signed-off-by: M
32 matches
Mail list logo
