On Tue, Sep 12, 2017 at 2:40 AM, Liam Ryan wrote:
> Fix checkpath-reported unbalanced braces in the following areas
>
> 221: FILE: drivers/staging/rtl8712/hal_init.c:221:
> 392: FILE: drivers/staging/rtl8712/os_intfs.c:392:
> 363: FILE: drivers/staging/rtl8712/rtl8712_cmd.c:363:
> 889: FILE: drive
On Tue, Sep 12, 2017 at 10:49 PM, Greg KH wrote:
> On Tue, Sep 12, 2017 at 01:40:15AM +0100, Liam Ryan wrote:
>> Fix checkpath-reported unbalanced braces in the following areas
>>
>> 221: FILE: drivers/staging/rtl8712/hal_init.c:221:
>> 392: FILE: drivers/staging/rtl8712/os_intfs.c:392:
>> 363: FI
On Tue, 12 Sep 2017, Haneen Mohammed wrote:
> This patch replace pr_debug with netdev_dbg when appropriate net_device
> structure is found.
> Issue found using the following Coccinelle script:
>
> @r exists@
> identifier f, s, i;
> position p;
> @@
>
> f(...,struct s *i,...) {
> <+... when != i
This patch replace pr_debug with netdev_dbg when appropriate net_device
structure is found.
Issue found using the following Coccinelle script:
@r exists@
identifier f, s, i;
position p;
@@
f(...,struct s *i,...) {
<+... when != i == NULL
(
pr_err@p(...);
|
pr_info@p(...);
|
pr_debug@p(...);
)
...
On Tue, Sep 05, 2017 at 06:42:20PM +0200, Hans de Goede wrote:
> Add mux support to the fusb302 driver, call devm_tcpc_gen_mux_create()
> to let the generic tcpc_mux_dev code create a tcpc_mux_dev for us.
>
> Also document the mux-names used by the generic tcpc_mux_dev code in
> our devicetree bin
On Tue, Sep 12, 2017 at 01:40:15AM +0100, Liam Ryan wrote:
> Fix checkpath-reported unbalanced braces in the following areas
>
> 221: FILE: drivers/staging/rtl8712/hal_init.c:221:
> 392: FILE: drivers/staging/rtl8712/os_intfs.c:392:
> 363: FILE: drivers/staging/rtl8712/rtl8712_cmd.c:363:
> 889: FI
On Fri, Sep 08, 2017 at 11:21:25PM +0530, Harsha Sharma wrote:
> Make code more concise and readable
>
> Signed-off-by: Harsha Sharma
> ---
> Change in v3:
> -Change in subject and log message
> Change in v2:
> -Change in subject
> -Change in log message
> drivers/staging/typec/tcpm.c | 2 +
On Tue, Sep 12, 2017 at 07:05:23PM +0530, Harsha Sharma wrote:
> Space required after ','
>
> Signed-off-by: Harsha Sharma
> ---
> Changes in v2:
> -Rebase against staging-testing and solve merge conflicts
>
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
> 1 file changed, 6 i
On Mon, Sep 11, 2017 at 10:37:05PM +0200, ArminSchoenlieb wrote:
> From: Armin Schoenlieb
>
> This is a patch to the irqueue.h file that fixes up pointer style errors and
> trailing whitespace errors, found by the checkpatch.pl tool
>
> Signed-off-by: Armin Schoenlieb
> ---
> drivers/staging/i
This patch convert printk() to the preferred variant dev_dbg() and
remove unnecessary comment line.
Issue detected with checkpatch.pl.
Signed-off-by: Haneen Mohammed
---
drivers/staging/pi433/pi433_if.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/
Okay. This way with each commit the version can compile and I will
be able to define the subsystem appropriately. Thank you for the
clarification Lars.
On Tue, Sep 12, 2017 at 08:14:18PM +0200, Lars-Peter Clausen wrote:
> On 09/12/2017 08:06 PM, Julia Lawall wrote:
> >
> >
> > On Tue, 12 Sep 20
On 09/12/2017 08:06 PM, Julia Lawall wrote:
>
>
> On Tue, 12 Sep 2017, himanshi wrote:
>
>> Thanks for the review Daniel! I will change the imperative mood for the
>> commit
>> message once the other changes are finalised too and as suggested by Julia,
>> would try to make the description speci
On 09/12/2017 09:53 AM, Daniel Baluta wrote:
> Hi Himanshi,
>
> On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain
> wrote:
>> Fixed IIO_DEVICE_ATTR_NAMED API to take name as a
>> string instead of implicit conversion to string using
>> preprocessors. Added double quotes around names in
>> existing
On Tue, 12 Sep 2017, himanshi wrote:
> Thanks for the review Daniel! I will change the imperative mood for the commit
> message once the other changes are finalised too and as suggested by Julia,
> would try to make the description specific than general.
>
> I tried to think of adding subsystem
Thanks for the review Daniel! I will change the imperative mood for the commit
message once the other changes are finalised too and as suggested by Julia,
would try to make the description specific than general.
I tried to think of adding subsystem to the commit subject but could not
conclude an
On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote:
> On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote:
> > Commented out code can be added as needed. Drop it.
> > Also drop TODO and an obsolete XXX comment.
> >
> > Signed-off-by: Guenter Roeck
> > ---
> > v2, v3: No cha
On Tue, 12 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and the return statements to return the value
> directly. Done using the following semantic patch by coccinelle.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by
Merge the assignment and the return statements to return the value
directly. Done using the following semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
drivers/staging/media/atomisp/pci/atomisp2/hmm/h
On Tue, 12 Sep 2017, Srishti Sharma wrote:
> Merge the assignment and the return statements to return the value
> directly. Done using the following semantic patch by coccinelle.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by
Merge the assignment and the return statements to return the value
directly. Done using the following semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
---
drivers/staging/media/atomisp/i2c/ov5693/ov5693.
Space required after ','
Signed-off-by: Harsha Sharma
---
Changes in v2:
-Rebase against staging-testing and solve merge conflicts
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_in
On Tue, 12 Sep 2017, Harsha Sharma wrote:
> Space between function name and open parentheses '(' is prohibited.
> Space is required around most binary operators '=', '==', '+=',
> '<', ':', '+', '-'
> Space required before '&', '*'
> Space is required after ',', ';'
>
> Signed-off-by: Harsha Sha
Space between function name and open parentheses '(' is prohibited.
Space is required around most binary operators '=', '==', '+=',
'<', ':', '+', '-'
Space required before '&', '*'
Space is required after ',', ';'
Signed-off-by: Harsha Sharma
---
drivers/staging/rtl8723bs/os_dep/mlme_linux.c |
On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>> drivers/staging/ccree/ssi_request_mgr.c | 2 +-
>> 1 file cha
Remove space between function name and open parenthesis '('
Remove space before ';', '++', ','
Signed-off-by: Harsha Sharma
---
Change in v3:
-Fix small spelling mistake
Change in v2:
-Merge patches 07/10 and 08/10
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file changed,
It'sa small detail, but perhaps you could fix the spelling of unnecessary
(1 c and 2 s's).
julia
On Tue, 12 Sep 2017, Harsha Sharma wrote:
> Remove space between function name and open parenthesis '('
> Remove space before ';', '++', ','
>
> Signed-off-by: Harsha Sharma
> ---
> Change in v2:
>
Remove space between function name and open parenthesis '('
Remove space before ';', '++', ','
Signed-off-by: Harsha Sharma
---
Change in v2:
-Merge patches 07/10 and 08/10
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --gi
On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
> The use of volatile for the variable monitor_lock is unnecessary.
>
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/ssi_request_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/
Seems correct.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, 12 Sep 2017, Daniel Baluta wrote:
> Hi Himanshi,
>
> On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain
> wrote:
> > Fixed IIO_DEVICE_ATTR_NAMED API to take name as a
> > string instead of implicit conversion to string using
> > preprocessors. Added double quotes around names in
> > existi
Hi Himanshi,
On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain wrote:
> Fixed IIO_DEVICE_ATTR_NAMED API to take name as a
> string instead of implicit conversion to string using
> preprocessors. Added double quotes around names in
> existing usage of IIO_DEVICE_ATTR_NAMED.
Always use imperative moo
On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote:
> Commented out code can be added as needed. Drop it.
> Also drop TODO and an obsolete XXX comment.
>
> Signed-off-by: Guenter Roeck
> ---
> v2, v3: No change
>
> drivers/staging/typec/tcpm.c | 37 +--
32 matches
Mail list logo
