Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

On Tue, 2017-08-15 at 09:26 +0300, Gilad Ben-Yossef wrote: > Fix wrong indentation and line breaks, including missing tabs, > breaking lines longer then 80 char or wrongly broken. [] > diff --git a/drivers/staging/ccree/ssi_driver.c > b/drivers/staging/ccree/ssi_driver.c [] > -

[PATCH v3 18/22] staging: ccree: move over to BIT macro for bit defines

Use BIT macro for bit definitions where needed. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.h | 10 +- drivers/staging/ccree/ssi_driver.c | 3 ++- drivers/staging/ccree/ssi_driver.h | 6 +++--- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/dri

[PATCH v3 21/22] staging: ccree: save ciphertext for CTS IV

The crypto API requires saving the last blocks of ciphertext in req->info for use as IV for CTS mode. The ccree driver was not doing it and so failing tcrypt tests in some situations. This patch fixes the issue. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 31

[PATCH v3 22/22] staging: ccree: remove BUG macro usage

Replace BUG() macro usage that crash the kernel with alternatives that signal error and/or try to recover. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 14 ++ drivers/staging/ccree/ssi_cipher.c | 1 - drivers/staging/ccree/ssi_pm.c | 3

[PATCH v3 20/22] staging: ccree: replace noop macro with inline

Replace noop macro with a noop inline function Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h index 0b9c7e6..063a1cc 100644 ---

[PATCH v3 14/22] staging: ccree: fix struct init braces

Put struct init braces on line of it's own. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c index e2dc5d8

[PATCH v3 17/22] staging: ccree: clean up comments

Clean up comments: fix style, trim long lines and remove useless ones. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 40 + drivers/staging/ccree/ssi_aead.h| 47 ++--- drivers/staging/ccree/ssi_buffer_mgr.c |

[PATCH v3 15/22] staging: ccree: fix line indentation and breaks

Fix source line indentation and breaks in ssi_aead.c Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 1024 -- 1 file changed, 532 insertions(+), 492 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_

[PATCH v3 13/22] staging: ccree: fix line indentation and breaks

Fix source line indentation and breaks Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c | 494 ++- 1 file changed, 284 insertions(+), 210 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c index b

[PATCH v3 19/22] staging: ccree: fix code indent

Fix multiple code indentation issues. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 23 --- drivers/staging/ccree/ssi_cipher.c | 2 +- drivers/staging/ccree/ssi_sysfs.c | 4 +++- 3 files changed, 16 insertions(+), 13 deletions(-) dif

[PATCH v3 11/22] staging: ccree: fix line indentation and breaks

Fix wrong indentation and line breaks, including missing tabs, breaking lines longer then 80 char or wrongly broken. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 107 +++-- 1 file changed, 67 insertions(+), 40 deletions(-) diff --git a

[PATCH v3 12/22] staging: ccree: align box comment correctly

Fix indentation in first comment. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_hash.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c index b7d6586..b95c3ce 100

[PATCH v3 06/22] staging: ccree: simplify resource release on error

The resource release on probe/init error was being handled in an awkward manner and possibly leaking memory on certain (unlikely) error path. Fix it by simplifying the error resource release and making it easier to track. Reported-by: Dan Carpenter Signed-off-by: Gilad Ben-Yossef --- drivers/s

[PATCH v3 16/22] staging: ccree: fix spelling mistakes

Fix various spelling mistakes in comments. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 2 +- drivers/staging/ccree/ssi_hash.c| 2 +- drivers/staging/ccree/ssi_hash.h| 2 +- drivers/staging/ccree/ssi_ivgen.c | 2 +- drivers/staging/ccree/ssi

[PATCH v3 07/22] staging: ccree: remove unused completion

icache_setup_completion is no longer used. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 2 -- drivers/staging/ccree/ssi_driver.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c in

[PATCH v3 08/22] staging: ccree: remove m32r as supported platform

M32R requires special handling due due to how it has implemented ioread32. It is also an orphaned arch on Linux and doesn't seem to be worth the trouble. So until we have a real user, remove support for it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig | 2 +- 1 file changed,

[PATCH v3 09/22] staging: ccree: Fix format/argument mismatches

From: Joe Perches By default, debug logging is disabled by CC_DEBUG not being defined. Convert SSI_LOG_DEBUG to use no_printk instead of an empty define to validate formats and arguments. Fix fallout. Miscellanea: o One of the conversions now uses %pR instead of multiple uses of %pad Signed-

[PATCH v3 10/22] staging: ccree: rewrite GET_DMA_BUFFER_TYPE as func

The GET_DMA_BUFFER_TYPE macro was triggering a macro argument reuse warning from checkpatch. Rewrite the macro as inline function instead to avoid risk of unintended side effects. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 26 +- drivers/

[PATCH v3 05/22] staging: ccree: Use platform_get_irq and devm_request_irq

From: Suniel Mahesh It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with platform_get_irq() and devm_request_irq(

[PATCH v3 04/22] staging: ccree: Convert to devm_ioremap_resource for map, unmap

From: Suniel Mahesh It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with devm_ioremap_resource(). (b) remove struct

[PATCH v3 03/22] staging: ccree: Replace kzalloc with devm_kzalloc

From: Suniel Mahesh It is recommended to use managed function devm_kzalloc, which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace kzalloc with devm_kzalloc. (b) drop kfree(), because memory allocated with devm_kzalloc() is automatically freed on driver

[PATCH v3 02/22] staging: ccree: kmalloc by sizeof var not type

Change places where we alloc memory by sizeof type to sizeof var. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 4 ++-- drivers/staging/ccree/ssi_cipher.c | 4 ++-- drivers/staging/ccree/ssi_driver.c | 2 +- drivers/staging/ccree/ssi_hash.c| 4 ++

[PATCH v3 01/22] staging: ccree: fix split strings

Fix strings in log messages being split across lines and the resulting alignment issues when being fixed. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 9 ++-- drivers/staging/ccree/ssi_buffer_mgr.c | 86 ++--- drivers/staging/ccree/s

[PATCH v3 00/22] staging: ccree: fixes and simplifications

The series includes various bug fixes, code simplification and style cleanups. Changer from v2: - Drop M32R as supported architecture, which resolve the kbuild bot warnings on Joe Perches patch. - Bug fix that properly saves last bytes of ciphertext for CTS in skcipher - Even more coding styl

[PATCH v2] staging: pi433: replace logical not with bitwise

sparse reports the following warning "warning: dubious: x & !y". Replaced te logical not with bitwise to resolve the warning Signed-off-by: Quentin Swain --- drivers/staging/pi433/rf69.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/s

Re: [PATCH] staging: pi433: Fix warnings from sparse

On Sat, Aug 12, 2017 at 10:39:41AM -0400, Quentin Swain wrote: > Running sparse produced warnings regarding use of conflicting > enum types and logical vs bitwise operator use. > > Signed-off-by: Quentin Swain > --- > drivers/staging/pi433/pi433_if.c | 4 ++-- > drivers/staging/pi433/rf69.c

Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c

On Tue, Aug 01, 2017 at 10:39:06AM +0530, Rishabh Hardas wrote: > From: Rishabh Hardas > > Solved a few coding style issues, used BIT macro to set MINORBITS. > > Signed-off-by: Rishabh Hardas > Reviewed-by: Marcus Wolf > --- > drivers/staging/pi433/pi433_if.c | 24 ++-- >

Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

On Thu, Aug 03, 2017 at 05:20:43PM +0530, Rishabh Hardas wrote: > Signed-off-by: Rishabh Hardas > --- I can not take patches without any changelog text at all, sorry. Please fix up and resend this series. thanks, greg k-h ___ devel mailing list de...

Re: [PATCH] staging: pi433: style fixes for conditionals

On Mon, Aug 07, 2017 at 07:51:42PM -0400, Frank Jozsa wrote: > Cleans up some incongruous braces > > Signed-off-by: Frank Jozsa > --- > drivers/staging/pi433/pi433_if.c | 203 > +++ > 1 file changed, 78 insertions(+), 125 deletions(-) You sent two patches th

Re: [PATCH 00/45] staging: unisys: more changes to the code.

On Thu, Aug 10, 2017 at 08:18:54PM +, Kershner, David A wrote: > > -Original Message- > > From: David Kershner [mailto:david.kersh...@unisys.com] > > Sent: Tuesday, August 1, 2017 10:40 AM > > To: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; > > *S-Par-Maintainer

Re: [PATCH] [media] staging/imx: always select VIDEOBUF2_DMA_CONTIG

Thanks, Reviewed-by: Steve Longerbeam Steve On 08/07/2017 03:49 AM, Arnd Bergmann wrote: I ran into a rare build error during randconfig testing: drivers/staging/media/imx/imx-media-capture.o: In function `capture_stop_streaming': imx-media-capture.c:(.text+0x224): undefined reference to `v

Re: [PATCH 6/6] [media] media: imx: capture: constify vb2_ops structures

Thanks, Reviewed-by: Steve Longerbeam Steve On 08/05/2017 03:47 AM, Julia Lawall wrote: These vb2_ops structures are only stored in the ops field of a vb2_queue structure, which is declared as const. Thus the vb2_ops structures themselves can be const. Done with the help of Coccinelle. //

Re: [PATCH] [media] media: imx: use setup_timer

Thanks, Reviewed-by: Steve Longerbeam Tested-by: Steve Longerbeam Steve On 08/13/2017 11:39 AM, Cihangir Akturk wrote: Use setup_timer function instead of initializing timer with the function and data fields. Generated by: scripts/coccinelle/api/setup_timer.cocci. Signed-off-by: Cihangir

Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API

On Mon, Aug 14, 2017 at 10:57:46AM -0700, Steve Longerbeam wrote: > Hi Akturk, this has already been fixed, see Sorry. Apparently, I missed to update my tree, somehow. > > 4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency"). > > Steve > > On 08/14/2017 04:00 AM, Cihangir Akturk wro

Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API

Hi Akturk, this has already been fixed, see 4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency"). Steve On 08/14/2017 04:00 AM, Cihangir Akturk wrote: This driver uses various v4l2_subdev_get_try_*() functions provided by V4L2 sub-device userspace API. Current configuration of Kconf

[PATCH 63/64] staging: lustre: libcfs: cleanup paths for libcfs headers

Rationalize include paths in all the libcfs header files. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h | 24 +++--- .../lustre/include/linux/libcfs/libcfs_debug.h | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/

[PATCH 61/64] staging: lustre: ksocklnd: add include path to Makefile

Rationalize include paths in the ksocklnd source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/klnds/socklnd/Makefile | 3 +++ drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/stagin

[PATCH 64/64] staging: lustre: lnet: cleanup paths for all LNet headers

Rationalize include paths in all the lnet header files. Signed-off-by: James Simmons --- drivers/staging/lustre/include/linux/lnet/api.h | 2 +- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 14 +++--- drivers/staging/lustre/include/linux/lnet/lib-types.h |

[PATCH 62/64] staging: lustre: libcfs: add include path to Makefile

Rationalize include paths in the libcfs source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/libcfs/Makefile| 3 +++ drivers/staging/lustre/lnet/libcfs/debug.c | 2 +- drivers/staging/lustre/lnet/libcfs/fail.c | 2 +- dr

[PATCH 58/64] staging: lustre: lnet: selftest: add include path to Makefile

Rationalize include paths in the lnet selftest source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/Makefile | 3 +++ drivers/staging/lustre/lnet/selftest/conctl.c | 6 +++--- drivers/staging/lustre/lnet/selftest/conrpc.c | 4 ++-- drivers/staging/lustre

[PATCH 55/64] staging: lustre: osc: add include path to Makefile

Rationalize include paths in the osc source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/osc/Makefile | 3 ++ drivers/staging/lustre/lustre/osc/lproc_osc.c | 6 ++-- .../staging/lustre/lustre/osc/osc_cl_internal.h| 6 ++-- drivers/staging/lustre/

[PATCH 57/64] staging: lustre: lustre: cleanup paths for lustre UAPI headers

Rationalize include paths for the lustre uapi headers Signed-off-by: James Simmons --- drivers/staging/lustre/include/uapi/linux/lustre/lustre_cfg.h | 2 +- drivers/staging/lustre/include/uapi/linux/lustre/lustre_fid.h | 2 +- drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h |

[PATCH 59/64] staging: lustre: lnet: add include path to Makefile

Rationalize include paths in the lnet core source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/Makefile | 3 +++ drivers/staging/lustre/lnet/lnet/acceptor.c| 2 +- drivers/staging/lustre/lnet/lnet/api-ni.c | 4 ++-- drivers/staging/lustre/lnet/lnet/

[PATCH 56/64] staging: lustre: lustre: cleanup paths for lustre internal headers

Rationalize include paths for the lustre internal headers Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/include/cl_object.h | 4 ++-- drivers/staging/lustre/lustre/include/llog_swab.h | 2 +- .../staging/lustre/lustre/include/lprocfs_status.h | 6 ++--- drivers/staging/lust

[PATCH 60/64] staging: lustre: ko2iblnd: add include path to Makefile

Rationalize include paths in the ko2iblnd source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/klnds/o2iblnd/Makefile | 3 +++ drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/

[PATCH 51/64] staging: lustre: mdc: add include path to Makefile

Rationalize include paths in the mdc source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/mdc/Makefile | 3 +++ drivers/staging/lustre/lustre/mdc/lproc_mdc.c| 4 ++-- drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +- drivers/staging/lustre/lustre/

[PATCH 53/64] staging: lustre: obdclass: add include path to Makefile

Rationalize include paths in the obdclass source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdclass/Makefile | 3 +++ drivers/staging/lustre/lustre/obdclass/cl_io.c | 8 drivers/staging/lustre/lustre/obdclass/cl_lock.c | 8 dri

[PATCH 52/64] staging: lustre: mgc: add include path to Makefile

Rationalize include paths in the mgc source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/mgc/Makefile | 3 +++ drivers/staging/lustre/lustre/mgc/lproc_mgc.c| 4 ++-- drivers/staging/lustre/lustre/mgc/mgc_internal.h | 10 +- drivers/staging/lustre

[PATCH 50/64] staging: lustre: lov: add include path to Makefile

Rationalize include paths in the lov source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/lov/Makefile | 3 ++ .../staging/lustre/lustre/lov/lov_cl_internal.h| 6 ++-- drivers/staging/lustre/lustre/lov/lov_dev.c| 2 +- drivers/staging/lustre/lu

[PATCH 48/64] staging: lustre: llite: add include path to Makefile

Rationalize include paths in the llite source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/llite/Makefile | 3 ++ drivers/staging/lustre/lustre/llite/dcache.c | 6 ++-- drivers/staging/lustre/lustre/llite/dir.c | 16 +- drivers/staging

[PATCH 49/64] staging: lustre: lmv: add include path to Makefile

Rationalize include paths in the lmv source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/lmv/Makefile | 3 +++ drivers/staging/lustre/lustre/lmv/lmv_fld.c | 14 +++--- drivers/staging/lustre/lustre/lmv/lmv_intent.c | 16 driver

[PATCH 54/64] staging: lustre: obdecho: add include path to Makefile

Rationalize include paths in the obdecho source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/obdecho/Makefile | 3 +++ .../staging/lustre/lustre/obdecho/echo_client.c| 24 +++--- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git

[PATCH 47/64] staging: lustre: ptlrpc: add include path to Makefile

Rationalize include paths in the ptlrpc/ldlm source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/ldlm/interval_tree.c | 6 +++--- drivers/staging/lustre/lustre/ldlm/l_lock.c | 6 +++--- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 12 ++---

[PATCH 46/64] staging: lustre: fld: add include path to Makefile

Rationalize include paths in the fld source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/fld/Makefile | 3 +++ drivers/staging/lustre/lustre/fld/fld_cache.c| 16 drivers/staging/lustre/lustre/fld/fld_internal.h | 8 drivers/stag

[PATCH 42/64] staging: lustre: uapi: remove CONFIG_LUSTRE_OBD_MAX_IOCTL

Now that lustre_ioctl.h is a UAPI header the kernel configuration option CONFIG_LUSTRE_OBD_MAX_IOCTL needs to be remove. The user land utilites will no longer be able to see this option and actually they never used this option before. Since this is the case setting the kernel configuration to somet

[PATCH 45/64] staging: lustre: fid: add include path to Makefile

Start to rationalize include paths in the fid source code files. Signed-off-by: James Simmons --- drivers/staging/lustre/lustre/fid/Makefile | 3 +++ drivers/staging/lustre/lustre/fid/fid_internal.h | 4 ++-- drivers/staging/lustre/lustre/fid/fid_lib.c | 4 ++-- drivers/staging/lus

[PATCH 43/64] staging: lustre: uapi: use proper byteorder functions in lustre_idl.h

In order for lustre_idl.h to be usable for both user land and kernel space it has to use the proper byteorder functions. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/16916 Reviewed-by: Frank Zago Reviewed-by: Dmitr

[PATCH 44/64] staging: lustre: uapi: remove BIT macro from UAPI headers

The BIT macro is not available for UAPI headers so remove it from the lustre UAPI headers. Signed-off-by: James Simmons --- .../lustre/include/uapi/linux/lustre/lustre_idl.h | 38 +++--- .../lustre/include/uapi/linux/lustre/lustre_user.h | 12 +++ 2 files changed, 25 inserti

[PATCH 41/64] staging: lustre: uapi: migrate remaining uapi headers to uapi directory

Move all the remaining lustre headers shared between user land and kernel space to the uapi directory. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/25246 Reviewed-by: Quentin Bouget Reviewed-by: Ben Evans Reviewe

[PATCH 14/14] staging: lustre: llite: add support set_acl method in inode operations

From: Dmitry Eremin Linux kernel v3.14 adds set_acl method to inode operations. This patch adds support to Lustre for proper acl management. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/25965 Reviewed-by: Bob Glo

[PATCH 40/64] staging: lustre: uapi: remove libcfs.h from lustre_id.h/lustre_user.h

These are the last UAPI headers that contain libcfs.h which is internal kernel header. Since it is not available to user land remove libcfs.h and add the need headers that libcfs.h provided. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https:/

[PATCH 10/14] staging: lustre: llite: cleanup posix acl xattr code

Have extra ifdef makes the code harder to read. For the case of ll_xattr_get_common() we have a variable initialized at the start of the function but it is only used in XATTR_ACL_ACCESS_T code block. Lets move that variable to that location since its only used there and make the code look cleaner.

[PATCH 12/14] staging: lustre: llite: cleanup xattr code comments

Add proper punctuation to the comments. Change buf_size to size for comment in ll_listxattr() since buf_size doesn't exit which will confuse someone reading the code. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27

[PATCH 13/14] staging: lustre: llite: style changes in xattr.c

Small style changes to match more the kernel code standard and it make it more readable. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed-by: Sebast

[PATCH 11/14] staging: lustre: llite: use proper types in the xattr code

Convert __uXX types to uXX types since this is kernel code. The function ll_lov_user_md_size() returns ssize_t so change lum_size from int to ssize_t. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by:

[PATCH 09/14] staging: lustre: llite: record in stats attempted removal of lma/link xattr

Keep track of attempted deletions as well as changing of the lma/link xattrs. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed-by: Sebastien Buisson

[PATCH 02/14] staging: lustre: llite: refactor lustre.lov xattr handling

From: Niu Yawei The function ll_xattr_set() contains special code to handle the lustre specific xattr lustre.lov. Move all this code to a new function ll_setstripe_ea(). Signed-off-by: Bobi Jam Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8998 Reviewed-on: https

[PATCH 07/14] staging: lustre: llite: fix sparse variable length array warning

Currently sparse reports "warning: Variable length array is used." The solution is use kasprintf to allocate full xattr name. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-

[PATCH 08/14] staging: lustre: llite: fix invalid size test in ll_setstripe_ea()

The size check at the start of ll_setstripe_ea() is only valid for a directory. Move that check to the section of code handling the S_ISDIR case. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmit

[PATCH 05/14] staging: lustre: llite: return from ll_adjust_lum() if lump is NULL

From: Bobi Jam No need to check several times if lump is NULL. Just test once and return 0 if NULL. Signed-off-by: Bobi Jam Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://review.whamcloud.com/27126 Reviewed-by: Dmitry Eremin Reviewed-by: Niu Yawei Reviewed-by: J

[PATCH 06/14] staging: lustre: llite: eat -EEXIST on setting trunsted.lov

Tools like rsync, tar, cp may copy and restore the xattrs on a file. The client previously ignored the setting of trusted.lov/lustre.lov if the layout had already been specified, to avoid causing these tools to fail for no reason. For PFL files we still need to silently eat -EEXIST on setting thes

[PATCH 00/14] staging: lustre: llite: xattr related handling fixes

This batch of patches resolves several issues with how lustre handles xattrs. Some of the patches also resolve some style issues with the code. The patch set is order dependent. These fixes resolve some of the test failures that happen. Bobi Jam (2): staging: lustre: llite: break up ll_setstripe

[PATCH 03/14] staging: lustre: llite: add simple comment about lustre.lov xattrs

From: Niu Yawei Simple comment added to ll_xattr_set. Signed-off-by: Bobi Jam Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8998 Reviewed-on: https://review.whamcloud.com/24851 Reviewed-by: Andreas Dilger Reviewed-by: Lai Siyao Reviewed-by: Jinshan Xiong Signe

[PATCH 04/14] staging: lustre: llite: break up ll_setstripe_ea function

From: Bobi Jam Place all the handling of information of trusted.lov that is not stripe related into the new function ll_adjust_lum(). Now ll_setstripe_ea() only handles striping information. Signed-off-by: Bobi Jam Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://re

[PATCH v2 01/14] staging: lustre: llite: Remove filtering of seclabel xattr

From: Robin Humble The security.capability xattr is used to implement File Capabilities in recent Linux versions. Capabilities are a fine grained approach to granting executables elevated privileges. eg. /bin/ping can have capabilities cap_net_admin, cap_net_raw+ep instead of being setuid root.

[PATCH 37/64] staging: lustre: libcfs: sort headers in libcfs.h

Move all the included headers in libcfs.h to the top of the file. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/28089 Reviewed-by: Dmitry Eremin Reviewed-by: Olaf Weber Reviewed-by: Oleg Drokin Signed-off-by: Jam

[PATCH 31/64] staging: lustre: libcfs: remove htonl hack in libcfs.h

This is really old hack for earlier gcc version that had a hard time compiling byteorder.h. Lets remove it. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/22138 Reviewed-by: Dmitry Eremin Reviewed-by: Jinshan Xiong

[PATCH 39/64] staging: lustre: lnet: remove BIT macro from lnetctl.h

Now that lnetctl.h is a UAPI header the BIT macro has to be removed. Signed-off-by: James Simmons --- drivers/staging/lustre/include/uapi/linux/lnet/lnetctl.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/include/uapi/linux/lnet/lnetctl.h b/d

[PATCH 35/64] staging: lustre: lnet: delete lnet.h

The header lnet.h is just a bunch of headers included in a header. Just delete it and include the appropriate headers where needed. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/28089 Reviewed-by: Dmitry Eremin Rev

[PATCH 23/64] staging: lustre: uapi: move lustre_cfg_string() to obd_config.c

To perserve the truncate warning move lustre_cfg_string() to obd_config.c. A identical function was created for userland. This function was a bit big for a inline function. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.

[PATCH 33/64] staging: lustre: libcfs: create libcfs_debug.h UAPI header

Break out the parts from libcfs_debug.h that is used by both user land and kernel space into a new UAPI header. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/28089 Reviewed-by: Dmitry Eremin Reviewed-by: Olaf Weber

[PATCH 32/64] staging: lustre: libcfs: remove LOGL and LOGU macros

The macro LOGU is not used anymore and LOGL is used in one place. No reason to keep LOGL around anymore. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/22138 Reviewed-by: Dmitry Eremin Reviewed-by: Jinshan Xiong Re

[PATCH 29/64] staging: lustre: uapi: style cleanup of lustre_cfg.h

Some style and white space cleanups to make lustre_cfg.h easy to read. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/26966 Reviewed-by: Quentin Bouget Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin Signed-off-by

[PATCH 36/64] staging: lustre: lnet: migrate headers to lnet uapi directory

Migrate the headers used by user land and kernel space to the libcfs/lnet uapi directory. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/28089 Reviewed-by: Dmitry Eremin Reviewed-by: Olaf Weber Reviewed-by: Oleg Dr

[PATCH 38/64] staging: lustre: lnet: remove userland function prototype in lnetctl.h

Several function prototypes of the form jt_ptl_* are only needed by userland so they can be removed. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: http://review.whamcloud.com/17643 Reviewed-by: Bob Glossman Reviewed-by: John L. Hammond Review

[PATCH 27/64] staging: lustre: uapi: change variable type to match

Change i from int to __u32 to match lcfg_bufcount field. Also this matches what the other functions also do. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/26966 Reviewed-by: Quentin Bouget Reviewed-by: Ben Evans R

[PATCH 34/64] staging: lustre: socklnd: create socklnd.h UAPI header

Break out the parts from libcfs_debug.h that is used by both user land and kernel space into a new UAPI header. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/28089 Reviewed-by: Dmitry Eremin Reviewed-by: Olaf Weber

[PATCH 26/64] staging: lustre: uapi: remove need for libcfs.h from lustre_cfg.h

Several libcfs.h macros are present in lustre_cfg.h, but libcfs.h is not available so lets replace those macros with real code. The header libcfs.h also provides errno.h so with libcfs.h gone include errno.h directly. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/L

[PATCH 24/64] staging: lustre: obdclass: no need to check for kfree

In class_config_llog_handler() a flag, inst, was used to determine if it was safe to call kfree. Its not needed so remove the flag. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/26966 Reviewed-by: Quentin Bouget Re

[PATCH 25/64] staging: lustre: uapi: move lustre_cfg.h to uapi directory

Move lustre_cfg.h to its proper place. Adjust additonal headers included in lustre_cfg.h. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/26966 Reviewed-by: Quentin Bouget Reviewed-by: Ben Evans Reviewed-by: Oleg Dr

[PATCH 28/64] staging: lustre: uapi: check if argument for lustre_cfg_buf() is NULL

Check if lcfg passed in is NULL and if it is just return NULL. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6245 Reviewed-on: https://review.whamcloud.com/22138 Reviewed-by: Dmitry Eremin Reviewed-by: Jinshan Xiong Reviewed-by: Fan Yong Reviewed-by: Oleg Dro

[PATCH 30/64] staging: lustre: uapi: label lustre_cfg.h as an uapi header

Change LUSTRE_CFG_H to _UAPI_LUSTRE_CFG_H_ now that it is a proper UAPI header. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/26966 Reviewed-by: Quentin Bouget Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin Sign

[PATCH 22/64] staging: lustre: uapi: don't memory allocate in UAPI header

The inline function lustre_cfg_new() calls kzalloc() but this is a UAPI header. Remove kzalloc() and rename the function to lustre_cfg_init(). The lustre kernel code that was calling lustre_cfg_new() can doing the memory allocation and pass the new buffer to lustre_cfg_init() to fill in. Signed-of

[PATCH 13/64] staging: lustre: uapi: use __ALIGN_KERNEL for lustre_ioctl.h

Replace cfs_size_round() standard __ALIGN_KERNEL macro. This removes the dependency of libcfs.h which is a kernel only header. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/24568 Reviewed-by: Andreas Dilger Reviewe

[PATCH 19/64] staging: lustre: uapi: label lustre_param.h as an uapi header

Change LUSTRE_PARAM_H_ to _UAPI_LUSTRE_PARAM_H_ now that is a proper UAPI header Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/24325 Reviewed-by: Ben Evans Reviewed-by: John L. Hammond Reviewed-by: Oleg Drokin Si

[PATCH 09/64] staging: lustre: uapi: remove obd_ioctl_popdata() wrapper

Replace obd_ioctl_popdata() with direct copy_to_user() call. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/24568 Reviewed-by: Andreas Dilger Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin Signed-off-by: James Si

[PATCH 21/64] staging: lustre: uapi: remove lustre_cfg_free wrapper

Replace all lustre_cfg_free() calls with direct kfree() call. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/26966 Reviewed-by: Quentin Bouget Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin Signed-off-by: James S

[PATCH 11/64] staging: lustre: uapi: move obd_ioctl_is_invalid() to linux-module.c

The inline function obd_ioctl_is_invalid() is no longer needed by userland and also the function was pretty bug for a inline function. Since this is the case we can move this kernel only code to the linux-module.c which is the only place it is used. Signed-off-by: James Simmons Intel-bug-id: http

[PATCH 17/64] staging: lustre: uapi: remove included headers out of lustre_param.h

All the included headers in lustre_param.h are lustre kernel internal headers and they are not even needed. Just remove them. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/24325 Reviewed-by: Ben Evans Reviewed-by:

[PATCH 15/64] staging: lustre: uapi: label lustre_ioctl.h as a UAPI header

Change LUSTRE_IOCTL_H_ to _UAPI_LUSTRE_IOCTL_H_ now that is a proper UAPI header Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401 Reviewed-on: https://review.whamcloud.com/24568 Reviewed-by: Andreas Dilger Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin Sig

  1   2   >