[PATCH 7/7] staging: typec: tcpm: Check cc status before entering SRC_TRY_DEBOUCE

2017-08-10 Thread Guenter Roeck
From: Badhri Jagan Sridharan [ 130.893355] state change SNK_DEBOUNCED -> SRC_TRY [ 130.893363] cc:=3 [ 130.893490] pending state change SRC_TRY -> SNK_TRYWAIT @ 100 ms [ 130.895602] CC1: 3 -> 0, CC2: 0 -> 0 [state SRC_TRY, polarity 0, disconnected] [ 130.895613] state change SRC_TRY -> SRC_

[PATCH 1/7] staging: typec: tcpm: Constify alternate modes

2017-08-10 Thread Guenter Roeck
Constify alternate mode configuration data which won't be touched by the driver. Signed-off-by: Guenter Roeck --- This series has been in my queue and kind of got lost. Sorry for the delay. drivers/staging/typec/tcpm.c | 2 +- drivers/staging/typec/tcpm.h | 2 +- 2 files changed, 2 insertions(+

[PATCH 5/7] staging: typec: tcpm: Add timeout when waiting for role swap completion

2017-08-10 Thread Guenter Roeck
The Type-C protocol manager state machine could fail, which might result in role swap requests from user space to hang forever. Add a generous timeout when waiting for role swaps to complete to avoid this situation. Originally-from: Badhri Jagan Sridharan Signed-off-by: Guenter Roeck --- driver

[PATCH 4/7] staging: typec: tcpm: Select default state based on port type

2017-08-10 Thread Guenter Roeck
From: Badhri Jagan Sridharan tcpm_default_state wasn't considering the port type when determining the default role. This change makes tcpm_default_state to consider port type as well. tcpm_default_state would return the following based on the port type: TYPEC_PORT_UFP - SNK_UNATTACHED TYPEC_PORT

[PATCH 6/7] staging: typec: tcpm: Improve role swap with non PD capable partners

2017-08-10 Thread Guenter Roeck
If the partner is not PD capable, we can not use a power role set request to swap roles. Use the data role set request instead. Also, if a partner is not PD capable, it does not really make sense to send a PD message to trigger a role swap. On top of that, we should really wait for the attempted r

[PATCH 2/7] staging: typec: tcpm: Report role swap complete after entering READY state

2017-08-10 Thread Guenter Roeck
Role swap requests fail unless the current role is either SRC_READY or SNK_READY. This works fine for VCONN and data role swaps, where we immediately enter READY state after reporting a successful role swap to user space. However, on power role changes, the role swap is currently reported as succes

[PATCH 3/7] staging: typec: tcpm: Set default state after error recovery based on port type

2017-08-10 Thread Guenter Roeck
From: Badhri Jagan Sridharan While exiting ERROR_RECOVERY, choose default state based on the port type instead of current power role. Quoting from specification: 4.5.2.2.2 ErrorRecovery State This state appears in Figure 4-12, Figure 4-13, Figure 4-14, Figure 4-15, Figure 4-16 and Figure 4-17.

[PATCH 2/2] Tools: hv: update buffer handling in hv_fcopy_daemon

2017-08-10 Thread kys
From: Olaf Hering Currently this warning is triggered when compiling hv_fcopy_daemon: hv_fcopy_daemon.c:216:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] kernel_modver = *(__u32 *)buffer; Convert the send/receive buffer to a union and pas

[PATCH 0/2] Tools: hv: Miscellaneous adjustments

2017-08-10 Thread kys
From: K. Y. Srinivasan Miscellaneous adjustments. Olaf Hering (2): Tools: hv: fix snprintf warning in kvp_daemon Tools: hv: update buffer handling in hv_fcopy_daemon tools/hv/hv_fcopy_daemon.c | 32 +--- tools/hv/hv_kvp_daemon.c |2 +- 2 files changed, 1

[PATCH 1/2] Tools: hv: fix snprintf warning in kvp_daemon

2017-08-10 Thread kys
From: Olaf Hering Increase buffer size so that "_{-INT_MAX}" will fit. Spotted by the gcc7 snprintf checker. Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_kvp_daemon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/hv/hv_kvp_daemon

RE: [PATCH 00/45] staging: unisys: more changes to the code.

2017-08-10 Thread Kershner, David A
> -Original Message- > From: David Kershner [mailto:david.kersh...@unisys.com] > Sent: Tuesday, August 1, 2017 10:40 AM > To: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; > *S-Par-Maintainer ; jes.soren...@gmail.com > Cc: Kershner, David A > Subject: [PATCH 00/45] st

[RFC PATCH 05/10] crypto: caam/qi - prepare for gcm(aes) support

2017-08-10 Thread Horia Geantă
Update gcm(aes) descriptors (generic, rfc4106 and rfc4543) such that they would also work when submitted via the QI interface. Signed-off-by: Horia Geantă --- drivers/crypto/caam/caamalg.c | 19 +++-- drivers/crypto/caam/caamalg_desc.c | 165 ++--- drivers/c

[RFC PATCH 07/10] crypto: caam - add Queue Interface v2 error codes

2017-08-10 Thread Horia Geantă
Add support to translate error codes returned by QI v2, i.e. Queue Interface present on DataPath Acceleration Architecture v2 (DPAA2). Signed-off-by: Horia Geantă --- drivers/crypto/caam/error.c | 75 +++-- drivers/crypto/caam/error.h | 6 +++- drivers/cr

[RFC PATCH 03/10] staging: fsl-mc: dpio: add order preservation support

2017-08-10 Thread Horia Geantă
From: Radu Alexe Order preservation is a feature that will be supported in dpni, dpseci and dpci devices. This is a preliminary patch for the changes to be introduced in the corresponding drivers. Signed-off-by: Radu Alexe Signed-off-by: Horia Geantă --- drivers/staging/fsl-mc/include/dpopr.h

[RFC PATCH 09/10] crypto: caam/qi2 - add ablkcipher algorithms

2017-08-10 Thread Horia Geantă
Add support to submit the following ablkcipher algorithms via the DPSECI backend: cbc({aes,des,des3_ede}) ctr(aes), rfc3686(ctr(aes)) xts(aes) Signed-off-by: Horia Geantă --- drivers/crypto/caam/Kconfig | 1 + drivers/crypto/caam/caamalg_qi2.c | 816 ++

[RFC PATCH 01/10] staging: fsl-mc: dpio: add frame list format support

2017-08-10 Thread Horia Geantă
Add support for dpaa2_fd_list format, i.e. dpaa2_fl_entry structure and accessors. Frame list entries (FLEs) are similar, but not identical to frame descriptors (FDs): + "F" (final) bit - FMT[b'01] is reserved - DD, SC, DROPP bits (covered by "FD compatibility" field in FLE case) - FLC[5:0] not us

[RFC PATCH 02/10] staging: fsl-mc: dpio: add congestion notification support

2017-08-10 Thread Horia Geantă
Add support for Congestion State Change Notifications (CSCN), which allow DPIO users to be notified when a congestion group changes its state (due to hitting the entrance / exit threshold). Signed-off-by: Ioana Radulescu Signed-off-by: Radu Alexe Signed-off-by: Horia Geantă --- drivers/staging

[RFC PATCH 10/10] arm64: defconfig: enable CAAM crypto engine on QorIQ DPAA2 SoCs

2017-08-10 Thread Horia Geantă
Enable CAAM (Cryptographic Accelerator and Assurance Module) driver for QorIQ Data Path Acceleration Architecture (DPAA) v2. It handles DPSECI (Data Path SEC Interface) DPAA2 objects that sit on the Management Complex (MC) fsl-mc bus. Signed-off-by: Horia Geantă --- arch/arm64/configs/defconfig

[RFC PATCH 04/10] staging: fsl-dpaa2/eth: move generic FD defines to DPIO

2017-08-10 Thread Horia Geantă
Previous commits: 6e2387e8f19e ("staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver") 39163c0ce0f4 ("staging: fsl-dpaa2/eth: Errors checking update") have added bits that are not specific to the WRIOP accelerator. Move these where they belong (in DPIO) such that other accelerators can mak

[RFC PATCH 06/10] crypto: caam - add DPAA2-CAAM (DPSECI) backend API

2017-08-10 Thread Horia Geantă
Add the low-level API that allows to manage DPSECI DPAA2 objects that sit on the Management Complex (MC) fsl-mc bus. The API is compatible with MC firmware 10.2.0+. Signed-off-by: Horia Geantă --- drivers/crypto/caam/dpseci.c | 858 +++ drivers/crypto/caa

[RFC PATCH 00/10] crypto: caam - add DPAA2 (DPSECI) driver

2017-08-10 Thread Horia Geantă
Hi, This patch set adds the CAAM crypto engine driver for DPAA2 (Data Path Acceleration Architecture v2) found on ARMv8-based SoCs like LS1088A, LS2088A. Driver consists of: -DPSECI (Data Path SEC Interface) backend - low-level API that allows to manage DPSECI devices (DPAA2 objects) that sit on

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

2017-08-10 Thread Vitaly Kuznetsov
Ingo Molnar writes: > I'm getting this build failure with this series: > > arch/x86/hyperv/mmu.c: In function ‘hyperv_setup_mmu_ops’: > arch/x86/hyperv/mmu.c:256:3: error: ‘pv_mmu_ops’ undeclared (first use in > this > function) >pv_mmu_ops.flush_tlb_others = hyperv_flush_tlb_others; >^

Re: [PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-10 Thread David Miller
From: Eduardo Otubo Date: Thu, 10 Aug 2017 09:40:27 +0200 > On 08/09/2017 11:02 AM, Eduardo Otubo wrote: >> On 08/09/2017 06:11 AM, David Miller wrote: >>> From: Eduardo Otubo >>> Date: Tue, 8 Aug 2017 15:53:45 +0200 >>> This patch fixes the behavior of the hv_set_ifconfig script when

[PATCH v3 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Sakari Ailus
From: Rui Miguel Silva We are allocating memory for the v4l2 flash configuration structure and leak it in the normal path. Just use the stack for this as we do not use it outside of this function. Also use IS_ERR() instead of IS_ERR_OR_NULL() to check return value from v4l2_flash_init() for it n

[PATCH v3 0/3] Create sub-device per LED

2017-08-10 Thread Sakari Ailus
Hi folks, The original design decision in the V4L2 flash API allows controlling a two LEDs (an indicator and a flash) through a single sub-device. This covered virtually all flash driver chips back then but this no longer holds as there are many LED driver chips with multiple flash LED outputs. Th

[PATCH v3 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references

2017-08-10 Thread Sakari Ailus
The v4l2_flash_init() keeps a reference to the ops struct but not to the config struct (nor anything it contains). Document this. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Acked-by: Hans Verkuil --- include/media/v4l2-flash-led-class.h | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH v3 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-10 Thread Sakari Ailus
The V4L2 flash interface allows controlling multiple LEDs through a single sub-devices if, and only if, these LEDs are of different types. This approach scales badly for flash controllers that drive multiple flash LEDs or for LED specific associations. Essentially, the original assumption of a LED

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

2017-08-10 Thread Vitaly Kuznetsov
Ingo Molnar writes: > * Vitaly Kuznetsov wrote: > >> Vitaly Kuznetsov writes: >> >> > Changes since v9: >> > - Rebase to 4.13-rc3. >> > - Drop PATCH1 as it was already taken by Greg to char-misc tree. There're >> > no >> > functional dependencies on this patch so the series can go through a

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

2017-08-10 Thread Ingo Molnar
* Vitaly Kuznetsov wrote: > Vitaly Kuznetsov writes: > > > Changes since v9: > > - Rebase to 4.13-rc3. > > - Drop PATCH1 as it was already taken by Greg to char-misc tree. There're no > > functional dependencies on this patch so the series can go through a > > different tree > > (and it a

[PATCH] staging:media:atomisp:Fix code indent error

2017-08-10 Thread Harold Gomez
code indent should use tabs where possible change spaces to tabs Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Rui Miguel Silva
Hi, On Thu, Aug 10, 2017 at 04:56:50PM +0300, Sakari Ailus wrote: > Hi Hans, > > On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote: > > > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct > > > gb_light *light) > > > { > > > struct gb_connection *connection = get

[PATCH] staging:media:atomisp:Fix trivial codingstyle issues

2017-08-10 Thread Harold Gomez
change comment style to match codingstyle. Issue found by checkpatch change four comments. Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 38 -- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/atomisp

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 02:25:57PM +0100, Phil Elwell wrote: > > > On 10/08/2017 12:24, Dan Carpenter wrote: > > On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > >> On 10/08/2017 11:21, Dan Carpenter wrote: > >>> The original patch did not go through the normal review process... > >

[PATCH] staging:media:atomisp:Fix block comments use * on subsequent lines ap1302.c

2017-08-10 Thread Harold Gomez
This patch fixes the warning WARNING: Block comments use * on subsequent lines +/* When loading firmware, host writes firmware data from address 0x8000. + When the address reaches 0x9FFF, the next address should return to 0x8000. WARNING: Block comments use a trailing */ on a separate line +

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Sakari Ailus
Hi Hans, On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote: > > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct > > gb_light *light) > > { > > struct gb_connection *connection = get_conn_from_light(light); > > struct device *dev = &connection->bundle->dev

[PATCH 3/3] staging: pi433: rf69.c style fix - spaces open brace

2017-08-10 Thread Marcin Ciupak
This patch fixes the following checkpatch.pl error: ERROR: space required before the open brace '{' in rf69.c file as requested by TODO file. Signed-off-by: Marcin Ciupak --- drivers/staging/pi433/rf69.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/

[PATCH 1/3] staging: pi433: rf69.c style fix - that open brace

2017-08-10 Thread Marcin Ciupak
This patch fixes the following checkpatch.pl error: ERROR: that open brace { should be on the previous line in rf69.c file as requested by TODO file. Note: ERROR: else should follow close brace '}' remains valid here and is going to be fixed by the next patch in set. Additionally some style war

[PATCH 2/3] staging: pi433: rf69.c style fix - else close brace

2017-08-10 Thread Marcin Ciupak
This patch fixes the following checkpatch.pl error: ERROR: else should follow close brace '}' in rf69.c file as requested by TODO file. Signed-off-by: Marcin Ciupak --- drivers/staging/pi433/rf69.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/rf69

[PATCH 0/3] staging: pi433: rf69.c style errors fixes - braces

2017-08-10 Thread Marcin Ciupak
This set of patches is intended to fix coding style errors with braces in rf69.c file in order to comply with kernel coding style guide as requested by TODO file. The following errors were fixed: ERROR: that open brace { should be on the previous line ERROR: else should follow close brace '}' ERRO

[PATCH] staging: media: atomisp: Add blank line after variable declarations.

2017-08-10 Thread Harold Gomez
This patch fixes the checkpatch.pl warning WARNING: Missing a blank line after declarations + int i; + dev_dbg(&client->dev, "Dump registers for context[%d]:\n", context) WARNING: Missing a blank line after declarations + int ret; + ret = request_firmware(&dev->fw, "ap1302

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Phil Elwell
On 10/08/2017 12:24, Dan Carpenter wrote: > On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: >> On 10/08/2017 11:21, Dan Carpenter wrote: >>> The original patch did not go through the normal review process... >>> >>> On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: I'

Re: [PATCH v2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-10 Thread Hans Verkuil
On 09/08/17 13:15, Sakari Ailus wrote: > The V4L2 flash interface allows controlling multiple LEDs through a single > sub-devices if, and only if, these LEDs are of different types. This > approach scales badly for flash controllers that drive multiple flash LEDs > or for LED specific associations.

Re: [PATCH v2 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references

2017-08-10 Thread Hans Verkuil
On 09/08/17 13:15, Sakari Ailus wrote: > The v4l2_flash_init() keeps a reference to the ops struct but not to the > config struct (nor anything it contains). Document this. > > Signed-off-by: Sakari Ailus > Acked-by: Pavel Machek Acked-by: Hans Verkuil Regards, Hans > --- > include

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Hans Verkuil
On 10/08/17 15:02, Hans Verkuil wrote: > On 09/08/17 13:15, Sakari Ailus wrote: >> From: Rui Miguel Silva >> >> We are allocating memory for the v4l2 flash configuration structure and >> leak it in the normal path. Just use the stack for this as we do not >> use it outside of this function. > > I

[PATCH] media:atomisp:ap1302 Fix style warning

2017-08-10 Thread Harold Gomez
Add a blank line after declarations to avoid checkpatch.pl script warning Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c index

Re: [PATCH] Subject:staging:media:atomisp:ap1302: fix comments style

2017-08-10 Thread Sakari Ailus
On Thu, Aug 10, 2017 at 05:57:35PM +0530, Harold Gomez wrote: > fix comment style Warning in ap1302.c > fix WARNING on Block comments use * on subsequent lines > > Signed-off-by: Harold Gomez If you're making a number of trivial cleanups to a single driver, please submit them as a single patch i

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-10 Thread Hans Verkuil
On 09/08/17 13:15, Sakari Ailus wrote: > From: Rui Miguel Silva > > We are allocating memory for the v4l2 flash configuration structure and > leak it in the normal path. Just use the stack for this as we do not > use it outside of this function. I'm not sure why this is part of this patch series

[PATCH] media:staging:atomisp:ap1302: Fix comment style

2017-08-10 Thread Harold Gomez
fix comment style to avoid warning from checkpatch.pl script Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2

[PATCH] staging:media:atomisp: Add blank line after declarations

2017-08-10 Thread Harold Gomez
Add blank line after declarations to avoid warning from checkpatch.pl script Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c ind

[PATCH] Subject:staging:media:atomisp:ap1302: fix comments style

2017-08-10 Thread Harold Gomez
fix comment style Warning in ap1302.c fix WARNING on Block comments use * on subsequent lines Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/st

[PATCH] [media] staging: atomisp: fix bounds checking in mt9m114_s_exposure_selection()

2017-08-10 Thread Dan Carpenter
These clamp_t() calls are no-ops because we don't save the results. It leads to an array out of bounds bug. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c b/drivers/staging/media/at

[PATCH v2 29/29] staging: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

2017-08-10 Thread Cihangir Akturk
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. drm_*_reference() and drm_*_unreference() functions are just compatibility alias for drm_*_get() and drm_*_put() and should not be used by new code. So convert all users of compatibility functions

[PATCH v2 00/29] DRM API Conversions

2017-08-10 Thread Cihangir Akturk
Changes since v1: - This time patches were generated with coccinelle instead of my own script, as suggested by Daniel Vetter. - Fixed the typo in commit messages. s/adn/and Note: I've included r-b, a-b tags, as these patches are identical to v1 except for the file: drivers/gpu/drm/i915/i915_gem

Re: [PATCH v10 0/9] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

2017-08-10 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Changes since v9: > - Rebase to 4.13-rc3. > - Drop PATCH1 as it was already taken by Greg to char-misc tree. There're no > functional dependencies on this patch so the series can go through a > different tree > (and it actually belongs to x86 if I got Ingo's commen

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 02:24:51PM +0300, Dan Carpenter wrote: > On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > > On 10/08/2017 11:21, Dan Carpenter wrote: > > > The original patch did not go through the normal review process... > > > > > > On Tue, Aug 08, 2017 at 01:05:02PM +0100,

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > On 10/08/2017 11:21, Dan Carpenter wrote: > > The original patch did not go through the normal review process... > > > > On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: > >> I'm all for fixing memory leaks, but freeing a b

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Phil Elwell
On 10/08/2017 11:21, Dan Carpenter wrote: > The original patch did not go through the normal review process... > > On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: >> I'm all for fixing memory leaks, but freeing a block while it is still >> being used is a recipe for hard-to-debug kern

Re: [PATCH] Subject:drivers:staging:media:atomisp:

2017-08-10 Thread Sakari Ailus
Hi Harold, Please use a better subject line. On Thu, Aug 10, 2017 at 03:08:26PM +0530, Harold Gomez wrote: > Fix Warning from checkpatch.pl > Block comments use * on subsequent lines > > Signed-off-by: Harold Gomez > --- > drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++-- > 1 file changed

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote: > > This label name is out of date. There is a later error path where > > vc_vchi_audio_init() fails and we leak on that path. > > Also agreed. I'll rework it. > Actually I wasn't right. That error path should probably stay how it is

Re: [PATCH] staging: bcm2835-audio: Fix memory corruption

2017-08-10 Thread Dan Carpenter
The original patch did not go through the normal review process... On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote: > I'm all for fixing memory leaks, but freeing a block while it is still > being used is a recipe for hard-to-debug kernel exceptions. > This bug completely breaks the

[PATCH] Subject:drivers:staging:media:atomisp:

2017-08-10 Thread Harold Gomez
Fix Warning from checkpatch.pl Block comments use * on subsequent lines Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp

[PATCH] Subject:drivers:staging:media:atomisp:i2c:api1302.c

2017-08-10 Thread Harold Gomez
Fix Warning Block comments use * on subsequent lines Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c b/drivers/staging/media/atomisp/i2c/ap1302.c index

Re: [PATCH] Subject: drivers:staging:media:atomisp:12c:ab1302.c fix CHECK

2017-08-10 Thread Sakari Ailus
Hi Harold, On Thu, Aug 10, 2017 at 01:58:24PM +0530, Harold Gomez wrote: > CHECK: Do not include the paragraph about writing to the Free Software > Foundation's mailing address from the sample GPL notice. > The FSF has changed addresses in the past, and may do so again. > Linux already includes a

[PATCH] Subject: drivers:staging:media:atomisp:12c:ab1302.c fix CHECK

2017-08-10 Thread Harold Gomez
CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. remove the unnecessary paragraph Signed-off-by: Harold Gomez -

[PATCH] Subject: drivers:staging:media:atomisp:12c:ab1302.c fix CHECK

2017-08-10 Thread Harold Gomez
CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. remove the unnecessary paragraph Signed-off-by: Harold Gomez -

Re: [PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-10 Thread Eduardo Otubo
On 08/09/2017 11:02 AM, Eduardo Otubo wrote: On 08/09/2017 06:11 AM, David Miller wrote: From: Eduardo Otubo Date: Tue, 8 Aug 2017 15:53:45 +0200 This patch fixes the behavior of the hv_set_ifconfig script when setting the interface ip. Sometimes the interface has already been configured by