Use resource_size function on resource object
instead of explicit computation.
Generated by: scripts/coccinelle/api/resource_size.cocci
Fixes: a037b7ec2eb7 ("staging: fsl-mc: allow the driver compile multi-arch")
CC: Laurentiu Tudor
Signed-off-by: Julia Lawall
Signed-off-by: Fengguang Wu
---
From: Stephen Hemminger
Date: Wed, 19 Jul 2017 11:53:11 -0700
> These fix sparse and lockdep warnings from netvsc driver.
> Targeting these at net-next since no actual related failures
> have been observed in non-debug kernels.
Series applied, thanks Stephen.
Fix an error detected by checkpatch.pl on line 75 and move the opening
brace after the function signature to a new line.
Signed-off-by: Munir Contractor
---
drivers/staging/rtl8188eu/include/rtw_ioctl.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188
From: Randy Dunlap
The pi433 driver uses SPI interfaces so it should depend on SPI.
Also, the "default n" can be removed since that is already the
default.
Fixes these build errors when SPI is not enabled:
drivers/staging/pi433/pi433_if.o: In function `pi433_probe':
pi433_if.c:(.text+0x1135): u
On Wed, Jul 19, 2017 at 11:18 PM, Haiyang Zhang wrote:
>> struct hv_fcopy_hdr {
>> __u32 operation;
>> - uuid_le service_id0; /* currently unused */
>> - uuid_le service_id1; /* currently unused */
>> + __u8 service_id0[16]; /* currently unused */
>> + __u8 service_id1[16];
On Wed, Jul 19, 2017 at 2:25 PM, Dan Carpenter wrote:
> Everyone please delete this confidential email. Piotr is leakier than
> the Trump administration!
>
Sanity level of Dan's assessments is less than half the average level
of Hillary's supporter!
__
The changes look good to me.
-Original Message-
From: James Simmons [mailto:jsimm...@infradead.org]
Sent: Saturday, July 15, 2017 8:32 AM
To: Greg Kroah-Hartman ;
de...@driverdev.osuosl.org; Dilger, Andreas ; Drokin,
Oleg ; Arnd Bergmann ; Al Viro
Cc: Shehata, Amir ; Olaf Weber ;
Lin
> -Original Message-
> From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com]
> Sent: Wednesday, July 19, 2017 2:29 PM
> To: linux-a...@vger.kernel.org; de...@linuxdriverproject.org;
> sparmaintai...@unisys.com; de...@driverdev.osuosl.org; linux-
> wirel...@vger.kernel.org; linu
CONGRATULATIONS YOUR MOBILE NUMBER WON 500,000 CASH FROM SAMSUNG PROMO CLAIMS
SEND YOUR.
NAME
MOBILE NO
AGE
SEX
ADDS
REPLY TO: deptsamsung06@hotmail.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailm
Hi Colin,
thanks for your patches.
#1 is fine. Same fix was provided by Joseph Wright. I tested it and it works
fine.
#2 looks fine, too.
Conerning #3, I would suggest to declare rf69_set_dc_cut_off_frequency static,
as well. Would you prefer to remove rf69_set_dc_cut_off_frequency from the
h
Hi Joseph,
tested your patch and didn't observe a problem.
Thanks for your help :-)
Marcus
> Joseph Wright hat am 16. Juli 2017 um 16:48
> geschrieben:
>
>
> Error should be checked with IS_ERR after calling kthread_run()
> instead of comparing the returned pointer to an int.
>
> Found by spar
On Wed, Jul 19, 2017 at 8:28 PM, Andy Shevchenko
wrote:
> There are new types and helpers that are supposed to be used in new code.
>
> As a preparation to get rid of legacy types and API functions do
> the conversion here.
Please talk to Mika about this one.
Thanks,
Rafael
_
On Wed, Jul 19, 2017 at 01:48:03PM -0400, Mohammed Gamal wrote:
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to de...@linuxdriverproject.org.
> Perhaps that should be updated.
get_maintainer.pl gives you both because drivers/net/ is netdev
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, July 19, 2017 2:53 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> Cc: de...@linuxdriverproject.org; net...@vger.kernel.org
> Subject: [PATCH net-next 3/8] netvsc: change
Hello Todd Kjos,
The patch 26549d177410: "binder: guarantee txn complete / errors
delivered in-order" from Jun 29, 2017, leads to the following static
checker warning:
drivers/android/binder.c:3622 binder_thread_read()
error: uninitialized symbol 'cmd'.
drivers/android/binder.c
The rndis_filter_device_add function is called both in
probe context and RTNL context,and creates the netvsc_device
inner structure. It is easier to get the RTNL lock annotation
correct if it returns the object directly, rather than implicitly
by updating network device private data.
Signed-off-by
Keep back pointer in the per-channel data structure to
avoid any possible RCU related issues when napi poll is
called but netvsc_device is in RCU limbo.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/hyperv_net.h | 1 +
drivers/net/hyperv/netvsc.c | 3 ++-
2 files changed, 3 inserti
In a couple places RTNL is held, and the netvsc_device pointer
is acquired without annotation.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/netvsc.c | 5 +++--
drivers/net/hyperv/netvsc_drv.c | 7 ---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/h
The rndis functions are used when changing device state.
Therefore the references from network device to internal state
are protected by RTNL mutex.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/hyperv_net.h | 6 --
drivers/net/hyperv/netvsc.c | 6 --
drivers/net/hype
If two MTU changes are in less than update interval (2 seconds),
then the netvsc network device may get stuck with no carrier.
The netvsc driver debounces link status events which is fine
for unsolicited updates, but blocks getting the update after
down/up from MTU reinitialization.
Signed-off-by
These fix sparse and lockdep warnings from netvsc driver.
Targeting these at net-next since no actual related failures
have been observed in non-debug kernels.
Stephen Hemminger (8):
netvsc: force link update after MTU change
netvsc: add some rtnl_dereference annotations
netvsc: change order
The netvsc_device structure should be accessed by rcu_dereference
in the send path. Change arguments to netvsc_send() to make
this easier to do correctly.
Remove no longer needed hv_device_to_netvsc_device.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/hyperv_net.h | 10 +++---
Use device detach/attach to ensure that no packets are handed
to device during state changes. Call rndis_filter_open/close
directly as part of later VF related changes.
Signed-off-by: Stephen Hemminger
---
drivers/net/hyperv/hyperv_net.h | 1 +
drivers/net/hyperv/netvsc_drv.c | 38 +
This fixes the error unwind logic for incorrect number of queues.
If netif_set_real_num_XX_queues failed then rndis_filter_device_add
would have been called twice. Since input arguments are already
ranged checked this is a hypothetical only problem, not possible
in actual code.
Signed-off-by: Step
> -Original Message-
> From: Mohammed Gamal [mailto:mga...@redhat.com]
> Sent: Wednesday, July 19, 2017 1:48 PM
> To: Stephen Hemminger
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger ;
> ot...@redhat.com; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; vkuzn...@r
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: "K. Y. Srinivasan"
Cc: Haiyang Zhang
Cc: Stephen Hemminger
Cc: de...@linuxdriverproject.org
Signed-off-by: Andy Shevchenko
---
d
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: "Rafael J. Wysocki"
Cc: Mika Westerberg
Cc: linux-a...@vger.kernel.org
Signed-off-by: Andy Shevchenko
---
drivers/acpi/property.c
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
While here, re-indent couple of lines to increase readability.
Cc: David Kershner
Cc: Greg Kroah-Hartman
Cc: sparmaintai...@unisys.com
This series is converting the rest of the users of old UUID API to a new
one and dropping UUID UAPI header away. Note, ABI is kept the same.
User space should have not used those headers. We have libuuid and it
likely would be extended to cover GUID operations.
All patches have been compiled test
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: Matt Fleming
Cc: Ard Biesheuvel
Signed-off-by: Andy Shevchenko
---
drivers/firmware/efi/cper.c | 10 ++---
include/linux/cper.h
There are new types and helpers that are supposed to be used in new code.
As a preparation to get rid of legacy types and API functions do
the conversion here.
Cc: Tomas Winkler
Cc: Guenter Roeck
Cc: Samuel Ortiz
Signed-off-by: Andy Shevchenko
---
drivers/misc/mei/bus-fixup.c| 35 +++
There is no more users for uapi/uuid.h. Remove it for good.
Anyone needs it in user space better to use libuuid.
Signed-off-by: Andy Shevchenko
---
include/linux/uuid.h | 20 +++-
include/uapi/linux/uuid.h | 42 --
scripts/mod/file2al
Bugfixes for rf69_set_modulation, rf69_set_deviation, rf69_set_lna_gain and
rf69_get_lna_gain
The fixes are cross-checked with the datasheet of the rfm69cw
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Marcus Wolf
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/p
On Wed, 19 Jul 2017 13:48:03 -0400 (EDT)
Mohammed Gamal wrote:
> - Original Message -
> > On Wed, 19 Jul 2017 15:19:28 +0200
> > Mohammed Gamal wrote:
> >
> > > This condition already uses an object of type ipv6hdr in the line above.
> > > Use the object directly instead of calling ip
- Original Message -
> On Wed, 19 Jul 2017 15:19:28 +0200
> Mohammed Gamal wrote:
>
> > This condition already uses an object of type ipv6hdr in the line above.
> > Use the object directly instead of calling ipv6_hdr
> >
> > Signed-off-by: Mohammed Gamal
> > ---
> > drivers/net/hyper
Once again in plain text, only - sorry for frogetting to set the switch in my
mailtool
Hi Dan, Hi Walter,
thank you for your investigation.
rf69_get_modulation, rf69_get_lna_gain, rf69_set_lna_gain: Seems like I messed
up a few things :-/
In the beginning, the defines were left-bound "r
Hi Laurentiu,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.13-rc1 next-20170718]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/laurentiu-tudor-nxp-com/staging
On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
[]
> diff --git a/drivers/staging/speakup/speakup_keypc.c
> b/drivers/staging/speakup/speakup_keypc.c
[]
> @@ -28,7 +28,7 @@
>
> #define DRV_VERSION "2.10"
> #define SYNTH
On Wed, 19 Jul 2017 15:19:28 +0200
Mohammed Gamal wrote:
> This condition already uses an object of type ipv6hdr in the line above.
> Use the object directly instead of calling ipv6_hdr
>
> Signed-off-by: Mohammed Gamal
> ---
> drivers/net/hyperv/netvsc_drv.c | 2 +-
> 1 file changed, 1 insert
From: Colin Ian King
The arguments args->lstio_ses_force and args->lstio_ses_timeout are
in the incorrect order. Fix this by swapping them around.
Detected by CoverityScan, CID#1226833 ("Arguments in wrong order")
Signed-off-by: Colin Ian King
---
drivers/staging/lustre/lnet/selftest/conctl.c
Hi Laurentiu,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.13-rc1 next-20170718]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/laurentiu-tudor-nxp-com/staging
On Wed, Jul 19, 2017 at 04:21:06PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 19, 2017 at 02:57:28PM +0100, Piotr Gregor wrote:
> > + * Id : Description
> > + * 0 Enter the interrupt of amplc_dio200_common
> > + * 1 Called from same ISR of amplc_dio200_common if IRQ is handled
>
>
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit A
> -Original Message-
> From: Mohammed Gamal [mailto:mga...@redhat.com]
> Sent: Wednesday, July 19, 2017 9:19 AM
> To: KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> vkuzn...@redhat.com; cav...@redhat.com; ot...@redh
On Wed, Jul 19, 2017 at 02:57:28PM +0100, Piotr Gregor wrote:
> + * Id : Description
> + * 0 Enter the interrupt of amplc_dio200_common
> + * 1 Called from same ISR of amplc_dio200_common if IRQ is handled
That is a very device-specific tracepoint, do we really want each driver
to be able to set t
This patch originates from the need to measure latency
introduced by driver for Amplicon's PCIE215 during interrupt
handling.
Added is a single ftrace event:
/*
* Tracepoint for calling from various places inside Comedi.
* Takes simple id and prints it to the trace log if trace
* events from Come
Everyone please delete this confidential email. Piotr is leakier than
the Trump administration!
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This condition already uses an object of type ipv6hdr in the line above.
Use the object directly instead of calling ipv6_hdr
Signed-off-by: Mohammed Gamal
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/dri
This patch originates from the need to measure latency
introduced by driver for Amplicon's PCIE215 during interrupt
handling.
Added is a single ftrace event:
/*
* Tracepoint for calling from various places inside Comedi.
* Takes simple id and prints it to the trace log if trace
* events from Come
On Wed, Jul 19, 2017 at 05:36:28AM -0700, Joe Perches wrote:
> On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote:
> > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
> []
> > diff --git a/drivers/staging/speakup/speakup_keypc.c
> > b/drivers/staging/speakup/speakup_keypc.c
>
Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
Signed-off-by: Jaya Durga
---
drivers/staging/speakup/speakup_keypc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/speakup_keypc.c
b/drivers/staging/speakup/speakup_keypc.c
ind
CHECK: Macro argument reuse 'addr' - possible side-effects?
convert AD7280A_DEVADDR to ad7280a_devaddr static function
to fix checkpath check
v3: small style changes
Signed-off-by: Jaya Durga
---
drivers/staging/iio/adc/ad7280a.c | 21 +
1 file changed, 13 insertions(+), 8
Replace symbolic permissions with their
octect representation to fix checkpatch warnings.
Signed-off-by: Jaya Durga
---
drivers/staging/iio/light/tsl2x7x_core.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/iio/light/tsl2x7x_core.c
b/
On Tue, Jul 18, 2017 at 12:53:23PM +0530, Jaya Durga wrote:
> Replace symbolic permissions with their
> octect representation to fix checkpatch warnings.
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/iio/light/tsl2x7x_core.c | 20 ++--
> 1 file changed, 10 insertions(+),
On Tue, Jul 18, 2017 at 05:53:04PM +0530, Jaya Durga wrote:
> CHECK: Macro argument reuse 'addr' - possible side-effects?
>
> convert AD7280A_DEVADDR to ad7280a_devaddr static function
> to fix checkpath check
>
> v3: small style changes
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/ii
From: Laurentiu Tudor
Add an alternate dependency on COMPILE_TEST, thus leaving
this driver compile on other architectures.
Also, other drivers depending on the bus are updated to depend
on ARCH_LAYERSCAPE until they'll also be made multi-arch.
This was compiled tested on:
- booke powerpc (coren
From: Laurentiu Tudor
As raw device io functions are not portable and don't handle byte-order
(triggering suspicion that endianness isn't handled well) switch to
using the standard api.
Since MC expects LE byte-order and the upper layers already take care
of that, we need to trick the device io a
From: Laurentiu Tudor
The bus driver relies on generic msi domain ops.
Fix compilation for architectures that don't provide it (e.g. x86_64).
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
drivers/staging/fsl-mc/bus/fsl-m
From: Laurentiu Tudor
Since there's no real constrain in MC to do only atomic 64-bit we can
enable this driver on 32-bit platforms too.
Include linux/io-64-nonatomic-hi-lo.h to make quad device io apis used
in the driver available on 32-bit platforms.
Signed-off-by: Laurentiu Tudor
Acked-by: Ar
From: Laurentiu Tudor
Use correct format specifier for phys_addr_t variables (%pa) instead
of %llx. This fixes these warnings on 32 bit targets:
"format '%llx' expects argument of type 'long long unsigned int',
but argument 4 has type 'phys_addr_t' [-Wformat=]"
Signed-off-by: Laurentiu Tudor
From: Laurentiu Tudor
The mc-bus specific field, fsl_mc in struct msi_desc is missing its
comment so add it.
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
include/linux/msi.h | 1 +
1 file changed, 1 insertion(+)
diff -
From: Laurentiu Tudor
Apart from a small change (first patch) which adds a missing comment,
this series make the bus driver compile on other architectures, as per
GregKH comment [1].
Compiled tested on:
- booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch [2]
- x86 (i386_defconfig
From: Laurentiu Tudor
Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be
safely dropped.
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 -
dr
From: Laurentiu Tudor
No need to use arch-specific memory barriers; switch to using generic
ones. The rmb()s were useless so drop them.
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
drivers/staging/fsl-mc/bus/mc-sys.c |
On Wed, Jul 19, 2017 at 12:30:28PM +0100, Piotr Gregor wrote:
>
> The information contained in this e-mail is confidential. It may also be
> legally privileged. It is only intended for the stated addressee(s) and
> access to it by any other person is unauthorised.
>
> If you are not an addres
Actually, please drop this patch. I looked at this one the same as I
did the other one, but I didn't look closely enough. It's the same
situation where we have two bugs that probably cancel each other out
somewhat. It maybe needs to be fixed by someone who can test the code.
In rf69_set_lna_gai
Am 19.07.2017 11:51, schrieb Dan Carpenter:
> We had intended to do the mask first and then the shift. Shift has
> higher precedence so we need to add parenthesis.
>
> Fixes: 874bcba65f9a ("staging: pi433: New driver")
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/pi433/rf69
The code looks in imx_enum_frame_size() looks like this:
2066 int index = fse->index;
2067 struct imx_device *dev = to_imx_sensor(sd);
2068
2069 mutex_lock(&dev->input_lock);
2070 if (index >= dev->entries_curr_table) {
2071 mutex_
The problem is this code from ap1302_enum_frame_size():
738 int index = fse->index;
739
740 mutex_lock(&dev->input_lock);
741 context = ap1302_get_context(sd);
742 if (index >= dev->cntx_res[context].res_num) {
743 mutex_unlo
The problem here is this code from atomisp_enum_input():
581 int index = input->index;
582
583 if (index >= isp->input_cnt)
584 return -EINVAL;
585
586 if (!isp->inputs[index].camera)
587 return -EINVAL;
"input-
Hello Marcus Wolf,
The patch 874bcba65f9a: "staging: pi433: New driver" from Jul 16,
2017, leads to the following static checker warning:
drivers/staging/pi433/rf69.c:104 rf69_get_modulation()
warn: shift has higher precedence than mask
drivers/staging/pi433/rf69.c:206 rf
We had intended to do the mask first and then the shift. Shift has
higher precedence so we need to add parenthesis.
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e391ce777bc7..508944
copy_to_user() to user returns the number of bytes that weren't copied,
but we should be returning -EFAULT to the user.
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 1bc478a7f
From: Colin Ian King
Module parameter vbox_modeset and structure vbox_bo_driver do not need to
be in global scope and hence can be made static.
Cleans up a couple of sparse warnings:
symbol 'vbox_modeset' was not declared. Should it be static?
symbol 'vbox_bo_driver' was not declared. Should it
From: Stefan Assmann
Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error:
CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o
In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0:
drivers/staging/rtl8723bs/core/rtw_mlme.c: In function ‘rtw_restruct_sec_ie’:
dr
75 matches
Mail list logo
