Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi

2017-07-15 Thread Greg KH
On Sat, Jul 15, 2017 at 07:05:04PM +0200, Wolf Entwicklungen wrote: > Am Sa, 15.07.2017, 15:47 schrieb Greg KH: > > On Sat, Jul 15, 2017 at 03:40:30PM +0200, Marcus Wolf wrote: > >> Hi Greg, > >> > > Hi Greg, > > now I added a TODO file and did a manual patchwork with lines of the old patch > (gi

Re: [PATCH] staging: lustre: lustre: fix all braces issues reported by checkpatch

2017-07-15 Thread James Simmons
> On Sat, 2017-07-15 at 11:39 -0400, James Simmons wrote: > > Cleanup all braces that was reported by checkpatch. The only > > issue not fixed up is in mdc_lock.c. Removing the braces in > > the case of mdc_lock.c will break the build. > > what checkpatch warning in mdc_locks.c is that? > > $ ./

Re: [PATCH 1/1] drivers/staging/pi433: New driver (fwd)

2017-07-15 Thread Julia Lawall
Please check on lines 894 and 688 (not shown) for the issues mentioned below. Note that the ifs and {s in the following code snippet don't always follow the kernel coding style, eg on line 901. julia -- Forwarded message -- Date: Sun, 16 Jul 2017 04:35:49 +0800 From: kbuild test

Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi

2017-07-15 Thread Wolf Entwicklungen
Am Sa, 15.07.2017, 15:47 schrieb Greg KH: > On Sat, Jul 15, 2017 at 03:40:30PM +0200, Marcus Wolf wrote: >> Hi Greg, >> Hi Greg, now I added a TODO file and did a manual patchwork with lines of the old patch (git format-patch master --stdout -p > pi433_patch) and the newer patch (git diff master

Re: [PATCH] staging: lustre: lustre: fix all braces issues reported by checkpatch

2017-07-15 Thread Joe Perches
On Sat, 2017-07-15 at 11:39 -0400, James Simmons wrote: > Cleanup all braces that was reported by checkpatch. The only > issue not fixed up is in mdc_lock.c. Removing the braces in > the case of mdc_lock.c will break the build. what checkpatch warning in mdc_locks.c is that? $ ./scripts/checkpatc

[PATCH] staging: lustre: lustre: fix all braces issues reported by checkpatch

2017-07-15 Thread James Simmons
Cleanup all braces that was reported by checkpatch. The only issue not fixed up is in mdc_lock.c. Removing the braces in the case of mdc_lock.c will break the build. Signed-off-by: James Simmons -- v1) Initial patch v2) Rebased again

[PATCH] staging: lustre: ko2iblnd: check copy_from_iter/copy_to_iter return code

2017-07-15 Thread James Simmons
From: Arnd Bergmann We now get a helpful warning for code that calls copy_{from,to}_iter without checking the return value, introduced by commit aa28de275a24 ("iov_iter/hardening: move object size checks to inlined part"). drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c: In function 'kib

Re: [PATCH] lustre: check copy_from_iter/copy_to_iter return code

2017-07-15 Thread James Simmons
On Fri, 14 Jul 2017, Al Viro wrote: > On Thu, Jul 13, 2017 at 10:57:59PM +0200, Arnd Bergmann wrote: > > > Thanks for testing it! > > > > That means we did not copy any data and the kernel continues with > > an uninitialized buffer, right? The problem may be the definition of > > > > struct k

Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi

2017-07-15 Thread Greg KH
On Sat, Jul 15, 2017 at 03:40:30PM +0200, Marcus Wolf wrote: > Hi Greg, > > I absolutly agree. My patch should meet the needs of an official patch. Again, don't use html email :) > But I don't know about the exact needs. Can you please help me? What is needed > / missing in my patch and how do

Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi

2017-07-15 Thread Greg KH
On Sat, Jul 15, 2017 at 03:10:48PM +0200, Marcus Wolf wrote: > Hi! > > Ok. Thanks for the info. Didn't observe that. > I'll give the old patch another try. > > I will send a new patch as soon, as I know. how to produce the > poper format (with subjects, signing and so on). Documentation/Subm

Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi

2017-07-15 Thread Greg KH
On Sat, Jul 15, 2017 at 02:59:25PM +0200, Marcus Wolf wrote: > Hi! > > It's me again. Seems like I also need help on sending the email :-/ > > I checked the whitespace/line wrap problem, but couldn't find any suspicious > lines. > > What I did: > * Looked into my outbox - the copy of my mail

Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi

2017-07-15 Thread Marcus Wolf
Hi! It's me again. Seems like I also need help on sending the email :-/ I checked the whitespace/line wrap problem, but couldn't find any suspicious lines. What I did: * Looked into my outbox - the copy of my mail to you seems to be okay... * I sent the patch once again (just to me) - result:

Re: [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read

2017-07-15 Thread Jonathan Cameron
On Fri, 14 Jul 2017 11:31:03 +0200 Arnd Bergmann wrote: > gcc-7 points out an older regression: > > drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw': > drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean > context, did you mean '<' ? [-Werror=int-in-bo

Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi

2017-07-15 Thread Greg KH
On Sat, Jul 15, 2017 at 01:15:43PM +0200, Marcus Wolf wrote: > Hi Greg, > > thanks for your reply :-) > > Today I moved the documentation and header files to drivers/staging/pi433 and > fromated it as a single patch. > > Cheers, > > Marcus I still need it in a format I can apply it in (i.e

[PATCH 3/3] staging: ccree: Use platform_get_irq and devm_request_irq

2017-07-15 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with platform_get_irq() and devm_request_irq(

[PATCH 0/3] staging: ccree: Employ devm_* functions, remove redundant code

2017-07-15 Thread sunil . m
From: Suniel Mahesh Hi This patch series replaces the current API's which request for device resources in driver probe, with devm_*() functions of the kernel framework as recommended by the kernel community. Doing so simplifies driver cleanup paths and code organization. The current set of A

[PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

2017-07-15 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with devm_ioremap_resource(). (b) remove struct

[PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-15 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_kzalloc, which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace kzalloc with devm_kzalloc. (b) drop kfree(), because memory allocated with devm_kzalloc() is automatically freed on driver