This patch fixed code alignment to open paranthesis.
Semantic should not be affected by this patch.
It has been rebased on top of media_tree atomisp branch
Signed-off-by: Philipp Guendisch
Signed-off-by: Chris Baller
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 93 +++--
This patch fixed comment style. Semantic should not be affected.
There are also two warnings left about too long lines, which
reduce readability if changed.
Signed-off-by: Philipp Guendisch
Signed-off-by: Chris Baller
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 44 +++--
On Wed, Jul 12, 2017 at 6:44 PM, Aviv Palivoda wrote:
> On Wed, Jul 12, 2017 at 07:26:08AM +0200, Frans Klaver wrote:
>> On Tue, Jul 11, 2017 at 9:51 PM, Aviv Palivoda wrote:
>> > Fix the following sparse warning:
>> > drivers/staging//wlan-ng/prism2sta.c:1691:20: warning: incorrect type in
>> >
On Jul 12, 2017, at 10:10 PM, Rui Teng wrote:
> Comparing two user space addresses to avoid sparse error:
>
> drivers/staging//lustre/lnet/selftest/conrpc.c:490:30: error:
> incompatible types in comparison expression (different address spaces)
>
> Signed-off-by: Rui Teng
> ---
> drivers/stagi
Comparing two user space addresses to avoid sparse error:
drivers/staging//lustre/lnet/selftest/conrpc.c:490:30: error:
incompatible types in comparison expression (different address spaces)
Signed-off-by: Rui Teng
---
drivers/staging/lustre/lnet/selftest/conrpc.c | 5 ++---
1 file changed, 2 i
On Jul 7, 2017, at 16:03, Dmitriy Cherkasov wrote:
>
> After removing commented out code, ksocknal_csum() becomes a useless
> wrapper for crc32_le(). Remove it, and instead call crc32_le() directly.
>
> Fixes the following checkpatch warning:
>
> WARNING: space prohibited before semicolon
>
>
On Jul 7, 2017, at 16:03, Dmitriy Cherkasov wrote:
>
> After removing commented out code, ksocknal_csum() becomes a useless
> wrapper for crc32_le(). Remove it, and instead call crc32_le() directly.
>
> Fixes the following checkpatch warning:
>
> WARNING: space prohibited before semicolon
>
>
From: Alfonso Lima Astor
These variables were set to u16 and u32 although they always hold a little
endian value.
This patch fixes multiple sparse warnings like:
drivers/staging/wlan-ng/prism2sta.c:375:46: warning: cast to restricted __le16
Signed-off-by: Alfonso Lima Astor
---
drivers/stagin
According the coding style guidelines, the ENOSYS error code must be returned
in case of a non existent system call. This code has been replaced with
the ENOTTY error code indicating a missing functionality.
v2: Improved punctuation
Fixed patch subject
Signed-off-by: Yves Lemée
---
drivers/
> spk_ttyio_initialise_ldisc is called separately for each module (e.g.
> speakup_apollo, speakup_ltlk etc) when it is loaded. spk_ttyio_release
> is also called separately for each module when it is unloaded. The ldisc
> stays around until the last of the modules is unloaded.
What guarantees that
> When opening from kernel, we don't use file pointer. The count mismatch
> is between tty->count and #fd's. So opening from kernel leads to #fd's
> being less than tty->count. I thought this difference is relevant to
> user-space opening of tty, and not to kernel opening of tty. Can you
> suggest
On 07/12/2017 08:50 AM, Philipp Zabel wrote:
On Tue, 2017-07-11 at 15:18 +0200, Arnd Bergmann wrote:
While looking at a compiler warning, I noticed the use of
IS_ERR_OR_NULL, which is generally a sign of a bad API design
and should be avoided.
In this driver, this is fairly easy, we can simpl
On Wed, Jul 12, 2017 at 07:26:08AM +0200, Frans Klaver wrote:
> On Tue, Jul 11, 2017 at 9:51 PM, Aviv Palivoda wrote:
> > Fix the following sparse warning:
> > drivers/staging//wlan-ng/prism2sta.c:1691:20: warning: incorrect type in
> > assignment (different base types)
> >
> > (a) Change struct
On Wed, Jul 12, 2017 at 08:06:24AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 11, 2017 at 10:03:01PM +0100, Sudip Mukherjee wrote:
> > Hi Greg,
> >
> > On Fri, Jun 30, 2017 at 09:57:43PM +0100, Sudip Mukherjee wrote:
> > > From: Teddy Wang
> > >
> >
> > A gentle ping.
>
> It's in the midd
On Tue, 2017-07-11 at 15:18 +0200, Arnd Bergmann wrote:
> While looking at a compiler warning, I noticed the use of
> IS_ERR_OR_NULL, which is generally a sign of a bad API design
> and should be avoided.
>
> In this driver, this is fairly easy, we can simply stop storing
> error pointers in persi
On Wed, 12 Jul 2017 18:28:56 +0530
PrasannaKumar Muralidharan wrote:
> Hi Christian,
>
> On 12 July 2017 at 17:48, Christian Gromm
> wrote:
> >
> > Hi,
> >
> > Microchip is planning to introduce a driver for a new companion
> > chip series capable of electical energy measurement. However, we
>
On Wed, 12 Jul 2017 14:51:01 +0200
Greg KH wrote:
> On Wed, Jul 12, 2017 at 02:18:54PM +0200, Christian Gromm wrote:
> >
> > Hi,
> >
> > Microchip is planning to introduce a driver for a new companion
> > chip series capable of electical energy measurement. However, we
> > are not sure which lo
Hi Christian,
On 12 July 2017 at 17:48, Christian Gromm wrote:
>
> Hi,
>
> Microchip is planning to introduce a driver for a new companion chip series
> capable of electical energy measurement. However, we are not sure which
> location in the source tree is the most suitable. First thought was to
On Wed, Jul 12, 2017 at 02:18:54PM +0200, Christian Gromm wrote:
>
> Hi,
>
> Microchip is planning to introduce a driver for a new companion chip series
> capable of electical energy measurement. However, we are not sure which
> location in the source tree is the most suitable. First thought was
Jaya Durga, on mer. 12 juil. 2017 16:53:53 +0530, wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
IIRC synth_immediate is meant to be usable in atomic contexts too, so
usleep can't be used.
Samuel
___
devel mailing list
de..
On Wed, Jul 12, 2017 at 04:53:53PM +0530, Jaya Durga wrote:
> Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/speakup/speakup_keypc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/st
Instead of directly using -Wno-foo, use cc-disable-warning, as it
checks if the compiler has the warnings we want to disable.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/atomisp/pci/atomisp2/Makefile | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
Hi,
Microchip is planning to introduce a driver for a new companion chip series
capable of electical energy measurement. However, we are not sure which
location in the source tree is the most suitable. First thought was to put
it into /drivers/powercap. But now we are in discussions whether it wo
Fix checkpatch issue: CHECK: usleep_range is preferred over udelay;
Signed-off-by: Jaya Durga
---
drivers/staging/speakup/speakup_keypc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/speakup_keypc.c
b/drivers/staging/speakup/speakup_keypc.c
ind
This fixes multiple block statements found not to match
style as per checkpatch
Signed-off-by: Craig Inches
---
drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 +
1 file changed, 81 insertions(+), 48 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/lne
This fixes a block statement which didnt end with */
Signed-off-by: Craig Inches
---
drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h
b/drivers/staging/lustre/include/lin
This patch fixes some multiline comment blocks which didnt conform
to the style guide, found by checkpatch.
Signed-off-by: Craig Inches
---
.../staging/lustre/include/linux/lnet/lib-types.h | 46 ++
1 file changed, 30 insertions(+), 16 deletions(-)
diff --git a/drivers/stag
This patch fixes a warning generated by checkpatch for
a line over 80 characters.
Signed-off-by: Craig Inches
---
drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h
b/dri
This series fixes a few style issues in lustre. All where picked up
by checkpatch.
v2 Changes:
- Fixed typo in patch subject s/luster/lustre/
Craig Inc
Hi Gilad,
I have added your comments and resent the patch.Thanks
On 11/07/17 17:16, Gilad Ben-Yossef wrote:
Hello Philip,
Thank your patch.
Your patch subject line is not descriptive and not formatted well.
A better subject would be something like:
staging: ccree: move comment to fit coding
On Wed, 2017-07-12 at 08:12 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 12, 2017 at 10:23:02AM +0800, Rui Teng wrote:
> > On 12/07/2017 1:04 AM, Greg Kroah-Hartman wrote:
> > > On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote:
> > > > This patch sets memory to zero directly to avoid unne
On Fri, Jun 30, 2017 at 8:39 PM, Mark Rogers wrote:
> Thank you for your feedback. I guess when making this patch I had the
> preferred coding style in mind, but didn't ask myself if making the code
> conform to it would truly improve readability.
>
> I agree with all of your comments. Do you thin
We were fixing checkpatch.pl warnings and accidentally reversed this
condition.
Fixes: 5b291e3c ("staging: rtl8188eu: removes comparison to null")
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 002d09159896
On Tue, Jul 11, 2017 at 06:02:09PM +0200, Marcus Wolf wrote:
> Hi folks,
>
> I developed a radio shield for the 433MHz ISM band [0] for the Raspberry Pi.
> This shield is called Pi433 [1]. It can be used to communicate between two
> Raspberries or to control third party equipment e. g. cheap radio
Trivial fix for Line over 80 characters
Moved the comment to top of the definition
Signed-off-by: Bincy K Philip
---
drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/c
35 matches
Mail list logo
