On 10 July 2017 at 01:22, Sakari Ailus wrote:
> On Sun, Jul 09, 2017 at 05:56:15PM +0530, hari prasath wrote:
>> On 8 July 2017 at 16:31, Sakari Ailus wrote:
>> > Hi Hari,
>> >
>> > On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
>> >> kstrdup kernel primitive can be used to replace
kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool.
Signed-off-by: Hari Prasath
---
v1: Replace kmalloc followed by memcpy with kmemdup. Based on
review comments from Alan Cox, this could better be done
Hi Mitchell,
On 09-07-17, 20:25, Mitchell Tasman wrote:
> Adjust formatting of various statements to keep line length within
> the 80 column limit preferred by the Linux kernel coding style.
We try to follow that most of the time, but the end result should be easily
readable. If it isn't, then w
Adjust formatting of various statements to keep line length within
the 80 column limit preferred by the Linux kernel coding style.
Signed-off-by: Mitchell Tasman
---
Changes in v2: Add back a missing space in a comment
drivers/staging/greybus/arche-platform.c | 29 +++--
> -Original Message-
> From: armetallica [mailto:armetall...@gmail.com]
> Sent: Sunday, July 9, 2017 7:58 PM
> To: gre...@linuxfoundation.org
> Cc: *S-Par-Maintainer ;
> de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org
> Subject: [PATCH]
>
> From bb1aac6ae6b21b903d8743712e21aeb1a6b
From: Tyler Olivieri
Patch to fix following checkpatch warning:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: Tyler Olivieri
---
drivers/staging/ccree/ssi_fips.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_fips.c
From: Tyler Olivieri
Patch to fix checkpatch errors:
ERROR: that open brace { should be on the previous line
ERROR: open brace '{' following function declarations go on the next line
Signed-off-by: Tyler Olivieri
---
drivers/staging/ccree/ssi_buffer_mgr.c | 12 ++---
drivers/staging/ccree/ssi_
From: Tyler Olivieri
This patchset fixes several checkpatch errors and warnings in /staging/ccree:
ERROR: that open brace { should be on the previous line
ERROR: open brace '{' following function declarations go on the next line
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function
From: Tyler Olivieri
Patch to fix following checkpatch error:
ERROR: do not use assignment in if condition
Signed-off-by: Tyler Olivieri
---
drivers/staging/ccree/ssi_hash.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/sta
From: Tyler Olivieri
Patch to fix following checkpatch error:
ERROR: switch and case should be at the same indent
Signed-off-by: Tyler Olivieri
---
drivers/staging/ccree/ssi_hash.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cc
From: Tyler Olivieri
Patch to remove checkpatch warning:
WARNING: Statements terminations use 1 semicolon
Signed-off-by: Tyler Olivieri
---
drivers/staging/ccree/ssi_buffer_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c
b/drive
>From bb1aac6ae6b21b903d8743712e21aeb1a6b22163 Mon Sep 17 00:00:00 2001
From: Armin Schoenlieb
Date: Mon, 10 Jul 2017 01:52:41 +0200
Subject: [PATCH] staging: unisys: visorbus: fix brace coding style issue in
visorbus_main.c This is a patch to the visorbus_main.c file that fixes up six
brace err
txq_count receives a value from wilc_wlan_handle_txq()
and therefore should be u32
found using sparse:
drivers/staging/wilc1000/linux_wlan.c:306:58: warning:
incorrect type in argument 2 (different signedness)
Signed-off-by: Ilia Sergachev
---
drivers/staging/wilc1000/linux_wlan.c | 3 ++-
1 f
Adjust formatting of various statements to keep line length within
the 80 column limit preferred by the Linux kernel coding style.
Signed-off-by: Mitchell Tasman
---
drivers/staging/greybus/arche-platform.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
di
>From 043428d63637a6dd8e52449b73dbb8341885d7e4 Mon Sep 17 00:00:00 2001
From: Armin Schoenlieb
Date: Mon, 10 Jul 2017 01:12:52 +0200
Subject: [PATCH] Staging: media: atomisp2: fixed trailing whitespace error in
atomisp_v4l2.c This is a patch to the atomisp_v4l2.c file that fixes up a
trailing wh
On Sun, Jul 09, 2017 at 05:56:15PM +0530, hari prasath wrote:
> On 8 July 2017 at 16:31, Sakari Ailus wrote:
> > Hi Hari,
> >
> > On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
> >> kstrdup kernel primitive can be used to replace kmalloc followed by
> >> string copy. This was report
Hi,
On Sun, Jul 09, 2017 at 06:04:17PM +0300, Andy Shevchenko wrote:
> Above
> 1. take mutex
> 2. take reference
>
> Here:
> 1. give mutex back
> 2. give reference back
>
> I think we usually see symmetrical calls, i.e.
>
> 1. give reference back
> 2. give mutex back
>
> So, what did I miss
On Sun, 2017-07-09 at 19:39 +0200, Philipp Guendisch wrote:
> This patch fixed alignment, comment style and one appearance of
> misordered constant in an if comparison.
> Semantic should not be affected by this patch.
Your email subject is wrong. This is not a checkpatch patch.
Your subject line
On Thu, 6 Jul 2017 18:56:26 -0400
Brian Masney wrote:
> The return value from tsl2x7x_invoke_change() was not checked in most
> places in the driver. This patch adds the proper error checks. The
> return values inside tsl2x7x_invoke_change() are now checked by
> this patch as well.
>
> Previous
This patch fixed alignment, comment style and one appearance of
misordered constant in an if comparison.
Semantic should not be affected by this patch.
There are still a few warnings and even errors left which require
a semantic change of the code to fix.
e.g. use of in_atomic in drivers
There ar
On Thu, 6 Jul 2017 18:56:25 -0400
Brian Masney wrote:
> The driver explicitly creates the in_illuminance0_integration_time sysfs
> attribute outside the IIO core. This attribute is available in the IIO
> core so this patches migrates the attribute to be created by
> the iio_chan_spec.
>
> Signe
On Thu, 6 Jul 2017 18:56:24 -0400
Brian Masney wrote:
> This driver in some cases can busy wait for upwards of 15ms. Since the
> kernel at this point is not running in atomic context, and is running in
> process context, we can safely use usleep_range() instead. This patch
> changes the two occu
On Thu, 6 Jul 2017 18:56:23 -0400
Brian Masney wrote:
> tsl2x7x_read_thresh() and tsl2x7x_write_thresh() currently assumes
> that IIO_EV_INFO_VALUE is the only iio_event_info that will be
> passed in. This patch refactors these two functions so that
> additional iio_event_infos can be passed in
On Thu, 6 Jul 2017 18:56:22 -0400
Brian Masney wrote:
> The calibration function calls i2c_smbus_write_byte() and
> i2c_smbus_read_byte(). These two function calls are replaced with a
> single call to i2c_smbus_read_byte_data() by this patch. This patch
> also removes an unnecessary call that re
On Thu, 6 Jul 2017 18:56:21 -0400
Brian Masney wrote:
> tsl2x7x_i2c_read() would call i2c_smbus_write_byte() and
> i2c_smbus_read_byte(). These two i2c functions can be replaced with a
> single call to i2c_smbus_read_byte_data(). This patch removes the
> tsl2x7x_i2c_read() function and replaces
On Thu, 6 Jul 2017 18:56:20 -0400
Brian Masney wrote:
> The TSL2X7X driver has a custom power_state sysfs attribute. Remove this
> attribute since the runtime power management code provides a sysfs
> attribute to control the power state of the device.
>
> Signed-off-by: Brian Masney
Applied.
>
On Thu, 6 Jul 2017 18:56:19 -0400
Brian Masney wrote:
> Add device tree documentation for the tsl2x7x IIO driver.
>
> Signed-off-by: Brian Masney
> CC: Rob Herring
> CC: Mark Rutland
> CC: devicet...@vger.kernel.org
For what it's worth given the simplicity of the patch
Acked-by: Jonathan Ca
On Thu, 6 Jul 2017 18:56:18 -0400
Brian Masney wrote:
> Add device tree support for the tsl2x7x IIO driver with no custom
> properties. The device tree documentation is in a separate commit so
> that the changes to trivial-devices.txt can go in via the device
> tree subsystem.
>
> Signed-off-by
Use BIT macro instead of left shifting in android/ion/ion.h
Signed-off-by: Mateusz Nowotyński
---
drivers/staging/android/ion/ion.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.h
b/drivers/staging/android/ion/ion.h
index b91328a..621e5f
Removes unnecessary blank lines in android/ion/ion_system_heap.c
Signed-off-by: Mateusz Nowotyński
---
drivers/staging/android/ion/ion_system_heap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_system_heap.c
b/drivers/staging/android/ion/ion_system_heap.c
Converts sizeof(type) to sizeof(variable) in android/ion/ion_cma_heap.c
Signed-off-by: Mateusz Nowotyński
---
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c
b/drivers/staging/android/ion/i
Removes unnecessary blank lines in android/ion/ion_cma_heap.c
Signed-off-by: Mateusz Nowotyński
---
drivers/staging/android/ion/ion_cma_heap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c
b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc
Fixes code alignment issue in ion/ion.h
Signed-off-by: Mateusz Nowotyński
---
drivers/staging/android/ion/ion.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/ion/ion.h
b/drivers/staging/android/ion/ion.h
index fa9ed81..b91328a 100644
--- a/d
On Sun, Jul 9, 2017 at 2:41 PM, Okash Khawaja wrote:
> +struct tty_struct *tty_kopen(dev_t device)
> +{
> + struct tty_struct *tty;
> + struct tty_driver *driver = NULL;
> + int index = -1;
> +
> + mutex_lock(&tty_mutex);
> + driver = tty_lookup_driver(device, NULL,
When TTY is not built, tty_kopen should return an error. This way
calling code remains consistent, regardless of whether tty is built or
not. This patch returns -ENODEV when there is no tty.
Signed-off-by: Okash Khawaja
---
include/linux/tty.h |2 +-
1 file changed, 1 insertion(+), 1 deleti
On Sun, Jul 09, 2017 at 01:50:55PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 09, 2017 at 12:41:55PM +0100, Okash Khawaja wrote:
> > This patch replaces call to tty_open_by_driver with a tty_kopen.
> >
> > Signed-off-by: Okash Khawaja
> >
> > ---
> > drivers/staging/speakup/spk_ttyio.c |
On 8 July 2017 at 16:31, Sakari Ailus wrote:
> Hi Hari,
>
> On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
>> kstrdup kernel primitive can be used to replace kmalloc followed by
>> string copy. This was reported by coccinelle tool
>>
>> Signed-off-by: Hari Prasath
>> ---
>> .../me
On Sun, Jul 09, 2017 at 12:41:53PM +0100, Okash Khawaja wrote:
> On Sat, Jul 08, 2017 at 10:38:03AM +0200, Greg Kroah-Hartman wrote:
> > Overall, the idea looks sane to me. Keeping userspace from opening a
> > tty that the kernel has opened internally makes sense, hopefully
> > userspace doesn't g
On Sun, Jul 09, 2017 at 12:41:54PM +0100, Okash Khawaja wrote:
> The commit 12e84c71b7d4ee (tty: export tty_open_by_driver) exports
> tty_open_by_device to allow tty to be opened from inside kernel which
> works fine except that it doesn't handle contention with user space or
> another kernel-space
On Sun, Jul 09, 2017 at 12:41:55PM +0100, Okash Khawaja wrote:
> This patch replaces call to tty_open_by_driver with a tty_kopen.
>
> Signed-off-by: Okash Khawaja
>
> ---
> drivers/staging/speakup/spk_ttyio.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/staging/
Since we have tty_kopen, we no longer need to export tty_open_by_driver.
This patch makes this function static.
Signed-off-by: Okash Khawaja
---
drivers/tty/tty_io.c |3 +--
include/linux/tty.h |5 -
2 files changed, 1 insertion(+), 7 deletions(-)
--- a/drivers/tty/tty_io.c
+++ b/
On Sat, Jul 08, 2017 at 10:38:03AM +0200, Greg Kroah-Hartman wrote:
> Overall, the idea looks sane to me. Keeping userspace from opening a
> tty that the kernel has opened internally makes sense, hopefully
> userspace doesn't get too confused when that happens. I don't think we
> normally return
This patch replaces call to tty_open_by_driver with a tty_kopen.
Signed-off-by: Okash Khawaja
---
drivers/staging/speakup/spk_ttyio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -164,7 +164,7 @@
The commit 12e84c71b7d4ee (tty: export tty_open_by_driver) exports
tty_open_by_device to allow tty to be opened from inside kernel which
works fine except that it doesn't handle contention with user space or
another kernel-space open of the same tty. For example, opening a tty
from user space while
44 matches
Mail list logo
