[PATCH] staging: rtl8712: fix "Alignment match open parenthesis"

2017-07-06 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/rtl8712/mlme_linux.c| 4 ++-- drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- drivers/staging/rtl8712/rtl8712_efuse.c | 2 +- 3 files changed, 4 insertions(+), 4 deletio

[PATCH 4/4] Staging: Lustre Fix block statement style issue

2017-07-06 Thread Craig Inches
This fixes a block statement which didnt end with */ Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/lin

[PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h

2017-07-06 Thread Craig Inches
This fixes multiple block statements found not to match style as per checkpatch Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 + 1 file changed, 81 insertions(+), 48 deletions(-) diff --git a/drivers/staging/lustre/include/linux/lne

[PATCH 1/4] Staging: Luster: Clean up line over 80Char in lib-lnet.h

2017-07-06 Thread Craig Inches
This patch fixes a warning generated by checkpatch for a line over 80 characters. Signed-off-by: Craig Inches --- drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/include/linux/lnet/lib-lnet.h b/dri

[PATCH 2/4] Staging: Lustre Fix up multiple Block Comments in lib-types.h

2017-07-06 Thread Craig Inches
This patch fixes some multiline comment blocks which didnt conform to the style guide, found by checkpatch. Signed-off-by: Craig Inches --- .../staging/lustre/include/linux/lnet/lib-types.h | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers/stag

[PATCH 0/4] Staging: Lustre Style Fixes

2017-07-06 Thread Craig Inches
This series fixes a few style issues in lustre. All where picked up by checkpatch. Craig Inches (4): Staging: Luster: Clean up line over 80Char in lib-lnet.h Staging: Lustre Fix up multiple Block Comments in lib-types.h Staging: Lustre Fixing multiline block comments in lnetst.h Staging:

Re: [PATCH v2] staging: typec: Fix endianness warning discovered by sparse

2017-07-06 Thread Thomas Gardner
Guenter Roeck / 2017-07-06T17:13-0700 > On 07/06/2017 03:54 PM, Thomas Gardner wrote: > > The below warning is resolved by removing the cpu_to_le32() call. This > > call was redundant; vdm_run_state_machine() ensures that SVDM responses > > have the correct endianness before sending. > > > > typec

[PATCH v3] staging: typec: Fix endianness warning discovered by sparse

2017-07-06 Thread Thomas Gardner
The below warning is resolved by removing the cpu_to_le32() call. This call was redundant; vdm_run_state_machine() ensures that SVDM responses have the correct endianness before sending. typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types) typec/tcpm.c:1019:49:ex

Re: [PATCH v2] staging: typec: Fix endianness warning discovered by sparse

2017-07-06 Thread Guenter Roeck
On 07/06/2017 03:54 PM, Thomas Gardner wrote: The below warning is resolved by removing the cpu_to_le32() call. This call was redundant; vdm_run_state_machine() ensures that SVDM responses have the correct endianness before sending. typec/tcpm.c:1019:49: warning: incorrect type in assignment (di

[PATCH] vmbus: fix the missed signaling in hv_signal_on_read()

2017-07-06 Thread Dexuan Cui
There is an off-by-one bug here, which can cause host-to-guest write to stall. When cur_write_sz == pending_sz, we shouldn't signal the host because it's meaningless: the ring mustn't be 100% full. But when cached_write_sz == pending_sz, we must signal the host. Fixes: 433e19cf33d3 ("Drivers: hv

[PATCH v2 9/9] staging: iio: tsl2x7x: check return value from tsl2x7x_invoke_change()

2017-07-06 Thread Brian Masney
The return value from tsl2x7x_invoke_change() was not checked in most places in the driver. This patch adds the proper error checks. The return values inside tsl2x7x_invoke_change() are now checked by this patch as well. Previously, if there was an error turning the chip back on, then the driver w

[PATCH v2 6/9] staging: iio: tsl2x7x: refactor {read, write}_event_value to allow handling multiple iio_event_infos

2017-07-06 Thread Brian Masney
tsl2x7x_read_thresh() and tsl2x7x_write_thresh() currently assumes that IIO_EV_INFO_VALUE is the only iio_event_info that will be passed in. This patch refactors these two functions so that additional iio_event_infos can be passed in. The functions are renamed from tsl2x7x_{read,write}_thresh() to

[PATCH v2 8/9] staging: iio: tsl2x7x: migrate in_illuminance0_integration_time sysfs attribute to iio_chan_spec

2017-07-06 Thread Brian Masney
The driver explicitly creates the in_illuminance0_integration_time sysfs attribute outside the IIO core. This attribute is available in the IIO core so this patches migrates the attribute to be created by the iio_chan_spec. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2x7x.c | 68

[PATCH v2 4/9] staging: iio: tsl2x7x: remove tsl2x7x_i2c_read()

2017-07-06 Thread Brian Masney
tsl2x7x_i2c_read() would call i2c_smbus_write_byte() and i2c_smbus_read_byte(). These two i2c functions can be replaced with a single call to i2c_smbus_read_byte_data(). This patch removes the tsl2x7x_i2c_read() function and replaces all occurrences with a call to i2c_smbus_read_byte_data(). Signe

[PATCH v2 5/9] staging: iio: tsl2x7x: cleaned up i2c calls in tsl2x7x_als_calibrate()

2017-07-06 Thread Brian Masney
The calibration function calls i2c_smbus_write_byte() and i2c_smbus_read_byte(). These two function calls are replaced with a single call to i2c_smbus_read_byte_data() by this patch. This patch also removes an unnecessary call that reads the CNTRL register a second time. One of the error paths retu

[PATCH v2 7/9] staging: iio: tsl2x7x: use usleep_range() instead of mdelay()

2017-07-06 Thread Brian Masney
This driver in some cases can busy wait for upwards of 15ms. Since the kernel at this point is not running in atomic context, and is running in process context, we can safely use usleep_range() instead. This patch changes the two occurrences of mdelay() to usleep_range(). Signed-off-by: Brian Masn

[PATCH v2 2/9] staging: iio: tsl2x7x: add device tree documentation

2017-07-06 Thread Brian Masney
Add device tree documentation for the tsl2x7x IIO driver. Signed-off-by: Brian Masney CC: Rob Herring CC: Mark Rutland CC: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/trivial-devices.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetr

[PATCH v2 0/9] staging: iio: tsl2x7x: staging cleanups

2017-07-06 Thread Brian Masney
This begins my work to clean this driver up and eventually move it out of staging. Driver changes were tested using a TSL2771 hooked up to a Raspberry Pi 2. Thanks to Jon Brenner at AMS/TAOS for loaning me some hardware samples to test my driver changes. Changes since v1: - checkpatch cleanups (o

[PATCH v2 1/9] staging: iio: tsl2x7x: add of_match table for device tree support

2017-07-06 Thread Brian Masney
Add device tree support for the tsl2x7x IIO driver with no custom properties. The device tree documentation is in a separate commit so that the changes to trivial-devices.txt can go in via the device tree subsystem. Signed-off-by: Brian Masney CC: Rob Herring CC: Mark Rutland CC: devicet...@vge

[PATCH v2 3/9] staging: iio: tsl2x7x: remove redundant power_state sysfs attribute

2017-07-06 Thread Brian Masney
The TSL2X7X driver has a custom power_state sysfs attribute. Remove this attribute since the runtime power management code provides a sysfs attribute to control the power state of the device. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2x7x.c | 34 ---

[PATCH v2] staging: typec: Fix endianness warning discovered by sparse

2017-07-06 Thread Thomas Gardner
The below warning is resolved by removing the cpu_to_le32() call. This call was redundant; vdm_run_state_machine() ensures that SVDM responses have the correct endianness before sending. typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types) typec/tcpm.c:1019:49:ex

Re: [PATCH v4] staging: lustre: lnet: remove dead code and crc32_le() wrapper

2017-07-06 Thread Dmitriy Cherkasov
On 06/29/2017 10:50 PM, Dmitriy Cherkasov wrote: After removing code which was permanently disabled with ifdefs, the function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove this useless wrapper and instead call crc32_le() directly. Any feedback on v4 please?

Re: [PATCH 1/6] staging: iio: tsl2x7x: add of_match table for device tree support

2017-07-06 Thread Rob Herring
On Thu, Jun 29, 2017 at 01:03:47PM -0400, Brian Masney wrote: > Add device tree support for the tsl2x7x IIO driver with no custom > properties. > > Signed-off-by: Brian Masney > CC: Rob Herring > CC: Mark Rutland > CC: devicet...@vger.kernel.org > --- > Documentation/devicetree/bindings/trivia

[PATCH] staging: atomisp: gc2235: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 107541360 4 121182f56 drivers/st

[PATCH] staging: atomisp: mt9m114: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 151482640 8 177964584 drivers/st

[PATCH] staging: atomisp: ov5693: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 207293264 0 239935db9 drivers/st

[PATCH] staging: atomisp: ov2722: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 147711880 0 16651410b drivers/s

[PATCH] staging: atomisp: gc0310: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 102971888 0 121852f99 drivers/s

[PATCH] staging: atomisp: ov8858: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 238048448 0 322527dfc drivers/s

[PATCH] staging: atomisp: ov2680: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 124663120 8 155943cea drivers/s

[PATCH] staging: atomisp: lm3554: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 53471920 2472911c7b drivers/s

Re: [PATCH] staging: typec: Fix type mismatch found with sparse

2017-07-06 Thread Guenter Roeck
On 07/05/2017 07:57 PM, Thomas Gardner wrote: Guenter Roeck / 2017-07-05T07:25-0700 On 07/05/2017 07:00 AM, Thomas Gardner wrote: The warning below is resolved by casting the LHS to __le32. typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types) typec/tcpm.c:1019:49

Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer

2017-07-06 Thread Dan Carpenter
On Thu, Jul 06, 2017 at 07:29:32AM +0530, yash007 wrote: > From: Yash Omer > Send your patch to yourself until you figure out the right format then send it to the list. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http:/

[PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer

2017-07-06 Thread yash007
From: Yash Omer --- drivers/staging/dgnc/dgnc_neo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 1943e66..0034ebe 100644 --- a/drivers/staging/dgnc/dgnc_neo.c +++ b/drivers/staging/dgnc/dgnc

Re: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro

2017-07-06 Thread Frans Klaver
On Thu, Jul 6, 2017 at 9:13 AM, Jaya Durga wrote: > Subject: Staging: lustre :lustre: include :lustre_compat.h: Prefer using the > BIT macro Don't overdo it ;-). Subject: staging: lustre: lustre_compat.h: Prefer using the BIT macro > Replace all instances of (1 << 27) with BIT(27) to fix > che

[PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro

2017-07-06 Thread Jaya Durga
Replace all instances of (1 << 27) with BIT(27) to fix checkpatch check messages Signed-off-by: Jaya Durga --- drivers/staging/lustre/lustre/include/lustre_compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_compat.h b/driver

[PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer

2017-07-06 Thread yash007
From: Yash Omer --- drivers/staging/dgnc/dgnc_neo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 1943e66..0034ebe 100644 --- a/drivers/staging/dgnc/dgnc_neo.c +++ b/drivers/staging/dgnc/dgnc

[PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer

2017-07-06 Thread yash007
From: Yash Omer --- drivers/staging/dgnc/dgnc_neo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 1943e66..0034ebe 100644 --- a/drivers/staging/dgnc/dgnc_neo.c +++ b/drivers/staging/dgnc/dgnc