Re: [greybus-dev] [PATCH v2] staging: greybus: loopback_test: fix comment style issues

2017-07-04 Thread Aleksey Rybalkin
On Tue, Jul 04, 2017 at 10:28:10AM +0200, Johan Hovold wrote: > On Tue, Jul 04, 2017 at 11:47:51AM +0530, Viresh Kumar wrote: > > + Greg > > > > On 03-07-17, 23:27, Aleksey Rybalkin wrote: > > > According to checkpatch warning, block comments should align the * on > > > each line. Also, preferred

[PATCH] Staging: android/ion: fix sparse warnings

2017-07-04 Thread Joseph Wright
ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \ was not declared. Should it be static? ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \ was not declared. Should it be static? ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \

Re: [PATCH] hv: fix msi affinity when device requests all possible CPU's

2017-07-04 Thread Stephen Hemminger
On Sun, 2 Jul 2017 16:38:19 -0500 Bjorn Helgaas wrote: > On Wed, Jun 28, 2017 at 04:22:04PM -0700, Stephen Hemminger wrote: > > When Intel 10G (ixgbevf) is passed to a Hyper-V guest with SR-IOV, > > the driver requests affinity with all possible CPU's (0-239) even > > those CPU's are not online (

[PATCH] drivers/staging/media/atomisp/i2c/gc2235: fix sparse warning: missing static

2017-07-04 Thread Guillermo O. Freschi
Several local use structs were missing declarations. Added static qualifier to clean up Sparse warning. Signed-off-by: Guillermo O. Freschi --- drivers/staging/media/atomisp/i2c/gc2235.c | 2 +- drivers/staging/media/atomisp/i2c/gc2235.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(

Re: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined

2017-07-04 Thread Stefan Assmann
On 04.07.2017 13:01, Kalle Valo wrote: > Stefan Assmann writes: > >> Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error: >> CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o >> In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0: >> drivers/staging/rtl8723

Re: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined

2017-07-04 Thread Kalle Valo
Stefan Assmann writes: > Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error: > CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o > In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0: > drivers/staging/rtl8723bs/core/rtw_mlme.c: In function ‘rtw_restruct_s

[PATCH 7/7] Staging: rtl8712 : rtl871x_io.c:fix coding style of kmalloc usage

2017-07-04 Thread Jaya Durga
CHECK: multiple assignments should be avoided CHECK: Prefer kmalloc(sizeof(*pintf_hdl->pintfpriv)...) over kmalloc(sizeof(struct intf_priv)...) Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/rtl871x_io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/stagin

Re: [PATCH] staging: comedi: Use offset_in_page macro

2017-07-04 Thread Ian Abbott
On 04/07/17 00:13, Amitoj Kaur Chawla wrote: Use offset_in_page macro instead of (var & ~PAGE_MASK) The Coccinelle semantic patch used to make this change is as follows: // @@ unsigned long p; @@ - p & ~PAGE_MASK + offset_in_page(p) // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/c

Re: [greybus-dev] [PATCH v2] staging: greybus: loopback_test: fix comment style issues

2017-07-04 Thread Johan Hovold
On Tue, Jul 04, 2017 at 11:47:51AM +0530, Viresh Kumar wrote: > + Greg > > On 03-07-17, 23:27, Aleksey Rybalkin wrote: > > According to checkpatch warning, block comments should align the * on > > each line. Also, preferred style for multi-line comments is starting the > > comment text after the s