[PATCH v2 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding style issue

2017-06-28 Thread Jaya Durga
The following variables and struct name are renamed to avoid camelcase issue Configuration to configuration BeaconPeriod to beacon_period DSConfig to ds_config ATIMWindowto atim_window pnic_Config to pnic_config FHConfig to fh_config HopPatternto hop_pattern HopSetto h

[PATCH] staging: lustre: lnet: remove dead code

2017-06-28 Thread Dmitriy Cherkasov
Remove code which was permanently disabled with ifdefs. This also resolves the following checkpatch warning which was triggered by the dead code: WARNING: space prohibited before semicolon Signed-off-by: Dmitriy Cherkasov --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 -- 1 fi

[PATCH] hv: fix msi affinity when device requests all possible CPU's

2017-06-28 Thread Stephen Hemminger
When Intel 10G (ixgbevf) is passed to a Hyper-V guest with SR-IOV, the driver requests affinity with all possible CPU's (0-239) even those CPU's are not online (and will never be). Because of this the device is unable to correctly get MSI interrupt's setup. This was caused by the change in 4.12 th

Re: [PATCH] staging: speakup: make function ser_to_dev static

2017-06-28 Thread Okash Khawaja
Hi, On Wed, Jun 28, 2017 at 02:13:51PM +0100, Colin King wrote: > From: Colin Ian King > > The helper function ser_to_dev does not need to be in global scope, so > make it static. > > Cleans up sparse warning: > "warning: symbol 'ser_to_dev' was not declared. Should it be static?" Thanks very m

[PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

2017-06-28 Thread Arnd Bergmann
While looking at a compiler warning, I noticed the use of IS_ERR_OR_NULL, which is generally a sign of a bad API design and should be avoided. In this driver, this is fairly easy, we can simply stop storing error pointers in persistent structures, and change the one function that might return eith

[PATCH] staging: ks7010: fix spelling mistake: "errror" -> "error"

2017-06-28 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in netdev_err message Signed-off-by: Colin Ian King --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c ind

Re: [PATCH] staging: speakup: make function ser_to_dev static

2017-06-28 Thread Samuel Thibault
walter harms, on mer. 28 juin 2017 16:49:03 +0200, wrote: > Am 28.06.2017 15:13, schrieb Colin King: > > diff --git a/drivers/staging/speakup/spk_ttyio.c > > b/drivers/staging/speakup/spk_ttyio.c > > index 442f191a017e..ed8e96b06ead 100644 > > --- a/drivers/staging/speakup/spk_ttyio.c > > +++ b/dr

Re: [PATCH] staging: speakup: make function ser_to_dev static

2017-06-28 Thread walter harms
Am 28.06.2017 15:13, schrieb Colin King: > From: Colin Ian King > > The helper function ser_to_dev does not need to be in global scope, so > make it static. > > Cleans up sparse warning: > "warning: symbol 'ser_to_dev' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King

[PATCH] staging: speakup: make function ser_to_dev static

2017-06-28 Thread Colin King
From: Colin Ian King The helper function ser_to_dev does not need to be in global scope, so make it static. Cleans up sparse warning: "warning: symbol 'ser_to_dev' was not declared. Should it be static?" Signed-off-by: Colin Ian King --- drivers/staging/speakup/spk_ttyio.c | 2 +- 1 file chan

Re: [PATCH v4] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 2:46 PM, Hans de Goede wrote: > On 27-06-17 06:25, kbuild test robot wrote: >> >> Hi Hans, >> >> [auto build test ERROR on staging/staging-testing] >> [also build test ERROR on v4.12-rc7 next-20170626] >> [if your patch is applied to the wrong git tree, please drop us a not

Re: [PATCH] staging: rts5208 : Fixing coding style warnings

2017-06-28 Thread Frans Klaver
Hi, On Wed, Jun 28, 2017 at 2:50 PM, Simo Koskinen wrote: > Fixed following warnings found by checkpatch.pl script: > > WARNING: Prefer using '"%s...", __func__' to using '', > this function's name, in a string > > Signed-off-by: Simo Koskinen > --- > drivers/staging/rts5208/rtsx.c |

Re: [PATCH] staging: rts5208 : Fixing coding style warnings

2017-06-28 Thread Greg KH
On Wed, Jun 28, 2017 at 02:50:12PM +0200, Simo Koskinen wrote: > Fixed following warnings found by checkpatch.pl script: > > WARNING: Prefer using '"%s...", __func__' to using '', > this function's name, in a string > > Signed-off-by: Simo Koskinen Is this different from a previous patch?

[PATCH] staging: rts5208 : Fixing coding style warnings

2017-06-28 Thread Simo Koskinen
Fixed following warnings found by checkpatch.pl script: WARNING: Prefer using '"%s...", __func__' to using '', this function's name, in a string Signed-off-by: Simo Koskinen --- drivers/staging/rts5208/rtsx.c | 2 -- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- drivers/staging/rts52

Re: [PATCH v4] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Hans de Goede
Hi Michael, On 27-06-17 06:25, kbuild test robot wrote: Hi Hans, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12-rc7 next-20170626] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding

2017-06-28 Thread Dan Carpenter
On Tue, Jun 27, 2017 at 05:13:39PM +0530, Jaya Durga wrote: > diff --git a/drivers/staging/rtl8712/osdep_intf.h > b/drivers/staging/rtl8712/osdep_intf.h > index 1985423..dac6aed 100644 > --- a/drivers/staging/rtl8712/osdep_intf.h > +++ b/drivers/staging/rtl8712/osdep_intf.h > @@ -29,7 +29,10 @@ >

Re: [PATCH] staging: rts5208 : Fixing coding style warnings

2017-06-28 Thread Greg KH
On Wed, Jun 28, 2017 at 11:15:09AM +0200, Simo Koskinen wrote: > Fixed following warnings found by checkpatch.pl script: > > WARNING: Prefer using '"%s...", __func__' to using '', > this function's name, in a string > > Signed-off-by: Simo Koskinen > --- > drivers/staging/rts5208/rtsx.c

Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

2017-06-28 Thread Gilad Ben-Yossef
Thank you Karthik, On Wed, Jun 28, 2017 at 12:37 PM, wrote: > From: Karthik Tummala > > This patch series fixes coding style and removes the following > checkpatch.pl warnings: > > Prefer using '"%s...", __func__' to using the function's name, > in a string. This one is good. > > Braces {} are

[PATCH 2/2] staging: ccree: Remove braces {} for single statement blocks

2017-06-28 Thread karthik
From: Karthik Tummala Fixed following checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks. Signed-off-by: Karthik Tummala --- drivers/staging/ccree/ssi_aead.c | 38 ++ 1 file changed, 14 insertions(+), 24 deletions

[PATCH 0/2] staging: ccree: Fix coding style and remove warnings

2017-06-28 Thread karthik
From: Karthik Tummala This patch series fixes coding style and removes the following checkpatch.pl warnings: Prefer using '"%s...", __func__' to using the function's name, in a string. Braces {} are not necessary for single statement blocks. Rebased on top of next-20170627. Patches were tested

[PATCH 1/2] staging: ccree: Use __func__ instead of function name

2017-06-28 Thread karthik
From: Karthik Tummala Fixed following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using the function's name, in a string It is prefered to use '%s & __func__' instead of function name for logging. Signed-off-by: Karthik Tummala --- drivers/staging/ccree/ssi_aea

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Dan Carpenter
On Mon, Jun 26, 2017 at 04:55:46PM +0200, Hans de Goede wrote: > >> +int vbox_dumb_create(struct drm_file *file, > >> + struct drm_device *dev, struct drm_mode_create_dumb *args) > >> +{ > >> + int ret; > >> + struct drm_gem_object *gobj; > >> + u32 handle; > >> + > >> + args->pit

[PATCH] staging: rts5208 : Fixing coding style warnings

2017-06-28 Thread Simo Koskinen
Fixed following warnings found by checkpatch.pl script: WARNING: Prefer using '"%s...", __func__' to using '', this function's name, in a string Signed-off-by: Simo Koskinen --- drivers/staging/rts5208/rtsx.c | 2 +- drivers/staging/rts5208/rtsx_chip.c | 5 +++-- drivers/staging/rts5

Re: [PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl.

2017-06-28 Thread Frans Klaver
Hi, On Wed, Jun 28, 2017 at 4:49 AM, Quytelda Kahja wrote: > Replace the literal function name "visorbus_create_instance" with the format > specifier "%s" so it can be dynamically filled by the __func__ macro. On a general note, I think the actual change or effect is more import to mention in th