File size before:
textdata bss dec hex filename
11058 816 24 118982e7a
drivers/staging/unisys/visorbus/visorchipset.o
File size After adding 'const':
textdata bss dec hex filename
11122 752 24 118982e7a
drivers/staging/unisy
drivers/staging/wlan-ng/prism2mgmt.c:188:25: warning: incorrect type in
assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:188:25:expected unsigned short
[unsigned] [addressable] [usertype] tx_rate
drivers/staging/wlan-ng/prism2mgmt.c:188:25:got restricted __le16
[use
This problem shows up in 4.11 when netvsc driver is removed and reloaded.
The problem is that the channel is closed during module removal and the
tasklet for processing responses is disabled. When module is reloaded
the channel is reopened but the tasklet is marked as disabled.
Patch for upstream
This problem shows up in 4.11 when netvsc driver is removed and reloaded.
The problem is that the channel is closed during module removal and the
tasklet for processing responses is disabled. When module is reloaded
the channel is reopened but the tasklet is marked as disabled.
The fix is to re-ena
From: Arnd Bergmann
Date: Thu, 22 Jun 2017 00:16:37 +0200
> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
>
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_
On Thu, 2017-06-22 at 16:35 +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor
>
> Several macros were triggering this checkpatch.pl warning:
> "Macro argument reuse '$arg' - possible side-effects?"
> Fix the warning by turning them into real functions.
good idea and
> diff --git a
> -Original Message-
> From: laurentiu.tu...@nxp.com [mailto:laurentiu.tu...@nxp.com]
> Sent: Thursday, June 22, 2017 3:52 PM
> To: gre...@linuxfoundation.org; Ruxandra Ioana Radulescu
>
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Bogdan
> Purcareata ; Leo Li ;
> stuyo.
On Thu, Jun 22, 2017 at 04:36:55PM +0300, Gilad Ben-Yossef wrote:
> static int ssi_ahash_export(struct ahash_request *req, void *out)
> {
> struct crypto_ahash *ahash = crypto_ahash_reqtfm(req);
> struct ssi_hash_ctx *ctx = crypto_ahash_ctx(ahash);
> + struct device *dev = &ctx->d
On Tue, Jun 20, 2017 at 5:51 PM, Jhih-Ming Huang wrote:
>
> Hi,
>
> This patch fix all coding style error in driver/staging/ccree/ssi_aead.c.
For patches 1-6:
Acked-by: Gilad Ben-Yossef
Thanks you,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics,
On Sat, Jun 17, 2017 at 5:44 AM, Derek Robson wrote:
> Changed code indent to be tabs across whole driver
> Found using checkpatch
>
> Signed-off-by: Derek Robson
>
> V1 had vague subject.
Acked-by: Gilad Ben-Yossef
Thanks you,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take
We were waiting for a completion notification of HW DMA
operation using an interruptible wait which can result
in data corruption if a signal interrupted us while
DMA was not yet completed.
Fix this by moving to uninterrupted wait.
Fixes: abefd6741d ("staging: ccree: introduce CryptoCell HW drive
The ccree driver has build time configurable support
to work on top of coherent (e.g. ACP) vs. none coherent bus
connections. Turn it to run-time configurable option
based on device tree.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c | 37 ++--
The function set_ack_last was not used anywhere. Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index c73
Some SoC which implement CryptoCell have a dedicated clock
tied to it, some do not. Implement clock support if exists
based on device tree data and tie power management to it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Makefile | 2 +-
drivers/staging/ccree/ssi_driver.c | 40
Add support for the older CryptoCell 710 and 630P hardware revisions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Kconfig| 7 +-
drivers/staging/ccree/cc_crypto_ctx.h| 16 ---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 +-
drivers/staging/ccree/cc_regs.h
Fix a bug where the transformation init code did
not register a setkey method for none hash based MACs.
Fixes commit 50cfbbb7e627 ("staging: ccree: add ahash support").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 83
1 file cha
Hash import and export was saving and restoring the wrong context
and therefore disabled. Fix it by restoring intermediate digest
and additional state needed.
The hash and mac transform now pass testmgr partial hash tests.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 1
From: Laurentiu Tudor
dprc.h is only used in the mc bus driver so move it together with the
sources thus making it private.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc.c | 2 +-
drivers/staging/fsl-mc/{include => bus}/dprc.h | 0
drivers/staging/fsl-mc/bus/f
An assortment of bug fixes and staging TODO items.
Highlights includes the driver passing crypto testmgr boot tests
and support of multiple HW revs. without build time changes.
CC: Dan Carpenter
Changes from v1:
- Rebased on top of latest patches sent to mailing
list but not yet marged for sam
From: Laurentiu Tudor
mc-cmd.h contains some low level functions used to encode and decode
commands to the MC. They are used by the drivers so move them to the
public headers and get rid of the mc-cmd.h header.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-dpaa2/ethernet/dpni.c | 1
From: Laurentiu Tudor
mc-sys.h contains the API to send commands to the MC and is used
by drivers. Move it to the public headers and get rid of the mc-sys.h
header.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 -
drivers/staging/fsl-dpaa2/ethernet/dpni
From: Laurentiu Tudor
The function fsl_mc_bus_exists() has a prototype but is never
implemented so delete it from the header file.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/include/mc-bus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/include/mc-b
From: Laurentiu Tudor
Few files using byte order macros but did not explicitly
included the required kernel header, so add it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpbp.c | 1 +
drivers/staging/fsl-mc/bus/dpcon.c | 1 +
drivers/staging/fsl-mc/bus/dpio/dpio.c |
From: Laurentiu Tudor
dpmng.h & dpmng.c files expose an API of just one function which is only
used by the bus driver. Move that single API in the bus source as static
and remove the two files.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpmng.c | 74
From: Laurentiu Tudor
All the mc-bus.h contents is only used privately in the bus driver so
move everything to the private header and get rid of the mc-bus.h
header file.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 1 -
drivers/staging/fsl-mc/bus/fs
From: Laurentiu Tudor
fsl_mc_msi_create_irq_domain() will is used from the irqchip glue code
so it needs to be in the public headers.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/include/mc-bus.h | 7 ---
drivers/staging/fsl-mc/include/mc.h | 7 +++
2 files changed, 7
From: Laurentiu Tudor
Define dev_is_fsl_mc() and the bus type definition (fsl_mc_bus_type)
are used externally so move them to the public header.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/include/mc-bus.h | 9 -
drivers/staging/fsl-mc/include/mc.h | 9 +
2 f
From: Laurentiu Tudor
In its current form, the public headers of the mc-bus depend only on a
structure "dprc_obj_desc" defined in dprc.h. Move it to the bus public
header together with its associated defines and, in order to keep the
naming prefixes consistent rename it to "fsl_mc_obj_desc".
This
From: Laurentiu Tudor
They are never used outside the source they are implemented in and very
likely never will, so it's safe to make them static.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 8 +++-
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 5 ++---
drive
From: Laurentiu Tudor
These functions already have their prototypes in fsl-mc-private.h
header file so delete them from mc-bus.h.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/include/mc-bus.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/fsl-mc/include
From: Laurentiu Tudor
These couple of header files are not needed in the source
so remove them.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
b/drivers/staging
From: Laurentiu Tudor
Several macros were triggering this checkpatch.pl warning:
"Macro argument reuse '$arg' - possible side-effects?"
Fix the warning by turning them into real functions.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 15 +--
From: Laurentiu Tudor
This patch series contain mainly clean-ups of the mc-bus header files
with the final goal of reorganizing them in just 2 files: a public
and a private one, as per GregKH suggestion [1].
Here's a summary of the header reorganizing:
- existing mc.h used as public header (cont
On Thu, Jun 22, 2017 at 12:04 PM, Dan Carpenter
wrote:
> On Thu, Jun 22, 2017 at 10:07:52AM +0300, Gilad Ben-Yossef wrote:
>> The ccree driver has build time configurable support
>> to work on top of coherent (e.g. ACP) vs. none coherent bus
>> connections. Turn it to run-time configurable option
On Thu, Jun 22, 2017 at 11:58 AM, Dan Carpenter
wrote:
> On Thu, Jun 22, 2017 at 10:07:51AM +0300, Gilad Ben-Yossef wrote:
>> +int cc_clk_on(struct ssi_drvdata *drvdata)
>> +{
>> + int rc = 0;
>> + struct clk *clk = drvdata->clk;
>> +
>> + if (IS_ERR(clk))
>> + /* No all devices ha
From: Laurentiu Tudor
dpni.c is using byte order macros and error codes but does
not explicitly include the required kernel header, so add it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/fsl-
This is obviously much better and easier to review. I ended up
reviewing it like I would normal code instead of staging code. My main
thing is could you please re-write the module init error handling so
that each function does its own error handling instead of just calling
vbox_driver_unload().
Hi,
Please consider my patch file for octeon-usb/octeon-hcd.c coding style
issue.
Regards
Bincy
On 15/06/17 10:28, bincy_k_phi...@yahoo.co.in wrote:
From: bincy k philip
trivial fix for extra space error
Signed-off-by: bincy k philip
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1
Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR'
are not preferred.Consider using octal permissions '0644'.
Signed-off-by: Jaya Durga
--6
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intf
It was found that SMI_TRESHOLD of 5 is not enough for Hyper-V
guests in nested environment and falling back to counting jiffies
is not an option for Gen2 guests as they don't have PIT. As Hyper-V
provides TSC frequency in a synthetic MSR we can just use this information
instead of doing a error
Hyper-V TLFS specifies two bits which should be checked before accessing
frequency MSRs:
- AccessFrequencyMsrs (BIT(11) in EAX) which indicates if we have access to
frequency MSRs.
- FrequencyMsrsAvailable (BIT(8) in EDX) which indicates is these MSRs are
present.
Rename and specify these bits
Changes since v1:
- s/AVAILABELE/AVAILABLE/ fixing the typo [Thomas Gleixner]
Original description:
TSC calibration on virtual machines is always error prone. It was found
that in nested environments Gen2 instances may get stuck on boot. As
Hyper-V hosts provide us with all the required informati
Hi All,
As discussed during the review of v2 here is a new version of the vboxvideo
driver, now with all files converted to kernel coding style, making the
entire patch 100% checkpatch clean (with the exception of some -ENOSYS
warnings).
Still TODO is converting the driver to the atomic modesetti
On Thu, Jun 22, 2017 at 10:07:52AM +0300, Gilad Ben-Yossef wrote:
> The ccree driver has build time configurable support
> to work on top of coherent (e.g. ACP) vs. none coherent bus
> connections. Turn it to run-time configurable option
> based on device tree.
>
> Signed-off-by: Gilad Ben-Yossef
On Thu, Jun 22, 2017 at 10:07:51AM +0300, Gilad Ben-Yossef wrote:
> +int cc_clk_on(struct ssi_drvdata *drvdata)
> +{
> + int rc = 0;
> + struct clk *clk = drvdata->clk;
> +
> + if (IS_ERR(clk))
> + /* No all devices have a clock associated with CCREE */
> + goto out;
Ug
On Thu, Jun 22, 2017 at 11:28 AM, Dan Carpenter
wrote:
> On Thu, Jun 22, 2017 at 10:14:08AM +0300, Gilad Ben-Yossef wrote:
>> On Thu, Jun 22, 2017 at 10:07 AM, Gilad Ben-Yossef
>> wrote:
>> > An assortment of bug fixes and staging TODO items.
>> > Highlights includes the driver passing crypto te
On Thu, Jun 22, 2017 at 10:14:08AM +0300, Gilad Ben-Yossef wrote:
> On Thu, Jun 22, 2017 at 10:07 AM, Gilad Ben-Yossef
> wrote:
> > An assortment of bug fixes and staging TODO items.
> > Highlights includes the driver passing crypto testmgr boot tests
> > and support of multiple HW revs. without
On Thu, Jun 22, 2017 at 10:07 AM, Gilad Ben-Yossef wrote:
> An assortment of bug fixes and staging TODO items.
> Highlights includes the driver passing crypto testmgr boot tests
> and support of multiple HW revs. without build time changes.
>
> Gilad Ben-Yossef (7):
> staging: ccree: fix hash im
We were waiting for a completion notification of HW DMA
operation using an interruptible wait which can result
in data corruption if a signal interrupted us while
DMA was not yet completed.
Fix this by moving to uninterrupted wait.
Fixes: abefd6741d ("staging: ccree: introduce CryptoCell HW drive
Some SoC which implement CryptoCell have a dedicated clock
tied to it, some do not. Implement clock support if exists
based on device tree data and tie power management to it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Makefile | 2 +-
drivers/staging/ccree/ssi_driver.c | 43
The ccree driver has build time configurable support
to work on top of coherent (e.g. ACP) vs. none coherent bus
connections. Turn it to run-time configurable option
based on device tree.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c | 37 ++--
The function set_ack_last was not used anywhere. Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index c73
Add support for the older CryptoCell 710 and 630P hardware revisions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Kconfig| 7 +-
drivers/staging/ccree/cc_crypto_ctx.h| 16 ---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 +-
drivers/staging/ccree/cc_regs.h
An assortment of bug fixes and staging TODO items.
Highlights includes the driver passing crypto testmgr boot tests
and support of multiple HW revs. without build time changes.
Gilad Ben-Yossef (7):
staging: ccree: fix hash import/export
staging: ccree: register setkey for none hash macs
sta
Fix a bug where the transformation init code did
not register a setkey method for none hash based MACs.
Fixes commit 50cfbbb7e627 ("staging: ccree: add ahash support").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 83
1 file cha
Hash import and export was saving and restoring the wrong context
and therefore disabled. Fix it by restoring intermediate digest
and additional state needed.
The hash and mac transform now pass testmgr partial hash tests.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 1
56 matches
Mail list logo
