Hi,
Please consider my new patch send.
Regards
Bincy
On 15/06/17 14:47, bincy wrote:
I have updated the comments here and resend the new patch
On 13/06/17 18:07, Greg KH wrote:
On Tue, Jun 13, 2017 at 03:45:32PM +0530, bincy_k_phi...@yahoo.co.in
wrote:
From: bincy
trivial fix for space al
On Tue, Jun 20, 2017 at 11:40:59PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 20, 2017 at 11:20 PM, Dan Carpenter
> wrote:
> > That's totally bogus. Just say you don't know. It's never a
> > reguirement that people fix AMD drivers before they can review code...
>
> Agree. It's not a cargo cult
Hi Dan,
On Tue, Jun 20, 2017 at 11:20:55PM +0300, Dan Carpenter wrote:
> That's totally bogus. Just say you don't know. It's never a
> reguirement that people fix AMD drivers before they can review code...
Yes, I don't know how drm drivers work, so I blindly follow what has
been done there. And
On Tue, Jun 20, 2017 at 11:20 PM, Dan Carpenter
wrote:
> That's totally bogus. Just say you don't know. It's never a
> reguirement that people fix AMD drivers before they can review code...
Agree. It's not a cargo cult.
If there any real thing behind that #ifdef I would like to hear.
--
With
That's totally bogus. Just say you don't know. It's never a
reguirement that people fix AMD drivers before they can review code...
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailm
On Mon, Jun 19, 2017 at 11:47:20PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee
> wrote:
>
>
> > +#ifdef CONFIG_X86
> > + primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> > + IORESOURCE_ROM_SHADOW;
> > +#endif
>
On Tue, Jun 20, 2017 at 06:50:13PM +0200, Dhananjay Balan wrote:
> The locking and unlocking code used by copy routines is common, so
> moved it to a macro.
>
> Signed-off-by: Dhananjay Balan
> ---
> drivers/staging/sm750fb/sm750.c | 81
> -
> 1 file chan
On Mon, 19 Jun 2017, Vitaly Kuznetsov wrote:
> +#define HV_X64_ACCESS_FREQUENCY_MSRS (1 << 11)
>
> /*
> * Basic SynIC MSRs (HV_X64_MSR_SCONTROL through HV_X64_MSR_EOM
> @@ -73,6 +67,9 @@
>*/
> #define HV_X64_MSR_STAT_PAGES_AVAILABLE (1 << 8)
>
> +/* Frequency MSRs a
On Tue, Jun 20, 2017 at 05:11:51PM +0200, Christian Gromm wrote:
> @@ -411,21 +428,31 @@ static int aim_rx_data(struct mbo *mbo)
> struct sk_buff *skb;
> struct net_device *dev;
> unsigned int skb_len;
> + int ret = 0;
>
> - nd = get_net_dev_context(mbo->ifp);
> - if
On Tue, Jun 20, 2017 at 10:51:58PM +0800, Jhih-Ming Huang wrote:
>
> Hi,
>
> This patch fix all coding style error in driver/staging/ccree/ssi_aead.c.
Much better. Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
ht
The locking and unlocking code used by copy routines is common, so
moved it to a macro.
Signed-off-by: Dhananjay Balan
---
drivers/staging/sm750fb/sm750.c | 81 -
1 file changed, 31 insertions(+), 50 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750
From: Andrey Shvetsov
This adds the dev_hold and dev_put calls to the functions
aim_resume_tx_channel, aim_rx_data and on_netinfo to postpone the
unregistration of the used net device.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-network/networkin
From: Andrey Shvetsov
This introduces the mutex that protects the consistency between the
tx.linked, rx.linked and the presence of the net divice.
Additionally, this patch optimizes the setup of the ch->linked in the
function aim_probe_channel.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Chr
From: Andrey Shvetsov
The function aim_probe_channel calls only one of the functions
alloc_netdev and register_netdev per run.
Correspondingly, the function aim_disconnect_channel calls only one of
the functions unregister_netdev and free_netdev per run.
This patch makes it obvious by using the
From: Andrey Shvetsov
This removes redundant netdev_info/pr_info.
Signed-off-by: Andrey Shvetsov
Signed-off-by: Christian Gromm
---
drivers/staging/most/aim-network/networking.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/most/aim-network/networking.c
b/drivers/s
From: Jhih-Ming Hunag
Move else to follow close brace '}'
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 57c7c68..c70e450 100644
From: Jhih-Ming Hunag
Remove improper space.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 6b9d
From: Jhih-Ming Hunag
Move * to close variable name instead of type.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 3d9957f..6b9de3
From: Jhih-Ming Hunag
Move '{' to next line for function.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 6bcab5a..3d9957f 100
From: Jhih-Ming Hunag
Move brace { to previous line for if.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index ca3f11f..6bcab5a 1
From: Jhih-Ming Hunag
Add space around comma, brace, and opertor.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/cc
Hi,
This patch fix all coding style error in driver/staging/ccree/ssi_aead.c.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, 2017-06-20 at 11:20 +0300, Dan Carpenter wrote:
> On Tue, Jun 20, 2017 at 01:19:44PM +0800, Jhih-Ming Huang wrote:
[]
> > In this series patches, I fix all of the coding style error in
> > driver/staging/ccree/ssi_aead.c from 54 errors to 0 error.
>
> You could put this into the cover let
On Tue 2017-06-20 08:05:05, Fabio Estevam wrote:
> On Tue, Jun 20, 2017 at 5:29 AM, Pavel Machek wrote:
>
> > Hmm. I changed the subject to grab Shawn's attetion.
> >
> > But his acks should not be needed for forward progress. Yes, it would
> > be good, but he does not react -- so just reorder th
On Tue, Jun 20, 2017 at 5:29 AM, Pavel Machek wrote:
> Hmm. I changed the subject to grab Shawn's attetion.
>
> But his acks should not be needed for forward progress. Yes, it would
> be good, but he does not react -- so just reorder the series so that
> dts changes come last, then apply the part
synths[] array caches currently loaded synths. synth_add checks
synths[] before adding a new one. It however ignores the result of
do_synth_init. So when do_synth_init fails, the failed synth is still
cached. Since, as a result module loading fails too, synth_remove -
which is responsible for remov
This patch changes the type of variable done from int to boolean. As it
is been used as a boolean in the function sfw_test_rpc_done(). It also
makes the code more readable and bool data type also requires less
memory in comparison to int data type.
Signed-off-by: simran singhal
---
drivers/stagi
Hi!
> >> But as Pavel pointed out, in fact we are missing many
> >> Acks still, for all of the dts source changes (patches
> >> 4-14), as well as really everything else (imx-media staging
> >> driver patches).
> >
> > No Acks needed for the staging part. It's staging, so not held
> > to the same
On Tue, Jun 20, 2017 at 01:21:46PM +0800, Jhih-Ming Huang wrote:
> From: Jhih-Ming Hunag
>
> Fixed "ERROR: space prohibited after that open parenthesis '('".
>
> Signed-off-by: Jhih-Ming Hunag
> ---
> drivers/staging/ccree/ssi_aead.c | 16
> 1 file changed, 8 insertions(+), 8
On Tue, Jun 20, 2017 at 01:20:59PM +0800, Jhih-Ming Huang wrote:
> From: Jhih-Ming Hunag
>
> Fixed 'ERROR: spaces required around that'
>
You're breaking the patches up in a bad way. This one should be
combined with the previous patch.
regards,
dan carpenter
_
Subject is wrong. It should be:
[PATCH 1/11] Staging: ccree: add spaces blah blah blah
On Tue, Jun 20, 2017 at 01:19:44PM +0800, Jhih-Ming Huang wrote:
> From: Jhih-Ming Hunag
>
No need.
> In this series patches, I fix all of the coding style error in
> driver/staging/ccree/ssi_aead.c from
31 matches
Mail list logo
