sorry for the inconvenience caused i have corrected it.
Regards,
Jaya Durga R
On June 13, 2017 at 11:25 AM Greg KH wrote:
> On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote:
> > This e-mail is for the sole use of the intended recipient(s) and may
> > contain confidential and privilege
From: bincy
Signed-off-by: bincy
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..f309298 100644
--- a/drivers/staging/octeon-usb/octe
On Tue, Jun 13, 2017 at 11:31:42AM +0530, bincy wrote:
> Signed-off-by: bincy k philip
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
You didn't fix everything my patch-bot told you about, please try again.
thanks,
greg k-
On Tue, 2017-06-13 at 08:52 +0300, Aviya Erenfeld wrote:
> Shorten lines over 80 chars
Most of these changes are not useful.
Style nits if 80 columns are _really_ desired.
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
[]
> @@ -157,7
Signed-off-by: bincy k philip
---
drivers/staging/octeon-usb/octeon-hcd.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c1f715e 100644
--- a/drivers/staging/octeo
On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote:
> This e-mail is for the sole use of the intended recipient(s) and may
> contain confidential and privileged information. If you are not the
> intended recipient, please contact the sender by reply e-mail and destroy
> all copies and the
Shorten lines over 80 chars
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58 +++-
1 file changed, 39 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt
Remove unneeded blank lines
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index c6a7df5..cd348ca 100644
--- a/d
Remove redundant parenthesis
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
in
Fix some of the issues that checkpatch complains on like redundant
parenthesis, redundant blank lines and lines over 80 chars.
Aviya Erenfeld (3):
staging: rtl8188eu: Remove redundant parenthesis
staging: rtl8188eu: Remove unneeded blank lines
staging: rtl8188eu: Shorten lines over 80 chars
From: bincy
Signed-off-by: bincy k philip
---
drivers/staging/octeon-usb/octeon-hcd.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 068aece..c1f715e 100644
--- a/drivers
On Mon, Jun 12, 2017 at 08:20:15PM +, Dilger, Andreas wrote:
> On Jan 21, 2017, at 02:24, Greg Kroah-Hartman
> wrote:
> >
> > On Fri, Jan 20, 2017 at 11:33:11PM +, James Simmons wrote:
> >>
> > On Mon, Dec 19, 2016 at 12:06:47PM -0500, James Simmons wrote:
> >> Not for landing.
Convert the uses of MAC_FMT, MAC_ARG and IP_FMT, IP_ARG to the
kernel extensions.
This could eventually be improved with an in-place substitution.
This reduces object code size a bit too.
$ size drivers/staging/rtl8723bs/r8723bs.o*
textdata bss dec hex filename
672812 27040
On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote:
> Fixed WARNING: line over 80 characters
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/rtl8712/ieee80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 1.9.1
>
> diff --git a/drivers/staging/rtl8712/iee
Greg said to go ahead... I think you misread something. We've all
agreed to move the uapi directories into a separate dir and later we
can discuss if it should be one enormous file or 12 huge files.
regards,
dan carpenter
___
devel mailing list
de...
On Jan 21, 2017, at 02:24, Greg Kroah-Hartman
wrote:
>
> On Fri, Jan 20, 2017 at 11:33:11PM +, James Simmons wrote:
>>
> On Mon, Dec 19, 2016 at 12:06:47PM -0500, James Simmons wrote:
>> Not for landing. This is the purposed UAPI headers
>> with the removal of unlikely and debug
No, sorry. This doesn't look right at all.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: Gabriel Somlo
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
index e5d6674..8c45f81 100644
--- a/drivers/staging/
On Mon, Jun 12, 2017 at 7:15 PM, wrote:
> From: Suniel Mahesh
>
> The following type mismatch warnings reported by sparse
> have been amended:
> warning: cast to restricted __le16
> warning: incorrect type in assignment (different base types)
Why not change the type of the struct fields to __le
On 06/11/2017 01:05 PM, Vladimir Zapolskiy wrote:
On 06/10/2017 02:26 AM, Hans Verkuil wrote:
On 10/06/17 01:16, Steve Longerbeam wrote:
On 06/07/2017 12:02 PM, Hans Verkuil wrote:
We're still waiting for an Ack for patch 02/34, right?
Hi Hans, Rub has provided an Ack for patch 2.
Other
From: Suniel Mahesh
The following type mismatch warnings reported by sparse
have been amended:
warning: cast to restricted __le16
warning: incorrect type in assignment (different base types)
Signed-off-by: Suniel Mahesh
---
drivers/staging/wlan-ng/prism2mgmt.c | 22 +++---
1 fi
Hi,
On 12-06-17 18:03, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote:
Hi,
On 12-06-17 13:44, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
The most important thing is for the driver to be atomic if it's KMS
On Mon, Jun 12, 2017 at 05:40:21PM +0200, Hans de Goede wrote:
> Hi,
>
> On 12-06-17 13:44, Greg Kroah-Hartman wrote:
> > On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
> > > > The most important thing is for the driver to be atomic if it's KMS
> > > > only, and it would be good to
Hi,
On 12-06-17 13:44, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
The most important thing is for the driver to be atomic if it's KMS
only, and it would be good to have someone review that properly.
I believe it does not use the atomic APIs atm, s
On Mon, Jun 12, 2017 at 04:16:18PM +0300, Aviya Erenfeld wrote:
> From: Aviya Erenfeld
No need for this, your email is set up correctly so it works fine as-is.
>
> Shorten lines over 80 chars
>
> Signed-off-by: Aviya Erenfeld
> ---
> drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58
> +
On Mon, Jun 12, 2017 at 6:47 PM, Dan Carpenter wrote:
> On Mon, Jun 12, 2017 at 06:16:30PM +0530, srishti sharma wrote:
>>
>> Thanks :) , so will this be accepted ?
>>
>
> Probably, yes. Unless Greg has already dropped it because you said to
> drop it.
>
> regards,
> dan carpenter
>
Okay, Thank
On Mon, Jun 12, 2017 at 06:16:30PM +0530, srishti sharma wrote:
>
> Thanks :) , so will this be accepted ?
>
Probably, yes. Unless Greg has already dropped it because you said to
drop it.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriv
From: Aviya Erenfeld
Shorten lines over 80 chars
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58 +++-
1 file changed, 39 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl
From: Aviya Erenfeld
Remove unneeded blank lines
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index c6a7df5.
From: Aviya Erenfeld
Remove redundant parenthesis
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188e
From: Aviya Erenfeld
Fix some of the issues that checkpatch complains on like redundant
parenthesis, redundant blank lines and lines over 80 chars.
Aviya Erenfeld (3):
staging: rtl8188eu: Remove redundant parenthesis
staging: rtl8188eu: Remove unneeded blank lines
staging: rtl8188eu: Short
On Mon, Jun 12, 2017 at 02:46:54PM +0200, Michael Thayer wrote:
> Hello Greg,
>
> 12.06.2017 13:47, Greg Kroah-Hartman wrote:
> > On Mon, Jun 12, 2017 at 01:44:09PM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
> > > > > The most important th
Hello Greg,
12.06.2017 13:47, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 01:44:09PM +0200, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
The most important thing is for the driver to be atomic if it's KMS
only, and it would be good to have some
On Mon, Jun 12, 2017 at 5:53 PM, Dan Carpenter wrote:
> On Sat, Jun 10, 2017 at 12:33:57AM +0530, srishti sharma wrote:
>> On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma
>> wrote:
>> > Fixed alignment so that it matched open paranthesis .
>> >
>> > Signed-off-by: srishti sharma
>
On Sat, Jun 10, 2017 at 12:33:57AM +0530, srishti sharma wrote:
> On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma
> wrote:
> > Fixed alignment so that it matched open paranthesis .
> >
> > Signed-off-by: srishti sharma
^ ^
You're the opposite of me. My mama named me w
The patch numbering doesn't make sense.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
It's going to be basically impossible to keep the out of tree in sync
with the staging version because there are so many changes needed
everywhere.
Generally in the kernel we don't care about out of tree stuff. So the
OS independent stuff is going to get completely re-worked. It's
mechanical cha
On Mon, Jun 12, 2017 at 01:44:09PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
> > > The most important thing is for the driver to be atomic if it's KMS
> > > only, and it would be good to have someone review that properly.
> >
> > I believe it
On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
> > The most important thing is for the driver to be atomic if it's KMS
> > only, and it would be good to have someone review that properly.
>
> I believe it does not use the atomic APIs atm, so that would be one
> of the first things
This patch implements the suggestions of checkpatch.pl to remove
unnecessary spaces before function pointer arguments as well as in
statements of the form "foo * bar" (which should be "foo *bar").
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
drivers/staging/rtl8723bs/os_dep/wifi_
This patch adjusts the alignment of several lines to match their
respective opening parenthesis.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/
This patch improves the formatting of block comments and removes one
commented-out line of code entirely (keeping it would be redundant
thanks to version control).
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 16
1 f
This patch adds spaces around the binary operators '-' and '+', which
is the preferred style, and reformats a pointer argument declaration
to fix a false positive "spaces preferred around that '*'" message
reported by checkpatch.pl.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
dr
This patch removes unnecessary braces in an if/else-construct, thereby
fixing both a checkpatch.pl warning about superfluous braces and an
error about an ill-placed closing brace preceding the "else" keyword.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
drivers/staging/rtl8723bs/
This patch fixes the checkpatch.pl warning 'Statements should start on
a tabstop' by reformatting the affected lines.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
This patch series fixes all errors and warnings generated by
checkpatch.pl for wifi_regd.c.
Fabian Wolff (7):
staging: rtl8723bs: wifi_regd.c: put spaces around binary operators
staging: rtl8723bs: wifi_regd.c: fix checkpatch.pl warning 'Statements
should start on a tabstop'
staging: rtl
This patch inserts a missing blank line after variable declarations.
Signed-off-by: Fabian Wolff
Signed-off-by: Mate Horvath
---
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
b/drivers/staging/rtl87
Hello Dave,
12.06.2017 09:27, Dave Airlie wrote:
On 12 June 2017 at 16:56, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card used in Virtual Box virtual machines to drivers/staging.
Why drivers/staging? This driver is already being patched into t
Hi,
On 12-06-17 09:27, Dave Airlie wrote:
On 12 June 2017 at 16:56, Hans de Goede wrote:
This commit adds the vboxvideo drm/kms driver for the virtual graphics
card used in Virtual Box virtual machines to drivers/staging.
Why drivers/staging? This driver is already being patched into the kern
On 12 June 2017 at 16:56, Hans de Goede wrote:
> This commit adds the vboxvideo drm/kms driver for the virtual graphics
> card used in Virtual Box virtual machines to drivers/staging.
>
> Why drivers/staging? This driver is already being patched into the kernel
> by several distros, thus it is goo
50 matches
Mail list logo
