Re: [PATCH v8 17/34] [media] add Omnivision OV5640 sensor driver

2017-06-10 Thread Sakari Ailus
Hi Steve, On Wed, Jun 07, 2017 at 11:33:56AM -0700, Steve Longerbeam wrote: ... > +/* > + * FIXME: remove this when a subdev API becomes available > + * to set the MIPI CSI-2 virtual channel. > + */ > +static unsigned int virtual_channel; > +module_param(virtual_channel, int, 0); > +MODULE_PARM_DE

[PATCH v9 19/34] media: Add i.MX media core driver

2017-06-10 Thread Steve Longerbeam
Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam Switch from the v4l2_of_ APIs to the v4l2_fwnode_ APIs. Signed-off-by: Philipp Zabel Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King --- Changes since v8 [1]:

Re: [PATCH] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-10 Thread Greg Kroah-Hartman
On Sat, Jun 10, 2017 at 03:07:14PM +0200, Hans de Goede wrote: > Hi, > > On 09-06-17 11:58, Hans de Goede wrote: > > This commit adds the vboxvideo drm/kms driver for the virtual graphics > > card used in Virtual Box virtual machines to drivers/staging. > > > > Why drivers/staging? This driver is

Re: [PATCH] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-10 Thread Hans de Goede
Hi, On 09-06-17 11:58, Hans de Goede wrote: This commit adds the vboxvideo drm/kms driver for the virtual graphics card used in Virtual Box virtual machines to drivers/staging. Why drivers/staging? This driver is already being patched into the kernel by several distros, thus it is good to get t

Re: [PATCH] staging: lustre: llite: Make structure describing various file operations 'const'

2017-06-10 Thread Greg KH
On Sat, Jun 10, 2017 at 02:40:06PM +0300, Roman Storozhenko wrote: > On Fri, Jun 09, 2017 at 04:30:02PM +0300, Roman Storozhenko wrote: > > Use 'const' in declarations of various 'file_operations' structures. > > > > Signed-off-by: Roman Storozhenko > > --- > > drivers/staging/lustre/lustre/llit

Re: [PATCH] staging: lustre: llite: Make structure describing various file operations 'const'

2017-06-10 Thread Roman Storozhenko
On Fri, Jun 09, 2017 at 04:30:02PM +0300, Roman Storozhenko wrote: > Use 'const' in declarations of various 'file_operations' structures. > > Signed-off-by: Roman Storozhenko > --- > drivers/staging/lustre/lustre/llite/file.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > dif

Re: [PATCH] staging: lustre: llite: Make structure describing various file operations 'const'

2017-06-10 Thread Roman Storozhenko
improve the system] > > url: > https://github.com/0day-ci/linux/commits/Roman-Storozhenko/staging-lustre-llite-Make-structure-describing-various-file-operations-const/20170610-121428 > config: sparc64-allmodconfig (attached as .config) > compiler: sparc64-linux-gnu-gcc (Debian 6.

Re: [PATCH] Drivers: unisys: visorhba - style fix

2017-06-10 Thread Dan Carpenter
Drivers is never a valid subsystem. Do a `git log --oneline ` to look at what other people are doing. The style varies by subsystem so you should always run that command. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http:

[PATCH 6/7] [media] media: bcm2048: use MEDIA_REVISION isntead of KERNEL_VERSION

2017-06-10 Thread Johannes Thumshirn
Use MEDIA_REVISION isntead of KERNEL_VERSION to encode the bcm2048 driver version. Signed-off-by: Johannes Thumshirn --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/stag

[PATCH 7/7] staging/atomisp: use MEDIA_VERSION instead of KERNEL_VERSION

2017-06-10 Thread Johannes Thumshirn
Use MEDIA_VERSION instead of KERNEL_VERSION to encode the driver version of the Atom ISP driver. Signed-off-by: Johannes Thumshirn --- drivers/staging/media/atomisp/include/linux/atomisp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/inc

[PATCH 5/7] [media] media: s3c-camif: Use MEDIA_REVISON instead of KERNEL_VERSION

2017-06-10 Thread Johannes Thumshirn
Use MEDIA_REVISON instead of KERNEL_VERSION to encode the driver version. Signed-off-by: Johannes Thumshirn --- drivers/media/platform/s3c-camif/camif-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platfor

[PATCH 4/7] [media] cx25821: use MEDIA_REVISION instead of KERNEL_VERSION

2017-06-10 Thread Johannes Thumshirn
Use MEDIA_REVISION instead of KERNEL_VERSION to encode the CX25821_VERSION_CODE. Signed-off-by: Johannes Thumshirn --- drivers/media/pci/cx25821/cx25821.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx25821/cx25821.h b/drivers/media/pci/cx25821/cx25821.

[PATCH 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

2017-06-10 Thread Johannes Thumshirn
Currently the media subsystem has a very creative abuse of the KERNEL_VERSION macro to encode an arbitrary version triplet for media drivers and device hardware revisions. This series introduces a new macro called MEDIA_REVISION which encodes a version triplet like KERNEL_VERSION does, but clearly

[PATCH 2/7] video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION

2017-06-10 Thread Johannes Thumshirn
Don't use the KERNEL_VERSION() macro for the v4l2 capabilities, use MEDIA_REVISION instead. Signed-off-by: Johannes Thumshirn --- drivers/video/fbdev/matrox/matroxfb_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers

[PATCH 3/7] [media] media: document the use of MEDIA_REVISION instead of KERNEL_VERSION

2017-06-10 Thread Johannes Thumshirn
Update the documentation to introduce the use of MEDIA_REVISON instead of KERNEL_VERSION for the verison triplets of a media drivers hardware revision or driver version. Signed-off-by: Johannes Thumshirn --- Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst| 2 +- Documentation/media/

[PATCH 1/7] [media] media: introduce MEDIA_REVISION macro

2017-06-10 Thread Johannes Thumshirn
Currently the media code abuses the KERNEL_VERSION macro to encode a version triplet. Introduce a MEDIA_REVISION macro to get rid of the confusing and creative KERNEL_VERSION usage in the media subsystem. Signed-off-by: Johannes Thumshirn --- include/uapi/linux/media.h | 4 +++- 1 file changed,

Re: [PATCH v8 00/34] i.MX Media Driver

2017-06-10 Thread Pavel Machek
Hi! > >> Other than that everything is ready AFAICT. > >> > > > > But as Pavel pointed out, in fact we are missing many > > Acks still, for all of the dts source changes (patches > > 4-14), as well as really everything else (imx-media staging > > driver patches). > > No Acks needed for the stagi

[PATCH] Drivers: rtl8192u: style fix

2017-06-10 Thread Derek Robson
Fixed checkpatch.pl warnings of "function definition argument FOO should also have an identifier name" Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h | 4 ++-- drivers/stagin