On Mon, Jun 05, 2017 at 09:26:35AM +0800, Jia-Ju Bai wrote:
> Last patch lacks code explanation, and it is included in this patch.
That should go below the --- line, as a 'v2' patch. Please fix it up so
I don't have to hand-edit this and resend.
Please read Documentation/SubmittingPatches for ho
Hi,
I am attempting to test the ks7010 SIDO Wi-Fi driver (drivers/staging/ks7010/).
Currently probing the driver fails because of a firmware upload error.
I am seeking ideas on where to continue troubleshooting this issue.
Test setup:
- Spectec SDW-823 WIFI card (micro SD).
- Raspberry Pi B 1 (
Changed code indent to be tabs across whole driver
Found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/ccree/ssi_cipher.c | 45 +-
drivers/staging/ccree/ssi_driver.c | 6 ++---
drivers/staging/ccree/ssi_driver.h | 6 ++---
drivers/
According to rtsx_chip.c and xd.c, the driver may sleep under a spin lock.
The function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
rtsx_enter_ss
rtsx_power_off_card
xd_cleanup_work
xd_delay_write
xd_finish_write
xd_set_unused_blo
According to rtsx_chip.c and xd.c, the driver may sleep under a spin lock.
The function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
rtsx_enter_ss
rtsx_power_off_card
xd_cleanup_work
xd_delay_write
xd_finish_write
xd_set_unused_blo
According to rtsx_chip.c and xd.c, the driver may sleep under a spin lock.
The function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
rtsx_enter_ss
rtsx_power_off_card
xd_cleanup_work
xd_delay_write
xd_finish_write
xd_set_unused_blo
The driver may sleep under a spin lock, and the function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
rtsx_enter_ss
rtsx_power_off_card
sd_cleanup_work
sd_stop_seq_mode
sd_switch_clock
sd_ddr_tuning
sd_ddr_pre_tuning_t
Last patch lacks code explanation, and it is included in this patch.
The driver may sleep under a spin lock, and the function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
rtsx_enter_ss
rtsx_power_off_card
xd_cleanup_work
xd_delay_write
xd_fini
Signed-off-by: Jia-Ju Bai
---
drivers/staging/rts5208/xd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 85aba05..74d36f9 100644
--- a/drivers/staging/rts5208/xd.c
+++ b/drivers/staging/rts5208/xd.c
@@ -126
On 06/03/2017 04:52 PM, Greg KH wrote:
On Thu, Jun 01, 2017 at 11:43:35AM +0800, Jia-Ju Bai wrote:
The driver may sleep under a spin lock, and the function call path is:
rtsx_exclusive_enter_ss (acquire the lock by spin_lock)
rtsx_enter_ss
rtsx_power_off_card
sd_cleanup_work
Update the default screen resolution and also use 24bpp for a better
screen performance.
Tested-by: Teddy Wang
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging
On 06/03/2017 11:02 AM, Steve Longerbeam wrote:
Hi Sakari,
On 05/29/2017 11:56 PM, Sakari Ailus wrote:
Hi Steve,
On Mon, May 29, 2017 at 02:50:34PM -0700, Steve Longerbeam wrote:
+
+static int ov5640_s_ctrl(struct v4l2_ctrl *ctrl)
+{
+struct v4l2_subdev *sd = ctrl_to_sd(ctrl);
+
Fixed a BLOCK_COMMENT_STYLE warning reported by checkpatch.pl script.
Signed-off-by: Adrian Stanciu
---
drivers/staging/comedi/drivers/ni_labpc_isadma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_labpc_isadma.h
b/drivers/staging/comedi/
From: Richard Porter
Fixes sparse warning:
drivers/staging/ks7010/ks_hostif.c:959:24: warning: restricted __le16
degrades to integer
Signed-off-by: Richard Porter
---
Every access of struct association_request_t.req_ies_size is wrapped with
le16_to_cpu(), except the one at ks_hostif.c:959.
dr
On Sat, Jun 03, 2017 at 05:38:12PM +0900, Greg KH wrote:
> On Sun, May 21, 2017 at 10:15:11AM +0100, d...@acm.org wrote:
> > From: Richard Porter
> >
> > Fixes sparse warnings:
> > drivers/staging/ks7010/ks_hostif.c:339:21: warning: cast to restricted
> > __be16
> > drivers/staging/ks7010/ks_hos
On Sun, Jun 04, 2017 at 05:02:08AM +0530, srishti sharma wrote:
> Added * on subsequent lines of a comment block.
>
> Signed-off-by: srishti sharma
> ---
> drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This whole series also does not apply. Note,
On Sat, Jun 03, 2017 at 06:04:59PM +0530, srishti sharma wrote:
> Fixed a comment coding style issue , block comments use * on subsequent lines.
>
> Signed-off-by: srishti sharma
> ---
> drivers/staging/ccree/ssi_aead.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Patch does not
Remove definitions of descriptor context which are not used
in the driver.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 86 ---
1 file changed, 86 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/cc
The cipher code had some left overs of an attempt to support
synch. cipher API with the HW. Remove the code handling this.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_cipher.c | 102 +++--
drivers/staging/ccree/ssi_driver.h | 1 -
2 files chang
Some of the register definition files had none
kernel coding style usage of tabs vs. spaces in macro
definitions. This patch fixes them.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/dx_crys_kernel.h | 308 -
drivers/staging/ccree/dx_host.h| 25
The hash code had some left overs from a misguided attempt
to support shash API with the HW. Remove the code handling
this.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 448 +++
1 file changed, 127 insertions(+), 321 deletions(-)
dif
Remove spurious blank line from cc_regs.h
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_regs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_regs.h b/drivers/staging/ccree/cc_regs.h
index 53675e3..4a893a6 100644
--- a/drivers/staging/ccree/cc_regs.h
+
Remove some unused macro definitions from hash definitions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/hash_defs.h | 31 +++
1 file changed, 3 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/ccree/hash_defs.h
b/drivers/staging/ccree/hash_d
With all users removed or re-factored to use the standard
kernel bit fields ops we can now drop the custom
bit field macros.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_bitops.h| 39 --
drivers/staging/ccree/cc_hw_queue_defs.h | 2 +-
drivers/staging/ccr
MSB64 macro is no longer used or needed. Drop it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index 1cbd2e1..aaa56c8 100644
-
request_mgr was using custom bit field macros. move over to
standard kernel bitfield ops.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_regs.h | 5 +
drivers/staging/ccree/ssi_request_mgr.c | 27 +--
2 files changed, 22 insertions(+), 10 deleti
struct SepHashPrivateContext is not used anywhere in the code.
Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/hash_defs.h | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/ccree/hash_defs.h
b/drivers/staging/ccree/hash_defs.h
index 3f2b
Hash enum were named using CamelCase, move over to snake_case.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 4 ++--
drivers/staging/ccree/hash_defs.h| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queu
The ccree driver had support for rough performance debugging
via cycle counting which has bit rotted and can easily be
replcaed with perf. Remove it from the driver.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 14
drivers/staging/ccree/ssi_aead.c
The DUMP_SGL() and DUMP_MLLI_TABLE() debug macros were
defined but not used anywhere and the difference of their
definitions for debug vs. none debug indicated this has
not being used in a while.
Remove the dead code.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c |
The Linked List Item descriptors were being programmed via
a set of macros which suffer a few problems:
- Use of macros rather than inline leaves out parameter type
checking and risks multiple macro parameter evaluation side
effects.
- Implemented via hand rolled versions of bitfield operations
A bunch of macros used to define M/LLI descriptors where
being defined in the C file. Move them over to private
include file where other relevant definitions are stored.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_lli_defs.h| 8
drivers/staging/ccree/ssi_buffer_mgr.
Remove no longer needed code used to simulate 48 bit dma addresses
on 32 bit platforms for development purposes.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 19
drivers/staging/ccree/ssi_buffer_mgr.c | 83 -
drivers/stag
This is another batch of clean ups for the ccree driver.
Mostly comprised of:
- Coding Style fixes
- Move to kernel infrastructure from custom constructs
- Replace macros with static inline functions
- Removal of dead code
Changes from v2:
- Rebase on top of commit ed5210cb07de90b8dc31a42046684775
CC_CTX_SIZE was being defined using a hand rolled bit shift operation.
Replace with use of BIT macro.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/sta
On Fri, Jun 2, 2017 at 10:18 PM, Arnd Bergmann wrote:
> On Fri, Jun 2, 2017 at 2:18 PM, Yan, Zheng wrote:
>> On Fri, Jun 2, 2017 at 7:33 PM, Arnd Bergmann wrote:
>>> On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng wrote:
>>> What I meant is another related problem in ceph_mkdir() where the
>>> i_cti
36 matches
Mail list logo
