Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Tobin C. Harding
On Thu, Jun 01, 2017 at 12:46:30PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Driver ks7010 does not currently have a maintainer. > > > > Add maintainers entry for ks7010. > > > > Signed-off-by: Tobin C. Harding > > --- > > MAINTAINERS | 7

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

2017-05-31 Thread Tobin C. Harding
On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > > Current driver implements the WEXT interface. WEXT is in maintenance > > mode, we need to re-write the driver using cfg80211. The current > > driver is handy as a referen

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Joe Perches
On Thu, 2017-06-01 at 12:46 +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Add maintainers entry for ks7010. [] > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > @@ -7429,6 +7429,13 @@ F: Documentation/auxdisplay/ks0108 > > F: drivers/auxdisplay/ks0

[PATCH] rts5208: Fix a sleep-in-atomic bug in sd_power_off_card3v3

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: rtsx_exclusive_enter_ss (acquire the lock by spin_lock) rtsx_enter_ss rtsx_power_off_card sd_power_off_card3v3 wait_timeout schedule_timeout --> may sleep To fix it, "wait_timeout" is replaced with

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Greg KH
On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > Driver ks7010 does not currently have a maintainer. > > Add maintainers entry for ks7010. > > Signed-off-by: Tobin C. Harding > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MA

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

2017-05-31 Thread Greg KH
On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > Current driver implements the WEXT interface. WEXT is in maintenance > mode, we need to re-write the driver using cfg80211. The current > driver is handy as a reference for the new implementation, we can keep > it in tree for now.

[PATCH] rts5208: Fix a sleep-in-atomic bug in rtsx_exclusive_enter_ss

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: rtsx_exclusive_enter_ss (acquire the lock by spin_lock) rtsx_enter_ss rtsx_power_off_card sd_cleanup_work sd_stop_seq_mode sd_switch_clock sd_ddr_tuning sd_ddr_pre_tuning_t

[RFC 2/3] staging: ks7010: add cfg80211 files

2017-05-31 Thread Tobin C. Harding
We are in the process of re-writing the current WEXT driver to use the cfg80211 configuration API. Currently driver root directory is empty. First step is to implement all the firmware interface in a single layer of abstraction, Firmware Interface Layer (FIL). We can add a skeleton implementation f

[RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

2017-05-31 Thread Tobin C. Harding
Driver ks7010 does not currently have a maintainer. Add maintainers entry for ks7010. Signed-off-by: Tobin C. Harding --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e98464..75250ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7429,6

[RFC 0/3] staging: ks7010: cfg80211 conversion, add FIL

2017-05-31 Thread Tobin C. Harding
Current ks7010 driver uses the WEXT interface. This series is the initial stage of re-writing the driver to use cfg80211. Patch set applies on Linus' mainline. 5ed02dbb497422bf225783f46e6eadd237d23d6b Linux 4.12-rc3 Throws 4 compiler warnings for functions defined and not used. As a first step

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-31 Thread Joe Perches
On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote: > From: Michael Kelley > Date: Tue, 30 May 2017 10:43:04 -0700 > > > Add direct #include statements for declarations of csum_tcpudp_magic() > > and csum_ipv6_magic(). While the needed #include's are picked up > > indirectly for the x86 archit

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-31 Thread David Miller
From: Joe Perches Date: Wed, 31 May 2017 15:59:31 -0700 > On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote: >> From: Michael Kelley >> Date: Tue, 30 May 2017 10:43:04 -0700 >> >> > Add direct #include statements for declarations of csum_tcpudp_magic() >> > and csum_ipv6_magic(). While the

Re: [PATCH v7 00/34] i.MX Media Driver

2017-05-31 Thread Pavel Machek
Hi! > >If there's a need for this (there should not be, as the controls are exposed > >to the user space through the sub-device nodes as the other drivers do), the > >framework APIs need to be extended. > > Right, this gets back to the media framework usability arguments. At least > myself, Phili

Re: [PATCH v7 16/34] [media] add Omnivision OV5640 sensor driver

2017-05-31 Thread Pavel Machek
Hi! > +/* min/typical/max system clock (xclk) frequencies */ > +#define OV5640_XCLK_MIN 600 > +#define OV5640_XCLK_MAX 2400 > + > +/* > + * FIXME: there is no subdev API to set the MIPI CSI-2 > + * virtual channel yet, so this is hardcoded for now. > + */ > +#define OV5640_MIPI_VC 1

[patch] staging: speakup: check for null before calling TTY's flush_buffer

2017-05-31 Thread Okash Khawaja
We should check the flush_buffer method of a tty for null before invoking it. Some drivers such as usbserial don't implement flush_buffer. This will be required for upcoming patches where we expand spk_ttyio to support more than just ttyS*. Signed-off-by: Okash Khawaja Reviewed-by: Samuel Thibaul

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-31 Thread David Miller
From: Michael Kelley Date: Tue, 30 May 2017 10:43:04 -0700 > Add direct #include statements for declarations of csum_tcpudp_magic() > and csum_ipv6_magic(). While the needed #include's are picked up > indirectly for the x86 architecture, they aren't on other > architectures, resulting in compile

Re: [PATCH v5 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls

2017-05-31 Thread Vitaly Kuznetsov
Jork Loeser writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Tuesday, May 30, 2017 04:34 >> To: x...@kernel.org; de...@linuxdriverproject.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; Haiyang >> Zhang ; Stephen Hemminger >> ; Thomas

Re: [PATCH v5 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set

2017-05-31 Thread Andy Shevchenko
On Wed, May 31, 2017 at 5:37 PM, Vitaly Kuznetsov wrote: >>> # Hyper-V paravirtualization support >>> -obj-$(CONFIG_HYPERVISOR_GUEST) += hyperv/ >>> +ifdef CONFIG_HYPERV >>> +obj-y += hyperv/ >>> +endif >> >> Can >> obj-$(CONFIG_HYPERV) += hyperv/ >> work for you instead? >> > > CONFIG_HYPERV ca

Re: [PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor

2017-05-31 Thread Vitaly Kuznetsov
Stephen Hemminger writes: > On Tue, 30 May 2017 13:34:16 +0200 > Vitaly Kuznetsov wrote: > >> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c >> index 04cb8d3..bdcc433 100644 >> --- a/arch/x86/kernel/cpu/mshyperv.c >> +++ b/arch/x86/kernel/cpu/mshyperv.c >> @@ -175,9

Re: [PATCH v5 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set

2017-05-31 Thread Vitaly Kuznetsov
Andy Shevchenko writes: > On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: >> Code is arch/x86/hyperv/ is only needed when CONFIG_HYPERV is set, the >> 'basic' support and detection lives in arch/x86/kernel/cpu/mshyperv.c >> which is included when CONFIG_HYPERVISOR_GUEST is set. >> >> Si

Re: [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements

2017-05-31 Thread Vitaly Kuznetsov
Andy Shevchenko writes: > On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > >> K. Y., while all the changes are not groundbreaking I still have to drop >> 'Tested-by' tags on affected patches. It would be great to have this >> series retested. >> >> Thomas, Ingo, Peter, would you like t

Re: [PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_exit

2017-05-31 Thread Oleg Drokin
Hello! On May 31, 2017, at 4:00 AM, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cfs_wi_exit (acquire the lock by spin_lock) > LASSERT >lbug_with_loc > libcfs_debug_dumplog >schedule and kthread_run --> may sleep > > To fix it, al

Re: [PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_deschedule

2017-05-31 Thread Oleg Drokin
Hello! On May 31, 2017, at 3:57 AM, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cfs_wi_deschedule (acquire the lock by spin_lock) > LASSERT >lbug_with_loc > libcfs_debug_dumplog >schedule and kthread_run --> may sleep > > To fix

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

2017-05-31 Thread srishti sharma
Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/cc_c

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

2017-05-31 Thread srishti sharma
Fixed a comment coding style issue that generated a warning stating block comments use * on subsequent lines. Signed-off-by: srishti sharma --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h

Re: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

2017-05-31 Thread Laurentiu Tudor
Hi Marc, On 05/31/2017 02:15 PM, Marc Zyngier wrote: > On 31/05/17 11:58, laurentiu.tu...@nxp.com wrote: >> From: Stuart Yoder >> >> Move the source files out of staging into their final locations: >>-include files in drivers/staging/fsl-mc/include go to include/linux/fsl >>-irq-gic-v3-it

Re: [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

2017-05-31 Thread Marc Zyngier
On 31/05/17 11:58, laurentiu.tu...@nxp.com wrote: > From: Stuart Yoder > > Move the source files out of staging into their final locations: > -include files in drivers/staging/fsl-mc/include go to include/linux/fsl > -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip > -source in drivers/

[PATCH v2 07/10] staging: fsl-mc: add binding path to MAINTAINERS

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor The mc bus device tree binding is maintained but not mentioned in the MAINTAINERS file. This patch adds it. Signed-off-by: Laurentiu Tudor --- Notes: -v2 -added commit description MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging

2017-05-31 Thread laurentiu.tudor
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, p

[PATCH 09/10] staging: fsl-mc: add reference to mc-bus DT binding

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Update README to reference the mc-bus device tree node binding. Signed-off-by: Laurentiu Tudor --- Notes: -no changes drivers/staging/fsl-mc/README.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fsl-mc/README.txt b/drivers/staging/fsl-mc/RE

[PATCH 08/10] staging: fsl-mc: drop reference to restool

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Drop reference to user space restool utility from the README. It will be added back together with the actual support in the bus driver. Signed-off-by: Laurentiu Tudor --- Notes: -no changes drivers/staging/fsl-mc/README.txt | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 05/10] staging: fsl-mc: remove extra blank line

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Remove extra blank line reported by checkpatch.pl. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/dprc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/dprc.h b/drivers/staging/fsl-mc/include/dprc.h index 8498a5e..2f4

[PATCH 06/10] staging: fsl-mc: drop unused forward declaration

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor This forward declaration of "struct fsl_mc_resource" is of no use so drop it. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/include/mc-sys.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/mc-sys.h b/drivers/staging/fsl-mc/in

[PATCH 03/10] staging: fsl-mc: simplify couple of deallocations

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Simplify a couple of deallocations code paths. This also fixes these checkpatch.pl false positives: "WARNING: kfree(NULL) is safe and this check is probably not required" Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 12 +++- 1

[PATCH 02/10] staging: fsl-mc: fix macros with possible side effects

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Several macros were triggering this checkpatch.pl warning: "Macro argument reuse '$arg' - possible side-effects?" Fix the warning by avoiding multiple macro argument use. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/dprc-driver.c | 10 +++--- d

[PATCH 04/10] staging: fsl-mc: drop a few useless #includes

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Some #includes were needlessly done from header files. Drop them from there and update the only .c file that implicitly needed one of those #includes. Signed-off-by: Laurentiu Tudor --- drivers/staging/fsl-mc/bus/fsl-mc-msi.c | 1 + drivers/staging/fsl-mc/bus/fsl-mc-p

[PATCH 01/10] staging: fsl-mc: enclose macro params in parens

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Several macros didn't had macro params enclosed in parens. Fix them to avoid precedence issues. Found with checkpatch.pl who was issuing this message: "Macro argument 'id' may be better as '(id)' to avoid precedence issues" Signed-off-by: Laurentiu Tudor --- drivers

[PATCH v6 00/10] staging: fsl-mc: move bus driver out of staging

2017-05-31 Thread laurentiu.tudor
From: Laurentiu Tudor Now that there is a functional ethernet driver probed on the mc bus this patch series requests that the fsl-mc bus driver be moved out of staging. The proposed destination for the bus driver is drivers/bus. Proposed location for global header files for fsl-mc and dpaa2 is t

[PATCH] libcfs: Fix a sleep-in-atomic bug in cfs_percpt_lock and cfs_percpt_unlock

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cfs_percpt_lock/cfs_percpt_unlock (acquire the lock by spin_lock) LASSERT lbug_with_loc libcfs_debug_dumplog schedule and kthread_run --> may sleep To fix it, all "LASSERT" is placed out of the spin_lock and

[PATCH] libcfs: Fix a sleep-in-atomic bug in cfs_wi_scheduler

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cfs_wi_scheduler (acquire the lock by spin_lock) LASSERT lbug_with_loc libcfs_debug_dumplog schedule and kthread_run --> may sleep To fix it, all "LASSERT" is placed out of the spin_lock and spin_unlock. Si

[PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_deschedule

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cfs_wi_deschedule (acquire the lock by spin_lock) LASSERT lbug_with_loc libcfs_debug_dumplog schedule and kthread_run --> may sleep To fix it, all "LASSERT" is placed out of the spin_lock and spin_unlock. S

[PATCH] libcfs: Fix a sleep-in-atomic bug in cfs_wi_schedule

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cfs_wi_schedule (acquire the lock by spin_lock) LASSERT lbug_with_loc libcfs_debug_dumplog schedule and kthread_run --> may sleep To fix it, all "LASSERT" is placed out of the spin_lock and spin_unlock. Sig

[PATCH] libcfs: Fix a sleep-in-atomic bug in cfs_wi_sched_destroy

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cfs_wi_sched_destroy (acquire the lock by spin_lock) LASSERT lbug_with_loc libcfs_debug_dumplog schedule and kthread_run --> may sleep To fix it, all "LASSERT" is placed out of the spin_lock and spin_unlock.

[PATCH V2] libcfs: Fix a sleep-in-atomic bug in cfs_wi_exit

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cfs_wi_exit (acquire the lock by spin_lock) LASSERT lbug_with_loc libcfs_debug_dumplog schedule and kthread_run --> may sleep To fix it, all "LASSERT" is placed out of the spin_lock and spin_unlock. Signed-

[PATCH] libcfs: Fix a sleep-in-atomic bug in cfs_wi_deschedule

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cfs_wi_deschedule (acquire the lock by spin_lock) LASSERT lbug_with_loc libcfs_debug_dumplog schedule and kthread_run --> may sleep To fix it, all "LASSERT" is placed out of the spin_lock and spin_unlock. S