Re: [PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls

2017-05-30 Thread Laura Abbott
On 05/30/2017 07:11 AM, Gleb Fotengauer-Malinovskiy wrote: > This problem was found by strace ioctl list generator. > > Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and > ion_client") > Signed-off-by: Gleb Fotengauer-Malinovskiy > --- > drivers/staging/android/uapi/ion.h | 18

Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-05-30 Thread Stephen Hemminger
On Tue, 30 May 2017 19:17:46 + Jork Loeser wrote: > > -Original Message- > > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > > Sent: Tuesday, May 30, 2017 09:53 > > To: Vitaly Kuznetsov > > Cc: x...@kernel.org; de...@linuxdriverproject.org; linux- > > ker...@vger.kernel.or

Re: [PATCH-v2 0/5] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-30 Thread Bjorn Helgaas
On Wed, May 24, 2017 at 01:41:23PM -0700, Jork Loeser wrote: > From: Jork Loeser > > Update the Hyper-V vPCI driver to use the Server-2016 version of the vPCI > protocol, fixing MSI creation and retargeting issues. > > Changes since v1: > - reduced spew in protocol negotiation (Dan Carpenter) >

RE: [PATCH-v2 0/5] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-30 Thread KY Srinivasan
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Bjorn Helgaas > Sent: Tuesday, May 30, 2017 12:45 PM > To: Jork Loeser > Cc: o...@aepfle.de; Stephen Hemminger ; > linux-...@vger.kernel.org; jasow...@redhat.com; linux- > ker...@vge

Re: [PATCH V2 00/27] Drivers: ccree - align block comments

2017-05-30 Thread Tobin C. Harding
On Tue, May 30, 2017 at 08:49:41AM +0200, Antoine Tenart wrote: > Hello Derek, > > On Tue, May 30, 2017 at 06:09:37PM +1200, Derek Robson wrote: > > Fixed block comments across whole ccree driver > > Since all these commits are doing the same logical change across a > single driver, you could pro

Re: [PATCH-v2 0/5] Hyper-V vPCI: use vPCI protocol version 1.2

2017-05-30 Thread Bjorn Helgaas
On Wed, May 24, 2017 at 01:41:23PM -0700, Jork Loeser wrote: > From: Jork Loeser > > Update the Hyper-V vPCI driver to use the Server-2016 version of the vPCI > protocol, fixing MSI creation and retargeting issues. > > Changes since v1: > - reduced spew in protocol negotiation (Dan Carpenter) >

Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 10:17 PM, Jork Loeser wrote: >> > +#define HV_FLUSH_ALL_PROCESSORS0x0001 >> > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES0x0002 >> > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY 0x0004 >> > +#define HV_FLUSH_USE_EXTENDED_RANGE_FO

RE: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-05-30 Thread Jork Loeser
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Tuesday, May 30, 2017 09:53 > To: Vitaly Kuznetsov > Cc: x...@kernel.org; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org; KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Thomas Gl

RE: [PATCH v5 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls

2017-05-30 Thread Jork Loeser
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, May 30, 2017 04:34 > To: x...@kernel.org; de...@linuxdriverproject.org > Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; Haiyang > Zhang ; Stephen Hemminger > ; Thomas Gleixner ; Ingo > Molnar ; H.

[PATCH v2 net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-30 Thread mikelley
From: Michael Kelley Add direct #include statements for declarations of csum_tcpudp_magic() and csum_ipv6_magic(). While the needed #include's are picked up indirectly for the x86 architecture, they aren't on other architectures, resulting in compile errors. Signed-off-by: Michael Kelley ---

[PATCH 7/7] vmbus: remove unused vmbus_sendpacket_multipagebuffer

2017-05-30 Thread Stephen Hemminger
This function is not used anywhere in current code. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 56 -- include/linux/hyperv.h | 6 -- 2 files changed, 62 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c

[PATCH 0/7] vmbus: cleanups and optimizations

2017-05-30 Thread Stephen Hemminger
This removes unused bits from vmbus internals, and also does some optimization to the host signalling part of ring buffer logic. Stephen Hemminger (7): vmbus: simplify hv_ringbuffer_read vmbus: drop unused ring_buffer_info elements vmbus: refactor hv_signal_on_read vmbus: eliminate duplica

[PATCH 4/7] vmbus: eliminate duplicate cached index

2017-05-30 Thread Stephen Hemminger
Don't need cached read index anymore now that packet iterator is used. The iterator has the original read index until the visible read_inde is updated. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 17 - include/linux/hyperv.h | 14 -- 2 files chan

[PATCH 3/7] vmbus: refactor hv_signal_on_read

2017-05-30 Thread Stephen Hemminger
The function hv_signal_on_read was defined in hyperv.h and only used in one place in ring_buffer code. Clearer to just move it inline there. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 32 +-- include/linux/hyperv.h | 49

[PATCH 6/7] vmbus: add prefetch to ring buffer iterator

2017-05-30 Thread Stephen Hemminger
When iterating over incoming ring elements from the host, prefetch the next descriptor so that it is cache hot. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffe

[PATCH 5/7] vmbus: more host signalling avoidance

2017-05-30 Thread Stephen Hemminger
Don't signal host if it has disabled interrupts for that ring buffer. Check the feature bit to see if host supports pending send size flag. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git

[PATCH 1/7] vmbus: simplify hv_ringbuffer_read

2017-05-30 Thread Stephen Hemminger
With new iterator functions (and the double mapping) the ring buffer read function can be greatly simplified. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 118 +++ 1 file changed, 17 insertions(+), 101 deletions(-) diff --git a/driv

[PATCH 2/7] vmbus: drop unused ring_buffer_info elements

2017-05-30 Thread Stephen Hemminger
The elements ring_data_start_offset and priv_write_index are not used. Signed-off-by: Stephen Hemminger --- include/linux/hyperv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index e09fc8290c2f..10e690e787b0 100644 --- a/include/linux/hype

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-30 Thread Joe Perches
On Tue, 2017-05-30 at 10:43 -0700, Michael Kelley wrote: > Add direct #include statements for declarations of csum_tcpudp_magic() > and csum_ipv6_magic(). While the needed #include's are picked up > indirectly for the x86 architecture, they aren't on other > architectures, resulting in compile erro

[PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-30 Thread Michael Kelley
Add direct #include statements for declarations of csum_tcpudp_magic() and csum_ipv6_magic(). While the needed #include's are picked up indirectly for the x86 architecture, they aren't on other architectures, resulting in compile errors. Signed-off-by: Michael Kelley --- drivers/net/hyperv/netvs

Re: [PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > K. Y., while all the changes are not groundbreaking I still have to drop > 'Tested-by' tags on affected patches. It would be great to have this > series retested. > > Thomas, Ingo, Peter, would you like to take this through x86 tree or sh

Re: [PATCH v5 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > Hyper-V hosts may support more than 64 vCPUs, we need to use > HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE_EX/LIST_EX hypercalls in this > case. > +/* HvFlushVirtualAddressSpaceEx, HvFlushVirtualAddressListEx hypercalls */ > +struct hv_flush_pcpu_

Re: [PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor

2017-05-30 Thread Stephen Hemminger
On Tue, 30 May 2017 13:34:16 +0200 Vitaly Kuznetsov wrote: > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c > index 04cb8d3..bdcc433 100644 > --- a/arch/x86/kernel/cpu/mshyperv.c > +++ b/arch/x86/kernel/cpu/mshyperv.c > @@ -175,9 +175,15 @@ static void __init ms_hype

Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > Hyper-V host can suggest us to use hypercall for doing remote TLB flush, > this is supposed to work faster than IPIs. > > Implementation details: to do HvFlushVirtualAddress{Space,List} hypercalls > we need to put the input somewhere in me

Re: [PATCH v5 07/10] hyper-v: globalize vp_index

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > To support implementing remote TLB flushing on Hyper-V with a hypercall > we need to make vp_index available outside of vmbus module. Rename and > globalize. > +u32 *hv_vp_index; > + hv_vp_index[smp_processor_id()] = (u32)msr_vp_in

Re: [PATCH v5 06/10] x86/hyper-v: implement rep hypercalls

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > Rep hypercalls are normal hypercalls which perform multiple actions at > once. Hyper-V guarantees to return exectution to the caller in not more > than 50us and the caller needs to use hypercall continuation. Touch NMI > watchdog between h

Re: [PATCH v5 04/10] x86/hyper-v: fast hypercall implementation

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > Hyper-V supports 'fast' hypercalls when all parameters are passed through > registers. Implement an inline version of a simpliest of these calls: > hypercall with one 8-byte input and no output. > + u64 hv_status, control = (u64)cod

Re: [PATCH v5 03/10] x86/hyper-v: make hv_do_hypercall() inline

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > We have only three call sites for hv_do_hypercall() and we're going to > change HVCALL_SIGNAL_EVENT to doing fast hypercall so we can inline this > function for optimization. > > Hyper-V top level functional specification states that r9-r1

Re: Firmware for staging atomisp driver

2017-05-30 Thread Alan Cox
On Sun, 2017-05-28 at 14:30 +0200, Hans de Goede wrote: > I started with an Asus T100TA after fixing 2 oopses in the sensor > driver there I found out that the BIOS does not allow to put the > ISP in PCI mode and that there is no code to drive it in ACPI > enumerated mode. In ACPI mode it's enumer

Re: [PATCH v5 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov wrote: > Code is arch/x86/hyperv/ is only needed when CONFIG_HYPERV is set, the > 'basic' support and detection lives in arch/x86/kernel/cpu/mshyperv.c > which is included when CONFIG_HYPERVISOR_GUEST is set. > > Signed-off-by: Vitaly Kuznetsov >

[PATCH] staging: android: uapi: drop definitions of removed ION_IOC_{FREE,SHARE} ioctls

2017-05-30 Thread Gleb Fotengauer-Malinovskiy
This problem was found by strace ioctl list generator. Fixes: 15c6098cfec5 ("staging: android: ion: Remove ion_handle and ion_client") Signed-off-by: Gleb Fotengauer-Malinovskiy --- drivers/staging/android/uapi/ion.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/

[PATCH v5 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()

2017-05-30 Thread Vitaly Kuznetsov
Add Hyper-V tracing subsystem and trace hyperv_mmu_flush_tlb_others(). Tracing is done the same way we do xen_mmu_flush_tlb_others(). Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan Tested-by: Simon Xiao Tested-by: Srikanth Myakam --- MAINTAINERS | 1 + arc

[PATCH v5 06/10] x86/hyper-v: implement rep hypercalls

2017-05-30 Thread Vitaly Kuznetsov
Rep hypercalls are normal hypercalls which perform multiple actions at once. Hyper-V guarantees to return exectution to the caller in not more than 50us and the caller needs to use hypercall continuation. Touch NMI watchdog between hypercall invocations. This is going to be used for HvFlushVirtual

[PATCH v5 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT

2017-05-30 Thread Vitaly Kuznetsov
We need to pass only 8 bytes of input for HvSignalEvent which makes it a perfect fit for fast hypercall. hv_input_signal_event_buffer is not needed any more and hv_input_signal_event is converted to union for convenience. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan --- Changes sin

[PATCH v5 03/10] x86/hyper-v: make hv_do_hypercall() inline

2017-05-30 Thread Vitaly Kuznetsov
We have only three call sites for hv_do_hypercall() and we're going to change HVCALL_SIGNAL_EVENT to doing fast hypercall so we can inline this function for optimization. Hyper-V top level functional specification states that r9-r11 registers and flags may be clobbered by the hypervisor during hyp

[PATCH v5 04/10] x86/hyper-v: fast hypercall implementation

2017-05-30 Thread Vitaly Kuznetsov
Hyper-V supports 'fast' hypercalls when all parameters are passed through registers. Implement an inline version of a simpliest of these calls: hypercall with one 8-byte input and no output. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan --- Changes since v4: - Avoid union aliasing,

[PATCH v5 07/10] hyper-v: globalize vp_index

2017-05-30 Thread Vitaly Kuznetsov
To support implementing remote TLB flushing on Hyper-V with a hypercall we need to make vp_index available outside of vmbus module. Rename and globalize. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan Tested-by: Simon Xiao Tested-by: Srikanth Myakam --- arch/x86/hyperv/hv_init.c

[PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-05-30 Thread Vitaly Kuznetsov
Hyper-V host can suggest us to use hypercall for doing remote TLB flush, this is supposed to work faster than IPIs. Implementation details: to do HvFlushVirtualAddress{Space,List} hypercalls we need to put the input somewhere in memory and we don't really want to have memory allocation on each cal

[PATCH v5 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls

2017-05-30 Thread Vitaly Kuznetsov
Hyper-V hosts may support more than 64 vCPUs, we need to use HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE_EX/LIST_EX hypercalls in this case. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan --- Changes since v4: - Use __set_bit(), minor code style changes [Andy Shevchenko] --- arch/x86/hyperv/

[PATCH v5 02/10] x86/hyper-v: stash the max number of virtual/logical processor

2017-05-30 Thread Vitaly Kuznetsov
Max virtual processor will be needed for 'extended' hypercalls supporting more than 64 vCPUs. While on it, unify on 'Hyper-V' in mshyperv.c as we currently have a mix, report acquired misc features as well. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan Tested-by: Simon Xiao Tested-

[PATCH v5 00/10] Hyper-V: praravirtualized remote TLB flushing and hypercall improvements

2017-05-30 Thread Vitaly Kuznetsov
Changes since v4: - Get rid of union aliasing in the series [Andy Shevchenko]. We still use it a lot across Hyper-V code and we should probably get rid of it entirely. - Code style changes [Andy Shevchenko]. - Use __set_bit(), lower/upper_32_bits where possible [Andy Shevchenko]. - Use 'A' doub

[PATCH v5 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set

2017-05-30 Thread Vitaly Kuznetsov
Code is arch/x86/hyperv/ is only needed when CONFIG_HYPERV is set, the 'basic' support and detection lives in arch/x86/kernel/cpu/mshyperv.c which is included when CONFIG_HYPERVISOR_GUEST is set. Signed-off-by: Vitaly Kuznetsov Acked-by: K. Y. Srinivasan Tested-by: Simon Xiao Tested-by: Srikant

Re: [PATCH] staging: ks7010: define ether_hdr.h_proto to be big-endian

2017-05-30 Thread Dick Porter
On Mon, May 29, 2017 at 04:33:58PM +0200, Greg KH wrote: > On Sun, May 21, 2017 at 10:15:11AM +0100, d...@acm.org wrote: > > From: Richard Porter > > > > Fixes sparse warnings: > > drivers/staging/ks7010/ks_hostif.c:339:21: warning: cast to restricted > > __be16 > > drivers/staging/ks7010/ks_hos