This patch fixes the checkpoint.pl warning:
WARNING: Prefer printk_ratelimited or pr__ratelimited to
printk_ratelimit
Signed-off-by: Konrad Malkowski
---
drivers/staging/lustre/lnet/libcfs/tracefile.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/stagi
Greg,
Sure, I will fix it and resend a fresh patch.
Thanks,
Hari
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Assuming the intension of the function is to clean up, so fix the function
name accordingly.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vc04_service
In the unlikely case that service is NULL we should bail out instead
of calling BUG_ON(). The other BUG_ON calls will be fixed in separate
patches.
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 38 ++
1 file changed, 24 insertions(+), 1
Use the PAGE_MASK instead of open code it.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
b/drivers/staging
In case VCHIQ state is already initialized we need to bailout
in order to aovid a memory leak.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_ar
Reduce the indentation within vchiq_dump_service_use_state in order
to avoid a multiline derefernce.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vc04
Instead of saving the return value of mutex_lock_killable in a
local variable we could use the value directly.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/vc
Properly handle the error case in case of an invalid tx_pos.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b
This replaces all remaining BUG_ON with WARN_ON. So in case of
a VCHIQ bug the system is still usable.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc
The variable slot_mem_size is assigned a value which is never used.
This issue has been found by CppCheck.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interfac
VCHIQ suspend and resume isn't implemented, but even it was
there is no need to call BUG().
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_c
This patch series addresses mostly minor issues. It's based on top of
the latest vchiq bugfix [1].
[1] - https://lkml.org/lkml/2017/5/4/228
Changes in v2:
* fix the signed-off-by in patches 8 and 9
Stefan Wahren (16):
staging: vchiq_core: Use return value of mutex_lock_killable directly
stag
Bail out properly if the process index doesn't match the remote insert.
We also drop the BUG in case the process index is at local insert,
so we can trigger the WARN_ON again some steps later.
Signed-off-by: Stefan Wahren
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c| 11 +++
Since the ARM side of VCHIQ support only 1 state, we could simplify
the init code. This makes it possible to avoid BUG_ON and a theoretical
overflow of id.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 5 +
1 file changed, 1 insertion(+), 4
In case vmalloc_to_page returns NULL create_pagelist must abort
imediatly.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm
If the ref counter of service has an unexpected value then we better
bail out.
Signed-off-by: Stefan Wahren
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/v
This comment was apparently forgotten in the correction of CamelCase.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
We can reduce the scope of the counting variable i. This has
been found by CppCheck.
Signed-off-by: Stefan Wahren
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/v
> Greg Kroah-Hartman hat am 25. Mai 2017 um 18:35
> geschrieben:
>
>
> On Sat, May 20, 2017 at 11:30:33PM +0200, Stefan Wahren wrote:
> >
> > > Stefan Wahren hat am 20. Mai 2017 um 14:22
> > > geschrieben:
> > >
> > >
> > > Since the ARM side of VCHIQ support only 1 state, we could simpli
On 28 April 2017 at 11:07, Greg KH wrote:
> On Sun, Apr 23, 2017 at 03:21:31PM +0100, Eric Curtin wrote:
>> checkpatch spits out a warning about the 80 character line limit. Split
>> the parameters of these functions onto different lines. Put the ; with
>> the macro caller instead. Lined up parame
On Thu, May 25, 2017 at 7:03 PM, kbuild test robot wrote:
>>> cc1: warning: unrecognized command line option
>>> "-Wno-suggest-attribute=format"
>>> cc1: warning: unrecognized command line option
>>> "-Wno-unused-but-set-variable"
>>> cc1: warning: unrecognized command line option "-Wno-unused-
On Thu, May 25, 2017 at 10:27 PM, Greg KH wrote:
> On Sat, May 20, 2017 at 02:00:24AM +0530, srishti sharma wrote:
>> fixed a trailing */ issue .
>>
>> Signed-off-by: srishti sharma
>> ---
>> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
Comparisons should place the constant on the right side of the test
This patch fixes coding style issues as reported by checkpatch.
Signed-off-by: Szilveszter Székely
---
drivers/staging/rtl8192u/r8192U_core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/driver
Fix a missing blank line issue reported by checkpatch.pl
Signed-off-by: Marko Stankovic
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
Fix the multiple blank lines issue reported by checkpatch.pl
Signed-off-by: Marko Stankovic
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc
Subject: [PATCH 2/2] staging: wilc1000: add missing blank line after struct
declaration
Fix a missing blank line issue reported by checkpatch.pl
Signed-off-by: Marko Stankovic
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/stag
Date: Thu, 25 May 2017 18:44:25 +0200
Subject: [PATCH 1/2] staging: wilc1000: remove excessive blank lines
Fix the multiple blank lines issue reported by checkpatch.pl
Signed-off-by: Marko Stankovic
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 15 ---
1 file changed, 15 d
Hi Mauro,
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20170525]
[cannot apply to v4.12-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mauro-Carvalho
On Mon, May 22, 2017 at 03:09:32PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor
>
> Signed-off-by: Laurentiu Tudor
> ---
>
> Notes:
> -v2
> -no changes
then why is it "v2"?
___
devel mailing list
de...@linuxdriverproject.or
On Mon, May 22, 2017 at 03:09:32PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor
>
> Signed-off-by: Laurentiu Tudor
I don't take patches without any changelog text :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev
On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor
Your subject line is very odd, please use the 'v2' marking properly...
>
> Remove several unneeded #includes, forward
> declarations and fix several issues reported
> by checkpatch.pl --strict, such
On Sat, May 20, 2017 at 02:00:24AM +0530, srishti sharma wrote:
> fixed a trailing */ issue .
>
> Signed-off-by: srishti sharma
> ---
> drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This file isn't in my tree, always work against linux-n
On Sun, May 21, 2017 at 01:03:55AM +0530, Ranjit W wrote:
> fixing following checkpatch warning wherever possible:
> WARNING: line over 80 characters
>
> Signed-off-by: Ranjit W
> ---
> drivers/staging/wlan-ng/cfg80211.c | 11 ---
> drivers/staging/wlan-ng/hfa384x.h | 21 +++
On Sat, May 20, 2017 at 11:35:04PM +0530, Jaya Durga wrote:
> Fixed coding style issue
>
> Renamed cap_Privacy to cap_privacy
>
> Signed-off-by: Jaya Durga
> ---
> drivers/staging/rtl8712/ieee80211.c | 2 +-
> drivers/staging/rtl8712/wifi.h | 2 +-
> 2 files changed, 2 insertions(+), 2 del
On Sat, May 20, 2017 at 11:26:17PM +0530, Jaya Durga wrote:
> Fixed coding style issue
>
> Renamed cap_ShortPremble to cap_short_premble
>
> Signed-off-by: Jaya Durga
Where are patches 1-4 of this patch series? Please fix up and resend.
thanks,
greg k-h
__
On Sat, May 20, 2017 at 11:30:33PM +0200, Stefan Wahren wrote:
>
> > Stefan Wahren hat am 20. Mai 2017 um 14:22
> > geschrieben:
> >
> >
> > Since the ARM side of VCHIQ support only 1 state, we could simplify
> > the init code. This makes it possible to avoid BUG_ON and a theoretical
> > overf
On Thu, 25 May 2017 14:19:55 +0100
Alan Cox wrote:
> > > Signed-off-by: Haiyang Zhang
> > > ---
> >
> > According to Stephen Hemminger , there are
> > additional programs, like X.org, DPDK, are also using 16-bit only
> > PCI domain numbers. So, I'm submitting this patch for re-consideration
On Thu, 25 May 2017 09:15:33 +1000
"Tobin C. Harding" wrote:
> On Wed, May 24, 2017 at 10:38:57PM +0800, Jamie Huang wrote:
>
> Comment on your patch subject line. Patches to staging typically
> include the driver in the subject. You can view previous commits to
> get an idea using
>
> $ git lo
According to the coding-style documentation, functions in source files
should be separated with one blank line. Redundant blank lines were
removed from this source file, in accordance with coding-style
documentation.
Signed-off-by: Aliza Minkov
---
drivers/staging/dgnc/dgnc_driver.c | 2 --
1 fi
> > Signed-off-by: Haiyang Zhang
> > ---
>
> According to Stephen Hemminger , there are
> additional programs, like X.org, DPDK, are also using 16-bit only
> PCI domain numbers. So, I'm submitting this patch for re-consideration.
The correct way to handle this is to send the needed patches to
> -Original Message-
> From: Laurentiu Tudor
> Sent: Wednesday, May 24, 2017 3:34 PM
> To: Ruxandra Ioana Radulescu ;
> gre...@linuxfoundation.org
> Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org;
> ag...@suse.de; a...@arndb.de; linux-arm-ker...@lists.infradead.org;
> io...@li
On Thu, May 25, 2017 at 02:33:31PM +0300, Aliza Minkov wrote:
> According to the coding-style documentation, functions in source files
> should be separated with one blank line. Redundant blank lines were
> removed from this source file, in accordance with coding-style
> documentation.
>
> Signed-
According to the coding-style documentation, functions in source files
should be separated with one blank line. Redundant blank lines were
removed from this source file, in accordance with coding-style
documentation.
Signed-off-by: Aliza Minkov
---
drivers/staging/dgnc/dgnc_driver.c | 2 --
1 fi
On Thu, May 25, 2017 at 12:22:15PM +0300, Aliza Minkov wrote:
> Signed-off-by: Aliza Minkov
> ---
> drivers/staging/dgnc/dgnc_driver.c | 2 --
> 1 file changed, 2 deletions(-)
Hi Aliza,
Well done getting your patch together. I think you might get an
automated message from Greg's patch robot so
Signed-off-by: Aliza Minkov
---
drivers/staging/dgnc/dgnc_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index 253f38b..c1b6079 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_d
On Wed, May 24, 2017 at 01:39:15PM -0700, Haiyang Zhang wrote:
> From: Haiyang Zhang
>
> This patch uses the lower 16 bits of the serial number as PCI
> domain, otherwise some drivers may not be able to handle it.
>
> Besides Nvidia drivers, we also found X.org, and DPDK handle
> only 16 bit PCI
drivers/media/platform/video-mux.c:246:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
CC: Philipp Zabel
Signed-off-by: Fengguang Wu
---
video-mux.c |5 +
1 file changed, 1 insert
Hi Philipp,
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.12-rc2 next-20170525]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Steve-Longerbeam/i-MX-Media
Replace CamelCase variable names with underscores and remove
hungarian prefixes to comply with the standard kernel coding style
Signed-off-by: Richa Jha
---
drivers/staging/sm750fb/ddk750_chip.c | 59 ++-
drivers/staging/sm750fb/ddk750_chip.h | 18 +--
Hi Tobin,
> I began testing the card you sent today. I'm getting a firmware load
> error like you mentioned.
Nice. Firstly, that means the card is alive and survived the mailing.
> I checked out code from when you originally merged into staging,
> however I built the module in a 4.9 kernel.
I t
> "Tobin C. Harding" hat am 25. Mai 2017 um 01:28 geschrieben:
>
>
> On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote:
>
> This driver is not in Greg KH's staging tree.
The driver has moved to drivers/staging/vc04_services/bcm2835-audio
> You may like to work off
> of that tree
52 matches
Mail list logo
